| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This is partly so video can distinguish between
0.1.41 which they pushed internally and 0.1.42 which
will be our next push.
Review URL: http://codereview.chromium.org/179015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
O3D.
What happens is client.toDataURL creates a RenderSurface
and DepthSurface, sets those as the current Surface
then renders. It then calls Surface::GetBitmap to
get the pixels in the bitmap.
The complications are
1) I needed to make Renderer::StartRendering /
Renderer::FinishRendering be nestable because the
Renderer::SetRenderSurface required StartRendering
to already have been called. I didn't see a cleaner
way to do this but I'm happy to change it if you
have a better idea.
2) Since we can only create POT RenderSurfaces
I added a clip_width / clip_height to render surfaces.
Renderer::SetViewport uses these values so we end up
rendering correctly to the top/left area of the
POT render surface.
3) Doing it this way means that screenshots are NOT
anti-aliased. I feel like that issue can be handled
later. It's more important that toDataURL work now
than it have the ultimate best results. (I hope). It
probably means I'll need to create all new reference
images.
4) I was wondering we we should expose SetClipWidth
to JavaScript. Given that we require POT render surfaces
they should always get the same results on all hardware.
Or, rather, we could just allow the user to create NPOT
RenderSurfaces. Under the hood they'd get a POT surface
but the clip_width/clip_height would be set to the size
the requested. There would have to be a note that texture
wrapping only works if the size if POT.
5) I had to split FinishRendering into FinishRendering
and Present since when taking a screenshot nothing will
be drawn to the backbuffer and so I don't want a
present to happen.
Review URL: http://codereview.chromium.org/174594
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Stable (2.x)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dev tools window.
It makes app mode windows feel a lot more native.
BUG=16474
Review URL: http://codereview.chromium.org/183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The signal-self syntax needed to fix bug 20370 doesn't work on Leopard and
causes the Sandbox to barf so renderers don't star tup.
We introduce a ;10.5_ONLY keyword to the sandbox that is substituted at runtime (the line with the rule is effectively uncommented). This allows us to use leopard or snow-leapard-only sandbox syntax
BUG=20516
TEST=Chrome should no longer crash on launch under SL.
Review URL: http://codereview.chromium.org/183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/175012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extensions that increase privilges.
BUG=20461
Review URL: http://codereview.chromium.org/174637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DISALLOW_EVIL_CONSTRUCTORS in a bunch of files.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/173538
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10398
TEST=green webkit builders
Review URL: http://codereview.chromium.org/178014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20288
Review URL: http://codereview.chromium.org/180016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also distinguish dump files by architecture, so they don't clobber each other when archived.
Review URL: http://codereview.chromium.org/177025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the user hits backspace with the caret on the LHS in a keyword
search, should exit keyword search.
[Apple keyboards may label what I'm calling "backspace" as "delete".
The wide key above |\ key.]
http://crbug.com/20286
TEST=Type www.google.com, then tab to enter keyword search. Type some
text. Select-all and hit backspace, should stay in keyword mode.
Type some text, backspace should work as normal. Type some text,
position caret at LHS, backspace should take you out of keyword mode.
Review URL: http://codereview.chromium.org/180009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=tc
Review URL: http://codereview.chromium.org/175011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
font height is a design measure and should not be used for a bounding box.
BUG=20401
TEST=Open google.com in a tab. Tab title should be fully visible and not clipped.
Review URL: http://codereview.chromium.org/179022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
all the tests pass.
TBR=michaeln@chromium.org
Review URL: http://codereview.chromium.org/182013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/177022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20017
TEST=unittests
Review URL: http://codereview.chromium.org/177016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patch from Julien Tinnes)
* Light changes to make it compile as C99 code instead of C++ (no
variable declaration inside 'for' loops initialization)
* argc = 0 would lead to memory corruption.
* Now always in CHROME_DEVEL_SANDBOX mode:
+ In the previous mode, the trusted binary was attacker-owned anyway
because of the environment variables, so I believe it was trivial
to bypass the check.
+ Remove check for being owned by current user.
* Move all the tmp dir creation stuff *before* CLONE_FS happens: avoid
doing stuff in a scary environment. I closed the fd in the untrusted
process.
* changed if (st.st_uid || st.st_gid || st.st_mode & S_IWOTH) to if
(st.st_uid || st.st_gid || st.st_mode & 0777)
* Check rmdir/fchown/fchmod return values
* Check snprintf return value x3 (probably useless)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html for Windows and Linux. Chrome allows xhr's to local directories (if the security origin of the document is file://) and Safari does not, so when testXHRDirectory is run on Safari hits an error handler, but returns a real result in Chrome. Mac is still marked as failing because of unimplemented test shell features (See http://crbug.com/20458 for more details).
TEST=layout test try bots
BUG=20458,20450,18686
Review URL: http://codereview.chromium.org/173598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
scrollbarsModeDidChange was also added to HostWindow.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/183001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't specify one.
This icon came from Crystal Clear [1] and is licensed under
LGPL.
[1] http://commons.wikimedia.org/wiki/Crystal_Clear
BUG=20510
Review URL: http://codereview.chromium.org/173604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20496
TEST=more alerts should get localized strings.
Review URL: http://codereview.chromium.org/181006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should reduce the time to show the NTP with about 5ms :-)
Fix a bug with tips causing an exception when there are no tips.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/178015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is in preparation for adding about:memory support for Linux, but
the change is otherwise too large to be considered the same file
without this trick.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15872
TEST=none
Review URL: http://codereview.chromium.org/182007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after this one causes a compile failure.
TBR=michaeln@chromium.org
BUG=none
TEST=canary bots
Review URL: http://codereview.chromium.org/179021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/20284
TEST=Type "test text". You should see "Type to search" hint. TAB
should take you into the content view. Unfortunately, there are other
unrelated bugs around the tab sequencing, so this only works with NTP
on a new window. Hit TAB twice and you should start tabbing between
thumbnails.
Review URL: http://codereview.chromium.org/180010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This leak is intermittent and I can't reproduce it reliably on my machine but after this fix I haven't been able to reproduce it at all.
BUG=16128
TEST=no test possible
Review URL: http://codereview.chromium.org/176013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull in the popup corners by half a pixel to more closely match the
rounding on the buttons. Pull up the gap between the popup and the
field by one pixel to match Windows.
http://crbug.com/20446
Review URL: http://codereview.chromium.org/178007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new method to ChromeClient, so now ours doesn't compile. I'm not 100% sure
that doing nothing is the right course of action here, but it seems to be what
most ports are doing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/176014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needed it)
Added restart_browser as a helper like Views helper for putting up a request for the user to restart.
Added a new string needed for Mac style alerts to go with the existing restart string.
Make Mac Chromium use a custom about box.
Give Chromium and Google Chrome an about box that matches the one on other platforms
Use all the existing UI strings for the about box so we get credits, copy rights, etc.
TEST=New aboutbox for Chromium and Google Chrome. About box should be fully l10n and size as needed. Chrome update messaging should more match windows and be localized.
BUG=13219,19020
Review URL: http://codereview.chromium.org/173606
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We want to make google.com homepage by default and also show the home button (see the bug below).
BUG=http://crbug.com/19392
TEST=Delete user profile and launch Chrome - homepage should be set to google.com and should be enabled. also home button should show up.
Review URL: http://codereview.chromium.org/174030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plain new[] with scoped_array.
BUG=20497 (http://crbug.com/20497)
TEST=Valgrind does not report memory leaks any more in media/base/yuv_convert_unittest.cc
Review URL: http://codereview.chromium.org/182010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"npapi::plugininstance::npp_newstream___ipc::syncchannel::sendwithtimeout" to the known crash list (reliability test).
After an completely unrelated CL was checked in, this crash (the top frame being in NPSWF) showed up. This may be a dupe, but it's hard to tell because most of frames are not resolved to symbols.
BUG=20494
TEST=A similar stack does not trigger a reliability test failure.
TBR=huanr
Review URL: http://codereview.chromium.org/173607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=2078,2776,7579,20406,11921,17964
TEST=All the test passes (especially, NetUti*.IDN* tests)
TBR=mal
Review URL: http://codereview.chromium.org/179019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173577
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173605
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
set by the DOM agent.
BUG=20482
Review URL: http://codereview.chromium.org/182009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sorry for a layout-test failure caused by my WebKit change.
I forgot sending this change that implements code that makes test_shell sends function-key events when submitting my WebKit change.
BUG=20332 "Need to implement the handling of function key values passed to EventSendingController::keyDown"
TEST=LayoutTests/fast/events/keydown-function-keys.html
Review URL: http://codereview.chromium.org/174601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173545
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to go back in its history
With the changes made in CL http://codereview.chromium.org/173344, gtk_window_activate_key() is used to handle a key event that was not handled by webkit. Unlike the old code, gtk_window_activate_key() may match the key event with predefined accelerators according to its hardware_keycode rather than keyval. Thus, we need to set hardare_keycode to an invalid value in GtkIMContextWrapper if the key event is handled by IME, to prevent BrowserWindowGtk from handling it again.
BUG=20297: Typing backspace while in a form field causes the browser to go back in its history
TEST=Starts scim's XIM server by running "scim -d", then runs chrome with GTK_IM_MODULE=xim. Open www.google.com and press backspace in the search box, the browser shall not go back to previous page.
Review URL: http://codereview.chromium.org/179016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/180018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/181004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=rvargas
BUG=20459
TEST=none
Review URL: http://codereview.chromium.org/181003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/177015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173600
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19982
TEST=Assign @role=article on a DOM element. It will be exposed as MSAA role document.
Review URL: http://codereview.chromium.org/182006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gallery.
BUG= http://crbug.com/20344
TEST= On vista 64 , install a non-default theme. Open theme gallery and choose "Classic" theme. Close browser and restart. Theme should be default aero theme on Vista, and not the opaque blue windows theme.
Review URL: http://codereview.chromium.org/174562
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/181002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24708 0039d316-1c4b-4281-b951-d872f2087c98
|