| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
twice and added to the wrong place (wrong in alphabetical
order) of the file list. In r7854 the wrong order of files
was propagated to net_lib.scons. This change fixes both of
these problems.
R=eroman
Review URL: http://codereview.chromium.org/20438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This currently crashes when trying to load a new URL. (It looks like some housekeeping isn't being done in RenderWidgetHostViewGtk, the underlying widget isn't attached to any GTK window...)
Review URL: http://codereview.chromium.org/21438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is still valid
with a VirtualQuery call.
This fixes http://code.google.com/p/chromium/issues/detail?id=7701
Bug=7701
Review URL: http://codereview.chromium.org/21434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the curved lines are due to anti-aliasing. Also, the dotted lines, and the vertical edge line of the bounding box, are shaded (very) slightly different.
Review URL: http://codereview.chromium.org/20441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
process_singleton.cc can just become process_singleton_win.cc since it's all Windows-specific.
Review URL: http://codereview.chromium.org/20442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They would not be focused when shown and tab traversal was not working.
This was caused by several issues:
- HWNDView was not focusing its HWND when focused through the View::RequestFocus() method (it would rely on the default view behavior which is to focus the root view HWND), so it would not be focused by default.
- DOMView (parent of HtmlDialogView) was not focusable so would not get the focus when pressing tab.
- DOMView was not eating tab keys events (by returning false in View::CanProcessTabKeyEvents()), so the render view would not get the tab key press messages (for focus traversal in the render view).
Note: most of the file changes in this CL are just the consequence of changing the constness of the WindowDelegate::GetInitiallyFocusedView method.
BUG=6859
TEST=Open a web page, from the page menu, select the "Create application shortcut..." menu. In the dialog, press the TAB key, focus should alternate between the different fields
Review URL: http://codereview.chromium.org/21439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on locale_settings_en-US.rc.
We don't use this anywhere yet, just putting things in place.
- Fix preprocessor defines in grit vcproj files (needs to be defined
everywhere) and update grit_localized_resources.rules to pass the
preprocessor define to grit.
- Add generated .h files to chrome_strings.vcproj so people can ctrl+alt+a
open them.
- Update GRIT so it knows how to substitute [GRITLANGCODE] in strings
to the locale value.
Review URL: http://codereview.chromium.org/20440
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
which I suspect is causing purify ui test flakeyness.
BUG=6557
TEST=none
Review URL: http://codereview.chromium.org/20439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
regression.
TBR=darin
Review URL: http://codereview.chromium.org/20436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
callback to use GearsShortCutData2.
Review URL: http://codereview.chromium.org/20412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
circumstances this might be NULL if we opened the file after initialization and
it failed. In this case, we should just silently fail rather than throwing
an invalid parameter exception.
I'm not 100% sure this will fix the bug below, I did this by inspection.
BUG=7566
Review URL: http://codereview.chromium.org/21425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- It seems that BrowserList::GetLastActive() is returning null, probably it takes longer now for the browser to become active.
- But rather than guessing the profile, get it from the guts of the location bar.
- crasher is ranked #34 by Laforge
BUG=6211
Review URL: http://codereview.chromium.org/20381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=6538
Review URL: http://codereview.chromium.org/21432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
line used in the vertical edges - this difference is not apparent visibly. I suspect this happens due to the way Skia handles colors/shading a bit differently.
Review URL: http://codereview.chromium.org/20376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DNS pre-resolution system already "learns" what domains are commonly
needed when rendering sub-resources of a page at a given domain.
This patch saves (some of) the information learned into a persistent
pref, and restores it on startup.
For now, I put in a wimpy pruning of the list each time I save, so that
the list will not grow endlessly from session to session. I probably need
a better pruning algorithm, such as one that prunes after a given amount
of time, rather than only during shutdown. For now, this should get
a lot of nice results, and provide slightly larger than needed lists to
users that have long lived sessions, which is similar to the current
performance, where I didn't persist any info, and only pruned (actually
discarded) all learned info at shutdown.
r=mbelshe
Review URL: http://codereview.chromium.org/21374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Go ahead and convert our toolbar buttons to using the theme data
pack file.
Review URL: http://codereview.chromium.org/20433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Stop watching extension dirs for user script changes.
* Stop supporting unversioned extension dirs.
Also a few minor related cleanups.
Review URL: http://codereview.chromium.org/20390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
code from browser.cc to go along with it as well as enabling more functionality.
Review URL: http://codereview.chromium.org/21424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows. It was rather bogus that we were doing this before as there
is nothing for the window to link to.
BUG=5836
TEST=see bug
Review URL: http://codereview.chromium.org/21426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which mirror the vcproj files used by Windows.
Add the linux specific code to generate .pak files that we use for
resources on linux.
This doesn't include the necessary changes to build the theme default.dll on
windows, but the windows scons build is already really broken so punting for
now.
Review URL: http://codereview.chromium.org/21371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
redraw and scrolling issues.
Review URL: http://codereview.chromium.org/20435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I added more TODOs than I removed, but they're now for more subtle cases:
- the web page didn't handle a keystroke and our accelerators should;
- you tab off the end of the list of tabbable things on the page.
Review URL: http://codereview.chromium.org/21428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
advanced gestures. Returning to create a new tab is just wrong.
Review URL: http://codereview.chromium.org/20434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the version to 20.
BUG=7271
TEST=Start Chrome in Hebrew Windows or with cmdline switch "--country=IL --lang=he" and set the default
search engine to tapuz (it's in Hebrew) and type a keyword in the omnibox and select search with 'tapuz'.
Search result should come up with multiple hits.
Review URL: http://codereview.chromium.org/20315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
without registering its prefs.
Review URL: http://codereview.chromium.org/20431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a class for managing images for scalable themed widgets, and then
implement the toolbar on top of this.
Review URL: http://codereview.chromium.org/21390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I felt guilty that I allowed url_request_job to have some logic
in it about whether it can load an SDCH dictinary or not. This
patch pushed the logic back into sdch_manager (where it belongs).
r=wtc
Review URL: http://codereview.chromium.org/20379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- rename the mac platform delegate to be .mm so we can use cocoa in it.
- added the sandbox profile jeremy figured out.
- add the profile file to the project build.
- during renderer startup, check the process type and use our custom profile or
the pure compute profile based on if we're a renderer or a unittest.
Review URL: http://codereview.chromium.org/21419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
actual sandbox setup (to tell if we're a unittest vs. real chromium process).
Review URL: http://codereview.chromium.org/20425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
menus.
Review URL: http://codereview.chromium.org/20245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the delegate of the TabContents object. That allows page-load notifications to make their way through the browser UI layer. Hook up notification to Mac tab strip to set the title as it's changed.
Review URL: http://codereview.chromium.org/20429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/20428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that testing does stop.
Add a cancelation flag, set by run_webkit_tests.py on
KeyboardInterrupt and checked by the TestShellThread between each
test.
Have the TestShellThread record exception info if it's run() aborts on
an uncaught exception. Have run_webkit_tests.py check for such
exceptions after joining all threads, and re-raise it if found so as
to make it clear that testing was aborted. Otherwise, tests that did
not run would be assumed to have passed.
Review URL: http://codereview.chromium.org/21087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bug https://bugs.webkit.org/show_bug.cgi?id=23934). The SVG rebaseline
is because we now anti-alias text decorations correctly.
BUG=2982
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/21420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the visual representation. As such, we need to make sure the frame is
layed out, otherwise things are in a weird state and we get a crasher.
BUG=4123
TEST=Go to http://www.orkutplus.net/category/orkut-themes and make
sure we don't crash
Review URL: http://codereview.chromium.org/21364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
landing an upstream fix we always rendered rounded rect shadows as
solid rects. Now we correctly render them. The colored rectangle
behind 'multiple' in is a different color then that of the mac because
it's selected text.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/24019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pinkerton
Review URL: http://codereview.chromium.org/20424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/21416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
focusable, and clear the focus if it's not. This shouldn't kick in in any cases today (I don't think), but it will matter in fullscreen mode, where creating a new tab should not attempt to focus the (unfocusable) location bar, but should not do nothing either, since these leaves focus in a hosed state.
There are other choices here. I could make View::RequestFocus() try and clear the focus if the view is not focusable. That seems likely to cause side-effects unless I restore a lot of the calls to IsFocusable() that I previously removed. I also don't know whether sticking this on BrowserWindow was the right approach; if there's a better spot architecturally, speak up.
Review URL: http://codereview.chromium.org/21368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9882 0039d316-1c4b-4281-b951-d872f2087c98
|