| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
After talking with Darin, I'm convinced this was a bad idea. The issue is that Linux can't actually know the encoding of the file (bad Linux!), so on Linux this method is nonsensical. It also turns out to not be useful for the case I thought I needed it for.
Review URL: http://codereview.chromium.org/16252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace it with an implementation of GetScreenInfoHelper like
the other platforms. This webkit glue function is implemented
in webkit_glue_mac.mm.
Now that we have a GetScreenInfoHelper implemented for each
platform, I moved the implementation of GetScreenInfo into
test_shell.cc.
R=dglazkov
Review URL: http://codereview.chromium.org/16470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and with page heap enabled these tests consistenly crashed on me. I've
no idea about this code, but this change fixed it. As far as I can
tell in some cases Send deletes the NPObjectProxy, so that any code
that attempts to access the proxy after the Send may crash.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/16418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/16251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16469
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeRequestContext class. This will allow us to put browser-specific request
context here rather than in URLRequestContext and eliminates a lot of
duplicate code.
I looked at having two different classes using either inheritance (as proposed
by the existing TODO) or composition, but it seems like there isn't enough
difference between these two classes to justify it.
Removed is_off_the_record() because it wasn't being used anywhere and did a
few other minor code cleanup things.
Review URL: http://codereview.chromium.org/16408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that our subprocesses have started up. This causes Windows to promptly stop showing the IDC_APPSTARTING cursor when opening a new tab or navigating to a new domain via the location bar.
BUG=4805
R=ananta
Review URL: http://codereview.chromium.org/16464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
preparation for the refactoring.
Review URL: http://codereview.chromium.org/16225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pam
Review URL: http://codereview.chromium.org/16465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
build.
Review URL: http://codereview.chromium.org/16463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It starts failing with FILE, identifier not found, when
you remove the include for logging.h, which is included
in scoped_handle_win.h
Review URL: http://codereview.chromium.org/16461
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
it is skipped.
BUG=none
TEST=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/16460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay
Review URL: http://codereview.chromium.org/16245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove a wrong baseline and update the test list.
Review URL: http://codereview.chromium.org/16242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Fix missing Autoreleasepool warning in SafeBrowsing Unittest.
Review URL: http://codereview.chromium.org/16243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5814
Review URL: http://codereview.chromium.org/16237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* add POSIX version of IsPathWritable
* convert IsPathWritable to FilePath
* convert CreateNewTempDirectory to FilePath
* fix a bug where recursive delete errors weren't being handled in POSIX
Review URL: http://codereview.chromium.org/16241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/16455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
From http://codereview.chromium.org/16429/ by contributor ibrar.ahmed@gmail.com
TBR=pamg
Review URL: http://codereview.chromium.org/16454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this test fails on linux so we can't just rebaseline
tbr=ericroman
Review URL: http://codereview.chromium.org/16453
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
list.
BUG=2976
TBR=sky
Review URL: http://codereview.chromium.org/16240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is for places where you need to use a FilePath in a non-filesystem context (for example, adding a file to an archive file, or constructing a file:// URL).
Review URL: http://codereview.chromium.org/16239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=eroman
Review URL: http://codereview.chromium.org/16432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin
Review URL: http://codereview.chromium.org/16802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/16452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/transforms/2d/transform-value-types-expected.html. This
needs to be rebaselined as V8 returns different results for typeof
CSSValueList and WebKitCSSTransformValue then KJS.
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/16451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=eroman
Review URL: http://codereview.chromium.org/16449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=eroman
Review URL: http://codereview.chromium.org/16448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I jumped the gun, Peter raised additional issues after we
both LGTM'ed (and I didn't notice those emails).
TBR=pkasting
Review URL: http://codereview.chromium.org/16234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ctrl+U should show up view-source on Application shortcuts.
According to pkasting in dev mailing list:
"Ctrl-U for an application should do what the context menu
option does: open a source tab in some normal window."
Hence, made it a NEW_FOREGROUND_TAB for disposition
TBR=pkasting
BUG=http://crbug.com/5115
Review URL: http://codereview.chromium.org/16233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR: dglazkov
Review URL: http://codereview.chromium.org/16231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you use Alt-Shift-T and the arrow keys to go to the Page menu
and then launch the Save Page As dialog, we would navigate back after
saving the page.
This is because once we close the Save As dialog with Enter, focus
goes to the Back button (which arguable is also wrong, see issue 5750)
and it receives a KeyRelease(Enter), which causes us to navigate back
right after saving the page.
In Windows, pressing Enter while a button has focus clicks the button
on KeyPressed, whereas we currently click the button on KeyRelease.
This patch makes Chrome mimic native Windows behavior. We retain
the current behavior for Space, however, which clicks on KeyReleased
in both Chrome and Windows.
BUG=4830
TEST=Native Chrome buttons should click buttons on KeyPress when using
Enter and on KeyRelease when using Space.
Review URL: http://codereview.chromium.org/16202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/16217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
matches linux except for scrollbar differences.
TBR=sky
Review URL: http://codereview.chromium.org/16439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I think this will just pass in windows as well, but leaving the test as
failing until the buildbot runs the test.
Review URL: http://codereview.chromium.org/16438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
build on Friday).
TBR=darin
Review URL: http://codereview.chromium.org/15801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/16603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
power message status.
Review URL: http://codereview.chromium.org/16220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
animation methods to layout test controller.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/16602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
eventually do.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/16433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7395 0039d316-1c4b-4281-b951-d872f2087c98
|