| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
exception when you try to access a key
at an index that's greater than or equal to ___Storage.length, it simply returns a null.
This is yet another demonstration of why we need a NullableString16 (rather than passing around a string and
a bool) but this cannot block on that work.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
assuming a UTF16 to UTF8 conversion. Also, includes a .utf16() method on
WebCString to get a UTF16 string out. These methods mirror the similar
methods for UTF8 on WebString.
Make use of these conversion methods in a few more places.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WidgetGtk we should dispatch the event, not eat it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugin_carbon_interpose.dylib from the outer browser app bundle to the inner
helper app bundle.
Provide a separate app bundle for subprocesses like the renderer on the Mac.
Remove LSUIElement and related hacks from the browser's app bundle.
BUG=8044
TEST=Observe one Chromium and one or more Chromium Helper processes in
Activity Monitor
Review URL: http://codereview.chromium.org/164177
Review URL: http://codereview.chromium.org/164303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
wiki changes
Review URL: http://codereview.chromium.org/164302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
implementation. The stub will be replaced once the rest of
sync/engine lands as we open source the sync engine code.
Review URL: http://codereview.chromium.org/165257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make instructions a drag target and also make it possible to right click on it.
Also fix http://crbug.com/18967
Also report the right action in the drag motion handler (MOVE vs. COPY).
BUG=18967
Review URL: http://codereview.chromium.org/164295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
login credentials expire and we need the user to re-enter their
password.
Review URL: http://codereview.chromium.org/164278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
histograms:Sync.MergeAndSyncNeededCountNumber of times merge and sync is needed to run.Sync.AuthorizationTimeTime taken during initial authorization.Sync.UserPerceivedAuthorizationTimeTime the user spends looking at the authorization dialog.Sync.BookmarkAssociationTimeTime taken during bookmark association.Sync.ReauthorizationTimeTime taken from startup for the user to reauthorize.
Sync.Events
This is an enumeration of distinct events of the following types:
Number of times sync was started from the ad in NTP.Number of times sync was started from the Wrench menu.Number of times sync was started from Wrench->Options.Number of times sync was stopped from Wrench->Options.Number of times sync was stopped during the sign-on process.Number of times sync was stopped after successfully authorized.Number of times sync was cancelled when the merge dialog was surfaces.
BUG=None.
Test=None.
Review URL: http://codereview.chromium.org/165111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=amanda
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Will it fix browser_tests crashes on Vista?
Review URL: http://codereview.chromium.org/165287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL splits GtkIMContext related code into separated source files from render_widget_host_view_gtk.{h,cc}, making the code clearer to read. It also fixes issue 18061.
Focus moving issues related to AutocompleteEditViewGtk will be addressed in another CL, see issue 18393 for reference.
BUG=18061: pressing tab on form textfields goes directly to submit or login buttons
TEST=Starts scim's xim server with command "scim -d", then launches chrome with GTK_IM_MODULE=xim. Opens a web page with multiple input box, such as gmail.com, presses Tab and Shift-Tab multiple times to see if focus moves among focusable elements in the web page.
Review URL: http://codereview.chromium.org/160577
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/165284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/165278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Making it a copy by using a checked in copy if available or falling back on
the system copy otherwise.
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/164297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18229
Review URL: http://codereview.chromium.org/165245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
restored to the tab contents.
BUG=18294
Review URL: http://codereview.chromium.org/160566
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactored IMC for to be more safe and easy
to use.
It still needs:
*) structures/wrappers for message responces
*) Some of the error checking could probably be
moved out of the inidivdual message processing
functions
*) Need some constants or wrappers for the
handles so a message isn't pulling things
out of handles by magic numbers.
Review URL: http://codereview.chromium.org/165266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
than the desired size.
This makes the code a little more readable anyway.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a general rework of how "crashed extension" infobar works
and how the extension is actually recovered after the crash.
TEST=See bug.
http://crbug.com/15888
Review URL: http://codereview.chromium.org/164151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instances, SendNotifications was being run before CancelAuthDeferred, so the proper cleanup was not happening before this object was deleted which leads to a crash.
BUG=18973
TEST=Instructions in the bug report.
Review URL: http://codereview.chromium.org/165268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/164119
Items in the Downloads page should be loaded like a normal OS file when dragged
to a Tab content area. We need the URL to be set to the file path in the
IDataObject so that WebDropData can properly handle the file.
BUG=9266
TEST=Drag an item with a supported MIME type from the Downloads page to a Tab
content area. It should load within the browser. Drag an item with an
unsupported MIME type and it should not open it.
Review URL: http://codereview.chromium.org/165260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Made changes requested by maruel in http://codereview.chromium.org/159830. Also fixed DEPENDENT_DIRS check for windows.
TBR=maruel
Review URL: http://codereview.chromium.org/164270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove LSUIElement and related hacks from the browser's app bundle.
BUG=8044
TEST=Observe one Chromium and one or more Chromium Helper processes in
Activity Monitor
Review URL: http://codereview.chromium.org/164177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dark themes.
BUG= http://crbug.com/18451
TEST= Install a dark theme, cause download shelf to appear, note that the close button is visible.
Review URL: http://codereview.chromium.org/164276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
net_unittests was broken when using the system zlib.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=If it doesn't break the tree, it's perfect.
http://crbug.com/17706
Review URL: http://codereview.chromium.org/164096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I consulted RFC 959 while making the changes and checked with real FTP sites.
TEST=Covered by net_unittests.
http://crbug.com/4965
Review URL: http://codereview.chromium.org/165161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I found a much better way to implement middle-click-to-navigate: use gtk_get_current_event() to get the button release event that triggered the "clicked" signal. This simplifies greatly a lot of places that I had previously added complication.
Also this adds middle click to navigate on the go button.
Also this makes middle click on a bookmark bar button depress the button.
Review URL: http://codereview.chromium.org/165261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=maruel
Review URL: http://codereview.chromium.org/165247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18362
TEST=none
Review URL: http://codereview.chromium.org/164031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user has closed all browser windows and then tries to exit
with downloads in progress, Mac Chrome would just quit. This CL
handles the case of exiting without any windows open.
BUG=15899 (http://crbug.com/15899)
TEST=Start a download, close all windows then try to exit. Chrome
will now prompt the user with an exit confirm dialog.
Review URL: http://codereview.chromium.org/164273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adding support for whitelisting all URLs using a wildcard
and using namespace in place of URL for fallback and network
sections.
BUG=none
TEST=added checks for wildcard character in all sections
Review URL: http://codereview.chromium.org/165151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for us
BUG=18984
Review URL: http://codereview.chromium.org/165276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it.
BUG= http://crbug.com/18451
TEST= none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=amanda
BUG=17499
TEST=Happier Mac WebKit bot
Review URL: http://codereview.chromium.org/164283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=amanda
BUG=none
TEST=Happier Mac WebKit test bots.
Review URL: http://codereview.chromium.org/165267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like this one arrived via http://trac.webkit.org/changeset?new=46977@trunk/WebCore&old=46910@trunk/WebCore
TBR=awalker
BUG=16908
TEST=none
Review URL: http://codereview.chromium.org/165264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=18966
TEST=none
Review URL: http://codereview.chromium.org/165263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=18966
Review URL: http://codereview.chromium.org/165262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sgk
BUG=18939
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12030
TEST=Visit a site with an unsupported plugin (e.g., QuickTime); the plugin should not be loaded at all, rather than loading and then crashing.
Review URL: http://codereview.chromium.org/164272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22951 0039d316-1c4b-4281-b951-d872f2087c98
|