| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Removed packet_size parameter from Open().
2. Removed OnClose() from the callback. Now the callback is guaranteed to be called only between Start() and Stop().
3. Added samples_per_packet in the AudioParameters struct.
BUG=39825
TEST=Unittests
Review URL: http://codereview.chromium.org/4661001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=62777
TBR=jcivelli
Review URL: http://codereview.chromium.org/4796001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=unint test
BUG=none
Review URL: http://codereview.chromium.org/4632003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=62776
TBR=jcivelli
Review URL: http://codereview.chromium.org/4646008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=62772
TBR=jcivelli
Review URL: http://codereview.chromium.org/4722003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CloudPrintURLFetcherRetryBackoffTest.GiveUp
tests as flaky.
Bug=62758
TBR=sanjeevr
Review URL: http://codereview.chromium.org/4663003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
should change the functional behavior of the class or the tests, it just makes the upcoming functional patch smaller and clearer.
BUG=54274
TEST=none
Review URL: http://codereview.chromium.org/4627001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4683004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It has all sorts of +x files. We'll just be careful.
Review URL: http://codereview.chromium.org/4771005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
testSearchSelection
testSpecialChars
testFindInLargePage
testFindLongString
testFindBigString
testRandomFindTests
testFindWholeFileContent
testSingleOccurrence
testSearchInPDF
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3967003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61991
TEST=Enable Instant. Load extension at chrome/common/extensions/docs/examples/extensions/chrome_search. Type "src foo" into the omnibox. You should not see Instant displaying an error page.
Review URL: http://codereview.chromium.org/4782001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suppresion.
TEST=mac_valgrind
BUG=58244
Review URL: http://codereview.chromium.org/4755002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build/test windows connection
Review URL: http://codereview.chromium.org/4774001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason it's still failing on XP (but not other windows builders).
BUG=55642
TEST=none
Review URL: http://codereview.chromium.org/4788002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4774002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replacing the TODO(port) to log extension-N for the extensions
associated with a dump.
CL which landed TODO(port): http://codereview.chromium.org/457028
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4645005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=8455,8780,1127,11228,11229,13282
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4696002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
are a number of parts of this patch that need work, but it should be
good enough for us to decide if we want to pursue it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4385001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
defaults".
BUG=46510
TEST=manual
Review URL: http://codereview.chromium.org/4737003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, use it in MenuGtk, and implement it in BackForwardMenuModel.
BUG=38452
TEST=manual
Review URL: http://codereview.chromium.org/4780001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug introduced by me in 65223. The boolean indicating whether histograms
have been dumped must be on navigation_state instead of page_load_histograms.
Introduce a histogram for the Web Timing page load time which measures
the commit to the start/end of the load event. Also introduce two histograms
for troubleshooting abandonment and missing starts. We will use these
histograms temporarily for vetting these metrics.
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62289
TEST=open sync encryption settings.
Review URL: http://codereview.chromium.org/4780003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that the complete request is logged, not just the extra_headers.
Before I broke things, HttpNetworkTransaction was attempting to
do the logging, but after some refactors it no longer has access
to the final request. SpdySession already logs correctly in the
SPDY case, and I modified HttpBasicStream to log in the HTTP case.
Added unit tests is both HttpNetworkTransactionTest and
SpdyNetworkTransactionTest.
BUG=48962
TEST=net_unittests --gtest_filter=HttpNetworkTransactionTest.SimpleGET\*
Review URL: http://codereview.chromium.org/4644003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove current overrides (they have been moved to the upstream file and/or
those tests have been fixed)
- Add inspector/styles-source-lines-inline.html, which appears to be flaky
BUG=none
TEST=none
TBR=ukai
Review URL: http://codereview.chromium.org/4788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
if it can be lost.
BUG=52689
TEST=http://www.corp.google.com/~scheib/no_crawl/canvas2dtests/minupload1.html. Jitters/popping in texture are a side-effect of NON GPU accelerated rendering. Smooth rotation will occur only with GPU acceleration. On Windows XP even with --enable-accelerated-2d-canvas, only software rendering should appear. On Vista and later the flag should result in smooth rotation.
Review URL: http://codereview.chromium.org/4320003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
intuple.h/browser_render_process_host.cc (see bug description)
This is chromeos only and will be removed once I correct data.
BUG=chromium-os:7327
TEST=none
Review URL: http://codereview.chromium.org/4752003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I had wrong assumption that connected->connecting won't happen.
BUG=chromium-os:8285
TEST=none
Review URL: http://codereview.chromium.org/4678004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I forgot to init a member in r65677.
BUG=none
TEST=valgrind
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we install an extension without an icon, then we shouldn't
attempt to create an icon for it in the installed extension popup.
BUG=62607
TEST=ExtensionGalleryInstallApiTest.InstallAndUninstall
Review URL: http://codereview.chromium.org/4785001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first part, beginInstall, must be called during a user gesture. The second
part should supply a matching id and actually starts the download and install
process.
BUG=61954
TEST=Requires webstore server side changes before it can be fully tested. For
now, you can test that visiting the webstore and running something like the
following command in the javascript console generates an error:
chrome.webstorePrivate.beginInstall("mihcahmgecmbnbcchbopgniflfhgnkff")
Review URL: http://codereview.chromium.org/4727001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dangerous downloads always have different target_name from its full_path.BaseName(). Returning true from NeedsRename() wrongly makes DownloadManager::DownloadRenamedToFinalName() to call ContinueDownloadFinished() while it's not finished yet.
Renamed DownloadItem::NeedsRename() to NeedsRenameForSafeDownload() to avoid further confusion.
BUG=62398
TEST=downloads.DownloadsTest.testNoUnsafeDownloadsOnRestart
Review URL: http://codereview.chromium.org/4660007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Reland. First landed in r65714, reverted in r65715.)
These tests are Linux only for now. Adding Mac support should be pretty
easy. However, Windows will be tough to do without making the tests
flakey. Given the huge amounts of pain caused by testserver.py and
ephemeral ports I'd rather get the tests working well on a couple of
platforms (since the Snap Start code is all platform-generic anyway),
then add more flakiness.
BUG=none
TEST=snap_start_unittests
http://codereview.chromium.org/4524003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This was a TODO for chron).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4155010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ukai
Review URL: http://codereview.chromium.org/4750004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The view already has a parent in some shutdown scenarios.
gtk_box_pack_start: assertion `child->parent == NULL' failed
ExtensionInfoBarDelegate::CreateInfoBar() [0x7bdeea]
InfoBarContainerGtk::AddInfoBar() [0x7e67e8]
InfoBarContainerGtk::UpdateInfoBars() [0x7e68c5]
InfoBarContainerGtk::ChangeTabContents() [0x7e6b16]
BrowserWindowGtk::TabSelectedAt() [0x7a2241]
TabStripModel::ChangeSelectedContentsFrom() [0xae4523]
TabStripModel::DetachTabContentsAt() [0xae710a]
TabStripModel::Observe() [0xae71ec]
NotificationService::Notify() [0x14fe3bb]
TabContents::~TabContents() [0xacc83f]
BUG=62606
Review URL: http://codereview.chromium.org/4762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r65714. It broke the Linux shared library builders:
SOLINK(target) out/Debug/obj.target/net/libnet_base.so
/usr/bin/ld: error: out/Debug/obj.target/openssl/third_party/openssl/openssl/crypto/sha/sha512t.o: multiple definition of 'main'
/usr/bin/ld: out/Debug/obj.target/openssl/third_party/openssl/openssl/crypto/sha/sha256t.o: previous definition here
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests are Linux only for now. Adding Mac support should be pretty
easy. However, Windows will be tough to do without making the tests
flakey. Given the huge amounts of pain caused by testserver.py and
ephemeral ports I'd rather get the tests working well on a couple of
platforms (since the Snap Start code is all platform-generic anyway),
then add more flakiness.
BUG=none
TEST=snap_start_unittests
http://codereview.chromium.org/4524003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In IsAllowedBadCert, the pointer compare doesn't always work. Creating a
certificate by X509Certificate::CreateFromBytes and putting it in the
allowed bad list doesn't match the same certificate from a server.
InvalidateSessionIfBadCertificate: I'm sure that there's history here
that I don't know, so please review carefully. In order to test
resumption against a server with a test certificate we need to avoid
destroying the session.
ClearSessionCache, AdoptSocket: only for testing
BUG=none
TEST=none
http://codereview.chromium.org/4558004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=jcivelli
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
OptionsUtil::ResolveMetricsReportingEnabled().
BUG=62626
TEST=No DCHECKs when toggling crash reporting in debug+official builds.
Review URL: http://codereview.chromium.org/4771002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EXPECT_NSEQ() and EXPECT_NSNE() were implemented in terms of [x
isEqual:y]. This meant that EXPECT_NSEQ(nil, nil) failed, and
EXPECT_NSNE(nil, nil) succeeded. Add additional tests against the raw
pointers to resolve this.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4697004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/4058002
BUG=None
TEST=Was already passing try bots, etc. Now we're checking waterfall buildbot configs.
Review URL: http://codereview.chromium.org/4772001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently -[NSView setToolTip:] don't handle removing any existing
display. -removeAllToolTips or -setToolTip:nil both appear to do the
right thing.
This handles both transitions because you can go from reload mode to
stop mode due to in-page activity.
Unfortunately, after transition the new tooltip will never appear.
AFAICT, you can't force a tooltip up, we'd probably have to fake out
the appkit machinery, which seems excessive to me.
BUG=61556
TEST=See bug.
Review URL: http://codereview.chromium.org/4451003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
classifier. Patch by Naoki Takano (see http://codereview.chromium.org/4142006 ), r=me.
BUG=60059
TEST=Change a search engine keyword to "a", highlight text beginning with "a" in a webpage (e.g. "a movie"), right-click and select "Search Google for a movie". The result should be a Google search page, not a result page for whatever search engine has the keyword "a".
Review URL: http://codereview.chromium.org/4717001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and rename accordingly.
Rename URLResponseInfo.GetBody to GetBodyAsFileRef.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/4747001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
possible (Visual Studio C++ and GCC C++0x mode), specify int32_t as the representation type of the enum. For C, where enum gives us no type safety, just typedef an int32_t to the enum name. In all other cases, use a compile-time assertion to ensure that enums are 4 bytes wide.
This change only applies the new PP_ENUM macro in 2 commonly used places. This is to make sure that the (possibly contraversial) usage of variadic macro arguments is acceptable before I go change it everywhere. If I can't use variadic macro arguments, I think I will have to separate this in to 2 macros and the enum declarations will look something like this:
PP_ENUM_BEGIN(PP_Bool)
PP_FALSE=0, PP_TRUE=1
PP_ENUM_END(PP_Bool)
BUG=61004
TEST=This should be exercised by all tests that use PP_Bool and PP_Var.
Suggestions for improvement are welcome, as always.
Review URL: http://codereview.chromium.org/4720005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/4775001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=62629
TEST=Verify that metrics checkbox does not cause DCHECK failure on Chrome build.
Review URL: http://codereview.chromium.org/4654003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=13644
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4684003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/4718002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65700 0039d316-1c4b-4281-b951-d872f2087c98
|