| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
It's time to kill this. It's been marginally useful, but only marginally.
http://codereview.chromium.org/222021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
point in the code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fix division by zero if running only 1 WONTFIX test.
2) Do not add to the missing list if a test missing the result is marked as WONTFIX.
Also update the test_expectation list:
1) Remove SKIP for one test so that we can rebaseline it later.
2) Remove a qt test that was skipped previously because its missing result.
BUG=none
TEST=non
Review URL: http://codereview.chromium.org/246013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser crash that triggers ~100 times a day:
`anonymous namespace'::PureCall()
_invalid_parameter_noinfo
std::vector<unsigned char,std::allocator<unsigned char> >::operator[](unsigned int)
WebCursor::GetCursor(HINSTANCE__ *)
RenderWidgetHostViewWin::UpdateCursorIfOverSelf()
RenderWidgetHostViewWin::UpdateCursor(WebCursor const &)
I was unable to reproduce myself, so I don't know if the bad cursor came from
the web or from the Windows "external cursor" concept. Accordingly:
- Do not accept 0-sized cursors from the renderer.
- Do not access array[0] on an empty array as per other call sites in the
cursor code.
Thanks to The Mighty Hoppy for triggering this via means unknown!
BUG=NONE
TEST=NONE (unable to reproduce)
Review URL: http://codereview.chromium.org/251008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closes the dialog.
BUG=19786
TEST=Open Sync Bookmaeks Login dialog. Enter credentials, TAB between fields, etc. to ensure nothing is broken. Hit the ESC key to dismiss the dialog.
Patch by Randy Posynick (http://codereview.chromium.org/199069)
Review URL: http://codereview.chromium.org/246020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
GTK: Listen for BROWSER_THEME_CHANGED and upload proper colors.
BUG=23031
Review URL: http://codereview.chromium.org/248006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Currently, RSAPrivateKeyUnitTest.InitRandomTest takes too long to pass.
We ignore istrumentation of NSS to speed up the tests that use it.
Review URL: http://codereview.chromium.org/242032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Darwin-specific ignore files to ThreadSanitizer.
This is necessary because ThreadSanitizer cannot handle the dSYM files
properly and the "src:*" ignore rules don't work on Mac.
The ignores_mac file contains the rules that make ThreadSanitizer
ignore the false positives reported on
base::subtle::{NoBarrier_Load, Release_Store}
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/251017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
off the appropriate archive directory. This allows us to not lose the
layout tests results history one one of the bots is clobbered.
A small change is needed to the buildbots to pass in the --build-name flag
before we'll be able to actually grab the results of archive location.
Review URL: http://codereview.chromium.org/246014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
TEST=LayoutTests/fast/loader/*
BUG=8407
Review URL: http://codereview.chromium.org/243011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the list.
BUG:9798
Review URL: http://codereview.chromium.org/248018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix one "fullscreen" to be "full screen" to match all other uses (not yet used, so no translation issue for windows)
Fix two new strings that were in Title Case instead of Sentence case.
BUG=22257
TEST=the context menus on different types of web content should be title case on mac/linux but sentence case on windows. These are new strings, so they won't exist in other languages yet.
Review URL: http://codereview.chromium.org/244004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
==25902== </valgrindoutput>
==25902== FATAL: in suppressions file "/b/slave/chromium-rel-linux-valgrind-tests-1/build/src/tools/valgrind/memcheck/suppressions.txt" near line 1081:
==25902== too many callers in stack trace
==25902== exiting now.
So, i'm making the stack trace smaller.
Review URL: http://codereview.chromium.org/244020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for windows.
Please don't commit code that does not compile.
Review URL: http://codereview.chromium.org/244019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/248016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is still not perfect, but all least it should work
for all the use cases we currently have.
Review URL: http://codereview.chromium.org/254001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr:oshima@chromium.org
Review URL: http://codereview.chromium.org/242028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/235037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Tim's fix works.
Review URL: http://codereview.chromium.org/246018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/245023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CommandLine::Terminate.
This should relieve the purify redness.
TBR=nick
TEST=ProfileSyncServiceTest, sync_unit_tests
Review URL: http://codereview.chromium.org/243023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it fails too often on linux.
Also disable LayoutTests/transitions/transition-end-event-left.htmt
It looks like all the transition-end-event-* are flaky.
BUG:9798
Review URL: http://codereview.chromium.org/248015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
disabled because of flakyness, but it's not disabled, and it's
really flaky, so i'm disabling it for real.
BUG:22668
Review URL: http://codereview.chromium.org/242027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteEditViewTest.BrowserAccelerators
because they started failing all the time.
TBR:pkasting
BUG:23213
Review URL: http://codereview.chromium.org/246017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco@chromium.org
BUG=23197
TEST=None
Review URL: http://codereview.chromium.org/243020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add failure for newly added test for me to investigate.
TBR=senorblanco@chromium.org
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/242023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolling right up to the next breakage.
Adding new breakages that I need to investigate.
TBR=senorblanco@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/251006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=22926
Review URL: http://codereview.chromium.org/235033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=22926
Review URL: http://codereview.chromium.org/242015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It only adds a svn:ignore.
NO CODE CHANGE.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/235035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Linux shared build.
TBR=maruel
Review URL: http://codereview.chromium.org/245020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
wstring to avoid conversions "To and From wstring".
BUG=None
TEST=run unit_tests.exe
Review URL: http://codereview.chromium.org/217008
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/249011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23138,23139,23140
TEST=none
Review URL: http://codereview.chromium.org/249012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=27303.
TBR: arv
Review URL: http://codereview.chromium.org/242021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002
TBR=bradnelson@google.com
Review URL: http://codereview.chromium.org/244017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bradnelson
Review URL: http://codereview.chromium.org/249014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315
Review URL: http://codereview.chromium.org/153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
APIs. This change is purely additive. I'll rip out the old mechanism in the
next patch.
R=agl
Review URL: http://codereview.chromium.org/243012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think/hope this is the last big CL for this.
*) Moved GAPIInterface enums to cmd_buffer_format.h
The reason is you should not have to include CODE
to make data. The fact that the enums were in
GAPIInterface, a class, meant you had to include
code if you wanted to make a command buffer.
*) Typed arguments where I could.
So for example Draw takes PrimitiveType instead of
uint32. CreateVertexBuffer takes a ResourceId
*) Renamed enums etc to match style guide.
*) Moved BitFields into specific commands
*) renamed arguments from id to type_id.
Review URL: http://codereview.chromium.org/234002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/222017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It requires you to declare all views built an additional time. Sigh...
TBR=erikkay
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/244016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Browser Actions are like Page Actions, except they appear next to the Omnibox and are always visible. For details see http://code.google.com/p/chromium/wiki/BrowserActions.
Added a simple browser action sample that adds a Print button to the chrome toolbar (which brings up the Print dialog for the current page).
Removed |type| from PageActions, which is currently ignored and was already removed from the docs.
Each extension can only have 1 browser_action. Each browser action can specify more than one icon, but only the first is used. And no API has been added yet (besides the event definition).
BUG=22099
TEST=Install the sample browser action, navigate to google.com, press the print button. A print dialog should come up.
Review URL: http://codereview.chromium.org/243001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox
Review URL: http://codereview.chromium.org/153002
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/244014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
logging.h to suppress the definition of LOG() and friends unless
explicitly requested. Fix gyp paths to overrides files.
Review URL: http://codereview.chromium.org/225001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox
Review URL: http://codereview.chromium.org/153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27315 0039d316-1c4b-4281-b951-d872f2087c98
|