summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use utf_string_conversions header in more places.maruel@chromium.org2009-12-1112-14/+12
| | | | | | | | | | | Patch contributed by Thiago Farina (thiago.farina@gmail.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/465065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34348 0039d316-1c4b-4281-b951-d872f2087c98
* Pass one empty argument to ApuAgentDelegate.DispatchToApu to match ↵yurys@chromium.org2009-12-111-0/+1
| | | | | | | | | | ExtensionDevToolsBridge::OnRpcMessage. BUG=30087 Review URL: http://codereview.chromium.org/491046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34346 0039d316-1c4b-4281-b951-d872f2087c98
* adding a comment to trigger buildsthomasvl@chromium.org2009-12-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34345 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable ExtensionDevToolsBrowserTest.TimelineApi which is ↵yurys@chromium.org2009-12-111-1/+1
| | | | | | | | | | | failing after 34337 TBR=pfeldman BUG=30087 Review URL: http://codereview.chromium.org/490015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34342 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 51960:51976.eroman@chromium.org2009-12-112-3/+11
| | | | | | | | | | | | | | The change to weburlloader_impl.cc comes from: http://codereview.chromium.org/477008 Which is needed when picking up: http://trac.webkit.org/changeset/51967 TBR=dglazkov Review URL: http://codereview.chromium.org/487025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34341 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: support rpc messages with 4 and 5 argumentsyurys@chromium.org2009-12-116-13/+105
| | | | | | Review URL: http://codereview.chromium.org/491042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34340 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out the resource generation actions for Linux and FreeBSD.satorux@chromium.org2009-12-111-72/+89
| | | | | | | | | | | | | | | | | | | | | | | Create a new target 'packed_resources' that can be used for building resource files for Linux and FreeBSD, without building the chrome binary. The new target is useful for test programs that depend on the resource files. For example, view_examples on Linux depends on chrome.pak to be present in the product directory. Hence we needed to build "chrome" before "view_examples" just for resource files, which is not great. Note that I tried to unify the actions with Mac, but failed as Mac needs to build the mac bundle as part of chrome_dll library. TEST=try --clobber; locally clean-built chrome on linux. BUG=29969 Review URL: http://codereview.chromium.org/486006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34339 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: build fix add new line at the end of fileyurys@chromium.org2009-12-111-1/+2
| | | | | | | | TBR=pfeldman Review URL: http://codereview.chromium.org/490013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34338 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: use WebDevToolsMessageData for devtools rpc messagesyurys@chromium.org2009-12-1122-301/+269
| | | | | | | | Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34333 Review URL: http://codereview.chromium.org/463065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34335 (webkit merge 51960:51976).eroman@chromium.org2009-12-111-1/+1
| | | | | | | | | | For some reason this epic-failed on builders, even though it was fine on canary! TBR=dglazkov Review URL: http://codereview.chromium.org/491041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34336 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 51960:51976.eroman@chromium.org2009-12-111-1/+1
| | | | | | | | TBR=dglazkov. Review URL: http://codereview.chromium.org/488016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34335 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "DevTools: use WebDevToolsMessageData for devtools rpc messages"yurys@chromium.org2009-12-1121-264/+299
| | | | | | | | This reverts commit ea393f34b293ebf8b96bef5855b9f41faf82b192. Review URL: http://codereview.chromium.org/492018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34334 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: use WebDevToolsMessageData for devtools rpc messagesyurys@chromium.org2009-12-1121-299/+264
| | | | | | Review URL: http://codereview.chromium.org/463065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34333 0039d316-1c4b-4281-b951-d872f2087c98
* Get web app icon via FavIconHelper and auto repair/updatexiyuan@chromium.org2009-12-1110-175/+599
| | | | | | | | | | | | | | | | | | | | | - Expose a DownloadImage method from FavIconHelper to download/decode image for an image url; - Expose FavIconHelper from TabContents; - Update CreateApplicationShortcutView to use the exposed DownloadImage method to get web app icon instead of do it via URLFetcher/PNGCodec; - Check and update web app icon and shortcuts when chrome is lauched as app for OS_WIN; - Code cleanup: - Move a bunch of FavIconHelper methods that are not used externally to private; - Remove an unused cancelable_consumer_ from TabContents; BUG=8539 TEST=Verify issue 8539 is fixed. And create a web page with a non PNG shortcut icon and verify it shows up in create application shortcut dialog. Review URL: http://codereview.chromium.org/482003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34332 0039d316-1c4b-4281-b951-d872f2087c98
* Fix three issues in the RSS extension.finnur@chromium.org2009-12-113-12/+32
| | | | | | | | | | | | | | | 1) Content script now only talks to the background page if a feed is found, preventing one frame with feed info getting clobbered by another frame without feed info. 2) Properly deleting the feed info as the tab is closed. 3) Linux doesn't support popups so I've readded the onClick handler. BUG=None TEST=None Review URL: http://codereview.chromium.org/491039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34331 0039d316-1c4b-4281-b951-d872f2087c98
* It's unfortunate that some of the baselines of images on Linux were affectedmarkus@chromium.org2009-12-111-0/+1
| | | | | | | | | | | | | both by scrollbar changes and by SVG changes, and that both sets of images and the code are getting updated in somewhat overlapping fashion. It turns out, one of the tests was fixed for a few hours and then broke again when WebKit changed (I think). BUG=29748 Review URL: http://codereview.chromium.org/486028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34327 0039d316-1c4b-4281-b951-d872f2087c98
* LTTF: editing/selection/last-empty-inline is passing.hamaji@chromium.org2009-12-111-1/+0
| | | | | | | | | | | The upstream fix: https://bugs.webkit.org/show_bug.cgi?id=31985 BUG=28916 TEST=trybot Review URL: http://codereview.chromium.org/491003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34326 0039d316-1c4b-4281-b951-d872f2087c98
* After rebaselining the scrollbar images for Linux, a lot of tests have startedmarkus@chromium.org2009-12-111-396/+0
| | | | | | | | | working again. Updating the test expectations for these tests. BUG=29748 Review URL: http://codereview.chromium.org/484001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34325 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r34321 as it breaks the task manager:estade@chromium.org2009-12-112-15/+10
| | | | | | | | | | | | | | | | ------------------------------------------------------------------------ r34321 | estade@chromium.org | 2009-12-10 18:19:50 -0800 (Thu, 10 Dec 2009) | 5 lines Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process is fast-terminated (i.e., didn't crash). BUG=30057 Review URL: http://codereview.chromium.org/492014 Review URL: http://codereview.chromium.org/487023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34324 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 51959:51960.eroman@chromium.org2009-12-111-1/+1
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/488015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34323 0039d316-1c4b-4281-b951-d872f2087c98
* Find bar fixes:estade@chromium.org2009-12-114-20/+52
| | | | | | | | | | | | - prefer previous find from same tab contents over overall most recent find when re-opening find bar - GTK + Windows: always update find bar view text if it doesn't match the search results. TEST=see bug for repro steps BUG=30006 Review URL: http://codereview.chromium.org/482015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34322 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process ↵estade@chromium.org2009-12-112-10/+15
| | | | | | | | | | is fast-terminated (i.e., didn't crash). BUG=30057 Review URL: http://codereview.chromium.org/492014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34321 0039d316-1c4b-4281-b951-d872f2087c98
* Make flakiness dashboard "auto"-update expectations feature way less annoying -jparent@chromium.org2009-12-113-25/+129
| | | | | | | | | | | | | switch from using confirms to just html with buttons. This allows you to switch away from the tab at any time, and allows you to exit out of updating at any time. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/486026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34320 0039d316-1c4b-4281-b951-d872f2087c98
* fix chromeos buildoshima@chromium.org2009-12-112-4/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/492013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34319 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: for branded Google Chrome, handle SIGTERM in renderer to clean up Breakpad.viettrungluu@chromium.org2009-12-111-0/+137
| | | | | | | | | | | | | | | | | | | | Test: 1. Build a (branded) Google Chrome. 2. From the command-line, run: "launchctl bslist | wc -l" and note the number. 3. Start Google Chrome on a fresh profile. 4. Once a browser window has opened, do #2 again, and note the number -- it should have increased (by 2). 5. Close the tab, and do #2 again. The number should have decreased by 1. 6. Open tabs, navigate, etc., and do #2 between each stage. Whenever a new (e.g., renderer) process is started, the number should increase (e.g., when you go to a "new" site). When a process is terminated (e.g., you close the last tab for a particular site), the number should decrease. 7. Quit, and do #2 again. Hopefully, the number should be the same as the first time. (Note: when a renderer crashes, the number will not decrease -- so the number after quitting will not be the same as before starting. This is why this is only a stopgap. For comparison, do this on a branded Google Chrome without this patch; typically, the numbers will not decrease on renderer termination.) BUG=28547 TEST=See above. Review URL: http://codereview.chromium.org/484007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34318 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 51915:51959.eroman@chromium.org2009-12-112-4/+20
| | | | | | Review URL: http://codereview.chromium.org/491018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34317 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fixes bug where extension background hosts were being cleared when the ↵andybons@chromium.org2009-12-114-4/+35
| | | | | | | | | | last window was closed. It assumed that this meant the app was closing. Not the case with Mac apps. Added a mac-only notification APP_TERMINATED and use that to perform cleanup upon shutdown. TEST=More description in the bug, but basically just make sure that background views stick around even after you've closed the last window. BUG=28666 Review URL: http://codereview.chromium.org/465143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34316 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FFmpeg build for ARMhclam@chromium.org2009-12-116-15/+821
| | | | | | | | Add missing config.h. Review URL: http://codereview.chromium.org/491010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34315 0039d316-1c4b-4281-b951-d872f2087c98
* Handle the case of two scroll events cancelling each other out.darin@chromium.org2009-12-112-0/+21
| | | | | | | | | | R=pkasting BUG=none TEST=covered by unittests Review URL: http://codereview.chromium.org/491022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34314 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the manipulator samples so that the common javascript code is ↵simonrad@chromium.org2009-12-114-756/+312
| | | | | | | | | | | | | | | included from a js file. There is only one function that is specialized for each sample. The function is referenced in the js file but not defined. It is then defined in each html file. R=kbr BUG=none TEST=none Review URL: http://codereview.chromium.org/487019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34312 0039d316-1c4b-4281-b951-d872f2087c98
* Implement PhoneField, a FormField that matches a phone number field in a form.jhawkins@chromium.org2009-12-114-0/+162
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/488010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34311 0039d316-1c4b-4281-b951-d872f2087c98
* Logging cleanup for run_webkit_tests. This significantly revises the outputdpranke@google.com2009-12-114-167/+343
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to run_webkit_tests. First, a number of log messages have had their levels changed (mostly to make them quieter). Second, the script outputs a "meter" that shows progress through the test run, which is a one line summary of where it's at current (e.g. "parsing expectations", "gathering files". During the actual test execution, the meter displays "%d tests completed as expected, %d didn't, %d remain". The meter uses carriage returns but no linefeeds, so the output is overwritten as it progresses. The meter is disabled if --verbose is specified, to avoid unnecessary confusion. Third, I removed the --find-baselines option. I think I was the only one using it, and --sources is good enough (but added the baseline for the checksum as well as the .png when using --sources). Fourth, there is a new "--log" option that can be used to provide finer granularity of logging. It accepts a comma-separated list of options, like: --log 'actual,expected,timing': "actual": the actual test results (# of failures by type and timeline) "config": the test settings (results dir, platform, etc.) "expected": the results we expected by type and timeline "timing": test timing results (slow files, total execution, etc.) All of this information is logged at the logging.info level (if the appropriate option is enabled). Using the --verbose switch will cause all of options to be logged, as well as the normal verbose output. In addition, the verbose output will disable the meter (as mentioned above). Note that the "actual" results will be logged to stdout, not stderr, for compatibility with the buildbot log parser. Finally, the list of unexpected results (if any) will be logged to stdout, along with a one-line summary of the test run. The net result is that when run with no command line options (and when no tests fail), only one line of output will be produced. R=ojan@chromium.org,pam@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/465089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34310 0039d316-1c4b-4281-b951-d872f2087c98
* Add Arne's FAQ.kathyw@google.com2009-12-1036-222/+490
| | | | | | | | | | | (Already reviewed for content.) TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/490006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34309 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Puts a NULL check in case a native plugin library cannot be loaded ↵andybons@chromium.org2009-12-101-1/+1
| | | | | | | | | | (.dll on mac, for example). TEST=Load an extension that requires a .dll or other platform-specific file and make sure it does not crash the browser. BUG=29584 Review URL: http://codereview.chromium.org/492012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34308 0039d316-1c4b-4281-b951-d872f2087c98
* Don't force kill apache, and use the Apache-supplied PID for web server cleanup.mmoss@google.com2009-12-106-23/+36
| | | | | | | | | | | | SIGKILL was causing Apache to leave semaphores hanging around, leading to resource starvation and Apache failures on the bots (see also http://rackerhacker.com/2007/08/24/apache-no-space-left-on-device-couldnt-create-accept-lock/). Using the PID returned from Popen wasn't actually cleaning up anything, causing Apache processes to linger until the next run. Also change the shutdown method to just take a pid, since that's all it uses from the process object anyhow. TEST=After running layout_test_wrapper.py (like http://chrome-buildbot.corp.google.com:8016/builders/Webkit%20Linux%2064%20(V8-Latest)/builds/5080/steps/webkit_tests/logs/stdio), there are no lingering chrome-bot semaphores (ipcs -s | grep chrome) or apache processes (ps aux | grep apache2) Review URL: http://codereview.chromium.org/491025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34307 0039d316-1c4b-4281-b951-d872f2087c98
* landing the issue 482008 for dmuiroshima@chromium.org2009-12-101-1/+1
| | | | | | | | | | | original cl: http://codereview.chromium.org/482008 BUG=29578 TEST=Run valgrind test Review URL: http://codereview.chromium.org/491028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34306 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using the dummy window for QD plugin drawingstuartmorgan@chromium.org2009-12-104-81/+72
| | | | | | | | | | | | | This simplifies things a bit over the old way, and should be a step closer to supporting more QD-based plugins. Also makes the HandleInputEvent logic a bit clearer. BUG=none TEST=QuickTime movies should still play on the Mac. Leaving a page with QuickTime content should not cause a crash. Review URL: http://codereview.chromium.org/491027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34305 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix failing tests on the chrome frame builder.ananta@chromium.org2009-12-101-3/+4
| | | | | | | | | | The function to set keyboard focus to the chrome renderer window in a chrome frame instance was sending the mouse click to the ancestor window, which is not correct. The ancestor window is only needed to bring the whole hierarchy to the foreground. Review URL: http://codereview.chromium.org/491026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34304 0039d316-1c4b-4281-b951-d872f2087c98
* Don't screw up the retain count on the original WindowRef referenced by the ↵maf@google.com2009-12-101-0/+11
| | | | | | | | | copy we make of the browser NSWindow. We were accidentally disposing the dummy window in the plugin process that Chrome makes. Review URL: http://codereview.chromium.org/486021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34303 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppressions for a few fixed racestimurrrr@chromium.org2009-12-101-27/+0
| | | | | | | BUG=21468,22520,28559 Review URL: http://codereview.chromium.org/490008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34302 0039d316-1c4b-4281-b951-d872f2087c98
* Display channel in about box after version. Windows.jrg@chromium.org2009-12-101-1/+75
| | | | | | | | | BUG=3000 TEST=see bug Review URL: http://codereview.chromium.org/463062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34301 0039d316-1c4b-4281-b951-d872f2087c98
* BufferSend needs to call memio_GetWriteParams() and transport_->Write()wtc@chromium.org2009-12-102-23/+95
| | | | | | | | | | | | | | | | twice because the circular memio buffer may have two contiguous parts of data. In the SSLClientSocket unit tests, we should compare the result of sock->Write() with the expected value whether it completes synchronously or asynchronously. R=dank BUG=29815 TEST=a new unit test that issue a hanging Read and then issue a Write. Review URL: http://codereview.chromium.org/464082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34300 0039d316-1c4b-4281-b951-d872f2087c98
* Queue appcache update if current update process is terminating.jennb@chromium.org2009-12-107-3/+256
| | | | | | | | | TEST=update and group unittests added BUG=none Review URL: http://codereview.chromium.org/465132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34299 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Samples docs to point to the right placefinnur@chromium.org2009-12-102-2/+2
| | | | | | | | | | | | | in the repository for the RSS extension. BUG=None TEST=Open Chrome Extension Samples page, click the source code link and you should see the source, not a 404. Review URL: http://codereview.chromium.org/490004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34298 0039d316-1c4b-4281-b951-d872f2087c98
* First batch of GCC fixes for GPU code.scherkus@chromium.org2009-12-108-15/+21
| | | | | | | | | | | | This patch addresses signed/unsigned and 64-bit errors. The remaining fixes are more involved requiring changes/ifdefs to get around HWND. There's also a ton of "unused variable" warnings in the auto-generated code. BUG=n/a TEST=n/a Review URL: http://codereview.chromium.org/492009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34296 0039d316-1c4b-4281-b951-d872f2087c98
* .png assets that the chrome-login-for-chromeos change relies uponcmasone@google.com2009-12-103-0/+0
| | | | | | Review URL: http://codereview.chromium.org/491012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34295 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in manifest documentation.finnur@chromium.org2009-12-102-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/489006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34294 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromiumos build, try 2estade@chromium.org2009-12-101-1/+2
| | | | | | | tbr=oshima git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34293 0039d316-1c4b-4281-b951-d872f2087c98
* Only load resources for renderer, extension, and zygote processestony@chromium.org2009-12-101-9/+29
| | | | | | | | | | | | (and plugins processes on Windows). We used to always try to load them, even if we didn't use them. It would work fine if an update happened (because we didn't use them) and the files were replaced. Review URL: http://codereview.chromium.org/487001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34292 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromeos compileestade@chromium.org2009-12-101-1/+1
| | | | | | | | TBR=wtc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34291 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 00:40:57 +0000