| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/119231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and installer_util_strings.{rc,h}.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/118284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IPC channel (doh!).
BUG=119052
TEST=covered by ui test that Amit added
Review URL: http://codereview.chromium.org/119158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/119230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TCPClientSocketPool. Strictly a refactoring.
BUG=http://www.crbug.com/13289
TEST=still builds and tests pass
Review URL: http://codereview.chromium.org/119184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11678
TEST=Make a theme with bad references to images and try to install it. Or just verify that the InstallTheme unit_test passes.
Review URL: http://codereview.chromium.org/119137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
between the IPC layer and the audio hardware interface.
We have completely moved away from being blocking in
AudioRendererHost.
Since we'll be using PushSource for a longer period
of buffering. It's necessary to have
Play/Pause functionality in the AudioOutputStream,
this is simulated by start/stop the AudioOutputStream
multiple times.
Review URL: http://codereview.chromium.org/114069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current cert was already expired on Sat May 2 17:02:55 UTC 2009.
Update to the cert of validity
Not Before: Mar 18 23:35:19 2008 GMT
Not After : Mar 18 23:35:19 2011 GMT
BUG=none
TEST=net_unittests passes
Review URL: http://codereview.chromium.org/118231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<ibrar.ahmad@gmail.com>.
Now we can browse some ftp sites and can download files.
There are some TODO yet to be fixed.
Original review: http://codereview.chromium.org/115291
R=wtc
BUG=http://crbug.com/4965
TEST=none
Review URL: http://codereview.chromium.org/118274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR
Review URL: http://codereview.chromium.org/119225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
takes down the pulse machine too with it
Review URL: http://codereview.chromium.org/118288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Anticipating a broader test base, I wanted to reduce the percentage of
uses that were "holdback" (sdch not used when it was available). This
should reduce the impact on users, and also be sufficient to get
verification statistics from a larger group.
r=huanr
Review URL: http://codereview.chromium.org/118287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some dicitoaries provided by an SDCH server may be larger than
allowed by Chromium (which holds the dictionary memory-resident).
This CL prevents Chromium from endlessly re-trying such dicitonary loads,
BUG=7722
r=huanr
Review URL: http://codereview.chromium.org/119198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hopefully this will cure teh flaky problem under Valgrind.
I also had to re-read my own code, and so I put in to minor changes to
hopefully make it incrementally easier ot read. There should be no semantic
changes caused by my coding changes, but the level of nested braces is
reduced, which makes it easier ot see what is (supposed to be) going on.
r=dank,phajdan
Review URL: http://codereview.chromium.org/42266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This relands http://src.chromium.org/viewvc/chrome?view=rev&revision=17605
which was reverted in 17638.
It also disables MassiveConcurrentLookupTest, which was a stress test,
and is partially obsolete since the class now responds to congestion
produced by NOT resolving all names.
BUG=13356
TBR=willchan
Review URL: http://codereview.chromium.org/119196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old code was wrong and racy and the new message loop
really exposed the bug. It would be preferable to just wait
until the content area was properly sized, but I kept running
into corner cases trying to get that to work.
BUG=13364
TEST=more layout tests should pass
Review URL: http://codereview.chromium.org/119197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
systems, use sysctl(3) for OpenBSD
Review URL: http://codereview.chromium.org/118289
Patch from Peter Valchev <pvalchev@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This avoids some duplication in setup.
Review URL: http://codereview.chromium.org/118293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mouse is over it.
On windows, when the render view regains focus it receives a mouse move event with the coordinates of the pointer. We don't on linux, so we have to fake this. Without this, webkit doesn't know where the pointer is, so can have a wrong cursor or other graphical glitches.
TEST=bug is fixed
BUG=12879
Review URL: http://codereview.chromium.org/113987
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
re-open. Evmar, willchan, and I are still investigating.
TEST=none
BUG=13388
Review URL: http://codereview.chromium.org/119219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not the right time to move SineWaveAudioSource to a common
unit test yet since linux doesn't have mock audio stream
implemented.
TBR=cpu, willchan
Review URL: http://codereview.chromium.org/118286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that the browser window is informed of the download
shelf visibility status at the end of the show / hide animation.
BUG=13369
Review URL: http://codereview.chromium.org/118278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=erikkay
Review URL: http://codereview.chromium.org/119199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=nick
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
startup_tests.exe, page_cycler_tests.exe, plugin_tests.exe,
security_tests.dll, test_chrome_plugin.dll, theme/default.dll.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The change actually supports arbitrary write size but
write size greater than read size (packet size) is prohibited
by an explicit check.
Review URL: http://codereview.chromium.org/118170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Unit test for AudioMessageFilter
Review URL: http://codereview.chromium.org/119136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
See also http://codereview.chromium.org/118192
Review URL: http://codereview.chromium.org/118272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
They're ASCII anyway.
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/119131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Valgrind error that doesn't yet make sense.
BUG=none
TEST=none
TBR=willchan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This causes a DCHECK in FindBarWin if the Find box is open when the user switches to another app with Alt+Tab.
The Focus manager now calls ClearFocus everywhere it used to set focused_view_ = NULL, to make sure the event reaches all listeners for FocusWillChange.
BUG=13350
TEST=Open Chrome, press Ctrl+F then Alt+Tab. Swith focus back to Chrome and press Esc multiple times and you should not see the Find box flash briefly.
Review URL: http://codereview.chromium.org/118267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make Task Manager Table view a scoped_ptr so it and its columns are deleted regardless of whether or not the HWND has been constructed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/118243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
automation.lib, common.lib, debugger.lib, plugin.lib, renderer.lib.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents::GetSSLEVText methods.
This is discovered by Fumitoshi Ukai.
R=jcampan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
we keep the connection alive even if the server or proxy
tells us to close it.
R=eroman
BUG=http://crbug.com/8771
TEST=none
Review URL: http://codereview.chromium.org/119068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Change by Chase Phillips <cmp@google.com>
http://crbug.com/9576
TEST=open a standalone GMail shortcut window, attempt to drop a tab from an existing browser window into it. It should not be added.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13342
Review URL: http://codereview.chromium.org/119207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
test for the new behavior.
TEST=covered by unittest
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just the interface declaration plus a mocked
implementation of the interface.
BUG=12258
TEST=none
Review URL: http://codereview.chromium.org/119072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
indicates it's necessary (now that fetching the last change
info is in a separate target executed every build) by
getting rid of the never-built .bogus files in the rules.
Update chrome/installer/installer.gyp with the new patterns.
Make the use of the *_path variable names more consistent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
compatibility.
BUG=13001
TEST=Put an icon theme in $HOME/.icons, set it as the icon theme, and make sure Chromium picks it up on the download page. (May need to restart Chromium.)
Review URL: http://codereview.chromium.org/119206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've looked through old/new images and it looks to me they are all correctly passing tests and the difference is the recently updated scrollbar rendering, as described in bug http://code.google.com/p/chromium/issues/detail?id=13313.
BUG=13313, 13314
TEST=none
Review URL: http://codereview.chromium.org/118257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts svn://svn.chromium.org/chrome/trunk/src@17664 0039d316-1c4b-4281-b951-d872f2087c98
It broke linux test_shell_tests.
Review URL: http://codereview.chromium.org/119203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
compilation issues
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The old code was wrong and racy and the new message loop really exposed the
bug.
Review URL: http://codereview.chromium.org/119197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17663 0039d316-1c4b-4281-b951-d872f2087c98
|