summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixes crash that occurred because DialogClientView::AcceptWindow wassky@google.com2008-09-052-0/+15
| | | | | | | | | | | | | | | | | getting invoked twice. It appears that because we hide the window then destroy the window after a delay, it is possible for messages to get dispatched after the hide. Dispatching messages after the window was closed made it possible for two enters to be dispatched, which triggered a crash. I've modified the FocusManager to only dispatch key messages if the window is visible. BUG=1361863 TEST=See bug, but also make sure there are no weird focus traversal/accelerator issues in our dialogs. Review URL: http://codereview.chromium.org/251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1802 0039d316-1c4b-4281-b951-d872f2087c98
* generate the webkit_version.h header at build time. Use webkit_glue.cc ↵pinkerton@google.com2008-09-051-5/+5
| | | | | | | | instead of forking our own for mac. Review URL: http://codereview.chromium.org/261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1801 0039d316-1c4b-4281-b951-d872f2087c98
* Dupe of http://codereview.chromium.org/238jungshik@google.com2008-09-053-8/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The download page was quickly changed to address bug 1358202, but still there's a problem that the UI langauge of Chrome set-up program is different from what a user choose in the following scenarios: * English is chosen on non-en-US OS * Hebrew is chosen on non-Hebrew OS * Norwegian Bokmal is selected on non-Norwegian Bokmal OS Once these changes go in for next-point-release, the change made on the download server can be reverted. 1. Aliases {iw,no,tl} to {he,nb,fil}. 2. Also map en to en-US. 3. Map {zh-HK, zh-MK, zh-SG} to {zh-TW, zh-TW, zh-CN} This does not yet deal with other potentially problematic cases. Added a similar change for l10n_string_util.cc for installer . Tony already LGTM'd 238 so that I'm tbr'ing here. BUG=1358202 TEST=L10n* unittest TBR=tc Review URL: http://codereview.chromium.org/260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1800 0039d316-1c4b-4281-b951-d872f2087c98
* Modify HostResolver slightly to build on posix as well as windows.dkegel@google.com2008-09-054-1/+57
| | | | | | Review URL: http://codereview.chromium.org/403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1799 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve Array Overflow.sidchat@google.com2008-09-051-7/+10
| | | | | | | BUG=1362175 Review URL: http://codereview.chromium.org/474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1796 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback revisions 1785-1786 due to purify regression.aa@google.com2008-09-0510-368/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1795 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:ignore for xcodebuild and third_party/platformsdk_vista_6_0mmentovai@google.com2008-09-050-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1792 0039d316-1c4b-4281-b951-d872f2087c98
* Add non_thread_safe.cc and trace_event.cc to the Mac buildmmentovai@google.com2008-09-051-0/+12
| | | | | | Review URL: http://codereview.chromium.org/257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1789 0039d316-1c4b-4281-b951-d872f2087c98
* SCons build: move hamc_win.cc from the list of to-be-ported sourcesgk@google.com2008-09-051-1/+2
| | | | | | | | files to the list of Windows-only source files. Add hmac_mac.cc to the list fo Mac-only source files. Review URL: http://codereview.chromium.org/256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1787 0039d316-1c4b-4281-b951-d872f2087c98
* Missing files from r1785.aa@google.com2008-09-052-0/+147
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1786 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to begin compiling the files that implemen the HTML5aa@google.com2008-09-058-2/+221
| | | | | | | | | | | database API. This time, I added a project dependency from WebCore to sqlite on every solution that includes WebCore. Review URL: http://codereview.chromium.org/466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1785 0039d316-1c4b-4281-b951-d872f2087c98
* back out part of last change, better fix upcoming.pinkerton@google.com2008-09-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1784 0039d316-1c4b-4281-b951-d872f2087c98
* fix copy/paste errorpinkerton@google.com2008-09-051-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1783 0039d316-1c4b-4281-b951-d872f2087c98
* pick up another forked file in pending/kjs, if-def scrollView and bitmap ↵pinkerton@google.com2008-09-052-1/+37
| | | | | | | | usage in webframe until we're ready to tackle it. Review URL: http://codereview.chromium.org/248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1780 0039d316-1c4b-4281-b951-d872f2087c98
* ifdef around windows codepinkerton@google.com2008-09-051-1/+10
| | | | | | Review URL: http://codereview.chromium.org/249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1779 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include paths for v8 (v8/public -> v8/include)pinkerton@google.com2008-09-051-14/+14
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1778 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash. I believe this is happening during sessionsky@google.com2008-09-056-2/+44
| | | | | | | | | | | | | | | | end, which has a different shutdown path and is possible for the model to be deleted before the view. I'm also adding checking to XPFrame/VistaFrame to make sure the BookmarkBarView doesn't have a parent in the destructor. This shouldn't be possible, but I'm adding the check to be sure;) BUG=1359852 TEST=make sure you don't see problems with bookmarks Review URL: http://codereview.chromium.org/440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1754 0039d316-1c4b-4281-b951-d872f2087c98
* Same CL as 448. Had to redo it.cpu@google.com2008-09-055-21/+41
| | | | | | | | | | | | | Change the default download path if needed, in Vista it could be set tothe destkop which is a risky location.- Remove reading the download location from IE in vista.BUG=b/1355855 This was already LGTmed Review URL: http://codereview.chromium.org/462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1753 0039d316-1c4b-4281-b951-d872f2087c98
* Cache empty responses from the SafeBrowsing servers for GetHashpaulg@google.com2008-09-056-11/+67
| | | | | | | | | | | requests so that we don't keep asking for full hashes that don't exist. We flush this cache with each update, which is a little aggressive, but on the safe side. BUG=1358225 Review URL: http://codereview.chromium.org/454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1748 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crashing bug when shutting down the plugin process.michaeln@google.com2008-09-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1747 0039d316-1c4b-4281-b951-d872f2087c98
* New Frames.beng@google.com2008-09-051-1/+2
| | | | | | | | | Fix browser UI tests relating to page titles. "- Chromium" was not being appended to the window title. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1746 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back 1737 because it broke the build.aa@google.com2008-09-047-361/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1741 0039d316-1c4b-4281-b951-d872f2087c98
* Add base\trace_event.cc to the SCons build.sgk@google.com2008-09-041-0/+1
| | | | | | Review URL: http://codereview.chromium.org/449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1739 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build under Linux; there were recent changes toerg@google.com2008-09-042-27/+38
| | | | | | | | | webkit which meant we needed to disable some files temporarily. Review URL: http://codereview.chromium.org/447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1738 0039d316-1c4b-4281-b951-d872f2087c98
* gAdds the files that implement the HTML5 Database API to theaa@google.com2008-09-047-2/+361
| | | | | | | | | | | | | project. Also adds stubs for the integration with the renderer. Right now, the integration is done by just replacing two key cpp files: DatabaseTracker and OriginQuotaManager. Once this all gets up and running, I'll circle back and think about the changes necessary to WebCore to do a more elegant integration. Review URL: http://codereview.chromium.org/601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1737 0039d316-1c4b-4281-b951-d872f2087c98
* My new test is failing on the bots. Disabling while I investigate.finnur@google.com2008-09-041-1/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1736 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the following bugs reported with the Silverlight plugin:-iyengar@google.com2008-09-041-0/+10
| | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=248 http://code.google.com/p/chromium/issues/detail?id=666 The basic issue here was that the plugin would not paint correctly. The URLs mentioned in this bug load windowed silverlight plugin instances, which invoke the NPN_InvalidateRect API to paint. We send over the rects to the renderer, however these don't generate paints as the plugin is windowed. A peek at Safari's webkit implementation revealed that they merely invoke the InvalidateRect windows API in this context. The fix is to emulate this behavior. Review URL: http://codereview.chromium.org/431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1735 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-09-045-16/+16
| | | | | | | TBR=mal Review URL: http://codereview.chromium.org/442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1730 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the issue where a sub chunk coming in before an add chunk, both containg ↵jam@chromium.org2008-09-043-3/+42
| | | | | | | | | the same prefixes, will lead to the whole hostname looking like it's blocked. BUG=1358531 Review URL: http://codereview.chromium.org/439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1729 0039d316-1c4b-4281-b951-d872f2087c98
* bump for 152 dev cycle (151 built successfully)mal@chromium.org2008-09-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1728 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing issue 1343052: a regression where the Find box moves up when you open ↵finnur@google.com2008-09-043-3/+4
| | | | | | | | | | | | | | | a new tab and close it again. This is because during a TabClosingAt call, we end up calling ShowTabContents(NULL) which leads to ShelfVisibilityChangedImpl(NULL). Because the parameter current_tab is NULL, we end up removing the BookmarkBarView from the RootView (only to add it back a little too late), the Find window thinks there is no BookmarkBar and hence moves up a bit. I am also enabling the disabled UI test I wrote for this, since it should now pass. BUG=1343052 TEST=Covered by UI test. Review URL: http://codereview.chromium.org/441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1727 0039d316-1c4b-4281-b951-d872f2087c98
* Invoke a flag setting for 'dictionary download over' in the IO loop through ↵sidchat@google.com2008-09-041-33/+33
| | | | | | | | a proxy in the UI loop. Review URL: http://codereview.chromium.org/438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1726 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to pending to get WebCore to compile on linux. Thistc@google.com2008-09-0414-25/+33
| | | | | | | | | | | | | | | | | | doesn't enable it yet since there are more changes to WebKit that we need from the merge. Once the merge lands, pending will probably be clobbered, so this is temporary to allow us to keep moving forward. Go ahead and switch from PLATFORM_CHROME to PLATFORM_CHROMIUM and try to change all the places in the mac code. This change includes bits from http://codereview.chromium.org/228 which is by Seo Sanghyeon. Everything still compiles on Windows. Review URL: http://codereview.chromium.org/1201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1725 0039d316-1c4b-4281-b951-d872f2087c98
* HMAC-SHA1 implementation for Mac based on CommonCrypto;mmentovai@google.com2008-09-048-54/+238
| | | | | | | allow Windows HMAC-SHA1 to use keys longer than 16 bytes. Review URL: http://codereview.chromium.org/218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1724 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash caused by a NULL FILETIME when creating ftptc@google.com2008-09-042-3/+42
| | | | | | | | | directory listings. BUG=1350006 Review URL: http://codereview.chromium.org/419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1722 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to webkit/port to build via gcc on linux/mac.tc@google.com2008-09-042-2/+2
| | | | | | | | | | This is part of the change on issue 228, I'm just breaking it up into pieces to make it easier merge with. http://codereview.chromium.org/228 Review URL: http://codereview.chromium.org/437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1721 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up brettw's checkin of r1032.wtc@google.com2008-09-043-11/+1
| | | | | | | | | | | Fix a DCHECK on ssl().content_status() in web_contents.cc. Remove the unused ResetInternal method of NavigationController. R=brettw Review URL: http://codereview.chromium.org/221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1720 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the step to copy the rlz dll for the official builder.nsylvain@google.com2008-09-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1718 0039d316-1c4b-4281-b951-d872f2087c98
* Make gcc 4.1 happy with NULL in EXPECT_EQ.mmoss@google.com2008-09-041-3/+3
| | | | | | | | | This avoids warnings like: src/base/thread_local_unittest.cc:88: warning: passing NULL to non-pointer argument 3 of 'static testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*, const char*, const T1&, T2*) [with T1 = int, T2 = <unnamed>::ThreadLocalTesterBase]' Review URL: http://codereview.chromium.org/226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1716 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r1648 in timer_unittest.cc, this was for testing and should have nevermmentovai@google.com2008-09-041-24/+0
| | | | | | | escaped my working copy. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1712 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the polymorphic WindowResources class and FramePartBitmap enum.maruel@google.com2008-09-047-72/+84
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1710 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in BookmarkBarView. If the HistoryService fails to load itsky@google.com2008-09-045-60/+27
| | | | | | | | | | | | | | was possible for BookmarkBarView to deref NULL (the model_ field). There is no point in having the BookmarkBarView wait for history to load now though, so I've taken this out which makes it impossible to get in this situation. BUG=1356168 TEST=make sure bookmarks still work correctly Review URL: http://codereview.chromium.org/426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1709 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in history view. The crash occurs with the followingsky@google.com2008-09-042-0/+20
| | | | | | | | | | | | | | | | | | | | | | | sequence: 1. Delete a day of history. 2. Before the delete finishes, click to delete another day. 3. While the modal dialog is up wait for the delete/reload to complete. 4. Click ok. This crashes because the index supplied to delete in step 2 is bogus after step 3 completes. I suspect we could make this a bit more elegant, but I'm holding off until we figure out the HTML versions of these. BUG=1358107 TEST=Make sure history deletion still works. Review URL: http://codereview.chromium.org/602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1708 0039d316-1c4b-4281-b951-d872f2087c98
* Add cast to fix warning with gcc 4.1.mmoss@google.com2008-09-041-1/+1
| | | | | | | | | | src/webkit/port/platform/graphics/svg/SVGPaintServerGradientSkia.cpp: In constructor 'WebCore::SkiaGradientBuilder::SkiaGradientBuilder(const WTF::Vector<std::pair<float, WebCore::Color>, 0u>&, float)': src/webkit/port/platform/graphics/svg/SVGPaintServerGradientSkia.cpp:82: warning: passing 'float' for argument 1 to 'SkColor SkColorSetARGB(U8CPU, U8CPU, U8CPU, U8CPU)' Review URL: http://codereview.chromium.org/429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1707 0039d316-1c4b-4281-b951-d872f2087c98
* If we didn't read enough to be able to decrypt anything,wtc@google.com2008-09-041-0/+4
| | | | | | | | | | | go back to read more rather than reporting 0 bytes read, which would be interpreted as EOF. R=darin BUG=b/1329345,b/1329363 Review URL: http://codereview.chromium.org/217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1705 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the include order in aero_glass_frame.cc. This was causing issues with ↵maruel@google.com2008-09-041-2/+2
| | | | | | | | WPO enabled. Review URL: http://codereview.chromium.org/430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1703 0039d316-1c4b-4281-b951-d872f2087c98
* Localize the 11th hour popup window hack. Right before release, we made a ↵erg@google.com2008-09-042-10/+10
| | | | | | | | change to the behaviour of constrained windows, where we hard coded English strings. Localize this now... Review URL: http://codereview.chromium.org/427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1702 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead files.jam@chromium.org2008-09-042-225/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1701 0039d316-1c4b-4281-b951-d872f2087c98
* [abridged bug report from keunwoo]mmoss@google.com2008-09-041-2/+9
| | | | | | | | | | | | | | | These commands directly use 'type', which is the Microsofty way of saying 'cat'. type is also a valid shell builtin on Bourne-style shells, including bash and dash, with completely different semantics and slightly different error behavior among shells. Whereas dash will silently echo the line foo is foo for any foo which is not recognized, bash dies with an error that looks like this: type: foo: not found Since the default /bin/sh on Ubuntu Hardy is dash, the above scons commands silently pass, happily producing bogus html4.css and quirks.css. Review URL: http://codereview.chromium.org/415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1700 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the new frames' BrowserView2::TabSelectedAt calls ↵beng@google.com2008-09-031-1/+5
| | | | | | | | | TabContents::DidBecomeSelected, like Browser::TabSelectedAt does for the old frames. This was causing tab-restore related features (undo close tab, duplicate tab) to result in sad tab being shown when using the magic_browzR switch. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1698 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-06 16:58:40 +0000