summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Pull the entire hunspell tree and place it in depsBUG=14756TEST=Compiled ↵mhm@chromium.org2009-08-21550-4599046/+13
| | | | | | | | Chromium, ran tests Review URL: http://codereview.chromium.org/174127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23957 0039d316-1c4b-4281-b951-d872f2087c98
* More removal of WebCore usage from webplugin_impl.ccdarin@chromium.org2009-08-2118-114/+118
| | | | | | | | | | | | Adds a few helper methods on WebFrame. R=jam BUG=10036 TEST=none Review URL: http://codereview.chromium.org/173152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23956 0039d316-1c4b-4281-b951-d872f2087c98
* Change backing store constructor so that it bases the CGLayer on the parentamanda@chromium.org2009-08-212-4/+12
| | | | | | | | | window's characteristics, and change DidScrollRect to do immediate painting. BUG=14823 TEST=scrolling should appear slightly smoother on some machines Review URL: http://codereview.chromium.org/174223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23955 0039d316-1c4b-4281-b951-d872f2087c98
* Make the page info window remember its placement origin on the Macpinkerton@chromium.org2009-08-213-18/+92
| | | | | | | | | | | | | * Store x/y origin in the local state PrefService * Offset new windows when creating them so they don't overlap * Add a unit test for remembering window placement * Refactor PageInfoWindowControllerTest to make use of SetUp() Patch from Robert Sesek (rsesek@chromium.org) BUG=none TEST=Open a page info window and move it. Open another and it should open in the new location. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23954 0039d316-1c4b-4281-b951-d872f2087c98
* Make the main menu button only show if you pass in a command linesky@chromium.org2009-08-211-1/+7
| | | | | | | | | | | | switch. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/174221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23953 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dependency from the setup project to support.gyp.robertshield@chromium.org2009-08-211-0/+1
| | | | | | Review URL: http://codereview.chromium.org/174003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23952 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium to version 1.3.6.sgjesse@chromium.org2009-08-211-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ager@chromium.org Review URL: http://codereview.chromium.org/174218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23951 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools l10n: generate localized strings and use them.mnaganov@chromium.org2009-08-2111-33/+257
| | | | | | | | | | | Reapplying r23820, this time interactive UI tests should not fail. BUG=none TEST=none Review URL: http://codereview.chromium.org/174216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23950 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: wire Inspect Element action to DOMAgent-enabled inspector controller.pfeldman@chromium.org2009-08-211-0/+2
| | | | | | | TBR=mnaganov git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23949 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23946.mhm@chromium.org2009-08-21548-11/+4599043
| | | | | | Review URL: http://codereview.chromium.org/173185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23947 0039d316-1c4b-4281-b951-d872f2087c98
* Pull the entire hunspell tree and place it in depsmhm@chromium.org2009-08-21548-4599043/+11
| | | | | | | | BUG=14756 TEST=Compiled Chromium, ran tests Review URL: http://codereview.chromium.org/174127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23946 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 47591:47606dimich@google.com2009-08-211-1/+1
| | | | | | | | | TBR=jianli BUG=none TEST=none Review URL: http://codereview.chromium.org/174213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23945 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent a crash that can occur when redirecting a file URL.darin@chromium.org2009-08-218-10/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We redirect a file URL that corresponds to a directory when the file URL does not end in a slash. We redirect to the same URL with a slash appended to simplify other code, which can then rely on the presence of a trailing slash for all file URLs that correspond to a directory. It turns out that following the redirect could result in the job being used after free. The code in URLRequestJob::FollowDeferredRedirect clears some fields after calling FollowRedirect. For all other jobs this is not a problem since the process of following a redirect causes the job to be killed, and URLRequestJob::Kill takes a reference to the job. It turns out that URLRequestFileDirJob was not calling URLRequestJob::Kill, and so this extra reference was not being taken. The fix is two-fold: 1- Make URLRequestFileDirJob call URLRequestJob::Kill just like the rest of the jobs. This seems like a good idea for other reasons as well. 2- Make URLRequestJob::FollowDeferredRedirect not depend on itself being alive after the FollowRedirect call. This just seems good for future cases where a special URLRequestJob subclass might not call URLRequestJob::Kill for some reason or another. Finally, some minor changes were rqeuired to URLRequestFileDirJob to support the call to Kill. See changes to OnListDone. Writing a unit test for this was a bit tricky. It turns out that while the URLRequestFileDirJob is waiting for the client to call FollowDeferredRedirect, it is still traversing the directory. It does not pause the directory listing. The crash could only happen if the directory listing completed before the consumer called FollowDeferredRedirect because a reference to the job was taken on behalf of the DirectoryLister. To test this condition, I made it possible for a test to poll the URLRequestFileDirJob::list_completed_ flag. Once that is set, I then have the test call FollowDeferredRedirect. NOTE: When running within net_unittests, NetModule::SetResourceProvider has not been called. So, I downgraded a NOTREACHED to a DLOG(WARNING). NOTREACHED was a bit excessive since it is a condition that can be reached, and I don't see any problem with allowing unit tests to function without a resource provider. R=wtc BUG=18686 TEST=URLRequestTest.FileDirRedirectNoCrash Review URL: http://codereview.chromium.org/174076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23944 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23940.dimich@google.com2009-08-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/174212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23941 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 47591:47606dimich@google.com2009-08-211-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/173167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23940 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23931.dimich@google.com2009-08-215-50/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23939 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustagehclam@chromium.org2009-08-211-1/+1
| | | | | | | | | | Fix build bustage because of signed / unsigned mismatch. TBR=scherkus Review URL: http://codereview.chromium.org/174211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23938 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress slider thumb jumping around during seekinghclam@chromium.org2009-08-219-16/+91
| | | | | | | | | | | | | BUG=19396 TEST=Open a video, seek to any position, the thumb should stops a bit and then goes forward from there. Preventing the slider thumb from jumping around after seek by freezing the clock until we get a valid time update from the audio renderer. Review URL: http://codereview.chromium.org/173072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23937 0039d316-1c4b-4281-b951-d872f2087c98
* [Chrome OS] Adds support for injecting Corp cookies at startupcmasone@google.com2009-08-2110-1/+477
| | | | | | | | | To support single-sign-on for Chrome OS, we need a way to inject cookies into Chrome. In the case of session cookies, putting them into Chrome's cookie jar DB doesn't work. This CL adds a command line flag that tells chrome the name of a Unix pipe to open, from which it can read said cookies. Eventually, I want to replace this pipe-reading with an appropriate usage of DBus, but Chrome OS isn't there yet. This CL adds the appropriate infrastructure, though, and the PipeReader class can later be replaced with something that pulls the cookies off DBus instead. Review URL: http://codereview.chromium.org/174062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23936 0039d316-1c4b-4281-b951-d872f2087c98
* Adds prototype menu.sky@chromium.org2009-08-212-0/+65
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/174200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23935 0039d316-1c4b-4281-b951-d872f2087c98
* Make baselines for a new test. Test works by obscuring the red square with ↵dimich@google.com2009-08-215-7/+5
| | | | | | | | | | | the green one, which happens on all platforms same way. Also, created a bug for media/progress-events-at-least-one.html as it is an actual failure of a new test. R=jianli BUG=none TEST=none Review URL: http://codereview.chromium.org/174202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23933 0039d316-1c4b-4281-b951-d872f2087c98
* Uses the FilePath::CopyFile version that recieves FilePath instead of ↵thestig@chromium.org2009-08-211-11/+12
| | | | | | | | | | | | | | std::wstring. BUG=None TEST=None Patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/164383 Review URL: http://codereview.chromium.org/174168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23932 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb whiteListAccessFromOrigin() through Chromium's WebKit APIaa@chromium.org2009-08-215-8/+50
| | | | | | | | | | | and enable the related layout tests. BUG=47548,12129 TEST=Covered by layout tests Review URL: http://codereview.chromium.org/174175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23931 0039d316-1c4b-4281-b951-d872f2087c98
* Make ProcessSingletonLinux check the hostname to avoid multiple uses of a ↵mattm@chromium.org2009-08-2110-110/+264
| | | | | | | | | | | | | profile over NFS. In order to avoid the singleton socket filename from exceeding the max socket name length, the socket is just named "SingletonSocket" and a new file "SingletonLock" is used for the hostname&pid. BUG=17549 TEST=see bug Review URL: http://codereview.chromium.org/174041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23930 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpads missing from browser process.mark@chromium.org2009-08-211-16/+16
| | | | | | | | | | | | | | | | GoogleUpdateSettings::GetCollectStatsConsent uses the Chrome path provider, so if the Breakpad glue is going to decide whether to enable Breakpad based on that function, it can't call it until after the Chrome path provider has been added to the path service. TBR=jeremy BUG=19913 TEST=Does Breakpad work in the browser process? If stats reporting is enabled, in an official release Google Chrome build, you'd better not see this: [mmdd/hhmmss:WARNING:.../chrome/app/breakpad_mac.mm(57)] Breakpad disabled Review URL: http://codereview.chromium.org/173172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23929 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23924 - several builds brokedpranke@google.com2009-08-2116-540/+1040
| | | | | | | | | | BUG=none R=tony@chromium.org TEST=none Review URL: http://codereview.chromium.org/174207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23928 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show "Inspect Element" in the context menu if we can't inspect.agl@chromium.org2009-08-218-8/+81
| | | | | | | | | | Ubuntu want to ship with the inspector files in a separate package and having menu items which are broken isn't nice. http://codereview.chromium.org/174162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23927 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 23919 to investigate valgrind failures.rvargas@google.com2009-08-219-312/+45
| | | | | | | | | | | TBR=willchan TEST=none BUG=none Review URL: http://codereview.chromium.org/174205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23926 0039d316-1c4b-4281-b951-d872f2087c98
* We should only handle http and https in the URL job created to enable ↵ananta@chromium.org2009-08-211-9/+11
| | | | | | | | | | | | | | automation clients to handle URL requests. This fixes bug http://b/issue?id=2068725 Bug=2068725 Review URL: http://codereview.chromium.org/174197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23925 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor layout test scripts to clean up platform name handling.dpranke@google.com2009-08-2116-1040/+540
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In path_utils and platform_utils, we had four functions: - TestListPlatformName() - TestListPlatformDir() - PlatformDir() - PlatformNewResultsDir() TestListPlatformDir() was uniformly implemented as TestListPlatformName().lower(), and never called. PlatformDir() and PlatformNewResultsDir() returned the same value on win and linux - "chromium-" + TestListPlatformDir(). On the mac, PlatformDir() returned PlatformNewResultsDir() + "-leopard". PlatformDir() is used to prepend the directory in the search path for test results, and this is ironic since there is no chromium-mac-leopard directory, just chromium-mac. I have replaced all of these with one routine called PlatformDir() that returns "chromium-" + <platform name> [ + "-" + <platform version name> ]. I also modified the code so that test results will always go into a directory with that name, and then modified all of the files that referenced a _new_results_dir (which ostensibly used PlatformNewResultsDir(), which might be different from options.platform, but in practice never was). I also removed a number of platform parameters from functions, since it seemed like that functionality wasn't being used and was redundant with stuff stuffed into options contexts. Lastly, I also attempted to bring some consistency to files needing to import path_utils vs platform_utils, by adding wrapper functions to path_utils and then banning platform_utils imports from all other files. There's gotta be a cleaner way to do this, though. You can still change the platform you're comparing to with the --platform switch, and change the results directory with the --results-directory switch. BUG=none R=pam@chromium.org,tony@chromium.org TEST=none Review URL: http://codereview.chromium.org/164372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23924 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Close the experiment for new users.rvargas@google.com2009-08-211-20/+15
| | | | | | | | | | | | Also, make sure that only the main cache runs an experiment. BUG=none TEST=none Review URL: http://codereview.chromium.org/173132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23923 0039d316-1c4b-4281-b951-d872f2087c98
* Try to find trunk/src/tools/python before importing google.path_utils.pam@chromium.org2009-08-211-5/+42
| | | | | | | | | | | Don't require the buildbot slave_scripts unless running a test that needs them. BUG=none TEST=run 'smoketests.py --tests=ui' without having tools\buildbot\scripts\slave checked out Review URL: http://codereview.chromium.org/174191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23922 0039d316-1c4b-4281-b951-d872f2087c98
* Enable startup tests for custom frame. I meant to do this with thetony@chromium.org2009-08-211-0/+10
| | | | | | | | | last change, but missed it. Review URL: http://codereview.chromium.org/174115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23921 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DevToolsSanityTest.TestShowScriptsTab, which has been flaky for ↵estade@chromium.org2009-08-211-1/+1
| | | | | | | | | | quite a while. TBR=pfeldman Review URL: http://codereview.chromium.org/174203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23920 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Implement asynchronous IO for Posix.rvargas@google.com2009-08-219-45/+312
| | | | | | | | | | BUG=16507 TEST=Unittests Review URL: http://codereview.chromium.org/171085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23919 0039d316-1c4b-4281-b951-d872f2087c98
* Setup script for O3D plugin installer. This is the installer that we will ↵nmaxwell@google.com2009-08-201-0/+156
| | | | | | | | give to users that don't have a .deb or .rpm compatible distro. Creating a new issue since the last one was broken. Review URL: http://codereview.chromium.org/173081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23918 0039d316-1c4b-4281-b951-d872f2087c98
* Generalized cylinder code in primitives.js to handle truncated cones.kbr@google.com2009-08-204-34/+205
| | | | | | | | | | | | o3djs.primitives.createCylinderVertices now delegates to createTruncatedConeVertices. Updated primitives.html. Added o3djs.primitives.VertexInfo.append to allow multiple VertexInfos to be placed in a single Shape for efficiency; this functionality has been tested but is not yet demonstrated in a sample. Review URL: http://codereview.chromium.org/174186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23917 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Mock the LinkDoctor for tests. Should greatly decrease ErrorPage ↵phajdan.jr@chromium.org2009-08-2012-116/+52
| | | | | | | | | | test flakiness." TBR=darin Review URL: http://codereview.chromium.org/173165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23916 0039d316-1c4b-4281-b951-d872f2087c98
* Re-apply r23841 "During uninstall if Chrome is set as default"kuchhal@chromium.org2009-08-2010-106/+267
| | | | | | | | | BUG=14023 TEST=Make sure the option of choosing a different browser shows up during un Review URL: http://codereview.chromium.org/174194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23915 0039d316-1c4b-4281-b951-d872f2087c98
* Group spellcheck-related tests and hook them up to the right bugdglazkov@chromium.org2009-08-201-8/+5
| | | | | | | | | | TBR=hbono TEST=none BUG=11577 Review URL: http://codereview.chromium.org/173163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23914 0039d316-1c4b-4281-b951-d872f2087c98
* The HTTP response headers coming back from the automation URL job need to be ↵ananta@chromium.org2009-08-201-2/+3
| | | | | | | | | | | | | | | | | | normalized to be delimited by '\0' instead of '\r\n'. This causes URLs like microsoft.com, etc to not render correctly in automation HTTP clients. This fixes bug http://b/issue?id=2066632 Thanks to Eric Roman for his help in tracking this down. Bug=2066632 Review URL: http://codereview.chromium.org/174132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23913 0039d316-1c4b-4281-b951-d872f2087c98
* Added NPObjectBase, a base class for NPObject that forwards NPObject calls ↵apatrick@google.com2009-08-206-3/+489
| | | | | | | | | | | through to virtual functions in the subclass. BUG=none TEST=none Review URL: http://codereview.chromium.org/174180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23912 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using vfork() instead of fork() when we can.deanm@chromium.org2009-08-201-22/+28
| | | | | | | | | | | | | | | | This means we can avoid creating new page tables, but that we share our memory mappings / stack with the parent. This is a bit more fragile, but should be workable. This saves us some work since we are just going to exec(). This also removes some sandbox unsetting code, since we shouldn't be spawning processing under the sandbox anyway. BUG=19863 Review URL: http://codereview.chromium.org/173141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23911 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make the "change proxy settings" button able to start several proxy ↵mdm@chromium.org2009-08-204-52/+124
| | | | | | | | | | | | config utilities. Currently it still only ever starts gnome-network-properties but it is now easy to update. BUG=none TEST=none Review URL: http://codereview.chromium.org/174106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23910 0039d316-1c4b-4281-b951-d872f2087c98
* Moving util methods outside of installer tests.anantha@chromium.org2009-08-209-484/+513
| | | | | | Review URL: http://codereview.chromium.org/149217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23909 0039d316-1c4b-4281-b951-d872f2087c98
* Remove text-control-crash-on-select.html from the test_expectations. I ↵jorlow@chromium.org2009-08-201-1/+0
| | | | | | | | | | | can't reproduce the crash and it's building successfully on the bots it seems. This was hit during a webkit roll, so it's very possible it was fixed upstream. BUG=19782 TEST=none Review URL: http://codereview.chromium.org/173161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23908 0039d316-1c4b-4281-b951-d872f2087c98
* Comment why it is OK for ↵jianli@chromium.org2009-08-201-0/+4
| | | | | | | | | | | LayoutTests/platform/mac/editing/deleting/backward-delete.html to fail on Mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/173151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23907 0039d316-1c4b-4281-b951-d872f2087c98
* Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.phajdan.jr@chromium.org2009-08-2012-52/+116
| | | | | | | | | | | Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward. TEST=Covered by ui_tests and browser_tests. http://crbug.com/18365, http://crbug.com/19361 Review URL: http://codereview.chromium.org/174179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23906 0039d316-1c4b-4281-b951-d872f2087c98
* Update bug number for some failing test in test-expecations. They were ↵jparent@chromium.org2009-08-201-3/+2
| | | | | | | | | | | | marked as part of the webkit merge, but were not actually caused by the merge (the tests failed on main waterfall before the merge, see more details in bug). TEST=none BUG=19888 Review URL: http://codereview.chromium.org/174192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23905 0039d316-1c4b-4281-b951-d872f2087c98
* I forgot to hook up the inspector settings during my webpreferences ↵jorlow@chromium.org2009-08-201-0/+3
| | | | | | | | | | | refactoring change (http://src.chromium.org/viewvc/chrome?view=rev&revision=23589). Do that now. TEST=none BUG=none Review URL: http://codereview.chromium.org/173130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23904 0039d316-1c4b-4281-b951-d872f2087c98