| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
filenames/file extensions.
Review URL: http://codereview.chromium.org/21327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/24018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7721
Review URL: http://codereview.chromium.org/21372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead of Service and other child process service maintain it). In a future change I'll start moving some of the code from PluginProcessHost to ChildProcessInfo.
Review URL: http://codereview.chromium.org/24017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
requested bytes are read from the file in one call, assuming no errors occurr or EOF is reached.
Review URL: http://codereview.chromium.org/21363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also cached the NPObject we create for a CppBoundClass, so we only create one each time we bind it to a frame.
This will be useful for extensions.
Review URL: http://codereview.chromium.org/21337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
AutomationMsg_ActivateWindow and AutomationMsg_OpenNewBrowserWindow automation messages
to sync messages.
Review URL: http://codereview.chromium.org/20363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove some unnecessary cruft from BrowserView.
* Change Find bar to position itself based on the translated bounds of the bookmark bar or toolbar, whichever is found. This is a bit simpler than the offset-based version before and works much better with Fullscreen mode.
* Make Bookmark bar not have a strange "1 px" minimum size, which was only needed because we were always subtracting that much in the BrowserView layout functions.
* Change BrowserView toolbar layout functions to always lay out toolbars (instead of only when visible; they are 0-height when invisible), and explicitly set their visibility. This shouldn't have any visible effect, but it goes hand-in-hand with the Find bar changes.
* Add a function on the Bookmark bar to determine if we're displaying detached, and change various callers to use it. Right now this does fairly little, but in Fullscreen mode it becomes necessary because we always display the Bookmark bar this way. There is one user-visible effect: when toggling the Bookmark bar on/off while the Find bar is visible, the Find bar will now snap to the Bookmark bar only when it finishes "attaching" to the toolbar, not as soon as it starts. Finnur and I both think this actually looks slightly better.
Review URL: http://codereview.chromium.org/21359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=deanm
Review URL: http://codereview.chromium.org/20374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason for doing this is because the V8 ScriptController already
provides some functionality provided by the JSC WindowShell such
as disconnectFrame().
Also, merge the clearPluginObjects into clearScriptObjects, which
matches better what happens in JSC.
This change requires a roll in WebKit, since we remove the clearPluginObjects
method.
Review URL: http://codereview.chromium.org/20360
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Chromium side yet)
TBR=brettw
Review URL: http://codereview.chromium.org/20373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=deanm
Review URL: http://codereview.chromium.org/20372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/21362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
build on buildbot.
TBR=deanm
Review URL: http://codereview.chromium.org/21361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- eliminates one #ifdef
- Did I mention is cleaner?
Review URL: http://codereview.chromium.org/21331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
until we get a more permanent location for errors)
Review URL: http://codereview.chromium.org/20366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
RenderViewHost's delegate is a WebContents.
Review URL: http://codereview.chromium.org/23025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the svn:eol-style property as blank. This should allow
the try servers to apply patches.
TBR=glen
Review URL: http://codereview.chromium.org/20370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=deanm
Review URL: http://codereview.chromium.org/20369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
debugger_resources.rc, common_resources.rc, and renderer_resources.rc.
Review URL: http://codereview.chromium.org/21307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
has been typed when right click occurs after the text.
Review URL: http://codereview.chromium.org/20330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay
Review URL: http://codereview.chromium.org/20367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NullAudioRenderer effectively uses an extra thread to "throw away" the audio data at a rate resembling normal playback speed.
NullAudioRenderer can also be used in situations where the client has no audio device or we haven't written an audio implementation for a particular platform yet.
It supports any type of MediaFormat as long as the mime type has been set to audio/x-uncompressed. Playback rate is also supported and NullAudioRenderer will slow down and speed up accordingly.
Review URL: http://codereview.chromium.org/20339
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=brettw
Review URL: http://codereview.chromium.org/20282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
maximizing Chrome by double-clicking on the new tab button. This solution does work but another one is being coded for a more general problem. This change solves also the accidental maximizing of Chrome when double-clicking the close tab button except on the last tab (rightmost in LTR systems). See issue 2827 for further details.This change removes a band-aid which did not perform a hit-test on the tab-strip while it is animating in order to avoid unknown chromebot crashes as reported by Ben. The removal of the fix makes the hit-test perform as expected.Trying this now, at Peter's suggestion, so that we can measure and diagnose potential problems hidden by the said band-aid.
[NOTE]
Revied and approved as http://codereview.chromium.org/20329
by Peter kasting. Had to copy changes to repo where I have
commit rights.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Reviewed in issue 20321. Got reverted, but was not the cause of the debugger test failure.
Review URL: http://codereview.chromium.org/21355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20365
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DerivedSources.make changed, so we need to match it's change.
http://codereview.chromium.org/21351/diff/13/15
TBR=brettw
Review URL: http://codereview.chromium.org/21356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This error (sometimes) caused a crash when scrolling all the way to the bottom of a page and then attempting to scroll back up.
Review URL: http://codereview.chromium.org/20361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
triggered by clicking the window icon or hitting alt-space. Make clicking the icon for windows without a non-client view (e.g. the Bookmark Manager on Aero Glass) bring up the system menu.
Clean up more dead code, verbose code, or unnecessary statics/members.
TEST=Right-click titlebars, hit alt-space, and left-click window icons (where present), for:
* Main window
* Dialogs, e.g. the bookmark manager
* Popups
* App windows
When right-clicking, a system menu should appear at the cursor. For the other cases, a system menu should appear at the system native location (roughly just below the titlebar).
Review URL: http://codereview.chromium.org/20225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The only tricky bit here is how GetBookmarkBarView() is no longer guaranteed to return non-NULL. The only caller of this is the automation framework, in one place, which explicitly NULL-checks the result and does the right thing, so there should not be any problems.
Review URL: http://codereview.chromium.org/23026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/20350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hook. NtOpenKeyEx.
I don't know what the last parameter is. I suspect it's
a reserved flag for "options". (As in RegOpenKeyEx).
I do not handle the case where this unknown flag is non-zero.
The current unit tests covers this code.
bug:7611
Review URL: http://codereview.chromium.org/20287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
also removed some lint errors. This was reviewed by me and Scott
TBR=sky
Original changelist description (http://codereview.chromium.org/17608):
Context menu for title bar doesn't appear when a tab's context menu was open.
---------------------------------------------------------------------------
* About the Bug
---------------------------------------------------------------------------
- What steps will reproduce the problem?
1. Open the context menu for a tab of your choice.
2. Right-click on the title bar.
- What is the expected result?
The application context menu should show up.
- What happens instead?
Nothing (The tab's context menu is correctly closed, of course).
- What is the reason?
The context menu for an App is displayed when WM_NCRBUTTONDOWN event is
processed on the Window::OnNCRButtonDown() handler.
In normal case, when the right mouse button is clicked on the NC area, this
event is generated. But in the case that the context menu for a tab is being
displayed, WM_NCRBUTTONDOWN is not received. Instead, WM_NCLBUTTONDOWN is
generated. (This is wrong because left mouse button is never pressed.)
So the right handler (Window::OnNCRButtonDown()) cannot be called.
---------------------------------------------------------------------------
* About the Fix
---------------------------------------------------------------------------
What is modified?
Modified MenuController::RepostEvent() method. This function is called when the
mouse button is pressed while the context menu for a tab is being displayed.
In this function, following two steps occur in order.
1st. Determine the event type.
2nd. Post this event using PostMessage().
On the 2nd step,
In the case that the determined event on the 1st step is for the client area,
there's no problem. But in the case of the non-client area, it doesn't use the
right event type but use the fixed event type (WM_NCLBUTTONDOWN). This is the
wrong implementation.
So, I modified this part so that it use the right event type.
Bug=5695
http://crbug.com/5695
Review URL: http://codereview.chromium.org/21354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
SetVisible(false)) views would have ShowWindow() called on them, which was bogus.
Review URL: http://codereview.chromium.org/21333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* When we're on the only focusable view, AdvanceFocus() should just focus us again.
* When only one focusable view exists, FindLastFocusableView() should return it, not NULL. Also the code here was longer than it needed to be.
Review URL: http://codereview.chromium.org/20347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
See http://crbug.com/7652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The process of detaching plugin windows from tab window
involves windows messages across browser and plugin process.
If the pungin process is hung this hangs the browser
shutdown sequence.
This workaround first checks if the plugin is responsive
before detaching its window from the tab. If a plugin is
hung, it's window would not be detached (and would be
destroyed with the tab window).
The side effect of not detaching is that some plugins
expect their window to be valid until they get NPAPI
shut down notifications and may crash if those
notifications were sent after the window was destroyed.
But since the plugin is hung anyway, we can go ahead
not detaching the window. Plugin process will be
cleaned up later.
BUG=3613
Review URL: http://codereview.chromium.org/20301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The gyp-based build won't have an xml_config step, it will just use these
checked-in files. The Linux and Windows builds already work this way.
Review URL: http://codereview.chromium.org/21334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20352
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9750 0039d316-1c4b-4281-b951-d872f2087c98
|