| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous performance was O(n^2), due to how the interface delegated grouping by id to v8. Now v8 has been changed to make the grouping the caller's responsibility. We now do the grouping in the bindings, aiming for performance and scaling with many groups:
- Don't try to group as we are processing, do
one final pass to group the objects together.
- Ignore object groups with a single element. They
have nothing else to keep alive.
This change includes DEPS to bring in the v8 changes.
Review URL: http://codereview.chromium.org/13342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13737
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13735
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13684
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds a search field before the text field.
. When the search node is selected and there are no results or no
search text, a descriptive label is drawn on top of the table
telling the user what's happening.
. In the bookmark menus Edit... is now Rename... for folders.
BUG=5272 5319 5273 4165
TEST=see individual bugs
Review URL: http://codereview.chromium.org/13724
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. If the user launches incognito we don't attempt to restore last
session and instead just do default launch behavior (new tab page).
. Don't show the session restore info bar when launched incognito. I'm
assuming that if the user launched in incognito they were previously
running incognito so that there is nothing to restore.
BUG=4381 5119
TEST=turn on session restore and launch with --incognito, make sure
the incognito window comes up.
Review URL: http://codereview.chromium.org/13368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
test_shell_tests.
Review URL: http://codereview.chromium.org/13359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
And rebaseline the image on a layout test that now passes.
Review URL: http://codereview.chromium.org/13728
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
we never want to support legacy mac encodings other than MacRoman.
(although we include MacCyrillic data in our ICU for now).
Review URL: http://codereview.chromium.org/13365
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
All input is converted to UTF-8. Output is converted back to wide during std::wstring version of GetString().
This is part one of some more patches to come where I switch clients over to UTF-8 strings.
Review URL: http://codereview.chromium.org/13230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13729
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
no baselines! (Mac is missing theirs.) Thus, skip the test.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=5055
TEST=make sure control-d does nothing for apps and popup windows
Review URL: http://codereview.chromium.org/13363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
setSelectTrailingWhitespaceEnabled.
Now we allow both to be true because that's what we do on Windows.
Review URL: http://codereview.chromium.org/13213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
the previous blind fix I tried.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
GURL instead of wstring where appropriate. Original patch by phajdan.jr@gmail.com, r=me,sky. See http://codereview.chromium.org/13205 .
BUG=715234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is obviously black magic but appears to be slightly more correct
then the previous code for layout tests.
Review URL: http://codereview.chromium.org/13361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Windows rounds the smallcaps size, so should Linux. The advance numbers are
still wrong, but the size is correct at least.
Review URL: http://codereview.chromium.org/13330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Delete Windows baselines where they have been found to be bogus. Mark
then as failing in tests_fixable (if they weren't already) and also
mark as failing those SVG tests which will fail when we enable pixel
tests on Linux.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This adds image baselines for SVG tests where either the fuzzy matcher has
accpeted the output or where the diff has been reviewed manually.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically, if the Find box is open, pressing Ctrl+F should
set focus to the text field. This regressed when the Find
box moved into web_contents_view.
I have added a UI test to catch this in the future.
Review URL: http://codereview.chromium.org/13721
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13358
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
whether the recursive call to RemovePendingRequest is
removing the same or a different request.
R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/13329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lots of small things (mostly in spellcheck code), e.g.:
* L"" -> std::wstring()
* type *var; -> type* var;
* Fix parameter line-wrapping to comply with style guide
* Remove unnecessary classname scoping inside class delcaration
* Remove empty declaration
* Add/remove blank lines in hopes of increasing readability
* Add block ("{", "}") around local use of a temporary that is later redefined
* Fold temps into other statements where obvious
* Use std::find() instead of hand-rolling the same functionality
* Combine distinct cases in switch statements when they all do the same thing
* Range-check to avoid some algorithmic work when it's not needed
* at() -> []
...and various others. Pretty much every change stands on its own. Do not hesitate to complain about changes you think are unhelpful to the code, this change is something of a dumping ground. (I did try to avoid the sort of gratuitous "const"-adding that has gotten me in trouble before :). )
Review URL: http://codereview.chromium.org/13688
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash.
I failed to handle USCRIPT_INVALID_CODE as an input to GetFontFamilyForScript.
That constant has a value of -1 which caused my array indexing to be unhappy.
I also corrected the 'initialized' flag to be a static so that we would not
waste cycles calling InitailizeScriptFontMap over-and-over again. Yikes!
R=ojan
Review URL: http://codereview.chromium.org/13722
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
as one big lump.
Review URL: http://codereview.chromium.org/13696
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
surrounding script in a way that broke the code.
Review URL: http://codereview.chromium.org/13348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
All input is converted to UTF-8. Output is converted back to wide during std::wstring version of GetString().
This is part one of some more patches to come where I switch clients over to UTF-8 strings.
Review URL: http://codereview.chromium.org/13230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
add the strip-if-needed phase to these executables
Review URL: http://codereview.chromium.org/13357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
test_shell_tests.
Review URL: http://codereview.chromium.org/13719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the wrong side.
BUG=5067
TEST=see bug
Review URL: http://codereview.chromium.org/13353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Include a few more files to be built in glue upon which they depend.
Review URL: http://codereview.chromium.org/13712
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
probably just flaky, but I haven't seen it fail on debug yet.
Review URL: http://codereview.chromium.org/13714
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The Windows baseline was missing the green box. Delete the Windows baseline,
mark the test as failing on Windows and add a Linux baseline.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Check in new image baselines for LayoutTests/http/*. These images have either
been passed by the fuzzy matcher or verified manually.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Check in new image baselines for LayoutTests/editing/*. These image diffs have
either been accepted by the fuzzy matcher or reviewed by hand to be correct.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of highlevel WebCore types in the scrollbar code. I also found
some code that had been ifdef-ed that I missed deleting during
my last pass.
Review URL: http://codereview.chromium.org/13713
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6723 0039d316-1c4b-4281-b951-d872f2087c98
|