| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Shows how to use PolygonOffset to bring the shadows forward.
Also shows how to set up a quick drawpass using some
new o3djs functions so the shadows all get drawn last.
The reference screenshot CL is here.
http://codereview.appspot.com/91103
I'll add DEPS and DEPS_gpy in this CL once this is approved.
Review URL: http://codereview.chromium.org/149507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Checking in on a closed tree because Brett thinks it'll fix layout tests.)
Review URL: http://codereview.chromium.org/149557
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out we weren't documenting o3djs.math.matrix4
because it was missing an @namespace tag. I tried to
find a way to flag this as an error but as far as can
tell there, in jsdoctoolkit there is nothing I can use
to distinguish between a function with no parameters
and returns nothing and an un tagged namespace.
In other words
/**
* no tag here
*/
o3djs.foo.someNamespace = { };
..and..
/**
* Some func.
*/
o3djs.foo.someFunc = function() { };
Look exactly the same when they get to the doc generation
part of jsdoctoolkit. Both are members of o3djs.foo.
Both have no params and no return type. So I can't tell
that the first one is an error (a non function with no tags)
and the second one is not.
I guess we just have to be vigilant.
Also, a BIG error was I wasn't generated o3djs docs at all
in build_docs.py. Fixed that.
Finally I changed the format some. My opinion was the
summary docs at the top of each module/class were hard
to read so I put them in tables. Will have to check with
Josie once it's checked it now they actually appear on
her test server.
Also made it so for module methods and properties they
get documented as
o3djs.module.method
o3djs.module.property
but for object methods and properties they get documented
ObjectName.method
ObjectName.property
Both used to be documented as just
method
property
Which I found hard to read since there is no context.
Review URL: http://codereview.chromium.org/149523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems pretty useful for lots of samples.
Added o3djs.effect.createCheckerEffect
to support that.
Also put pseudoRandom into math since so many
samples use it. Will consider switching samples
to use it.
Review URL: http://codereview.chromium.org/149509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving LayoutTests to third_party/WebKit directory so people won't confuse about it. Another patch that allows run_webkit_tests to support both directories has been committed, for details, see http://codereview.chromium.org/146112.
BUG=8765
TEST=LayoutTests directory removed and run_wekkit_tests works
Review URL: http://codereview.chromium.org/155115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* An onminious new layout test crash, mouse event related (16639)
LayoutTests/fast/events/mouseover-mouseout2.html
* Some more worker message channel and port related failures, expected i think (16410)
BUG=16410,16639
TEST=none
Review URL: http://codereview.chromium.org/155431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
until we get the new process hooked into the testing harness.
Review URL: http://codereview.chromium.org/149551
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
directory format. Fixing the problem by using cygwin python instead of the included python for windows.
TEST=rebaselining tool
BUG=none
Review URL: http://codereview.chromium.org/155239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Now main_win.cc unregisters the full screen window class so that if the DLL is reloaded at a different address later, the WindowProc will point at the new address.
Also now using the DLL's module handle rather than the one associated with the plugin (which will likely be the browser exes handle).
Review URL: http://codereview.chromium.org/149496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The PlatformCanvas now tracks this, so we don't need to have the similar code
in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the
cairo_t has a transform and clip but the surface does not.
Review URL: http://codereview.chromium.org/149409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This just switches V8 to the 1.2 branch. All the code is identical.
TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/149543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the logging turned off the mac/linux builds as intended.
The referenced bug will stay open since this probably shouldn't be the long term fix.
BUG=16512
TEST=logging shows up for debug builds, but all platforms don't have logging in official builds.
Review URL: http://codereview.chromium.org/149534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
V8 to pull from branches/1.2.
This change only contains svn:ignore updates, no code changed.
TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/155427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/15811
TEST=Browse to www.google.com. Focus is in document. Click Go. No more crash.
Review URL: http://codereview.chromium.org/149487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous version was perhaps too optimal. This should be reasonable
for now since it only happens at the pace the user can enter input.
http://crbug.com/14628
TEST=Browse to www.google.com. Copy/paste the entire URL. Should be styled.
Review URL: http://codereview.chromium.org/149489
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I went auditing around, and AFAICT all remaining callers should be
fine with selecting everything.
http://crbug.com/12246
TEST=Type some stuff in address bar. With cursor in bar, Command-l should select all.
Review URL: http://codereview.chromium.org/149492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It does not directly use ICU, so this is its proper home.
Review URL: http://codereview.chromium.org/155415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none (no functional change).
Review URL: http://codereview.chromium.org/149410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This metadata request just returns a dummy string for the "metadata" scheme.
This doesn't do anything yet.
Review URL: http://codereview.chromium.org/149490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/140047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To wind down gconf, a cleanup task is posted to the UI thread. Don't
assert if that task is destroyed without being run (as may happen on
program exit).
BUG=16076
TEST=Run "sh tools/valgrind/chrome_tests.sh -t ui", look af the first couple
tests and check we don't get this assertion:
"proxy/proxy_config_service_linux.cc(211)] Check failed: !client_."
Review URL: http://codereview.chromium.org/155363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149537
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from branches/1.2. This update adds a possible work-around to
a few high priority crashers.
BUG=16276,16414
TEST=none
Review URL: http://codereview.chromium.org/155422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
print a TabContents.
This is on the same lines as the existing sync message AutomationMsg_PrintNow
Review URL: http://codereview.chromium.org/149468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it easier to add new constants.
Review URL: http://codereview.chromium.org/155407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on printers that had a non-printable area (like most physical printers do).
Two basic problems fixed. Firstly the margins where incorrectly calculated and secondly there was missing an offset int the rendering code (PHYSICALOFFSETX/Y is 0,0 when printing).
To track this down I added code to print out all relevant margins for visual inspection (turned off by default).
Chrome now prints using correctly calculated margins and is perfectly aligned on the page!
BUG=http://crbug.com/947, http://crbug.com/1566
TEST=Printing on various printers.
Review URL: http://codereview.chromium.org/155382
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16089,16091,16576,16577,16578,16579,16583,16584,16586
TEST=watch valgrind ui bots go greener
Review URL: http://codereview.chromium.org/155410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
attempt.
BUG=16606
Review URL: http://codereview.chromium.org/149529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16194
Review URL: http://codereview.chromium.org/149524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Memory Leak: (40 bytes, 1 blocks) AudioManagerWin::MakeAudioStream(Format::AudioManager,int,int,char) [unit_tests.exe]
Alloc Location
...
media/audio/win/audio_output_win.cc:126 AudioManagerWin::MakeAudioStream(Format::AudioManager,int,int,char)
chrome/browser/renderer_host/audio_renderer_host.cc:118 AudioRendererHost::IPCAudioSource::CreateIPCAudioSource(AudioRendererHost *,int,int,int,void *,Format::AudioManager,int,int,char,UINT,UINT)
chrome/browser/renderer_host/audio_renderer_host_unittest.cc:161 AudioRendererHostTest::CreateAudioStream(Format::AudioManager)
chrome/browser/renderer_host/audio_renderer_host_unittest.cc:174 AudioRendererHostTest::CreateMockStream(void)
chrome/browser/renderer_host/audio_renderer_host_unittest.cc:191 AudioRendererHostTest_MockStreamDataConversation_Test::TestBody(void)
testing/gtest/src/gtest.cc:2031 testing::Test::Run(void)
^^^
Review URL: http://codereview.chromium.org/149536
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=12969
R=darin
TEST=I wish I could write a test, but I can't reproduce the issue.
Review URL: http://codereview.chromium.org/149510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL:
http://codereview.chromium.org/155060
This patch changes the behavior of clear search button in cookies_view to work
as in firefox.
When the dialog is launched the clear search button in the old cookie_view the
state of this button is enabled,
but the text field is empty, so the correct behavior is make the button
disabled. Only when the user start typing
in the text field, the clear button will be enabled.
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL:
http://codereview.chromium.org/155059
A patch to make the grid column (table_view) of the passwords_page_view and
exceptions_page_view have the same size.
Without this, the table_view of exceptions_page_view has a width bigger than the
passwords_page_view.
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL:
http://codereview.chromium.org/155076
Add the menus copy, cut and paste to BookmarkBar and BookmarkMenu.
BUG=5354
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= none.
TEST= New NTP should come up with a default title in Tips and Suggestions box, then be loaded with actual data from popgadget.
Review URL: http://codereview.chromium.org/149255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The reference screenshot is in another CL
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I can't get the diff out of pulse so I'm just bumping
this up so it passes. When it goes through the QA hive
we can look at it.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm a little concerned that it renames the shaders
which means the developer has no way to lookup
"phong.fx" etc but I didn't see an easy way
to get that info out of the collada file from
the FCollada API. But he can at least look up
the name of the Effect from Max.
Review URL: http://codereview.chromium.org/149498
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I just wrote up some small docs to kind of get this out
of the way. If Josie wants to write a more formal doc
to put on the website we can do that but at least with
this it's documented.
Going through it I have a minor concern. The Buffer
format is fine because it spells out exactly how much
data it expects.
The Skin and Curve formats do not so if pass in a
valid offset but an invalid length when you call
Cuvre::Set(myRawData, validOffset, invalidLength)
you get undefined results and possibly no errors
depedning on what data it runs into.
This may or may not matter as it's unlikely the
user will get very far with an invalid length. The
issue is just more that it's possible.
Review URL: http://codereview.chromium.org/155246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
render process.
Specifically, if the pipeline hasn't started we should fail gracefully and not DCHECK. Volume and playback rate are now allowed to be set if the pipeline isn't running, and filters will now receive a call to SetVolume() and SetPlaybackRate() with the initial values when the pipeline has fully initialized.
Added tests and expectations for all of this and ran valgrind to verify that we were indeed leaking memory (now fixed).
BUG=16009, 13902
TEST=media_unittests, layout tests
Review URL: http://codereview.chromium.org/149500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20455 0039d316-1c4b-4281-b951-d872f2087c98
|