| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=12849
TEST=none
Review URL: http://codereview.chromium.org/160623
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds suppressions for lots of bugs. The only
problems left I know of result in valgrind internal
error messages.
Widen suppression for 16128 to match on Mac.
Remove suppression for 16210, which is a dup of 16128, and was out of date.
The reference builds don't have symbols on the mac,
so suppressions don't work. And they have old known
valgrind issues. Disable
SunSpiderReferenceTest.Perf and
V8BenchmarkReferenceTest.Perf under valgrind until
those problems are addressed (and possibly longer --
reference builds tend to have old valgrind errors
since fixed and no longer of interest).
Also, disable DownloadTest.UnknownSize under valgrind,
it is known to send garbage.
None of these errors are showing up on the bots
for some reason; they only show up when you do
a local run of shard_all_tests.sh, which does one
test at a time instead of the normal batches of 30.
It seems valgrind on the mac isn't stable enough
to do large batches of ui tests in a single run.
BUG=6522,16128,16210,17113,17451,18189,18223,18236,18252,18253,18268,18540
TEST=run tools/valgrind/shard_all_tests.sh for ui_tests on mac, verify it finds no normal valgrind warnings
Review URL: http://codereview.chromium.org/159770
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
gets sized properly on creation.
BUG=619
BUG=15960
TEST=none
Review URL: http://codereview.chromium.org/162016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160670
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bigger than before. This matches the font size used in Windows (the heights are the same), but on Linux, the text render a bit wider.
BUG=17866
Review URL: http://codereview.chromium.org/160663
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The bug was already fixed, but this change shouldn't hurt too.
Review URL: http://codereview.chromium.org/162020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16825
Review URL: http://codereview.chromium.org/159897
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/160347
This is the very preliminary implementation to support printing on Linux and it
has not been finished yet. For each page to be printed, we convert rendering
actions on canvas into cairo APIs and generate a PS/PDF file.
chrome/chrome.gyp:
Include our newly added and renamed files.
chrome/browser/browser.h:
chrome/browser/browser.cc:
Allow the user print the web page by hitting ctrl-p.
chrome/browser/gtk/standard_menus.cc:
Show "Print" in the menu.
chrome/renderer/print_web_view_helper.cc:
chrome/renderer/print_web_view_helper.h:
chrome/renderer/print_web_view_helper_mac.cc
chrome/renderer/print_web_view_helper_win.cc
Move the class PrepareFrameAndViewForPrint to the header file and move
platform dependent parts to their corresponding files.
chrome/renderer/print_web_view_helper_linux.cc:
Hard-coded parameters for printing. Only print the first page now.
skia/ext/vector_canvas.cc:
skia/ext/vector_canvas.h:
skia/ext/vector_canvas_linux.cc:
skia/ext/vector_canvas_win.cc:
Move platform dependent parts to their corresponding files.
skia/ext/vector_platform_device.h:
skia/ext/vector_platform_device_linux.cc:
skia/ext/vector_platform_device_linux.h
We translate skia APIs into Cairo APIs here. A PDF file is also created and
saved to the disk at this moment for testing purpose (you have to run chrome
without the sandbox to save the file). There are still lots of bugs.
skia/skia.gyp:
Include our newly added files when compiling skia package on Linux.
BUG=9847
Review URL: http://codereview.chromium.org/160673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
building because
the files are wrapped in #ifdef CHROME_PERSONALIZATION which is not defined anywhere at the moment.
Add live_sync to chrome\test and corresponding target to chrome.gyp
Review URL: http://codereview.chromium.org/159902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Covered by existing unittests
Review URL: http://codereview.chromium.org/162018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directly resize and relayout its children views. Now when a view needs
to be resized, it asks its resize delegate (typically its controller's
parent) to perform the resize.
BUG=http://crbug.com/17619
TEST=Make sure that views are laid out correctly, even when they change size.
Open and close the bookmark bar. Trigger an infobar and then close it. Trigger
the download shelf and then close it. Trigger a download shelf with the infobar
open, or with the bookmark bar open. Switch to and from fullscreen with various
bars open. Resize the browser window with various bars open. Start the browser
with and without the bookmark bar open. Try all of the above in a popup window.
Review URL: http://codereview.chromium.org/159776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160593
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15786
TEST=this is just a test change.
Review URL: http://codereview.chromium.org/160651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'm not especially happy with how it looks now, though I think it's
better than before.
Review URL: http://codereview.chromium.org/160661
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As most of the tests moved to the browser test, this is now unneeded.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/160666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't functional yet, but I want to get this reviewed
and in the tree so I can do the rest incrementally.
This works by having the bots generate JSON that is
then red into a static HTML file that generates
the dashboard from the JSON.
I've tried to make this generic, so we should be able
to use the same HTML file for our other test types
(e.g. UI tests) as well once this is functional by
just having the bots that run those tests generate
the JSON files and copy them to the right place.
All the work that needs doing to get this 100% functional
is listed as a TODO at the top of flakiness_dashboard.html.
Most of what's left is buildbot integration (i.e. copy
files to the right place on the bot).
Review URL: http://codereview.chromium.org/149656
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise when polling for configuration changes, we think the current configuration is different than the fetched one.
This was a recent regression from r22485.
BUG=http://crbug.com/18526
TEST=ProxyServiceTest.UpdateConfigAfterFailedAutodetect
Review URL: http://codereview.chromium.org/160654
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update Mac output path to match the gyp 'outputs' list, and restrict Mac to the four previously built locales.
A future change will add all the locales for Mac, probably after gyp adds looping capability (which isn't to say it couldn't be added now, but that feature is coming soon, so avoiding multiple refactors).
Review URL: http://codereview.chromium.org/159886
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This gets rid of some scary warnings and may also fix a flaky test.
BUG=http://crbug.com/17452
TEST=None
Review URL: http://codereview.chromium.org/160643
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable tests which were intermittently failing before this fix and remove
debugging code used to track down the issue.
TEST=Covered by net_unittests.
http://crbug.com/18036
Review URL: http://codereview.chromium.org/160537
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=jar
Review URL: http://codereview.chromium.org/160660
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
TEST=no layout test regressions
BUG=none
Review URL: http://codereview.chromium.org/160655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
land Min-Yu's changes in http://codereview.chromium.org/160347 .
TBR=evan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12849
TEST=none
Review URL: http://codereview.chromium.org/160560
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using the sandbox, the renderer cannot load the ffmpeg shared
objects from disk. So we load them in the zygote before the sandbox is
started.
(Note that this doesn't get media working, but it's a start.)
BUG=18329
http://codereview.chromium.org/159841
(Note: relanding. Original landing in r22392, reverted in r22405 due
to check-deps failure.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invalid (e.g. is the empty string). The Cancel button is never
disabled.
BUG=http://crbug.com/17006
TEST=Right click on a bookmark button to edit it.
Make sure OK is enabled.
Set URL to "" (the empty string).
Make sure OK is DISabled.
Set URL to "x".
Make sure OK is enabled.
Review URL: http://codereview.chromium.org/160628
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from build/LASTCHANGE.in if there's no actual svn or git change found.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159876
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
perf (should be a 2-4x speedup). Bug should remain open until a better approach (background threads, perhaps) is used.
BUG=17696
TEST=none
Review URL: http://codereview.chromium.org/159903
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
prevent massive visual flickering during resize.
Review URL: http://codereview.chromium.org/160646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We do bookmark matching in two passes: first, a quick search for all
the words, then a second filtering pass that obeys query syntax.
We were hitting a DCHECK when the second pass would filter any matches
out. For example, the query ["thi"] matches a bookmark [think], but
it shouldn't match because quotes mean literal match.
BUG=15786
Review URL: http://codereview.chromium.org/159905
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
When there are no strings to localize, but a stub value into the table to avoid a compile error from array_size.
Review URL: http://codereview.chromium.org/160645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
hopefully everyone has updated by now.
Review URL: http://codereview.chromium.org/162008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was unable to reproduce the failures from the bots on my machine.
If they appear again, the build will not break, ane we will get full info.
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159866
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: The drop-down menu is actually a drag-down (activating on
click-hold or on drag), working much like Safari's (and other Apple
apps, such as Dictionary). This can be changed to a pop-down if that's
what's desired.
[The previously included fix to bug 17990 has been split off to CL
159864.]
TODO: Show keyboard shortcut for "Show Full History".
Patch by viettrungluu.
BUG=http://crbug.com/13203
TEST=Navigate around, check out and use the menus; do so in multiple tabs and
windows.
Review URL: http://codereview.chromium.org/160496
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only adds a simple text-only tab which displays heap-related log.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159631
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it doesn't fail when the internal repository isn't available.
Review URL: http://codereview.chromium.org/159848
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/162005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/162003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As this is updated as a dumpAsText test, we don't need the expected images.
See also:
WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=28008
WebKit change: http://trac.webkit.org/changeset/46790
BUG=11613
BUG=18412
TEST=none
Review URL: http://codereview.chromium.org/160637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The original bug was apple specific and we don't need to fix our code.
BUG=18016
Review URL: http://codereview.chromium.org/160388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
suppression.
TBR=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159909
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
layout test failure.
BUG=18487
Review URL: http://codereview.chromium.org/160633
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
memory leaks in valgrind. DOM Storage is behind a flag, so
it's ok to hide the symptoms until the problem can be solved.
TBR=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
evaluate the script directly.
This change will break the isolatedWorld tests until I land the change to
rename the layoutTestController method upstream.
R=darin
TEST=Coverged by LayoutTests.
Review URL: http://codereview.chromium.org/159782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shell doesn't hit very much of the new code. I still plan to write unit tests and we're still goign to enable the layout tests in test shell, but this is still a good way for us to test the full stack ASAP.
Workers has used this technique for a while now. This CL factors out the layout test running code from the workers ui test and moves arounds directories a bit so not everything is in the "workers" directory.
Doing this via a v8 extension is the right way to go long term, but I ran into a couple snags, so I think this is a good first step.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159720
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22465 0039d316-1c4b-4281-b951-d872f2087c98
|