| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/149295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16149
Review URL: http://codereview.chromium.org/155182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=jam
Review URL: http://codereview.chromium.org/149289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the proxy doesn't respond (e.g., due to a timeout).
BUG=none
TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking).
Review URL: http://codereview.chromium.org/149281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Allow keyboard and mouse navigation between the two while one is open.
BUG=none
TEST=the page and wrench menus feel like a native menubar
Review URL: http://codereview.chromium.org/155164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
readers in AJAX web applications (e.g. Gmail).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/149265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instantiated at the same time.
Review URL: http://codereview.chromium.org/149287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a typo.
CID=2001
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I mvoed the implementation of the previously-inline amimate function to the .cc file so we don't have to depend on STL includes in the header.
Review URL: http://codereview.chromium.org/155170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
frame around it.
BUG=16094
TEST=Open the task manager in Linux. Make sure the task manager treeview has a frame around it.
Review URL: http://codereview.chromium.org/149286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
removed when we maximize/go full screen.
BUG=15317
Review URL: http://codereview.chromium.org/155169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=26088
Add in the test output for LayoutTests/fast/text/text-letter-spacing.html
(platform-specific output for https://bugs.webkit.org/show_bug.cgi?id=26088).
Chromium-mac matches the output in platform/mac from webkit.
R=darin
BUG=https://crbug.org/10977
TEST=none
Review URL: http://codereview.chromium.org/155162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
project. This simplifies further refactoring and eases understanding of the printing part of Chrome.
Also renamed win_printing_context to printing_context_win (correct naming convention) and added stub implementations for _linux and mac.
Now all but one file is compiling on all platforms.
TEST=none (no functional change).
BUG=none
Review URL: http://codereview.chromium.org/149212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=Open popuptest.com in one tab and anything else in another. Switch between
GTK theme and normal. Theme of blocked popup container should change, even when
not the active tab.
http://crbug.com/13967
Review URL: http://codereview.chromium.org/149277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
showing.
(The interstitial is displayed on top of an existing page. We don't want the hidden page to interfere with the interstitial.)
BUG=http://crbug.com/3256
TEST=Open the page attached in the bug (interstitial_test.html), no alert boxes should show.
Review URL: http://codereview.chromium.org/149261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was resulting in some situations where we attempted to unpack the .crx while its file was still in use by the download manager.
BUG=15881
R=mpcomplete
Review URL: http://codereview.chromium.org/149161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
here is warranted. I failed to translate this over when adapting this code to
the new interfaces.
The tight coupling with WebView, WebFrame and WebViewDelegate makes this code
non-trivial to test. My next patch was anyways to remove those dependencies.
I'll circle around at that point with some unit tests for these classes.
R=brettw
TEST=none
BUG=16144
Review URL: http://codereview.chromium.org/155166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Origin issue: http://codereview.chromium.org/150122
B=16052,12745
TBR=brettw
Review URL: http://codereview.chromium.org/155157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Testing to see if this is the reason we hit the CHECK(!group_name_.empty()) in ClientSocketHandle::GetLoadState().
BUG=http://crbug.com/15374
TEST=none
Review URL: http://codereview.chromium.org/155150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
revision number in DEPS.
Review URL: http://codereview.chromium.org/149210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
better error if there are missing dependencies. (I thought this was on by default already, but it turns out that adding -a turns it off by default.)
Review URL: http://codereview.chromium.org/149275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
stable channel for a future release.
M binaries/gears.pdb
M binaries/gears.dll
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14931
TEST=none.
Review URL: http://codereview.chromium.org/155159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We still have a few crashes when for some reason we believe
an entry is not dirty and we follow the pointer stored by
its rankings node only to crash while accessing the memory.
I have no explanation to why the dirty id matches the current
one (a page boundary issue maybe?), but having a map with all
open entries solves the issue of having to follow pointers
from disk.
BUG=15596, b/1120346
TEST=unittests
Review URL: http://codereview.chromium.org/149218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from a web page, and always run it through valgrind once no matter
how perfect it is visually.
Review URL: http://codereview.chromium.org/149271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15892
TBR=ojan
Review URL: http://codereview.chromium.org/149269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run the browser tests with the --gtest_also_run_disabled_tests flag. Disabled tests should be run.
Review URL: http://codereview.chromium.org/155112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue #1) creating HTML by string is fast in all browsers.
Creating HTML by DOM methods is extremely slow in IE. 100-300x slower.
http://www.quirksmode.org/dom/innerhtml.html
Issue #2) There's a bug in IE related to <select> tags.
http://support.microsoft.com/kb/276228
Review URL: http://codereview.chromium.org/155154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=pinkerton
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/149263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/149267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13907
Review URL: http://codereview.chromium.org/149150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout!
Review URL: http://codereview.chromium.org/42490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move default registration of this pref out of platform code and into shared code to avoid having to do it in at least 3 places. Fix gradient buttons to not draw their borders unless asked.
BUG=13151
TEST=showing/hiding home button and page/wrench buttons should work. Menus for page/wrench should work except for a few straggler items that aren't yet implemented even in the main menubar.
Review URL: http://codereview.chromium.org/155151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
later.
Review URL: http://codereview.chromium.org/149132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16096, 10737, 10738
TEST=watch the linux ui buildbots for valgrind warnings; this should make several go away
Review URL: http://codereview.chromium.org/155152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=2001
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Mac. I'm leaving the window resizable for now, because I dislike
non-resizable windows. This is easy enough to change later.
BUG=None
TEST=After bringing up the dialog, verify that the only way to dismiss
it is by pressing either the wait button or the kill button.
Review URL: http://codereview.chromium.org/151009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20044 0039d316-1c4b-4281-b951-d872f2087c98
|