| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This is a speculative fix for the crash in the bug.
BUG=58042
TEST=sync integration tests
Review URL: http://codereview.chromium.org/4155004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=60550
Review URL: http://codereview.chromium.org/4096003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This looks like a big review, but a lot of it is just shuffling code around:
- rip out dropshadow code
- move arrow state and drawing to a model class, to allow sharing between BrowserWindow and Infobar
- get rid of InfoBar's border_bin_ and slightly simplify baseclasses by no longer requiring them to call show() on the toplevel widget
Added stuff:
- transition between arrow colors (previous_color_ vs. target_color_ business)
- arrows protruding on neighboring infobars
BUG=48996
TEST=manual, with animations slowed down 100x
Review URL: http://codereview.chromium.org/3919004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are not enabled for the current platform but were at one point.
BUG=60206
TEST=none
Review URL: http://codereview.chromium.org/3989002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileSyncServiceTestHarness is an automation helper class that lives in chrome/test. It contains methods that allow you to wait on various sync events, and is used by the sync integration tests.
We now need to re-use ProfileSyncServiceTestHarness to support sync operations in TestingAutomationProvider, a class that lives in chrome/browser. In order to accomplish this, we do the following things in this patch:
1) Move ProfileSyncServiceTestHarness to chrome/browser, so that TestingAutomationProvider can re-use its functionality, and rename it to ProfileSyncServiceHarness (a less wordy name that reflects the purpose of the class).
2) Since TestingAutomationProvider relies on the fact that the UI message loop is always running, we must change the default behavior of ProfileSyncServiceHarness to not start/stop the UI message loop. We make 2 key wait methods pure virtual: SignalStateComplete() and AwaitStatusChange().
3) The integration tests use a specialization of ProfileSyncServiceHarness that start/stop the UI message loop.
4) TestingAutomationProvider can go on to use a specialization of ProfileSyncServiceHarness that uses WaitableEvents. (coming up in another patch)
NOTE: There were 2 earlier attempts at checking in this patch -- See
http://codereview.chromium.org/3492005/show and
http://codereview.chromium.org/3419029/show.
BUG=56460
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/4145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was a bug in the original implementation of this test
that caused it to close early. Depending on the exact
timing, this sometimes failed, which caused it to be marked
flaky. Later, a bug was introduced that broke the underlying
functionality, which is also fixed here.
BUG=60156
TEST=Covered by browser_tests.
Review URL: http://codereview.chromium.org/4026005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The referenced bug was long-sinced fixed, but forgot to follow
up on the TODO.
BUG=60239
TEST=unit_tests --gtest_filter=ExtensionsServiceTest.InstallApps
Review URL: http://codereview.chromium.org/4147001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Jim suggested that so long as you only add items, there's really no
need to bound things.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4113001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
individual function outputs, test higher-level sequences of actions.
This also adds a views unittest alongside the existing GTK one.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4114001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes absolute-positioned checkbox/radio input align with their outer
label element. If we don't do that, webkit might pick a wrong parent element
and not moving checkbox/radio element properly as in http://crosbug.com/7541.
BUG=chromium-os:7541
TEST=Verify fix for chromium-os:7541
Review URL: http://codereview.chromium.org/4100002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
or semi-colon as delimiter for backwards compatibility.
BUG=52601
TEST=chrome_frame_unittests / UtilTests.XUaCompatibleDirectiveTest
Review URL: http://codereview.chromium.org/4103004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
please restart your browser" dialogs during CF udpates. If this number gets high, we should do something better.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4110001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55125
TEST=none
Review URL: http://codereview.chromium.org/3822001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mnaganov
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4176002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
options. This is a speculative fix for a bug where the dates are added
twice.
BUG=60578
TEST=none
Review URL: http://codereview.chromium.org/4181003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dbus uses glib message loop which is driven by UI thread.
It is correct to use UI thread to talk to dbus (for now)
It's not proven but this may be a source of obscure race bugs, or at least, we can exclude this from the potential source.
BUG=chromium-os:7490.
TEST=screen locker works as before.
Review URL: http://codereview.chromium.org/4024005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compile failure on Linux x64.
BUG=56558
TEST=no functional change
TBR=aa
Review URL: http://codereview.chromium.org/4156002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to use unsuported Greasemonkey APIs.
Classic JavaScript bug :(
BUG=
TEST=
Review URL: http://codereview.chromium.org/4119003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I made Extension a refcounted object, and privitized the existing
con/destructor and InitFromValue. The only way to get an Extension is to call
a factory method.
In the next CL, I plan to make the factory method return a const Extension,
to guarantee that no one can modify the Extension object after creation.
Note: There was a tricky part of this CL because of the difference in
semantics between scoped_ptr and scoped_refptr. I had to be careful not to use
ptr.release(), since that would result in leaks (an un-Released AddRef).
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/3982001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=evan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Capture the keyboard and mouse events directly from X, create a corresponding
views::Event out of it, and send it to the associated RootView.
Includes Chad's (wyck) function FindRootViewForGdkEvent (from #3704005) slightly
modified (called FindRootViewForGdkWindow).
BUG=None
TEST=Click/Keypress events in a webpage should work correctly.
Review URL: http://codereview.chromium.org/3801011
Patch from Sadrul Chowdhury <sadrul@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We used to get this for free as part of the pref-linking object decoration, but after the fixes for managed preferences the URL field is no longer a pref-linked field, so we need to add the unload handler directly.
BUG=60636
TEST=Change the homepage in DOMUI prefs, and close the tab without changing focus.
Review URL: http://codereview.chromium.org/4119002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use chrome.exe --enable-tcp-fastopen
BUG=none
TEST=none yet
Review URL: http://codereview.chromium.org/4039003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
during Mesa 7.9 upgrade. Also necessarily disabled optimizations in
src/mesa/main/image.c, src/mesa/main/mipmap.c,
src/mesa/main/histogram.c, and src/mesa/math/m_eval.c. Updated
README.chromium and chromium.patch.
BUG=none
TEST=none (built Mesa in Release mode on Windows)
Review URL: http://codereview.chromium.org/4137004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57832
TEST=Unittests
Review URL: http://codereview.chromium.org/3606014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=12543,12544,12758,12878,12879,12918,13252,13285,13301,13391
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60353
TEST=see repro steps in the bug.
Review URL: http://codereview.chromium.org/3973008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
initialization to OnInitiate() in JingleChromotingConnection.
BUG=None
TEST=Unittests.
Review URL: http://codereview.chromium.org/4055002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
per-platform.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4040001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The select popup on Mac was based on a hack: we would create an invisible RenderWidget and redirect mouse and keyboard events to it and we would display a native Cocoa menu. With this CL we do not use a RenderWidget anymore, we send the user selection to the RenderView which in turns communicates to WebKit that selection.
BUG=None
TEST=On Mac, ensures the select popup works as expected. Also test that for an extension with a browser action containing a select popup, the select popup does work. Also ensures autocomplete/autofill still works (especially popups).
Original review:
http://codereview.chromium.org/3795006/show
Review URL: http://codereview.chromium.org/4078003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thakis
TEST=none
BUG=60532
Review URL: http://codereview.chromium.org/4157003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added back in --sync-invalidate-xmpp-login (now, not only in debug mode!).
Added --sync-allow-insecure-xmpp-connection, which enables sync to
connect to insecure XMPP servers (e.g., a local one).
Changed --use-ssl-tcp to --sync-try-ssltcp-first-for-xmpp.
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/4158001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=60532
Review URL: http://codereview.chromium.org/4128005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mnaganov
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4129003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* ResetMenu now simply remove all menu items.
* This will closes all submenus opened. It require
a lot more work to update submenus correctly.
Since there is no scenario that requires this so
this is good enough for our use case.
BUG=chromium-os:8106
TEST=manual: on chromeos device, open network menu and change network settings. (plug-unplug ethernet)
Review URL: http://codereview.chromium.org/4120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before converting to Time.
Also refactors the code to be a bit easier on the eye, and avoid a string copy.
BUG=None
TEST=built with use_openssl, net_unittests
Review URL: http://codereview.chromium.org/4005007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=59030
TEST=None
Review URL: http://codereview.chromium.org/3850003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=b/17777403
TEST=none
Review URL: http://codereview.chromium.org/4017004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=BrowserTest.OtherRedirectsDontForkProcess
Review URL: http://codereview.chromium.org/4088001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The relevant Webkit change was submitted earlier: http://bugs.webkit.org/show_bug.cgi?id=48068
The unit tests have been updated for the multi-results case as well.
BUG=none
TEST=unit_tests --gtest_filter=Speech*
Review URL: http://codereview.chromium.org/4119004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by: Sadrul Chowdhury <sadrul@chromium.org>
BUG=59146
TEST=see bug
Review URL: http://codereview.chromium.org/4039007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The error (with dynamic linking) is:
SOLINK(target) out/Debug/obj.target/chrome/libbrowser.so
out/Debug/obj.target/browser/chrome/browser/geolocation/wifi_data_provider_linux.o: In function `DeviceDataProvider<WifiData>::DefaultFactoryFunction()':
/home/sadrul/devel/c/src/chrome/browser/geolocation/wifi_data_provider_linux.cc:355: multiple definition of `DeviceDataProvider<WifiData>::DefaultFactoryFunction()'
out/Debug/obj.target/browser/chrome/browser/geolocation/wifi_data_provider_chromeos.o:/home/sadrul/devel/c/src/chrome/browser/geolocation/wifi_data_provider_chromeos.cc:71: first defined here
collect2: ld returned 1 exit status
make: *** [out/Debug/obj.target/chrome/libbrowser.so] Error 1
Patch by: Sadrul Chowdhury <sadrul@chromium.org>
BUG=None
TEST=Build completes with dynamic linking enabled and GYP_DEFINES='chromeos=1'.
Review URL: http://codereview.chromium.org/4019009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when running in Chrome Frame mode.
Also fix the installer_util_strings target that had a broken dependency on a file that has since been moved.
BUG=46013
TEST=Google Chrome Frame is correctly displayed when the installer is run in Chrome Frame mode.
Review URL: http://codereview.chromium.org/3968005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This is still behind --enable-snap-start because the SSLHostInfo's
don't get created without it.)
Have ssl_client_socket_nss always save certificates to the SSLHostInfo
and have the SSLHostInfo kick off a validation as soon as possible if
it has the certificates.
For now the validation just primes the OCSP cache and isn't tied into
anything else. In future patches, the SSL socket will compare the
actual certificates against the predicted certificates and avoid a
second validation if they match.
BUG=none
TEST=none
http://codereview.chromium.org/3968003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes the ability to stat any file on disk and instead only allows stating files to which we have read access.
The complication with removing the ability to stat an arbitrary path is that without extra work you get into a situation where you can stat a leaf directory, but not it's parent. e.g. stat("/foo/bar") succeeds while stat("/foo") fails with errno == EPERM.
The only place we currently run into this is the utility process where the file system is off limits except for one directory.
This causes problems in 2 places:
1) DirectoryExists() works it's way from / down to the leaf directory stating each directory as it goes.
2) The extension installation code calls realpath() which fails if it can't stat parent directories.
The fix for the above is to explictly allow stating parent directories. We achieve this in the sandbox code by adding a function which generates the appropriate sandbox syntax.
This CL also contains unit tests for the above functionality and re-enables it [bug 56765, the underlying issue appears to be unrelated to the test and previously fixed].
BUG=42989, 56765
TEST=Chrome should continue to render web pages correctly, installing extensions and themes should continue to work on OS X.
Review URL: http://codereview.chromium.org/4044002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a prelude to having SSLHostInfo be able to kick off
certificate validations.
The vector of intermediate certificates is added on Linux because,
otherwise, nothing is holding a reference to them. Previously, the
nss_fd_ was holding a reference. However, without the vector holding
references, CreateFromDERChain deletes them all at the end and NSS has
to AIA chase up the chain.
BUG=none
TEST=net_unittests
http://codereview.chromium.org/3920001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes.
Also remove the Registry class stub implementations in base/registry.h
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4166001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4155002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since |timer_| is one-shot, it seems that the failure counter is reset to zero almost every time and unlikely exceeds kMaxRetries (see issue 8096.)
I don't think we should implement another type of limiter since the on-demand ibus loading code is stable. Let's just remove failure_count_ and related logic.
BUG=none
TEST=manually tested that the flush function works fine without the counter.
Review URL: http://codereview.chromium.org/4102002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63872 0039d316-1c4b-4281-b951-d872f2087c98
|