| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
hard-coded strings in new tab page into localizable .grd strings, and fix bug introduced in r19556.
BUG= http://crbug.com/15467
TEST= Run with new new tab page for the first time, with no tips stored in preferences. Note that welcome tip is not a link.
Review URL: http://codereview.chromium.org/147247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11392
TEST=none
Review URL: http://codereview.chromium.org/151154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
going to need it again shortly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Implement displaying of notification, menu of popups still to come.
BUG=13160
TEST=popup notification should display and popups blocked accordingly. Can close notification widget to prevent more notifications for this tab.
Review URL: http://codereview.chromium.org/150132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13160
TEST=none
Review URL: http://codereview.chromium.org/150163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
hard, mmkay?).
BUG=12902
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=15691
R=cpu
TEST=Set language to 'ru', run setup.exe with --show-eula
Review URL: http://codereview.chromium.org/150126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fixed a bug in ClearBrowsingDataController: checking Delete Form Data would end
up deleting passwords instead. Patch from Jens Alfke (snej@google.com).
BUG=12902
TEST=deleting form data should actually delete the form data.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
is just missing expectations.
Review URL: http://codereview.chromium.org/150167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
overlapping views, including the findbar and resize widget. Three
classes currently inherit from BaseView: TabContentsViewCocoa,
RenderWidgetHostViewCocoa, and SadTabView (Mac).
BUG=http://crbug.com/10887
BUG=http://crbug.com/13150
TEST=Findbar should never disappear when searching. Resize
widget should never disappear. Clicking and dragging in a webpage should not move the window around.
Review URL: http://codereview.chromium.org/150104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
test, otherwise the test will hang waiting for reponse from the front-end.
Review URL: http://codereview.chromium.org/151143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=overflow-scroll.html
BUG=15710
Review URL: http://codereview.chromium.org/150159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
exceptions file.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/150156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy.
BUG=13936
Review URL: http://codereview.chromium.org/126137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also do a tiny roll of the WebKit deps.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Includes a fix to the build due to a file renaming.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=23849 is landed in Chromium it doesn't break devtools.
Review URL: http://codereview.chromium.org/149064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=15677
Review URL: http://codereview.chromium.org/151140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
injection, and user script injection.
Also adds unit tests that EXTENSIONS_READY always gets fired.
Also removes some old test data that we weren't using.
Review URL: http://codereview.chromium.org/149120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, PageTransition::CHAIN_END flag is removed from a History database
entry for a redirect source, even when the redirect is user initiated.
This change prevents the flag removal for user-initiated redirects.
TEST=Open http://www.google.com/ig and click on tabs multiple times. Without
this change, only the last tab clicked appears in the History page (CTRL+H).
With this change, all the tabs should appear.
TESTED=gcl try, manually
BUG=11355
Review URL: http://codereview.chromium.org/147145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue is caused by my another mistake that I forgot setting the modifier-key state in creating a Char event in RenderWidgetHostViewGtkWidget::ForwardCharEvent().
Since the GtkIMContext signal-handlers don't use GdkEventKey objects and cannot get the modififer-key state, this change save the state in RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent() before dispatching a key event to the GtkIMContext object.
Also, this change adds gtk_im_context_focus_in() and gtk_im_context_focus_out() calls to fix compatibility problems with ibus.
BUG=10953 "IME support"
BUG=15531 "regression: shift-space doesn't scroll the page backwards"
TEST=Open a test page in <http://crbug.com/15531>, press shift+space keys, and observe ev.shiftKey is true.
Review URL: http://codereview.chromium.org/151010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We also add ellipses to the bookmark title.
TEST = A bookmark with a title that has a UTF-8 character that spans
the 15 character truncation point should not cause "Gtk: Invalid input
string" errors. See http://dev.chromium.org/developers/coding-style
for an example of the problem. The title in that case is as follows:
"Coding Style \u200E(Chromium Developer Documentation)\u200E"
Review URL: http://codereview.chromium.org/147207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- set a better default size
- ellipsize columns
- allow users to change column widths
- remember user-modified column widths
BUG=http://crbug.com/14742
TEST=none
Review URL: http://codereview.chromium.org/151134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The optimization failed to account for the possiblity of consecutive reshapes with different sizes. Instead of making the optimization smarter, just get rid of it, as it isn't clear it helps anything.
BUG=none
TEST=resize browser with custom frame on.
Review URL: http://codereview.chromium.org/151132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
agl will revisit this as he continues to polish complex text, but for
now we can acknowledge it so the builder stays green.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This enables the ImageOperations.* and SkiaUtils.* test_shell_tests
on linux and mac.
Review URL: http://codereview.chromium.org/151097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Put a comment to clarify a behavior
See coverity CID 1703
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/150128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Intentionally no code change. For each plugin test, either fix baseline, mark
as passing, or annotate with why we're failing.
Review URL: http://codereview.chromium.org/151129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I used the upstream implementation as a guide for the changes I made,
so style faults are theirs.
Also includes updates to test_expectations for the new tests we pass,
and one new baseline for a test that had an output image that we match
Windows on aside from antialiasing.
BUG=11516
Review URL: http://codereview.chromium.org/150144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It is helpful when defining experiments to put all remaining probability
on the final (often the "control" group), without having to keep a careful
tally of assignments of probabilities. This CL implements that functionality.
r=rvargas
Review URL: http://codereview.chromium.org/150141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Max number of channels (2)
- Bits per sample (64)
- Sampling rate (256kHz)
- Queue audio buffer (64MB x 2)
BUG=none
TEST= WinAudioTest.SanityOnMakeParams
Review URL: http://codereview.chromium.org/151093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=erikkay
BUG=15659
Review URL: http://codereview.chromium.org/150109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- During first run (confusing the newbie)
- In other special situations when we show UI before the main chrome window is created
BUG=14192
TEST=see bug
Review URL: http://codereview.chromium.org/151061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added a stub for an unused method on Canvas in order to link.
TEST=Selecting "Open" from the shelf menu will open a download
BUG=15661
Review URL: http://codereview.chromium.org/150079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/150147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19689 0039d316-1c4b-4281-b951-d872f2087c98
|