| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=65664
TEST=none
TBR=scherkus
Review URL: http://codereview.chromium.org/5567007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds SCHEME_CHROMEUI as a valid URLPattern scheme in GetGrantedPermissions.
Ensures these schemes stay in sync with those in Extension.
BUG=65309
TEST=ExtensionPrefsGrantedPermissions
Review URL: http://codereview.chromium.org/5626004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65688
TEST=see bug
Review URL: http://codereview.chromium.org/5657002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=57351
TEST=Unittests
Review URL: http://codereview.chromium.org/5635003
TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/5581007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch by sjl@chromium.org:
http://codereview.chromium.org/5518008/
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57351
TEST=Unittests
Review URL: http://codereview.chromium.org/5635003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
StreamWriter classes are not used anymore. Removing them.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5575005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This script reads perf_expectations.json for revision
ranges, downloads the appropriate trace data, calculates
the improve/regress ranges, then writes the updated
values back to perf_expectations.json.
BUG=none
TEST=make_expectations.py downloads updated results,
writes correct perf_expectations.json file
Review URL: http://codereview.chromium.org/5607005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5606008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64652
TEST=none
Review URL: http://codereview.chromium.org/5517004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61534
TEST=ExtensionApiTest.FileAPI
Review URL: http://codereview.chromium.org/5392001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=62613
TEST=Set up sync, get to configure screen (second one), note no tabstrip or encryption options.
Review URL: http://codereview.chromium.org/5560008
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/5662001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add more values that we can get back from JavaScript. Very useful for writing
additional DOMUI browser test, and maybe in other cases as well.
BUG=none
TEST=RenderViewHostTest.ExecuteJavascriptInWebFrameNotifyResult
Review URL: http://codereview.chromium.org/4924001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=yutak
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62613
TEST=Set up sync, get to configure screen (second one), note no tabstrip or encryption options.
Review URL: http://codereview.chromium.org/5560008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webkit/tools/layout_tests/webkitpy/layout_tests/test_output_xml_to_json.py
BUG=41405
TEST=green bot
Review URL: http://codereview.chromium.org/5598007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
onInputChanged.
BUG=64538
TEST=Use the chrome_search sample extension and make sure the first suggestion updates in sync with what you type.
Review URL: http://codereview.chromium.org/5607003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9044
TEST=Clang builds
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pierre-Antoine LaFayette (see http://codereview.chromium.org/1403001/ ), r=me,brettw,aa.
Downloads are considered dangerous if:
a) The file is dangerous just by sitting on the drive, without needing to be clicked on e.g. dll, xbap
b) The file is executable and the download was not user initiated.
c) They are an extension that is not from the gallery
We have defined a user initiated download as 3 possible cases:
a) A user enters a URL into the address bar that is a file
b) A user left clicks on a URL that is a file
c) A user right clicks and does "Save As" on a URL that is a file.
BUG=9044
TEST=Open a page with a download link to a dangerous file that is not an extension, e.g. an .exe file, and left click on the link. The download should proceed without a prompt.
Review URL: http://codereview.chromium.org/5603008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65680
TEST=Greener memory tree
TBR=hclam
Review URL: http://codereview.chromium.org/5637004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, if there was no scrolling, then we would always paint the union of
any invalidations. With this change, if the area of the invalidation rects is
sufficiently less than the area of the union, then we will just paint the
individual invalidation rects.
This may regress page cycler performance (see http://crbug.com/29589).
R=brettw
BUG=50303
TEST=updated unit tests
Review URL: http://codereview.chromium.org/5613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Open bookmark manager. Searching should still work.
Review URL: http://codereview.chromium.org/5530006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58763
TEST=manual
Review URL: http://codereview.chromium.org/5601003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5118002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65399
TEST=manual
Review URL: http://codereview.chromium.org/5588004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added EncoderRowBased that implements encoding for both ZLib and Verbatim.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5382008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
PerformAction properly.
BUG=none.
TEST=manually with VoiceOver.
Review URL: http://codereview.chromium.org/5579004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65664
TEST=Memory tree test_shell tests stop failing.
TBR=scherkus
Review URL: http://codereview.chromium.org/5542006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Close button on DOMUI prefs subpages should still work.
Review URL: http://codereview.chromium.org/5568007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Implement search capability for top level panels.
- Code cleanups for options_page.js
BUG=59267
TEST=Verify search field presents results based on user input.
Review URL: http://codereview.chromium.org/5538002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also restricts the extra highlighting of options page list element to just the lead element, since that code was changing anyway to handle disabling.
BUG=60838
TEST=Startup page list in DOMUI options should look and act disable when the corresponding option is not selected.
Review URL: http://codereview.chromium.org/5608003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Colors are not screwed up
BUG=None
Review URL: http://codereview.chromium.org/5510003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us the appropriate icon depending on whether the
volume is increasing, decreasing, or muted.
BUG=chromium-os:8473
TEST=built it and tried the volume up, down, and mute keys in various combinations
Review URL: http://codereview.chromium.org/5559004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
build breaks.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor ZLib and Verbatim encoders.
Added EncoderRowBased that implements encoding for both ZLib and Verbatim.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5382008
TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/5586006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added EncoderRowBased that implements encoding for both ZLib and Verbatim.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5382008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64943
TEST=BrowserTest.ConvertTabToAppShortcut
Review URL: http://codereview.chromium.org/5589001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65362
TEST=Make sure select popups work as expected. Test all selects
on http://vescam.com/select_crasher.html
Review URL: http://codereview.chromium.org/5658001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It adds the following entries:
OpenGL ES 2.0 Conformance Tests
hunspell
hyphen-2.6
iccjpeg
Chinese and Japanese Word List
libvpx
It removes the entry for SCons.
BUG=NONE
TEST=Go to about:credits and make sure that the entries listed above are added/removed.
Review URL: http://codereview.chromium.org/5557003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5574003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dynamic textures.
TEST=loaded O3D on a test page on Linux and used the new API to display the framerate
BUG=none
Review URL: http://codereview.chromium.org/5591006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaResourceLoaderBridge.
Attempt #2 after fixing some race conditions between Initialize() and Abort() (see r68363).
One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag.
Patch by annacc@chromium.org:
http://codereview.chromium.org/3863002/
BUG=16751
TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered*
src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple*
src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media
webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65642
TEST=Valgrind unit tests go green.
TBR=bauerb
Review URL: http://codereview.chromium.org/5556009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CID=8391,8392,8526,8527,11212,11213,12566,12567,
12610,12611,13934,13935,13936,13937
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5577003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=static compile doesn't work with 'touchui=1 chromeos=1'
TEST=static compile should work with 'touchui=1 chromeos=1'
Review URL: http://codereview.chromium.org/5515007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65203
TEST=Open a DOMUI pref subpage; there should be a close button in the upper-right.
Review URL: http://codereview.chromium.org/5518006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=65642
TEST=Heapchecker goes green.
Review URL: http://codereview.chromium.org/5559008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suggest text.
BUG=65464
TEST=Type "hello" into the omnibox. When the suggestion appears, press right (or tab). Suggest text should turn black.
Review URL: http://codereview.chromium.org/5556007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two reasons that cause this problem:
1. See issue http://crbug.com/65375
2. By some reason, when BrowserWindowCocoa::PreHandleKeyboardEvent() is
called for Cmd-W, it fails to get its corresponding command id, because
the corresponding menu item is not enabled at that time.
This CL does following changes:
1. Change testing flow to work around issue 65375.
2. Fix the second problem by always retrieving the corresponding command
id regardless of the menu item's state.
The reason of the second issue:
When Cmd-T gets handled in NSApp, BrowserWindowController's -validateUserInterfaceItem: method will be called for all menu items to determine their enable states and the states will be cached in each menu item. At this time, because there is only one tab, the "Close Tab" menu item will be disabled.
Then when sending Cmd-W to the browser, it'll firstly be handled in BrowserWindowCocoa::PreHandleKeyboardEvent() method, which will look up the
command id associated to Cmd-W, but at this time, BrowserWindowController's -validateUserInterfaceItem: method does not get called yet, so the corresponding menu item is still not enabled. Then BrowserWindowCocoa::PreHandleKeyboardEvent() will not handle Cmd-W because it
cannot find its command id.
After removing the check in cr_firesForKeyEvent method, BrowserWindowCocoa::PreHandleKeyboardEvent() method will always get the correct command id of a key equivalent regardless of its enable state, then if it's a reserved key equivalent, it will always be sent to NSApp for handling, which will call BrowserWindowController's -validateUserInterfaceItem: to update the enable states of all menu items. Then if the corresponding menu item is really disabled, NSApp will do nothing and return false, then the key event will be dispatched to web page as normal.
BUG=50447 BrowserKeyEventsTest.ReservedAccelerators failed on Mac10.6 Tests (dbg)(1) bot.
TEST=The test should not flaky.
Review URL: http://codereview.chromium.org/5576002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68369 0039d316-1c4b-4281-b951-d872f2087c98
|