| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10675011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=143991 began using tracker_ as a state-tracking signal, but didn't reset tracker_ with a new instance of ImageLoadingTracker if the dialog instance is reused. This caused a crash the second time a user clicked a trash can on the extensions page.
BUG=134780
TEST=no longer crashes.
Review URL: https://chromiumcodereview.appspot.com/10689006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GrabWindowSnapshot() happens in the "Report Issue" (c/b/ui/webui/feedback_ui.cc)
and XGetImage runs earlier than closing the wrench menu. This could delay the
response on "Report Issue" but it's much more important to work correctly for this specific item.
R=derat@chromium.org
BUG=134818
TEST=manually done on lumpy / selecting "Report Issue" and Ctrl-F5
Review URL: https://chromiumcodereview.appspot.com/10694003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MakeCurrent() calls:
- GpuVideoDecodeAcceleratorHost is already AddRoute'd to
GpuChannelHost on creation, so
CommandBufferProxyImpl::OnChannelError doesn't have to call
GVDAH::OnChannelError as well (was causing double-notifications
of errors to GVDAH).
- GpuVideoDecodeAcceleratorHost::Send() would DCHECK that no
error had previously been reported on the channel, but that's
incorrect because its client will likely still have async
posted tasks from before the error notifications. Now instead
of DCHECK'ing simply early-return after an error was seen.
- gpu_video_decode_accelerator.cc:MakeDecoderContextCurrent()
used to unconditionally bind the GpuCommandBufferStub* into its
closure, but nothing guarantees the lifetime of the stub; in
fact context loss will cause the stub to be deleted so this
could crash as well. Now take a WeakPtr to the stub and check
its validity before every use (and return false if invalid to
allow clients to avoid assuming context currency).
- GpuVideoDecodeAccelerator is now a
GpuCommandBufferStub::DestructionObserver to avoid attempting
further work once the stub is about to be deleted.
- Removed a bunch of unnecessary MakeCurrent() calls; VAAPI_*
calls don't need it, and are sometimes made on the decoder (not
main) thread, from which it is incorrect to call GL-related
methods such as MakeCurrent() anyway.
BUG=134020
TEST=manual playback of multiple HW-decoded .mp4's doesn't crash anything when different tabs are closed.
Review URL: https://chromiumcodereview.appspot.com/10668030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=`SSLKEYLOGFILE=/ ./out/Release/chrome` shouldn't crash.
Review URL: https://chromiumcodereview.appspot.com/10636062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added check of both HKCU and HKLM values.
Chrome location detection switched to launcher_support.
BUG=none
TEST=unittest
Review URL: https://chromiumcodereview.appspot.com/10687007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These methods were left over from the old NaCl NPAPI/Pepper1 proxy,
which was removed some time ago.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2730
TEST=build
Review URL: https://chromiumcodereview.appspot.com/10700002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10636060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows ExtractBitmap() to return an ImageSkiaRep.
This simplifies code around using intermediate bitmaps a lot.
BUG=131475
TEST=Compiles
R=oshima,sky
TBR=sadrul
Review URL: https://chromiumcodereview.appspot.com/10562027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While trying to bullet proof a unit test, I had trouble getting very far when
running all tests in shuffle mode. Tracked that back to a few other tests doing
stuff that accessed Singleton()s outside of a test-scoped
ShadowingAtExitManager. Seemed to me that should be an invariant around any
unit test, so created this towards that end, hopefully helping stabilize out
unit_tests a bit more.
BUG=133403
Review URL: https://chromiumcodereview.appspot.com/10582012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Speech CL2.5)
BUG=116954
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10629003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current status_icon_gtk.cc implementation has a small esthetic bug: if a tray icon is shown and destroyed repeatedly under GTK, a small whitespace accumulates on the Linux tray area on every destruction.
BUG=116954
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10668040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This renames the Android WebSettings class to ContentSettings.
The naming change is related to downstream refactoring.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10700005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10678010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=134541
TEST=manually done on the repro steps in crbug.com/134541
Review URL: https://chromiumcodereview.appspot.com/10695005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=134143
TEST=unittests, tree green, no behavior change in blacklisting
R=vangelis
Review URL: https://chromiumcodereview.appspot.com/10625006
TBR=zmo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10690012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r9037: (bradchen) Fix enuminst so that it can do a proper ragel/ncval length comparison.
r9038: (mseaborn) Remove an "#ifdef NACL_STANDALONE" in sel_ldr_launcher_standalone.cc
r9039: (robertm) Fixed typos in pnacl's translator.
r9040: (kschimpf) Clean up actual classes used in tables extra_load_store and
r9041: (mseaborn) Remove the mostly-unused USE_CRYPTO code path for using libcrypto (OpenSSL)
r9042: (halyavin) Add MinGW.
BUG=none
TEST=nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10701003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per mocks, the placeholder text and blinking cursor of the edit box on
alternate ntp page should start 11px right of where it is now. Added
background so that the inset will be colored as the edit box.
BUG=134365
TEST=manual on linux aura.
Review URL: https://chromiumcodereview.appspot.com/10678008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=134143
TEST=unittests, tree green, no behavior change in blacklisting
R=vangelis
Review URL: https://chromiumcodereview.appspot.com/10625006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
When building with the NDK, RTTI is provided by stlport, but when building with the Android build system, it is provided by gabi++.
Review URL: https://chromiumcodereview.appspot.com/10695008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=105208
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123160
TEST=root_window_controller_unittest.cc
Review URL: https://chromiumcodereview.appspot.com/10659006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
running chrome.
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/10682006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These are already provided by
system/core/include/arch/linux-arm/AndroidConfig.h and cause warnings when
redefined.
Review URL: https://chromiumcodereview.appspot.com/10696007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test file edition.
BUG=none
TEST=none
TBR=remaining owners
Review URL: https://chromiumcodereview.appspot.com/10680013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes: Tell Interface Builder that UnderlayOpenGLHostingWindow is a subclass of NSWindow.
BUG=134751
TEST=no build warnings on mac
Review URL: https://chromiumcodereview.appspot.com/10697006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=124339
TEST=Check that lock screen has radial transtion effect on wallpaper load.
Review URL: https://chromiumcodereview.appspot.com/10668043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a weakptr to avoid the crash. We dont need to call SetCustomWallpaperThumbnail
when the wallpaper page closed by user.
BUG=134439
TEST=
1. Go to chrome://chrome/settings/setWallpaper
2. click "browse..." and chose any image from file system
3. close the set wallpaper... immediately (before the background actually changed
to the image you just selected)
Expected: the browser shouldn't crash and wallpaper changed to the image
you just selected.
Review URL: https://chromiumcodereview.appspot.com/10667039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::DIR_SOURCE_ROOT.
The environment variable overidde was only implemented on linux and not on the
other OSes. So it was not coherent across platforms. I searched for usage and
didn't find anything compelling. If this change causes any breakage, simply
revert it. If is is needed, it should be made coherent between platforms.
Note that this trick is not compatible with test isolation, where test should
find their data file at deterministic relative location, hence the removal of
this override.
R=willchan@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10661019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I could not find 'IsCursorInShelfZone 0' (the unrealized widget smoking gun) in several browser_tests logs, and DownloadTest.AutoOpen is consistently passing again on linux, so the logs are just spam.
Review URL: https://chromiumcodereview.appspot.com/10682004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=132937
TEST=when downloading, file icon is centered
Review URL: https://chromiumcodereview.appspot.com/10667041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No behavior change.
R=cmp@chromium.org
NOTRY=true
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10665051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a symlink is found, the symlink itself _and_ the data it points to are
processed. This is necessary for OSX bundles support.
R=cmp@chromium.org
NOTRY=true
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10656047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Symlinks are not supported by the commit queue so checking-in independently.
Ref: https://chromiumcodereview.appspot.com/10656047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to ensure correctness when adding symlink support to isolate.py
R=cmp@chromium.org
NOTRY=true
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10657049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=133511
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/10636054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Symlinks are not supported by the commit queue so checking-in independently.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Drive by cleanup: Consolidated the error reporting for the EnterpriseEnrollmentScreen.
BUG=chromium-os:30457
TEST=unit_tests. For manual testing set up the DMServer to send 402 error to registration request and observe the special error message on the enrollment screen.
Review URL: https://chromiumcodereview.appspot.com/10664017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Improve trace_inputs_smoke_tests.py in preparation to adding more smoke tests and add a smoke test for blacklist support in extract_directories().
Move the directory extraction check into a subdirectory as a new test for
symlink support will be added soon, requiring new test data files.
R=cmp@chromium.org
NOTRY=true
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10658036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed by fhd@ubercode.de
BUG=23145
TEST=Start with --kiosk and observe that Chromium is started in full screen and that the address bar etc. won't appear.
Review URL: https://chromiumcodereview.appspot.com/7484029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=yangguo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10693004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
These options currently don't work, so we shouldn't use them, irrespective of the value of android_build_type. We'll address each option individually in the future.
Review URL: https://chromiumcodereview.appspot.com/10703003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=132352
TEST=Manual test.
Review URL: https://chromiumcodereview.appspot.com/10632016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recognition. (Speech CL2.4)
This is done in order to avoid NO_SPEECH errors in the (very rare) case in which the endpointer did not pass the noise threshold but the recognition engine (that always receives audio, regardless the state of the endpointer) provides an intermedia result.
BUG=116954
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10537142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason:
http://build.chromium.org/p/chromium/builders/Mac10.6%20Sync/builds/19046
Make sync_listen_notifications listen for network changes.
Add a scoped NSAutoreleasePool to sync_listen_notifications.
Relax DEPS for sync/tools a bit.
BUG=106034
TEST=
Review URL: https://chromiumcodereview.appspot.com/10675012
TBR=akalin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10690007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144439 0039d316-1c4b-4281-b951-d872f2087c98
|