| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
This fixes a minor rendering issue on IE7. IE seemed to choking on (probably invalid) html where a <div> was a child of a <ul>
Review URL: http://codereview.chromium.org/506068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
codes.
- The logging of error codes is intended to be used in passive mode.
- The logging of string messages is intended to be used when in full-logging mode.
- The logging of string literal messages is intended to be used in passive mode.
BUG=27552
Review URL: http://codereview.chromium.org/503066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30154
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/501156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
by John Spiegel (see http://codereview.chromium.org/466086 ), r=me.
BUG=1922
TEST="View Page Source" in context menu should open to the immediate right of the current tab.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/18158, http://crbug.com/30381, http://crbug.com/30371, http://crbug.com/30373
TEST=valgrind bots green. Bookmark bubble still works.
Review URL: http://codereview.chromium.org/503064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a new flip option: "npn". --use-flip=npn to activate.
Allows for negotiation of SPDY via SSL for https urls.
Checks for the existence of existing SPDY sessions and reuses them where possible.
Review URL: http://codereview.chromium.org/500088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works by clicking a button in about:net-internals to turn on active logging.
Right now full logging means:
- Instead of just the most recent 25 requests, keep all requests info.
- Instead of limiting each request to 50 log entries, keep all log entries.
- Instead of saving the first 1000 bytes of request URLs, save all its bytes.
In the future full logging will be expanded to include other log events, and also string messages (so it can mirror what was sent to LOG(INFO) / LOG(WARNING)).
BUG=27552
Review URL: http://codereview.chromium.org/507055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
files moved in Breakpad r446, and the .gyp file should have been modified when
Breakpad was updated from r432 to r452 in our r34916.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/504077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30930
TEST=LayoutTests on WebKit-Linux-dbg-3
Review URL: http://codereview.chromium.org/505064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
response headers from the disk cache.
BUG=26729
TEST=current unit tests.
Review URL: http://codereview.chromium.org/506081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
single-core perf regressions.
TBR=chase
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/501151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since nothing writes to this map in the browser atm, this does not have any visible effect.
BUG=13156,25454
TEST=unittest
Review URL: http://codereview.chromium.org/501138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/504059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Follow-up to http://codereview.chromium.org/502090
BUG=28977
TEST=tab's context menu still works, is still localized. No warning about localize_strings when building chrome.
Review URL: http://codereview.chromium.org/502093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
555 (http://code.google.com/p/v8/issues/detail?id=555).
BUG=see above
TEST=none
Review URL: http://codereview.chromium.org/504075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was used to localize the context menu, but the context menu is no longer in the xib file.
BUG=28977
TEST=tab's context menu still works, is still localized.
Review URL: http://codereview.chromium.org/502090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/501149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crashes list.
BUG=30790
TEST=reliability tests
Review URL: http://codereview.chromium.org/507060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=tab switching test runs without needing additional
arguments
Review URL: http://codereview.chromium.org/502091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=startup test continues running
Review URL: http://codereview.chromium.org/507059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IDS_SANS_SERIF_FONT_FAMILY.
It turned out the values of these fields are used for the "Fonts and
Languages" dialog, so use of commas is not allowed.
On the other hand, IDS_WEB_FONT_FAMILY seems to be used for generating
HTML so use of commas is fine. For instance:
chrome/browser/dom_ui/chrome_url_data_manager.cc:
void ChromeURLDataManager::DataSource::SetFontAndTextDirection(
DictionaryValue* localized_strings) {
localized_strings->SetString(L"fontfamily",
l10n_util::GetString(IDS_WEB_FONT_FAMILY));
chrome/browser/dom_ui/history_ui.cc:
SetFontAndTextDirection(&localized_strings);
static const base::StringPiece history_html(
ResourceBundle::GetSharedInstance().GetRawDataResource(
IDR_HISTORY_HTML));
const std::string full_html = jstemplate_builder::GetI18nTemplateHtml(
history_html, &localized_strings);
BUG=30758
TEST=locally ran "LANGUAGE=ja chrome" and confirmed that specified fonts are shown in
the "Fonts and Languages" dialog, and Japanese pages are rendered with VL Gothic/PGothic.
Review URL: http://codereview.chromium.org/502088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
triggered by GC during code generation.
BUG=30790
TEST=reliability tests
Review URL: http://codereview.chromium.org/507058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix failed Linux Views and ChromeOS build.
BUG=11258
TEST=See bug report.
Review URL: http://codereview.chromium.org/503065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The combined IPC means that scrolling only requires one transport DIB instead
of two. Previously, we'd use one in the ScrollRect IPC to pass up the pixels
for the exposed region, and then we'd use a second one in the PaintRect IPC to
pass up the pixels for the updated scroll bar rendering. Now all paints are
done using a single transport DIB.
Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions.
This means calling GetUpdateRgn and GetRegionData to enumerate the list of
damage rects. Then only those rects are copied from the backing store.
The same optimization is not done for Linux or Mac yet.
R=brettw
BUG=29591
TEST=none
Originally reviewed at http://codereview.chromium.org/506013
Review URL: http://codereview.chromium.org/509005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The image view shows NSUser and is at y=72, so it's not visible. Looks like this was here since this file was first checked in. I can't imagine it serves an actual purpose.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/509004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It failed out of the blue here:
<http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP/builds/21055/steps/net_unittests/logs/stdio>
I'm tempted to pre-emptively mark the rest of URLRequestTestFTP flaky.
BUG=25045
TEST=more green, less red
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/509003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/509002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and corresponding strings from "Import Bookmarks & Settings" dialog since we none of the importers support importing cookies and likely won't in the future.
* Removed IDS_IMPORT_COOKIES string since it isn't used by any other part of the change.
* Modified nib to remove relevant checkbox and move the rest of the UI up to fill the space.
BUG=29125
Test=Open dialog in question, make sure "Import Cookies" option is no longer displayed and that profile import still works correctly.
Review URL: http://codereview.chromium.org/500066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
probably just too-smart zlib.
BUG=30667
TEST=green (Linux) valgrind
TBR=hamaji@chromium.org
Review URL: http://codereview.chromium.org/503069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See, e.g., failure here:
<http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(valgrind)(3)/builds/2168/steps/valgrind%20test%3A%20ui/logs/stdio>
BUG=30870
TEST=green (Linux) valgrind
TBR=slightlyoff@chromium.org, viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/501145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FlipFramer::DecompressFrame.
Probably it's just that zlib is smarter than us though.
BUG=30667
TEST=Linux valgrind test: net
TBR=hamaji@chromium.org
Review URL: http://codereview.chromium.org/505059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces code to properly enable DnD to the Omnibox without adding a
trivial |-updateDragTypeRegistration| to |AutocompleteTextFieldEditor| (so that
it falls through to the text field), but rather letting the field editor accept
DnD directly.
We'll see whether or not it turns Mac Perf(2) red (by regressing startup times).
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/500157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an experiment. I expect the startup times to regress and Mac Perf(2) to
turn red, at which point I'll revert this. If not, the TEST below applies.
[Yes, indeed, it turned red. Crazy!]
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
Review URL: http://codereview.chromium.org/500155
TBR=viettrungluu@chromium.org, shess@chromium.org
Review URL: http://codereview.chromium.org/502086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an experiment. I expect the startup times to regress and Mac Perf(2) to
turn red, at which point I'll revert this. If not, the TEST below applies.
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/500155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 481012 was: Mac: implement DnD of URLs onto Omnibox.
It was reverted due to a startup (perf) regression. The first half was re-committed at r35044. (Committing this at r35053, reverting at r35054, showed that this CL really does cause a regression.)
I don't know what causes this, so I'm committing it with the functionality turned off. So all that's changed is that some methods have been added and some protocols conformed to. If startup test times regress, something really weird is going on.
BUG=24631
TEST=Mac perf(2) doesn't turn red.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/508001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move the one existing test to final location
- Test more critical paths to be accessilbe and writable
- Test the OS version
- Test user or systemwide install type
BUG=27885
TEST=unit test updated
Review URL: http://codereview.chromium.org/504028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mac perf turns red.
Well, it turned red.
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/502084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
red.
CL 481012 was: Mac: implement DnD of URLs onto Omnibox.
It was reverted due to a startup (perf) regression. The first half was re-committed at r35044. I can't for the life of me reproduce the regression locally, so I'm re-committing and watching the bots.
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/500153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 481012 was: Mac: implement DnD of URLs onto Omnibox.
This is the half consisting of mild refactoring and no new functionality.
BUG=none
TEST=Dragging and dropping URLs onto the tab strip should still work as before. More important is whether this regresses the startup tests.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/505057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
measurements on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/505056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implement DnD of URLs onto Omnibox.
(DnD of text coming in another patch.)
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
Review URL: http://codereview.chromium.org/481012
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/501135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by their upstream equivalents and I don't see any reason to keep them around.
BUG=9161
BUG=11251
TEST=chrome/fast/forms/basic-textareas.html
TEST=chrome/fast/forms/textarea-metrics.html
R=ojan@chromium.org
Review URL: http://codereview.chromium.org/500151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jparent
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/501134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mbelshe
BUG=None
TeST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=chrome/fast/encoding/Invalid-multi-byte-over-consumption.html
R=ojan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=mbelshe
TEST=None
Review URL: http://codereview.chromium.org/504069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
key" to direct Keystone to use a tag stored in the application as opposed to
in its ticket.
BUG=30730
TEST= - ksadmin --print-ticket --productid com.google.Chrome should show
tagPath pointing to GC.app/Contents/Info.plist, and
tagKey of KSChannelID;
- ksadmin --print-tag --productid com.google.Chrome should show the
value of the KSChannelID key in GC.app/Contents/Info.plist;
this should be the tag that is used for auto-updates
The above steps should be validated after the following operations:
- launching Chrome when on a user ticket,
- promoting Chrome from a user ticket to a system ticket, and
- when a Chrome update is applied (using this version of
keystone_install.sh) when on either a user or a system ticket.
The tagPath and tagKey will NOT be set when launching Chrome on a
system (promoted) ticket, but they WILL be set when the ticket is
initially promoted and also when an update is applied using this version
of keystone_install.sh.
Review URL: http://codereview.chromium.org/506061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=htp://crbug.com/30173
Review URL: http://codereview.chromium.org/504065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35029 0039d316-1c4b-4281-b951-d872f2087c98
|