| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=55902
TEST=Renderer accessibility is not enabled on stock windows tablets.
Review URL: http://codereview.chromium.org/3575013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44265
TEST=change some bookmark titles to "" and note that the icons are not clipped
Review URL: http://codereview.chromium.org/3549011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting http://codereview.chromium.org/3569010/show.
It didn't seem to help the tree, and the bugs which motivated it have been fixed.
BUG=none
TEST=interactive_ui_tests --gtest_filter=AutocompleteEditViewTest.*
Review URL: http://codereview.chromium.org/3594009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test code should not go out of its way to disable external DNS queries, so we should not cause tests to fail when such queries are made. However, to avoid external depenencies in tests, we simulate failure for the queries themselves.
See http://codereview.chromium.org/3396022/show for some backstory.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3535003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=cevans
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3603008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes |WebDatabase::MigrateOldVersionsAsNeeded()| to return error status should database migration fail. If migration does fail then the initialization as a whole is rolled back. The error code is returned to caller so user is alerted. This also cleans up logging so that in all error cases log warnings are emitted. Additionally, this reworks the Autofill credit card migration logic to test the schema before migrating. This is preferable to the existing logic that attempted the migration and then looked for failure after the fact.
BUG=54012
TEST=WebDatabaseMigrationTest.*
Review URL: http://codereview.chromium.org/3615007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=12798, 12835, 12921, 12922, 12923, 13083, 1408, 7026, 7027, 13052, 13058, 8295, 2289, 13026, 13133, 13233, 13184, 13183
BUG=none
TEST=none
Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org>
Review URL: http://codereview.chromium.org/3567011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
receives focus.
BUG=47492,36217
TEST=Manual: Select text in a text box. Press F6 until focus returns to the webpage. NVDA should read the selected text.
Review URL: http://codereview.chromium.org/3561010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes http://code.google.com/p/chromium/issues/detail?id=57906 that was
introduced by http://codereview.chromium.org/3506007/show
BUG=57906
TEST=see bug. Go to http://www.flashtexteditor.com/ with pepper flash and
observe no crash
Review URL: http://codereview.chromium.org/3616005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few key design points.
* Uses DOMView to render menu content.
* MenuUI (subclass of DOMUI) uses GtkWiget tree to access
WidgetGtk and MenuModel. Alternative way was to change
TabContents::GetDOMUIForCurrentState() public and pass them throught it, but this seems to work fine.
* Input/Focus is controlled by gtk_grab_add. Input is grabbed by the root widget, and then sent to each active menu widget via gtk_grab_add.
* Menu gets shown after the renderer rendered the content
(thus has some size) to avoid showing small/empty menu.
Mouse processing is blocked until the menu is shown (see Dispatcher).
A few issues that will be addressed in separate CL
* RTL (will be after beta)
* menu scroll. working on it now.
* menu sometimes show scroll bar. (I just need to disable it)
* unit test for native_menu_domui
BUG=chromiun-os:6497
TEST=manual for now. all menu2 based meus should work as before (web pages's context menu, system menu, forward/back menu and several chromeos specific one) except for following two:
* mnemonic should work now on context menus.
* menu larger than screen does not scroll. I'll implement this in separate CL
Review URL: http://codereview.chromium.org/3442018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=tkent
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3617005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To build ICU without '-fno-strict-alias' flag on Linux with gcc 4.4.x.
BUG=NONE
TEST=ICU build goes fine with gcc 4.4.x after
regenerating make files with 'gclient runhooks' with
GYP_DEFINES="no_strict_aliasing=0'
Review URL: http://codereview.chromium.org/3433021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
necessitated by needing to hold off on showing instant results until I
know if the server really supports instant.
This change is mostly refactoring to enable this. Most of what was
MatchPreview has been moved into MatchPreviewLoader. LoaderManager is
used to determine which MatchPreviewLoader to use as well as keeping
around a cache of them. MatchPreview for the most part delegates to
LoaderManager and MatchPreviewLoader now.
I'll rename all these classes to instant (and move into its own
directory) next.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3541008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57910
TEST=valgrind/heapchecker goes greener.
TBR=ajwong
Review URL: http://codereview.chromium.org/3565008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This will slowly auto-opt-in people as their machines are wiped and/or preferences are reset.
BUG=none
TEST=install fresh copy of Chrome OS, Talk labs should be enabled by default
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes changes to code in webkit/ that broke chrome_frame. Will debug that portion later.
(Shaves ~2MB off Linux Debug .a files)
BUG=none
TEST=compiles
First Review URL: http://codereview.chromium.org/3563004
Review URL: http://codereview.chromium.org/3621003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was cruft left over from the workaround for handling plugins on zoomed pages; now that the underlying bug is fixed and the workaround removed, it's no longer called.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3602009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
some remaining gyp file tweaks.
Review URL: http://codereview.chromium.org/3423021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Frame should handle.
TEST=This adds a new policy list for Chrome Frame, "ChromeFrameContentTypes", which can be used to specify a list of content types that should always be rendered in Chrome Frame.
BUG=56543
Review URL: http://codereview.chromium.org/3611002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also need to be passed to the zygote process since logging is initialized before forking renderers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3597006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Extension of this change, applied more liberally:
http://src.chromium.org/viewvc/chrome/trunk/src/build/linux/chrome_linux.croc?r1=44710&r2=46647
Review URL: http://codereview.chromium.org/3540002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
Fixed logging error in Linux version of Launch On Startup support. Specifically, this corrects the handling of the result returned by WriteFile when generating the autostart .desktop file.
Review URL: http://codereview.chromium.org/3565004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=net_unittests
Review URL: http://codereview.chromium.org/3614001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move size based disposition override for ChromeOS from tab_container to browser.
* TYPE_APP_PANEL |= TYPE_POPUP so that special popup behavior applies to panels.
* Removed confusing BrowserFrameChromeos::IsPanel(), replaced with BrowserView::IsBrowserTypePopup() calls.
* Replaced now redundant checks against panel or popup types with 'browser->type() & Browser::TYPE_POPUP'.
* Added size limiting code to PanelBrowserView.
* Modified CreateWindowFunction::RunImpl() to create TYPE_APP_POPUP windows instead of TYPE_POPUP.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=5166
TEST=Test spawning popups/panels/tabs from web pages (e.g. gmail), extensions (e.g. chat manager), and apps
More info: https://docs.google.com/document/edit?id=14nBjW6gHJW0kk44o8Z8vfDSnDi0ZT1sUU74Zc5wmwIQ&hl=en&authkey=CKT6-O8I
!!! This commit didn't go through !!! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29fe99e
Review URL: http://codereview.chromium.org/3449007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
line flag '--no-pings'.
BUG=21589
TEST=none
R=darin
Review URL: http://codereview.chromium.org/3555007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=173
TEST=none
Review URL: http://codereview.chromium.org/3516010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=scarybeasts
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3620003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes the original code plus changes to 2 new files to fix a test that
was failing:
chrome/browser/resources/webstore_app/manifest.json
chrome/test/data/extensions/api_test/extension_gallery_install/test.html
Original review url was:
http://codereview.chromium.org/3537010
BUG=56399
TEST=You should be able to write an extension using the management API.
TBR=aa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
services are needed. If not, it shuts down. Also the ShutdownIfNeeded method checks to see if clients are connected before shutting down. And we only try to recreate the channel if we were previously connected to a client.
BUG=None.
TEST=Run the service process without any enabled services. It should die within a minute.
Review URL: http://codereview.chromium.org/3562004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When replacing a placeholder in a localized string, make sure the correct number of placeholders were found (i.e. the same number of strings that the calling code passed).
BUG=none
TEST=running/testing the browser in debug doesn't cause errors
Review URL: http://codereview.chromium.org/3396025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test was failing on the bots because the extensions get different ids
on different bots, since the paths are different. I've changed the test to
load the extensions first and then query their id, instead of relying on
the id they get on my computer.
BUG=36275
TEST=AllUrlsApiTest (2 new ones)
Review URL: http://codereview.chromium.org/3610006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Weird scenarios can lead to windows retaining a handle to a downloaded file
such that it cannot be removed. This leads to failures every once a while.
Mark all such files and delete them only after the browser has shut down.
Incorporated this in all the downloads tests.
BUG=
TEST=downloads.py
Review URL: http://codereview.chromium.org/3530008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=greener tree
Review URL: http://codereview.chromium.org/3612003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=tkent
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3599015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57884
TEST=no
Review URL: http://codereview.chromium.org/3555013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50760
TEST=interactive_ui_tests --gtest_filter=KeyboardAccessTest.ReserveKeyboardAccelerator
Review URL: http://codereview.chromium.org/3527007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
during chrome-initiated xmlhttprequest aborts. Two similar problems are fixed by this CL.
I found a race condition during the early-termination processing of the NpapiUrlRequest objects. If NpapiUrlRequest::Stop is invoked before NpapiUrlRequest::OnStreamCreated, then it is possible that a new stream will be created on the Chrome-Frame side, for which an operation that has been officially cancelled within Chrome. The fix is to add a new parameter fo the NPAPIUrlRequest, stop_requested_ that is used to track this behaviour. If a new stream is created on a request that has been stopped, then that stream is immediately destroyed, without notification back to Chrome.
If Chrome requests an abort of a url request, then Chrome-Frame should not send any notifications back to Chrome concerning the tear-down of that request. The delegate is revoked in NPAPIUrlRequest::Stop to achieve this behaviour.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3530002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3607004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works with the following caveat: the view does not update as the model does. The view does update the model (when pressing remove), but not vice versa (the view is only updated once, when it is first opened). This is actually also true of the native dialog version. To fix this I will need to add an observer interface to the Geolocation settings map similar to the one in HostContentSettingsMap.
I didn't use the GeolocationExceptionsTableModel because it doesn't seem helpful in this case, although I did copy some code from it. If we move to dom ui completely on all platforms, we can delete that file completely and the relevant parts will have migrated into ContentSettingsHandler. The GeolocationExceptionsTableModel allows for sorting, but I don't know if we care to keep that functionality as the mocks don't cover it, and if so it should probably be pageside.
content_settings_handler is getting more unwieldy and will continue to do so, which motivated me to refactor a little and in particular to add better (or rather, any) comments to the header. I may eventually want to factor out even more functionality as new, special content types get added (plugins, notifications, geolocation, etc? are all non-standard).
BUG=57457
TEST=manual
Review URL: http://codereview.chromium.org/3520012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=interactive_ui_tests --gtest_filter=AutofillTest.*
Review URL: http://codereview.chromium.org/3492009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=tkent
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3578010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for the case where the overlay is small.
BUG=53609
TEST=none
Review URL: http://codereview.chromium.org/3556011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CL began its life under rdsmith (http://codereview.chromium.org/3548001/show).
BUG=55728
TEST=Run chrome with invalid proxy server and examine navigation error message.
Review URL: http://codereview.chromium.org/3521010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It started as an attempt to put the decoder onto another thread. However, this became complicated due to multiple object ownership transfers and coupling between the decode layer and the network layer; the decoder's states were highly coupled with how the network packets were processed.
This could probably be broken up slightly, but at this point, it's easier to just commit as a whole The refactor includes:
1) Making the decoder interface unaware of "network packet" types.
2) Making the network layer process packets in order.
3) Threading through asynchronous APIs all over the place.
4) Simplifying the rectangle update protocol.
5) Cleaning up object lifetime and ownership semantics between the decode layer and the renderer.
As of right now, the Verbatim format is still broken on the encode side because it uses the old protocol.
BUG=52883, 57351
TEST=still connects to chromoting_simple_host
Review URL: http://codereview.chromium.org/3305001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(... instead of a PP_Var). This allows binary data to be appended to POSTs.
This rolls DEPS to pick up PPAPI r269.
BUG=none
TEST=Pepper URLLoader tests
Review URL: http://codereview.chromium.org/3548009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=57875
TEST=
Review URL: http://codereview.chromium.org/3552007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3560008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61399 0039d316-1c4b-4281-b951-d872f2087c98
|