summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Publish DEPS for Chromium 35.0.1916.7135.0.1916.71gitdeps2014-04-242-767/+533
|
* Incrementing VERSION to 35.0.1916.71chrome-release@google.com2014-04-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265656 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 35.0.1916.70chrome-release@google.com2014-04-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265546 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264463 "Resets global X11 error code each time X11ErrorTra..."varkha@chromium.org2014-04-231-1/+12
| | | | | | | | | | | | | | | > Resets global X11 error code each time X11ErrorTracker is instantiated > > BUG=362235 > TEST=Open Hangouts contact list and immediately close. Repeat many times. Make sure it opens as a panel docked at the bottom of the screen every time. > > Review URL: https://codereview.chromium.org/240713003 TBR=varkha@chromium.org Review URL: https://codereview.chromium.org/248403003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265543 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264189 "Don't show fullscreen controls for frame: none app..."jackhou@chromium.org2014-04-231-1/+1
| | | | | | | | | | | | | | > Don't show fullscreen controls for frame: none app windows. (Mac) > > BUG=362039 > > Review URL: https://codereview.chromium.org/240013002 TBR=jackhou@chromium.org Review URL: https://codereview.chromium.org/245973007 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265462 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 260800 "Fix display when host is larger than client"jamiewalch@chromium.org2014-04-231-0/+1
| | | | | | | | | | | | | | | | > Fix display when host is larger than client > > Cause and Fix: > Setting flex-shrink=0 to the plugin to make it non re-sizable > BUG=358139 > > Review URL: https://codereview.chromium.org/217713004 TBR=kelvinp@chromium.org Review URL: https://codereview.chromium.org/246023005 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265446 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264859 "Check if the target window for focus is a transien..."jennyz@chromium.org2014-04-231-1/+1
| | | | | | | | | | | | | | | > Check if the target window for focus is a transient child of the AppListView window when the mouse is pressed. > > BUG=364337 > TBR=xiyuan > > Review URL: https://codereview.chromium.org/241643002 TBR=jennyz@chromium.org Review URL: https://codereview.chromium.org/248333003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265431 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 35.0.1916.69chrome-release@google.com2014-04-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265428 0039d316-1c4b-4281-b951-d872f2087c98
* Manual merge of r265166 to branch 1916ccameron@chromium.org2014-04-221-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | > CoreAnimation: Fix avatar button > > The avatar button is a child of the NSThemeFrameView, which does not > have a layer, and therefore does not have a layer itself. As a result, > it will never appear above a view that has a layer, like, for instance, > the FloatingBarBackingView, when in presentation mode. > > Note that, while this does fix the issue empirically, there is no > guarantee about the ordering of layered views that do not have a common > ancestor that has a layer. In principle, this issue could happen again, > depending on internal implementation details -- this fix just makes > it so the issue is not guaranteed to happen all the time. In my testing > I haven't provoked the issue with the fix. > > The long-term solution to this problem is probably to have the > NSThemeFrameView have a layer. This will need to be done carefully > because simply making it layer-backed results in high memory usage and > poor performance. > > BUG=365266 > > Review URL: https://codereview.chromium.org/242843003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265425 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264607 "Fix the remaining subpixel antialiasing bugs in th..."dewittj@chromium.org2014-04-227-26/+142
| | | | | | | | | | | | | | | | | | | | | | > Fix the remaining subpixel antialiasing bugs in the notification center. > > This addresses bad text rendering in the following places: > * The "Chrome Notifications" label > * The "Nothing to see here, move along" label > * The "Settings" label > * The "Allow notifications from the following" settings label > * The user selection drop down > * The app selector buttons within settings. > > BUG=362369,335794 > > Review URL: https://codereview.chromium.org/240703004 TBR=dewittj@chromium.org Review URL: https://codereview.chromium.org/246433013 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265416 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 265392 "Fix script injection accessibility in ICS."dmazzoni@google.com2014-04-221-2/+5
| | | | | | | | | | | | | | > Fix script injection accessibility in ICS. > > BUG=359789 > > Review URL: https://codereview.chromium.org/246643007 TBR=dmazzoni@chromium.org Review URL: https://codereview.chromium.org/247633003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265414 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264965 "Fix a bug that phone number field is not saved occ..."tkent@chromium.org2014-04-223-2/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Fix a bug that phone number field is not saved occasionally. > > An editing phone number value is not applied correctly because a reply for a > chrome.send() has some delay. > > Bug scenario: > 1. Click handler for autofill-edit-address-apply-button is kicked. > 2. document.activeElement.blur() is called. > - An INPUT element in phone-list loses focus. > - AutofillPhoneValuesList.validateAndSave is called. > - It calls chrome.send('validatePhoneNumbers') > 3. 0ms delay by setTimeout in the click handler > 4. self.saveAddress_() is called, and the overlay is dismissed. > 5. AutofillEditAddressOverlay.setValidatedPhoneNumbers is called. It's too late. > > To fix this issue, we wait for completing phone number validation. > - AutofillPhoneValuesList provide a Promise which is fulfilled when all > of validation requests are completed. > - The autofill-edit-address-apply-button handler wait until the > Promise is fulfilled. > > This process worked well accidentally before r254991 because we incorrectly did > blur in the mousedown handler of autofill-edit-address-apply-button, and > setValidatedPhoneNumbers was called before mouseup. > > BUG=361950 > > Review URL: https://codereview.chromium.org/236003008 TBR=tkent@chromium.org Review URL: https://codereview.chromium.org/248453002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265413 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 265049 "Fix touch exploration issues with older Android ve..."dmazzoni@google.com2014-04-223-22/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Fix touch exploration issues with older Android versions. > > This change has three small related fixes. All of these fixes should help > with the latest Android version too, but the experience was far worse with > older Android versions and older TalkBack versions, and fixing these > bugs makes touch exploration work well everywhere. > > 1. ContentView shouldn't call super.onHoverEvent when touch exploration is on, > because the default implementation can send touch exploration accessibility > events that interfere with the ones sent by BrowserAccessibilityManager. > > 2. BrowserAccessibilityManager should send just a single HOVER_ENTER event > first and then a HOVER_EXIT event, whenever touch exploration reaches a > new virtual view. They must be in that order. > > 3. Finally, BrowserAccessibilityManager was waiting until a call to > notifyFrameInfoInitialized before creating any nodes or sending any events, > because without valid RenderCoordinates it's impossible to compute the > bounding box of any object. However, it was incorrectly assuming that > mRenderCoordinates was invalid upon BrowserAccessibilityManager construction > and also when the root node changes - both of which aren't necessarily true. > To fix this, we replace mFrameInfoInitialized with isFrameInfoInitialized() > that just checks whether mRenderCoordinates is valid or not - that way it's > never out of sync. > > BUG=359209 > NOTRY=true > > Review URL: https://codereview.chromium.org/244743002 TBR=dmazzoni@chromium.org Review URL: https://codereview.chromium.org/247723005 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265410 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 265003 "Get Android accessible link text from url if other..."dmazzoni@google.com2014-04-226-2/+52
| | | | | | | | | | | | | | > Get Android accessible link text from url if otherwise unlabeled > > BUG=360839 > > Review URL: https://codereview.chromium.org/237583007 TBR=dmazzoni@chromium.org Review URL: https://codereview.chromium.org/248423002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265408 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 260386 "Fix Host stuck at the right side"jamiewalch@chromium.org2014-04-222-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Fix Host stuck at the right side > > Cause: > This bug only repro on chrome v33 and v34 > > <div class="vertically-centered"> > <div class="horizontally-centered"> > <div id="video-container"> > <video id="mediasource-video-output"></video> > <div id="client-plugin-container"></div> > </div> > </div> > </div> > > Due to a chrome layout bug, the width of video-container collapses to 0 when the zoom level is greater than 100%. As a result, the flexbox defined in horizonally-centered fails to center the element. > > Fix: > Set width=100% on video-container so that its width remains valid. Since video-container now sizes to the parent, we need to move the horizontal-centered flexbox to the children of video-container. > > BUG=357114 > > Review URL: https://codereview.chromium.org/217363002 TBR=kelvinp@chromium.org Review URL: https://codereview.chromium.org/246673003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265405 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 35.0.1916.68chrome-release@google.com2014-04-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265377 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264394 "Fix ExtensionStartupBrowserTest on non-Windows off..."gab@chromium.org2014-04-222-4/+5
| | | | | | | | | | | | | | > Fix ExtensionStartupBrowserTest on non-Windows official builders. > > BUG=363579 > > Review URL: https://codereview.chromium.org/239213002 TBR=gab@chromium.org Review URL: https://codereview.chromium.org/248263002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265374 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264736 "linux_aura: Fix Ctrl-Home so it goes to the start ..."erg@chromium.org2014-04-221-1/+1
| | | | | | | | | | | | | | | | > linux_aura: Fix Ctrl-Home so it goes to the start of the buffer. > > This fixes an accidental typo in the MoveCurosr() logic. > > BUG=362659 > > Review URL: https://codereview.chromium.org/241463003 TBR=erg@chromium.org Review URL: https://codereview.chromium.org/247863003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265373 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264953 "CoreAnimation: Reduce VA usage by extra layers"ccameron@chromium.org2014-04-222-23/+78
| | | | | | | | | | | | | | | | | | | | > CoreAnimation: Reduce VA usage by extra layers > > Use a solid color layer for TabContentsContainerView instead of using > drawRect. This prevents a backing store from being allocated. > > Disable display updates when handling tab drags, to prevent the > background view from flashing. > > BUG=364808 > > Review URL: https://codereview.chromium.org/244043002 TBR=ccameron@chromium.org Review URL: https://codereview.chromium.org/248113002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265349 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264110 "linux_aura: Remove the 'a' badge."erg@chromium.org2014-04-228-26/+5
| | | | | | | | | | | | | | | | | > linux_aura: Remove the 'a' badge. > > Also bumps the theme version so that cached 'a' assets that might live > in the BrowserThemePack get regenerated. > > BUG=343787, 360905 > > Review URL: https://codereview.chromium.org/237963002 TBR=erg@chromium.org Review URL: https://codereview.chromium.org/247623004 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265339 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 261496 "Check the scheme of a RenderViewHost before assumi..."jyasskin@chromium.org2014-04-222-3/+69
| | | | | | | | | | | | | | | | > Check the scheme of a RenderViewHost before assuming it contains an extension. > > Thanks to ncarter for the test! > > BUG=357382 > > Review URL: https://codereview.chromium.org/216113007 TBR=timwillis@chromium.org Review URL: https://codereview.chromium.org/247873002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265309 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 265061 "Revert "Check existence of Widevince CDM/Adapter o..."xhwang@chromium.org2014-04-221-17/+0
| | | | | | | | | | | | | | | | | | | > Revert "Check existence of Widevince CDM/Adapter on load failure on Win." > > This reverts commit 8bcd56e28c781e796dd53744185c28dfbc15fa38. > > The check was originally added to help investigate some issues. See BUG for > details. > > BUG=356331 > > Review URL: https://codereview.chromium.org/244833004 TBR=xhwang@chromium.org Review URL: https://codereview.chromium.org/245393003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265302 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264161 "Fix crash in GetCandidateIndicesWithBestScores() w..."pkotwicz@chromium.org2014-04-222-6/+11
| | | | | | | | | | | | | | | > Fix crash in GetCandidateIndicesWithBestScores() when |candidate_sizes| is empty > > BUG=361516 > TEST=Crash stops occurring > > Review URL: https://codereview.chromium.org/239343005 TBR=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/246803004 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265293 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK crash in login_location_monitor on sign in screen. alemate@google.com2014-04-221-2/+1
| | | | | | | | | | This fixes incorrect call to function expecting IO thread on UI thread. BUG=364810 TEST=manual git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265250 0039d316-1c4b-4281-b951-d872f2087c98
* Setting version to MAJOR=35chrome-release@google.com2014-04-221-1/+1
| | | | | | | | | MINOR=0 BUILD=1916 PATCH=67 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265247 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 263915 "Check for empty callback, use only one authenticator"antrim@chromium.org2014-04-222-1/+3
| | | | | | | | | | | | | | | > Check for empty callback, use only one authenticator > > R=nkostylev@chromium.org > BUG=363202 > > Review URL: https://codereview.chromium.org/239263003 TBR=antrim@chromium.org Review URL: https://codereview.chromium.org/246063005 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265234 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 263636 "[DevTools] Pass sourceDevice in protocol gesture e..."dgozman@chromium.org2014-04-221-0/+1
| | | | | | | | | | | | | | > [DevTools] Pass sourceDevice in protocol gesture events. > > BUG=362559 > > Review URL: https://codereview.chromium.org/234803005 TBR=dgozman@chromium.org Review URL: https://codereview.chromium.org/247243002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265222 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264185 "Use flex box layout for centering user pod image"nkostylev@chromium.org2014-04-221-3/+4
| | | | | | | | | | | | | | | | | > Use flex box layout for centering user pod image > > Fixes image placement being off by 1px. > > NOTRY=true > BUG=363551 > > Review URL: https://codereview.chromium.org/239233002 TBR=nkostylev@chromium.org Review URL: https://codereview.chromium.org/246443004 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265190 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 35.0.1916.59chrome-release@google.com2014-04-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265181 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 35.0.1916.58chrome-release@google.com2014-04-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265178 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 263779 "extensions: Use base::RunLoop instead of deprecate..."sadrul@chromium.org2014-04-221-3/+3
| | | | | | | | | | | | | | | | | > extensions: Use base::RunLoop instead of deprecated MessageLoop methods. > > Speculative change to fix a crash. > > BUG=355083 > R=kalman@chromium.org > > Review URL: https://codereview.chromium.org/235483005 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/246393003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265173 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264888 "[Hotword] Disabling the extension on install shoul..."rlp@chromium.org2014-04-221-3/+9
| | | | | | | | | | | | | | > [Hotword] Disabling the extension on install should only occur if it was auto-installed. > > BUG=364853 > > Review URL: https://codereview.chromium.org/243083003 TBR=rlp@chromium.org Review URL: https://codereview.chromium.org/246423003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265149 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264825 "[Hotword, WebUI] Fix formatting for reset browser ..."rlp@chromium.org2014-04-222-2/+2
| | | | | | | | | | | | | | > [Hotword, WebUI] Fix formatting for reset browser settings. The formatting became misaligned when the same variable was used for the hotwording overlay. By giving the hotwording overlay its own id, the css for the hotwording overlay no longer affects the reset browser settings checkbox > > BUG=361549 > > Review URL: https://codereview.chromium.org/243133002 TBR=rlp@chromium.org Review URL: https://codereview.chromium.org/246473002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265148 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 263801 "Revert 259518 "Files.app: Allow to update cached m..."hirono@chromium.org2014-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Revert 259518 "Files.app: Allow to update cached metadata." > > The change causes crbug.com/363499. > > > Files.app: Allow to update cached metadata. > > > > Previously Files.app does not update cached metadata if the same type has already cached. This causes the following race. > > > > 1. [JS] Request to obtain metadata. > > 2. [C++] Obtain file size. > > 3. [C++] Copy completes and it is notified to JS. > > 4. [JS] Clear cached metadata for updating file size. > > 5. [JS] Request to obtain metadata. > > 6. [JS] Receive a result requested at step 1 and cache the result. > > 7. [JS] Receive the latest result requested at step 5. But it is ignored. > > > > This CL fixes the possible race. > > > > BUG=352732 > > TEST=manually > > > > Review URL: https://codereview.chromium.org/209773002 > > TBR=hirono@chromium.org > > Review URL: https://codereview.chromium.org/238163006 TBR=hirono@chromium.org Review URL: https://codereview.chromium.org/244853007 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265136 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264730 "Add keyboard showing delegate"dtrainor@chromium.org2014-04-221-0/+37
| | | | | | | | | | | | | | | | > Add keyboard showing delegate > > Add a way to override the keyboard visibility detection > > BUG=251343 > > Review URL: https://codereview.chromium.org/241263002 TBR=dtrainor@chromium.org Review URL: https://codereview.chromium.org/245913003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265135 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 35.0.1916.57chrome-release@google.com2014-04-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265117 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 244720 "When installations are in progress only delay cle..."mek@chromium.org2014-04-214-19/+10
| | | | | | | | | | | | | | | | | | | | | | | | Unfortunately this had the side effect of exposing a race conditions that could result in actually valid extensions being garbage collected. Since the real fix for that is too big to backport, reverting back to not garbage collecting at all in certain situations is the lesser of the two problems. BUG=342271,365469 > When installations are in progress only delay cleaning up of Temp directory, don't delay cleaning up of old extension versions. > > This makes the effect of chrome never finishing installing pending extension less severe since most data will still be cleaned up. > > BUG=329943 > > Review URL: https://codereview.chromium.org/131153003 TBR=mek@chromium.org Review URL: https://codereview.chromium.org/245843003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265111 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264451 "Fixes the crash for "learn more" link of the dialo..."mukai@chromium.org2014-04-212-9/+23
| | | | | | | | | | | | | | | | | > Fixes the crash for "learn more" link of the dialog for v2 apps. > > It assumed a browser but it might not exist in case of v2 apps. > > BUG=363716 > R=dkrahn@chromium.org, bartfab@chromium.org > > Review URL: https://codereview.chromium.org/236203017 TBR=mukai@chromium.org Review URL: https://codereview.chromium.org/243463006 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265098 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 261979 "Flush texture id for the mirrored content after it..."piman@chromium.org2014-04-211-0/+1
| | | | | | | | | | | | | | > Flush texture id for the mirrored content after it is created. > > BUG=358345 > > Review URL: https://codereview.chromium.org/226783002 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/245893003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265091 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 260276 "Change media galleries to external file system ty..."vandebo@chromium.org2014-04-2130-748/+263
| | | | | | | | | | | | | | | > Change media galleries to external file system type to add toURL support > > BUG=160900 > R=creis@chromium.org, joi@chromium.org, thestig@chromium.org, tsepez@chromium.org, tzik@chromium.org > > Review URL: https://codereview.chromium.org/185393012 TBR=vandebo@chromium.org Review URL: https://codereview.chromium.org/244253008 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265087 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264878 "[Android] Catch NotFoundExceptions when querying g..."jdduke@chromium.org2014-04-211-3/+21
| | | | | | | | | | | | | | | | | | | > [Android] Catch NotFoundExceptions when querying gesture constants > > Certain Sony/Japanese devices are throwing Resources.NotFoundExceptions when > looking up scale-related gesture constants. It's not yet clear why the lookup > is failing, but in any case such lookup failure should not crash the app. Use > a constant fallback in these cases, scaled to the current display configuration. > > BUG=363484 > > Review URL: https://codereview.chromium.org/243503003 TBR=jdduke@chromium.org Review URL: https://codereview.chromium.org/245843002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265075 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 261549 "Check shared memory size before allocating it."wjia@chromium.org2014-04-211-2/+5
| | | | | | | | | | | | | | | | > Check shared memory size before allocating it. > > This will prevent overflow from multiplication. > > BUG=359454 > > Review URL: https://codereview.chromium.org/214343006 TBR=wjia@chromium.org Review URL: https://codereview.chromium.org/245753002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265054 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264218 "CoreAnimation: Fix omnibox anti-aliasing on 10.6"ccameron@chromium.org2014-04-211-0/+8
| | | | | | | | | | | | | | | | | | > CoreAnimation: Fix omnibox anti-aliasing on 10.6 > > Transfer the drawsBackground and backgroundColor properties > explicitly to the editor text view on 10.6. This is not necessary > on subsequent versions. > > BUG=358416 > > Review URL: https://codereview.chromium.org/239513004 TBR=ccameron@chromium.org Review URL: https://codereview.chromium.org/245313003 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265043 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 263247 "Used condvar timed wait instead of indefinite wait..."jvoung@google.com2014-04-213-8/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Used condvar timed wait instead of indefinite wait for WaitForSelLdrStart. > > There are various reasons that the condvar signal will never happen: > - We currently do a CallOnMainThread in StartSelLdrContinuation > to invoke the callback that does the signaling. However, that > CallOnMainThread might not get scheduled as we are tearing down > the embed. > - The IPC reply from the browser -> renderer might get completely > dropped as the embed is being destroyed, so we may never even > get to StartSelLdrContinuation. > > Why care about the condvar being blocked at all? > > The ~Plugin is blocked on ~PnaclCoordinator, which is > blocked on trying to join the PnaclTranslateThread's thread. However > if the surfaway is "early enough" then PnaclTranslateThread's thread > may be waiting for SelLdrStart (the condvar). > > Another reason that ~PnaclCoordinator on the main thread > could be blocked is that it attempts to acquire the > subprocess_mu_. However, the subprocess_mu_ is being held > by the translate thread while it is waiting on the condvar. > I tried shifting the lock acquisition until after the > process is started and to the point that the code is > actually trying to write to the shared field. However, that > doesn't help because there is still the thread join... and > we need the thread join because it protects against > the thread using fields of PnaclCoordinator while it's > being free'd. > > Use timeout in background thread NaCl process startup condvar. > Don't wait too long though, because the renderer is hung > in the meantime. > > There are other places we block indefinitely on condvars > (reverse service thread), which show up in crash reports > (see the BUG), but that's not addressed here. > > BUG=350426 > REPRO (but not TEST)= www/~jvoung/test_embed_kills/ > not yet sure of how to make a test that isn't flaky, since you need to fuzz the surfaway time a bit to trigger (~150 ms) and the cond var timed-wait will make tests that do repro slow. > > R=dschuff@chromium.org, teravest@chromium.org > > Review URL: https://codereview.chromium.org/233443004 TBR=jvoung@google.com Review URL: https://codereview.chromium.org/245113005 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265042 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264565 "[Win] Fix reporting of the crash client ID/guid fo..."rsesek@chromium.org2014-04-211-0/+8
| | | | | | | | | | | | | | > [Win] Fix reporting of the crash client ID/guid for non-browser crash reports. > > BUG=364493 > > Review URL: https://codereview.chromium.org/238253014 TBR=rsesek@chromium.org Review URL: https://codereview.chromium.org/245563004 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265041 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 263787 "Allow chrome://devices only in non-incognito windows"noamsml@google.com2014-04-211-1/+2
| | | | | | | | | | | | | | | | | > Allow chrome://devices only in non-incognito windows > > Do not allow chrome://devices in incognito windows. > > BUG=357051 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/235853002 TBR=noamsml@chromium.org Review URL: https://codereview.chromium.org/243043005 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265038 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 262916 "Add NULL check before CanPauseForPendingResizeOrRe..."ccameron@chromium.org2014-04-211-0/+1
| | | | | | | | | | | | | | | | > Add NULL check before CanPauseForPendingResizeOrRepaints > > OLD BUG=361569 > BUG=352020 > TBR=dgozman > > Review URL: https://codereview.chromium.org/232283002 TBR=ccameron@chromium.org Review URL: https://codereview.chromium.org/245643002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265037 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 262431 "[Mac] Don't pause for pending resize in overlay vi..."ccameron@chromium.org2014-04-213-11/+30
| | | | | | | | | | | | | | > [Mac] Don't pause for pending resize in overlay views. > > BUG=352020 > > Review URL: https://codereview.chromium.org/223913002 TBR=dgozman@chromium.org Review URL: https://codereview.chromium.org/245503004 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265036 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 264918 "Fix the output request size for AudioBufferConvert..."dalecurtis@google.com2014-04-213-45/+84
| | | | | | | | | | | | | | | | | | | > Fix the output request size for AudioBufferConverter requests. > > Previously too little data was converted because the code was > incorrectly assuming the FIFO was enabled. > > BUG=364990 > TEST=new unittest > TBR=scherkus > > Review URL: https://codereview.chromium.org/243573005 TBR=dalecurtis@chromium.org Review URL: https://codereview.chromium.org/245523002 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265023 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 262276 "Remove references to WebContentsView::SizeContents..."erikchen@chromium.org2014-04-219-13/+113
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Remove references to WebContentsView::SizeContents from chrome/ and app/ > > WebContentsView::SizeContents was initially introduced as a hack to allow the > content module to resize a WebContentsView. This is odd because the embedder > should be in full control of the layout of the WebContentsView. Unfortunately, > SizeContents started being used as a platform-agnostic way for the embedder to > change the size of a WebContentsView. > > The mac implementation of SizeContents has never been correct. The > implementation would work correctly when SizeContents was used by the embedder, > but it did not work when used by the content module. See > https://code.google.com/p/chromium/issues/detail?id=264207 for details. I > changed the mac implementation of SizeContents to be a no-op, which fixed the > use of SizeContents from the content module, and broke its usage from the > embedder. > > This CL introduces a new platform agnostic utility method to resize a > WebContents. I've replaced all calls to SizeContents from chrome/ and app/ with > a call to the new utility method. There is no expected behavioral change on > aura, gtk, or android. This should fix the problems that have arisen from my > change to the mac implementation of SizeContents. > > Ideally, the utility method would take a gfx::NativeView as its parameter. > Unfortunately, I was unable perform the resizing on a ui::AndroidView*, and I > was forced to pass in the whole WebContents to mimic the behavior of > WebContentsViewAndroid::SizeContents. > > BUG=354769 > TEST=Follow steps listed in bug. > > Review URL: https://codereview.chromium.org/209023003 TBR=erikchen@chromium.org Review URL: https://codereview.chromium.org/244643008 git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@265022 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-07 06:21:12 +0000