| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1921/src@265299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1921/src@261040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/1921/src@261038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=356818
Review URL: https://codereview.chromium.org/214703006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When creating a WebContentDecryptionModule, verify that the key system is a concrete supported key system. This avoids fatal errors later when actually attempting to load the CDM, as only registered key systems will be allowed.
BUG=349181
TEST=Reenabled test succeeds
Review URL: https://codereview.chromium.org/210233004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/217653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clip the textfield background assets to avoid overlap.
This reduces the border appearance differences.
See before/after images at http://crbug.com/358452#c1
TODO: Update the find button assets to match even better.
BUG=358452
TEST=The Views find bar buttons blend with the textfield better.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/219473008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the current precision the following tests:
PromoResourceServiceTest.NotificationPromoCompatNoStringsTest,
PromoResourceServiceTest.NotificationPromoCompatPayloadStringsTest,
PromoResourceServiceTest.NotificationPromoTest
are failing if the time zone is set to Beijing.
Reason for failure: China Standard Time (CST), which is GMT+8,
is interpreted as Central Standard Time (GMT-6).
Increasing precision generates unique string for all time zones.
TEST=Run unit_tests using telemetry on Android devices
BUG=358714
Review URL: https://codereview.chromium.org/221063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
testSyntheticDelayConfiguration. Add sys.stderr.write() for more debugging info.
BUG=358655
Review URL: https://codereview.chromium.org/218583012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this change, TabContentsInformation, which plugs into
WebContentsResourceProvider, replaces TabConentsResourceProvider
( WebContentsResourceProvider is introduced in an earlier patch:
https://codereview.chromium.org/196203003/ )
( Printing is removed from TabContentsResourceProvider in an earlier
patch: https://codereview.chromium.org/201183005/)
BUG=348836
TEST=browser_tests
Review URL: https://codereview.chromium.org/217873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=358453
TEST=git commit a bad json file and do git cl presubmit
R=nednguyen@google.com
Review URL: https://codereview.chromium.org/221553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=358671
Review URL: https://codereview.chromium.org/218403008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1292: Ignore warning 4702 to avoid unreachable code error on VS2013.
r1291: Check in new Windows binaries.
r1290: Add support for Win64 stack unwind data as STACK CFI.
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/214743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Perform a CHECK() when creating a software TextureMailbox since these
come from outside of cc's control.
Do unsigned integer multiplication to produce an unsigned result,
preventing overflow when possible.
R=piman@chromium.org
BUG=348332
Review URL: https://codereview.chromium.org/220093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=rjkroege
Review URL: https://codereview.chromium.org/221123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
frame data.
The HW encoder may send BitstreamBufferReady even before EncodeVideo is called, for
example to send SPS and PPS headers. We should not notify error in this case, but
should drop the encoded data and still add back the output buffer to the encoder.
BUG=354267
TEST=trybot
R=hclam@chromium.org, pwestin@google.com
Review URL: https://codereview.chromium.org/213723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it easier to see in one place how many more dependencies we
need to break between //apps and //chrome.
BUG=none
TEST=checkdeps passes
R=derat@chromium.org, yoz@chromium.org
Review URL: https://codereview.chromium.org/221523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=finnur@chromium.org
TBR=finnur@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/220593009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This rolls in just clang r202555, which is a formatting change -- so this change
doesn't modify the compiler itself.
It does deploy the following things:
1.) On Mac, clang now packages libc++. This will hopefully allow clang to
continue running on OS X 10.6, even when clang is built with a dependency
on a standard library that provides c++11 features. (http://crbug.com/202555)
2.) It picks up r260249 for the plugin, fixing a crash in the plugin
(http://crbug.com/202555) and turning the warning off by default.
3.) It picks up oilplan plugin changes up to r260911.
This also changes the bundle build script to use the bootstrap compiler to
compile libc++ in bootstrap builds, and tweaks the script to keep clang
asan/android buildable with the r9d ndk (http://crbug.com/357890)
BUG=358500,356816,357890
TBR=hans@chromium.org
Review URL: https://codereview.chromium.org/217323005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
mojo/public/interfaces/bindings/tests/.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/219243011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move gtest/gmock BUILD.gn files to main tree.
>
> Also moves the "unused variable warning" to a config in the build directory so
> it can be shared with outher targets without duplication on the command line.
>
> BUG=
> R=cjhopman@chromium.org
>
> Review URL: https://codereview.chromium.org/219433005
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/218493017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bounds to pixel bounds on Windows.
This only matters for high dpi Windows and ensures that certain widgets like select items are displayed correctly.
We already do this in DesktopNativeWidgetAura::SetBounds.
The DesktopWindowTreeHostWin::Init function was using the DIPToScreenRect function in dpi.cc which was rounding the origin
and the size down.
Fix is to mimic the pixel conversion logic from the DesktopNativeWidgetAura::SetBounds function in the DIPToScreenRect function.
BUG=350312
R=sky@chromium.org
Review URL: https://codereview.chromium.org/219603005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves the "unused variable warning" to a config in the build directory so
it can be shared with outher targets without duplication on the command line.
BUG=
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/219433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements a visibility property for determining which targets can depend on a given target.
The property works mostly like Blaze from the internal Google build, but replaces the magic public and private strings with wildcards, and defaults to public visibility.
R=scottmg@chromium.org, scottmg
Review URL: https://codereview.chromium.org/46313003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to make sure we don't expose a permanent IPv6 address which has infinite
valid lifetime.
This code change belongs to Windows specific platform.
R=agl@chromium.org
Review URL: https://codereview.chromium.org/217663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=shess
Review URL: https://codereview.chromium.org/219223011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains lots of new licenses because the licensing script has seen
many improvements to include licenses we were missing up to now.
The most noticeable change is all Xorg packages used to be excluded and
are now listed independently, all pointing to the Xorg license or their own
COPYING file with the relevant MIT copyright assignment bits.
Package removed: chromeos-xkb-1.0.0.0
Package removed: greco-55123433
Package removed: ragel-6.7
Package removed: salsa-0.0.1
Package added: GoogleKeyboardInput-keyboards-1.3.1.2
Package added: GoogleKeyboardInput-xkb-1.0.1.2
Package added: avahi-daemon-0.0.1
Package added: bigreqsproto-1.1.1
Package added: compositeproto-0.4.2
Package added: daisydog-0.0.1
Package added: damageproto-1.2.1
Package added: dri2proto-2.6
Package added: fixesproto-5.0
Package added: fontsproto-2.1.1
Package added: iceauth-1.0.4
Package added: inputproto-2.3
Package added: kbproto-1.0.5
Package added: keyboard-input-1.0.0.0
Package added: libICE-1.0.7
Package added: libSM-1.2.0
Package added: libX11-1.6.0
Package added: libXScrnSaver-1.2.1
Package added: libXau-1.0.6
Package added: libXcomposite-0.4.3
Package added: libXcursor-1.1.14
Package added: libXdamage-1.1.3
Package added: libXdmcp-1.1.0
Package added: libXext-1.3.2
Package added: libXfixes-5.0.1
Package added: libXfont-1.4.4
Package added: libXft-2.2.0
Package added: libXi-1.7.1.901
Package added: libXinerama-1.1.3
Package added: libXmu-1.1.0
Package added: libXrandr-1.4.1
Package added: libXrender-0.9.8
Package added: libXt-1.1.4
Package added: libXtst-1.2.0
Package added: libXxf86vm-1.1.3
Package added: libdrm-2.4.52
Package added: libfontenc-1.1.0
Package added: libpciaccess-0.12.902
Package added: libxkbfile-1.0.7
Package added: mkfontdir-1.0.6
Package added: mmc-utils-0.0.1
Package added: pixman-0.28.2
Package added: randrproto-1.4.0
Package added: recordproto-1.14.1
Package added: renderproto-0.11.1
Package added: resourceproto-1.2.0
Package added: rgb-1.0.4
Package added: scrnsaverproto-1.2.1
Package added: setxkbmap-1.2.0
Package added: swap-init-0.0.1
Package added: trapproto-3.4.3
Package added: util-macros-1.17
Package added: videoproto-2.3.1
Package added: xauth-1.0.6
Package added: xbitmaps-1.1.1
Package added: xcmiscproto-1.2.1
Package added: xextproto-7.2.0
Package added: xf86-input-evdev-2.7.3
Package added: xf86-input-synaptics-1.6.2
Package added: xf86-video-intel-2.99.907
Package added: xf86bigfontproto-1.2.0
Package added: xf86dgaproto-2.1
Package added: xf86driproto-2.1.1
Package added: xf86rushproto-1.1.2
Package added: xf86vidmodeproto-2.3.1
Package added: xineramaproto-1.2.1
Package added: xinit-1.3.0
Package added: xinput-1.6.0
Package added: xkbcomp-1.2.3
Package added: xorg-drivers-1.12
Package added: xorg-server-1.12.4
Package added: xproto-7.0.23
Package added: xrandr-1.3.5
Package added: xrdb-1.0.9
Package added: xset-mini-1.2.2
Package added: xtrans-1.2.6
Package updated: GoogleChineseInput-cangjie from 1.3.0.0 to 2.0.0.0
Package updated: GoogleChineseInput-pinyin from 1.3.0.0 to 2.0.0.0
Package updated: GoogleChineseInput-zhuyin from 1.3.0.0 to 2.0.0.0
Package updated: chromeos-chrome from 35.0.1862.2_rc to 36.0.1918.0_rc
Package updated: chromeos-init from 0.0.6 to 0.0.21
Package updated: dosfstools from 3.0.9 to 3.0.26
Package updated: exfat-utils from 1.0.1 to 1.0.2_pre395
Package updated: freetype from 2.4.12 to 2.5.0.1
Package updated: fuse-exfat from 1.0.1 to 1.0.2_pre395
Package updated: gcc-libs from 4.8.1 to 4.8.2
Package updated: google-breakpad from 1245 to 1292
Package updated: harfbuzz from 0.9.18 to 0.9.27
Package updated: input-tools from 3.1.0.0 to 4.1.0.0
Package updated: libmbim from 0.0.1 to 1.9.0
Package updated: libnl from 3.2.14 to 1.1
Package updated: modemmanager-next from 0.5.999 to 1.3.0
Package updated: nacl-mozc from 1.12.1599.104 to 1.14.1639.104
Package updated: notofonts from 20130514 to 20140130
Package updated: openssh from 5.2_p1 to 6.4_p1
Package updated: pax-utils from 0.4 to 0.8.1
Package updated: pepper-flash from 13.0.0.133 to 13.0.0.182
Package updated: portage-utils from 0.41 to 0.53
Package updated: python-exec from 2.0.1 to 10000.1
Package updated: usbutils from 006 to 007
Package updated: wireless-regdb from 20101124 to 20131127
License removed: Source License flashmap/COPYING
License removed: Source License harfbuzz-0.9.18/src/hb-icu/COPYING
License removed: Source License harfbuzz-0.9.18/src/hb/COPYING
License removed: Source License wireless-regdb-2010.11.24/debian/copyright
License removed: Source License wireless-regdb/LICENSE
License added: Source License M2Crypto-0.21.1/M2Crypto.egg/PKG-INFO
License added: Source License M2Crypto/PKG-INFO
License added: Source License Mesa/docs/license.html
License added: Source License Python/Doc/license.rst
License added: Source License bigreqsproto/COPYING
License added: Source License compositeproto/COPYING
License added: Source License curl/docs/LICENSE-MIXING
License added: Source License damageproto/COPYING
License added: Source License dri2proto/COPYING
License added: Source License fixesproto/COPYING
License added: Source License fontsproto/COPYING
License added: Source License harfbuzz-0.9.27/src/hb/COPYING
License added: Source License harfbuzz-0.9.27/test/shaping/texts/in-tree/shaper-arabic/script-arabic/language/crulp/ligatures/LICENSE
License added: Source License harfbuzz-0.9.27/test/shaping/texts/in-tree/shaper-indic/indic/script/utrrs/LICENSE
License added: Source License iceauth/COPYING
License added: Source License inputproto/COPYING
License added: Source License kbproto/COPYING
License added: Source License libICE/COPYING
License added: Source License libSM/COPYING
License added: Source License libX11/COPYING
License added: Source License libX11/src/xlibi18n/lcUniConv/COPYRIGHT
License added: Source License libXScrnSaver/COPYING
License added: Source License libXau/COPYING
License added: Source License libXcomposite/COPYING
License added: Source License libXcursor/COPYING
License added: Source License libXdamage/COPYING
License added: Source License libXdmcp/COPYING
License added: Source License libXext/COPYING
License added: Source License libXfixes/COPYING
License added: Source License libXfont/COPYING
License added: Source License libXft/COPYING
License added: Source License libXi/COPYING
License added: Source License libXinerama/COPYING
License added: Source License libXmu/COPYING
License added: Source License libXrandr/COPYING
License added: Source License libXrender/COPYING
License added: Source License libXt/COPYING
License added: Source License libXtst/COPYING
License added: Source License libXxf86vm/COPYING
License added: Source License libfontenc/COPYING
License added: Source License libpciaccess/COPYING
License added: Source License libxkbfile/COPYING
License added: Source License llvm/lib/Support/COPYRIGHT.regex
License added: Source License mkfontdir/COPYING
License added: Source License pcre/cmake/COPYING-CMAKE-SCRIPTS
License added: Source License pixman/COPYING
License added: Source License randrproto/COPYING
License added: Source License recordproto/COPYING
License added: Source License renderproto/COPYING
License added: Source License resourceproto/COPYING
License added: Source License rgb/COPYING
License added: Source License scons/PKG-INFO
License added: Source License scrnsaverproto/COPYING
License added: Source License setuptools-0.8/setuptools.egg-info/EGG/PKG-INFO
License added: Source License setuptools-0.8/setuptools.egg/PKG-INFO
License added: Source License setuptools/PKG-INFO
License added: Source License setxkbmap/COPYING
License added: Source License swig/LICENSE-UNIVERSITIES
License added: Source License trapproto/COPYING
License added: Source License util-linux/Documentation/licenses/COPYING.BSD-3
License added: Source License util-linux/Documentation/licenses/COPYING.UCB
License added: Source License util-macros/COPYING
License added: Source License videoproto/COPYING
License added: Source License xauth/COPYING
License added: Source License xbitmaps/COPYING
License added: Source License xcmiscproto/COPYING
License added: Source License xextproto/COPYING
License added: Source License xf86-input-evdev/COPYING
License added: Source License xf86-input-synaptics/COPYING
License added: Source License xf86-video-intel/COPYING
License added: Source License xf86bigfontproto/COPYING
License added: Source License xf86dgaproto/COPYING
License added: Source License xf86driproto/COPYING
License added: Source License xf86rushproto/COPYING
License added: Source License xf86vidmodeproto/COPYING
License added: Source License xineramaproto/COPYING
License added: Source License xinit/COPYING
License added: Source License xinput/COPYING
License added: Source License xkbcomp/COPYING
License added: Source License xorg-server/COPYING
License added: Source License xproto/COPYING
License added: Source License xrandr/COPYING
License added: Source License xrdb/COPYING
License added: Source License xtrans/COPYING
R=vapier@chromium.org, xiyuan@chromium.org
Review URL: https://codereview.chromium.org/215293006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=258676
R=kbr@chromium.org
Review URL: https://codereview.chromium.org/177003009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes an unnecessary file descriptor duplication that takes place. Duplicating real file descriptors is more complicated than doing so for native_client's version of them.
I'm sending this as its own review to make sure its sane before moving much of
the NexeFileDidOpen logic to components/nacl/renderer.
BUG=239656
R=dmichael@chromium.org
Review URL: https://codereview.chromium.org/219053006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have to figure out where the .mojom files should go (since they're
also used by the JS bindings tests), probably somewhere under
public/interfaces/ (but where?).
R=darin@chromium.org
Review URL: https://codereview.chromium.org/218883013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't handle DCHECK failure
* Remove NOTREACHED()/LOG(ERROR) from cases that look like they could
legitimately happen
* All lines of args should begin at the same position
* WebDataService::SetDefaultSearchProvider() doesn't actually need a full
TemplateURL, just an ID
* Use GetCachedStatement correctly, and in more places
* Make KeywordTableTest a friend of KeywordTable to reduce FRIEND_TEST
declarations and in preparation for making Add/Update/RemoveKeyword private
* Data members should be private, not protected
* Function declarations: all args on first line or one arg per line
* Fix misspelling
BUG=none
TEST=none
R=shess@chromium.org
Review URL: https://codereview.chromium.org/217613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/212603005/)
Reason for revert:
Has caused many compile failures. We think the trybots didn't catch it because they didn't build ash_unittests.
Example:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/46547
../../ash/sticky_keys/sticky_keys_unittest.cc: In member function 'virtual void ash::StickyKeysTest_ScrollEventOneshot_Test::TestBody()':
../../ash/sticky_keys/sticky_keys_unittest.cc:622:41:error: 'class ui::DeviceDataManager' has no member named 'set_natural_scroll_enabled'
../../ash/sticky_keys/sticky_keys_unittest.cc: In member function 'virtual void ash::StickyKeysTest_ScrollDirectionChanged_Test::TestBody()':
../../ash/sticky_keys/sticky_keys_unittest.cc:674:41:error: 'class ui::DeviceDataManager' has no member named 'set_natural_scroll_enabled'
../../ash/sticky_keys/sticky_keys_unittest.cc: In member function 'virtual void ash::StickyKeysTest_ScrollEventLocked_Test::TestBody()':
../../ash/sticky_keys/sticky_keys_unittest.cc:711:41:error: 'class ui::DeviceDataManager' has no member named 'set_natural_scroll_enabled'
ninja: build stopped: subcommand failed.
Original issue's description:
> Don't handle NaturalScroll in Chrome but pass it to CMT instead
>
> In order to support mice via CMT (Project Cobra) we will have to do
> the natural scroll handling in the CMT driver instead of Chrome.
>
> BUG=chromium:285663
> TEST=test with touchpads and traditional mice. Everything should work as before,
> touchpad should have natural scroll applied, scroll wheels should not.
> Test changing the natural scroll property and see if it's applied correctly.
> Also test if touch mice have natural scroll applied.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260926
TBR=achuith@chromium.org,sky@chromium.org,sadrul@chromium.org,denniskempin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:285663
Review URL: https://codereview.chromium.org/221363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Media Galleries API Metadata: Image metadata
>
> Enables libexif and uses it to parse some image tags into the GetMetadata call.
>
> BUG=318450
>
> Review URL: https://codereview.chromium.org/191583002
TBR=tommycli@chromium.org
Review URL: https://codereview.chromium.org/217233005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From the logs:
Retrying 1 test (retry #1)
[0401/112720:ERROR:kill_posix.cc(191)] Unable to terminate process group 7136: No such process
[ RUN ] ExtensionToolbarModelTest.HighlightModeRemove
[852/852] ExtensionToolbarModelTest.HighlightModeRemove (2093 ms)
Retrying 1 test (retry #2)
[0401/112723:ERROR:kill_posix.cc(191)] Unable to terminate process group 7140: No such process
[ RUN ] ExtensionToolbarModelTest.HighlightModeRemove
[853/853] ExtensionToolbarModelTest.HighlightModeRemove (2356 ms)
Retrying 1 test (retry #3)
[0401/112725:ERROR:kill_posix.cc(191)] Unable to terminate process group 7146: No such process
[ RUN ] ExtensionToolbarModelTest.HighlightModeRemove
[854/854] ExtensionToolbarModelTest.HighlightModeRemove (2094 ms)
1 test failed:
ExtensionToolbarModelTest.HighlightModeRemove
NOTRY=true
R=rlarocque@chromium.org
TBR=kalman@chromium.org
BUG=358752
Review URL: https://codereview.chromium.org/221193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
performance can be evaluated
r=asvitkine
BUG=358241
Review URL: https://codereview.chromium.org/219363004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/212603015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to support mice via CMT (Project Cobra) we will have to do
the natural scroll handling in the CMT driver instead of Chrome.
BUG=chromium:285663
TEST=test with touchpads and traditional mice. Everything should work as before,
touchpad should have natural scroll applied, scroll wheels should not.
Test changing the natural scroll property and see if it's applied correctly.
Also test if touch mice have natural scroll applied.
Review URL: https://codereview.chromium.org/212603005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=skia:1945
Review URL: https://codereview.chromium.org/216173007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn Error Console on by default for users in Developer Mode, if they are using
Dev/Canary chrome. Turn Error Console on by default for all users of the
Chrome Apps Developer Tools.
BUG=357352
Review URL: https://codereview.chromium.org/215623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 809b76d5243988fa3ad3ad4dfda94d23246b1daf.
BUG=357016
Review URL: https://codereview.chromium.org/219463004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This prevents the performance test from crashing in debug mode.
Review URL: https://codereview.chromium.org/217563004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=358571
R=agl@chromium.org
Review URL: https://codereview.chromium.org/220593005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Enables libexif and uses it to parse some image tags into the GetMetadata call.
BUG=318450
Review URL: https://codereview.chromium.org/191583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Through UMA metrics we have discovered that it can take longer than expected for the invalidation service to become ready after sign in. The strategy of delaying the refresh scheduler to wait for invalidations to be ready is not useful. This change removes the delay and allows the refresh scheduler to fetch immediately on sign in.
BUG=355884
Review URL: https://codereview.chromium.org/210293006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=357848
Review URL: https://codereview.chromium.org/219443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When a page_set is specified in the benchmark, it should be relative to the base paths, but when specified from the command-line, it should be relative to cwd.
BUG=358746, 358695
TBR=nduca
Review URL: https://codereview.chromium.org/219223009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/216523003/)
Reason for revert:
This might have resulted in some flaky tests. This failure happened two builds after the patch landed.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10598
See bug for more details.
BUG=358759
Original issue's description:
> Tighten up webrtc audio tests.
>
> See http://goo.gl/LDae10. I'm trying to improve this algorithm. We used to
> check that some value was high enough and that the average was in the right
> ballpark. The new algorithm will count falling edges in the peaks instead,
> as a means to detect the peaks in the audio signal. The algorithm reliably
> yields one peak per second of sampled audio, which is correct because the
> audio signal beeps at 1 Hz. To get some margin, I'm sampling four seconds
> and checking that I get at least two peaks, which should be a rock solid
> assumption even on slow machines.
>
> BUG=357287,357626
> R=perkj@chromium.org
> NOTRY=True
> (passed all trybots, just got stuck on a broken win trybot)
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260878
TBR=perkj@chromium.org,phoglund@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357287,357626
Review URL: https://codereview.chromium.org/220403006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260913 0039d316-1c4b-4281-b951-d872f2087c98
|