summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add me to some watchlists, added new ones for tab_contents, history, and base.brettw@chromium.org2009-06-291-1/+13
| | | | | | Review URL: http://codereview.chromium.org/150048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19526 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some dead code -- this was moved into client_socket_pool_base.cc.ericroman@google.com2009-06-291-15/+0
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/150050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in a comment.ericroman@google.com2009-06-291-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19524 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux dependency making into osx, windowsgman@google.com2009-06-291-1/+2
| | | | | | Review URL: http://codereview.chromium.org/151036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19521 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension extensions to be case-insensitive.avi@chromium.org2009-06-296-48/+89
| | | | | | | | | BUG=none TEST=try to load an extension with a capital letter or two in the extension's extension. It should load. Review URL: http://codereview.chromium.org/147017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19520 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a stale comment.ericroman@google.com2009-06-291-2/+0
| | | | | | | | | | TBR=willchan BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/150049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19519 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing: DataSource is used before null check in GetLoadTimes.finnur@chromium.org2009-06-291-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19518 0039d316-1c4b-4281-b951-d872f2087c98
* Change to use encodeURIComponent to encode the UTF8 character in the returnedjianli@chromium.org2009-06-294-34/+2
| | | | | | | | | | | | | result. This is to make text-encoding.html work in UI test. Also removed a couple files forgot to remove during last commit. BUG=none TEST=none Review URL: http://codereview.chromium.org/150035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for ui_tests - accidental change went in.dimich@google.com2009-06-291-1/+1
| | | | | | | TBR=jianli Review URL: http://codereview.chromium.org/150043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19515 0039d316-1c4b-4281-b951-d872f2087c98
* Don't shutdown non-popup render views on clicks outside their bounds.estade@chromium.org2009-06-291-1/+5
| | | | | | Review URL: http://codereview.chromium.org/151031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19514 0039d316-1c4b-4281-b951-d872f2087c98
* Add three basic test items to RenderViewHostManagerTest:brettw@chromium.org2009-06-292-2/+134
| | | | | | | | | | | - Init - Navigate - DOMUI Original review: http://codereview.chromium.org/126060 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19513 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --enable-web-workers command-line switch.dimich@google.com2009-06-299-24/+1
| | | | | | | | BUG=4361 TEST=many ui/layout tests. Review URL: http://codereview.chromium.org/149114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where all clicks in app mode windows would result in a window move.tc@google.com2009-06-291-4/+10
| | | | | | | | | | | Also update the comment to properly describe the code. It was referring to the tab strip, but the code was using the toolbar. BUG=15576 Review URL: http://codereview.chromium.org/150037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19511 0039d316-1c4b-4281-b951-d872f2087c98
* Added Repair testcases. Also, currently installer tests are failing on ↵anantha@chromium.org2009-06-295-220/+416
| | | | | | | | official builds because the build location changed on filer. So added logic to handle it. Review URL: http://codereview.chromium.org/141058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19510 0039d316-1c4b-4281-b951-d872f2087c98
* fixes after reviewpiman@google.com2009-06-291-5/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19509 0039d316-1c4b-4281-b951-d872f2087c98
* add XEmbed bindingspiman@google.com2009-06-298-31/+323
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19508 0039d316-1c4b-4281-b951-d872f2087c98
* Bump nixysa rev to get the nspluginwrapper fix (and the signed/unsigned one)piman@google.com2009-06-292-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19507 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Drags from bookmark menus to the bookmark bar.erg@google.com2009-06-296-130/+244
| | | | | | Review URL: http://codereview.chromium.org/147241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19505 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize delegate_.finnur@chromium.org2009-06-291-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19504 0039d316-1c4b-4281-b951-d872f2087c98
* update dnd registry enum to work properly with bitmaskestade@chromium.org2009-06-291-4/+4
| | | | | | | | TBR=erg Review URL: http://codereview.chromium.org/150033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19503 0039d316-1c4b-4281-b951-d872f2087c98
* Support running http layout tests for workers in UI test framework.jianli@chromium.org2009-06-292-36/+113
| | | | | | | | | | | | | | | BUG=none TEST=This is a UI test. Nicolas, could you please review DEPS? I added a couple of new lines to DEPS in order to fetch a copy the following directory into UI test data directory: LayoutTests/http/tests/resources LayoutTests/http/tests/workers LayoutTests/http/tests/xmlhttprequest Review URL: http://codereview.chromium.org/147125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19502 0039d316-1c4b-4281-b951-d872f2087c98
* Removes our homespun grow box and replaces it with therohitrao@chromium.org2009-06-298-101/+38
| | | | | | | | | | | standard widget. This may also fix some of our resizing issues. BUG=http://crbug.com/14663 TEST=The resizer widget should still work as expected. Review URL: http://codereview.chromium.org/149094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19501 0039d316-1c4b-4281-b951-d872f2087c98
* Use C99 standard format macros for 64-bit values.agl@chromium.org2009-06-296-9/+71
| | | | | | | | | | | | | | | | | | | Currently we have several uses of %I64d in format strings to indicate a 64-bit value. This does not work on Mac or Linux, where 'I' indicates the use of locale specific digits. Instead, we introduce base/format_macros.h which mimic the C99 standard macros for 64-bit values in a cross-platform manner. Dean pointed out that V8 is handling this themselves rather than use inttypes.h. Maybe we'll end up going down the same path but, for the moment, we'll try and do it the 'correct' way and see how it works out. http://codereview.chromium.org/147154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19500 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member view_ to NULL in constructor.finnur@chromium.org2009-06-291-1/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19499 0039d316-1c4b-4281-b951-d872f2087c98
* Widen /lib/ld.so suppression to match on 64 bit systems.dkegel@google.com2009-06-291-8/+6
| | | | | | | | | BUG=none TEST="make -r base_unittests; sh tools/valgrind/chrome-tests.sh -t base_unittests" on 64 bit ubuntu and verify no valgrind warnings from ld-*.so Review URL: http://codereview.chromium.org/147254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19497 0039d316-1c4b-4281-b951-d872f2087c98
* Two fixes for tab dragging in gtk:jhawkins@chromium.org2009-06-292-2/+10
| | | | | | | | | | | * Check that backing_store_ is non-NULL before using it. A drag can be initiated before the backing store has been created. * Don't read a size greater than the size of the backing store image. BUG=15387 TEST=Hard to reproduce. Quickly initiate a tab drag after opening a new tab. Review URL: http://codereview.chromium.org/150008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19496 0039d316-1c4b-4281-b951-d872f2087c98
* GTK DND:estade@chromium.org2009-06-2910-79/+148
| | | | | | | | | | | | | | - Rearrange DND constants, create convenience functions - (partially) implement drag onto home button Note that the homepage is still hard-wired to the dev build splash page, so that it seems like this isn't working, but via debugging I ascertained that dragging a random file from the desktop onto the home button should successfully set that file as the homepage. TEST=drag a lot of stuff all over the place (tabs, bookmarks, what have you), make sure nothing crashes BUG=none Review URL: http://codereview.chromium.org/147256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19495 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Catch up with WebKit icon update.pfeldman@chromium.org2009-06-291-0/+1
| | | | | | Review URL: http://codereview.chromium.org/151027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19494 0039d316-1c4b-4281-b951-d872f2087c98
* Let RenderProcessHost provide a method HasConnection() instead of exposingbrettw@chromium.org2009-06-2912-17/+41
| | | | | | | | | | | | | | | | | | | | | | | | channel(). Motivation: Currently, components that are using RenderProcessHost are checking its liveness by null testing on channel(). I'd like to write unittests for those components, but to mock out RenderProcessHost instances, I have to also mock out the instance returned by RenderProcessHost::channel(), but there's no interface class prepared. SyncChannel is directly used in RenderProcessHost. Instead of dependency injection, I can let mock objects return invalid pointer such as 0x1, but its bad test design. Rather than that, I'd like to introduce HasConnection() method and override it to return true. In fact, most of those components are not accessing channel()'s methods directry. They're just checking channel() is null or not, and to issue IPCs, they are calling Send method. So, it's OK to hide channel pointer from users, I think. Original review: http://codereview.chromium.org/147077 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19493 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up the create browser window.sky@chromium.org2009-06-293-4/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19492 0039d316-1c4b-4281-b951-d872f2087c98
* Create a more fine grained histogram of SDCH payload sizesjar@chromium.org2009-06-292-2/+18
| | | | | | | r=mbelshe Review URL: http://codereview.chromium.org/149119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19491 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19489,19488.japhet@chromium.org2009-06-2920-107/+4420
| | | | | | Review URL: http://codereview.chromium.org/150024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19490 0039d316-1c4b-4281-b951-d872f2087c98
* Somehow missed a file in the original patch. Doh.japhet@chromium.org2009-06-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19489 0039d316-1c4b-4281-b951-d872f2087c98
* Use upstream V8Proxy and V8Utilitiesjaphet@chromium.org2009-06-2919-4419/+106
| | | | | | | | | BUG=15459 TEST=none Review URL: http://codereview.chromium.org/149086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19488 0039d316-1c4b-4281-b951-d872f2087c98
* Replace DeleteSoon with PostTask(DeleteTask) in browser_window_gtk for ↵pfeldman@chromium.org2009-06-291-1/+5
| | | | | | | | | | | | browser to be closed while in ui tests. DevToolsSanityTests are running various scenarios including the ones that are waiting for browser to be closed. Tests are closing all the tabs in the browser and are running nested message loop until the BROWSER_CLOSE message arrives. The browser close logic on Linux was using DeleteSoon on the window object, but DeleteSoon was never executed since the task was non-nestable. This change simply posts DeleteTask instead of DeleteSoon and hence browser close logic is working fine on a nested loop. Review URL: http://codereview.chromium.org/151020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove passing test from expected failures.ager@chromium.org2009-06-291-1/+0
| | | | | | | | BUG=15052 TEST=LayoutTests/transitions/repeated-firing-background-color.html Review URL: http://codereview.chromium.org/150019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19486 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SSL icon padding in Location Bar in Gtk.ukai@chromium.org2009-06-292-32/+59
| | | | | | | | | | | | | | | | | | When no ssl icon/ev text shown show 4px|location_entry|4px only When ssl icon/no ev text show 4px|location_entry|4px + 2px|ssl_icon|8px When ssl icon and ev text shown show 4px|location_entry|4px + 2px|ssl_icon|8px + |ev_text|4px BUG=none TEST=none Review URL: http://codereview.chromium.org/151017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19485 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: show all scopes for current call frame in the scopes pane.yurys@google.com2009-06-292-28/+108
| | | | | | | BUG=13674 Review URL: http://codereview.chromium.org/132069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19484 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.2.10.ager@chromium.org2009-06-291-1/+1
| | | | | | | | | | | This version contains a message reporting bugfix, improved debugger support and general optimizations. BUG=none TEST=none Review URL: http://codereview.chromium.org/150020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19483 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 13432.hbono@chromium.org2009-06-292-1/+6
| | | | | | | | | | | This is caused by my bonehead mistake that I forgot filtering out U_STRING_NOT_TERMINATED_WARNING while checking the return value in SpellCheckWordIterator::Normalize() in my change r10087. I have added code that checks if the result value is U_STRING_NOT_TERMINATED_WARNING and added a couple of test cases which verify this issue. BUG=13432 "Any word of 13 or 14 characters is not spellcheck" TEST=run unit_test.exe. Review URL: http://codereview.chromium.org/146074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19482 0039d316-1c4b-4281-b951-d872f2087c98
* Move render_view_host_manager* and site_instance* from tab_contents to ↵brettw@chromium.org2009-06-2921-33/+33
| | | | | | | | renderer_host. Review URL: http://codereview.chromium.org/150011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19481 0039d316-1c4b-4281-b951-d872f2087c98
* Another go at switching mini_installer to gyp.bradnelson@google.com2009-06-292-4/+1
| | | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/150012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19480 0039d316-1c4b-4281-b951-d872f2087c98
* Added stub native web worker support, including build support in preparationsehr@google.com2009-06-2912-6/+356
| | | | | | | for integrating the native client build. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19479 0039d316-1c4b-4281-b951-d872f2087c98
* Add 15547 to known crash.huanr@chromium.org2009-06-281-0/+3
| | | | | | Review URL: http://codereview.chromium.org/151008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19478 0039d316-1c4b-4281-b951-d872f2087c98
* Switching gyp off for mini_installer.bradnelson@chromium.org2009-06-281-1/+2
| | | | | | | | | | | | | | There still seem to be some issues. (Odd it worked locally...) BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/151007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19477 0039d316-1c4b-4281-b951-d872f2087c98
* Switching mini_installer to be gyp generated.bradnelson@chromium.org2009-06-281-1/+2
| | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/151005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19476 0039d316-1c4b-4281-b951-d872f2087c98
* linux: cleanup browser-side GtkSockets when plugins are destroyedevan@chromium.org2009-06-288-10/+41
| | | | | | | | | | | | WillDestroyWindow is already plumbed over to the browser process in the multiproc case; we want to plumb it to our RenderView delegate so we can do similar cleanup in test_shell. BUG=15423 Review URL: http://codereview.chromium.org/147251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19475 0039d316-1c4b-4281-b951-d872f2087c98
* Tests for socks4/4a implementation.arindam@chromium.org2009-06-286-150/+439
| | | | | | | | | | | Refactoring of void BuildHandshakeWriteBuffer() to const std::string BuildHandshakeWriteBuffer() const,and removing private members handshake_buf_len_ and buffer_len_ (since buffer_ is now std::string, buffer_.size()) is more than sufficient for buffer size. TEST=unittests BUG=469 Review URL: http://codereview.chromium.org/139009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19474 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting change 19472.bradnelson@chromium.org2009-06-283-175/+146
| | | | | | | | | | | | Broke the tree.... :-( BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/150009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19473 0039d316-1c4b-4281-b951-d872f2087c98
* Switching over mini_installer to gyp.bradnelson@chromium.org2009-06-283-146/+175
| | | | | | | | | | | | | | Ended up moving it to a separate gyp file so that msvs_use_common_release gets applied at the right time (has to be before the include gets evaluated). BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19472 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 18:44:21 +0000