| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2865030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
radius of the close button hover state circle a bit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2833050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome:
--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.
--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.
--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.
BUG=35198
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51231
Review URL: http://codereview.chromium.org/2802018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Wrap the model in a GtkTreeSortable. This corrects editing of
content exception entries in the presence of sorted columns.
- Also adds unit tests for this window.
BUG=47841
TEST=ContentExceptionsWindowGtkUnittest.* + see bug
Review URL: http://codereview.chromium.org/2876032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48030
TEST=none
Review URL: http://codereview.chromium.org/2859038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use them from views and gfx.
Sorry for the new patch on this and not an update. Not sure what happened.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2809047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in inserting into the wrong parent.
BUG=40544
TEST=see bug
Review URL: http://codereview.chromium.org/2856027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Recommit of r51371, this time not crashy.
BUG=http://crbug.com/47980
TEST=unit tested
Review URL: http://codereview.chromium.org/2817048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Addresses wtc's comments in http://codereview.chromium.org/2834030/show)
http://codereview.chromium.org/2827042/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Methods stubbed out for now, and not used anywhere yet.
BUG=45547
TEST=none
Review URL: http://codereview.chromium.org/2847041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=--bookmark-menu no longer does anything
Review URL: http://codereview.chromium.org/2853024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable chromoting host process if chrome is started with
--type=service --enable-chromoting
BUG=none
TEST=chrome --type=service --enable-chromoting
Review URL: http://codereview.chromium.org/2813038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically,
geolocation_exceptions_window_controller => simple_content_exceptions_window_controller (mac)
geolocation_exceptions_view => simple_content_exceptions_view (win)
geolocation_content_exceptions_window => simple_content_exceptions_window (linux)
It's now easy to use it to show desktop notification exceptions as well.
No functionality change.
BUG=45547
TEST=geolocation exceptions dialog still works
Review URL: http://codereview.chromium.org/2835031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46408
TEST=See bug description.
Review URL: http://codereview.chromium.org/2882007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ran tests for a few hours on windows without seeing a failure.
BUG=44026
TEST=BrowserAppRefocusTest.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51362
Review URL: http://codereview.chromium.org/2870036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This means, if you press enter, it'll work the same as if you clicked OK.
BUG=47752
TEST=Set up sync -> enter username/pw, press enter on choose datatypes screen, it should start syncing and eventually get to "success".
Review URL: http://codereview.chromium.org/2876017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2850038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the HttpNetworkTransaction correctly handles asynchronous auth token
generation, HttpAuthHandlerNegotiate can be turned into a state machine. This
also removes the need for the externally exposed "Resolve Canonical Name"
details to users of this handler.
BUG=42222
TEST=net_unittests
Review URL: http://codereview.chromium.org/2867022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
A simple implementation of compressor using zlib.
Review URL: http://codereview.chromium.org/2841032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that SSLSocketAdapter::OnReadEvent() was calling AsyncSocketAdapter::OnReadEvent() only when there are no pending read requests, so the reader wasn't always receiving notification when new data is received on the socket, especially when data received is bigger than the pending read request.
BUG=none
TEST=xmpp connection succeeds 100% of the time, particularly on mac.
Review URL: http://codereview.chromium.org/2834024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Version 18 means use the Favicons file (if the TopSites flag is on).
This avoids the check for a Thumbnails DB file on startup.
BUG=None
TEST=ThumbnailDatabaseTest, HistoryBackendTest
Review URL: http://codereview.chromium.org/2884013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/2842039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/2812037
TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/2878019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/2847040
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/2858041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change introduced a lot of brokeness.
TBR=yurys@chromium.org
TEST=workers, etc. (The bots turned red with this roll.)
BUG=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/2847040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/2812037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
failing after WebKit roll
TBR=levin
Review URL: http://codereview.chromium.org/2806047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=48073
TEST=none
Review URL: http://codereview.chromium.org/2845032
TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/2854034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=48073
TEST=none
Review URL: http://codereview.chromium.org/2845032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/47980
TEST=unit tested
Review URL: http://codereview.chromium.org/2859036
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/2883014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
main menu is using the bookmark menu, but still worth trying to
fix. We run a nested message loop when showing a menu. When a click
occurs outside the menu gtk closes the menu and we exit the nested
message loop. The problem is that click is dispatched from the nested
message loop, meaning it's possible to attempt to spawn another menu
or do other things from the nested message loop. To fix it I'm
manually closing the popup and not dispatching the event.
BUG=40492
TEST=see bug, but in general make sure chrome specific menus (time,
network ...) continue to work.
Review URL: http://codereview.chromium.org/2861037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/47980
TEST=unit tested
Review URL: http://codereview.chromium.org/2859036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
derive from it.
No functionality change.
This will be used to share the content settings exceptions dialog code between geolocation and notifications.
BUG=45547
Review URL: http://codereview.chromium.org/2838037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/4321
TEST=Go though OOBE process. When update has initiated and failed update screen proceeds.
Review URL: http://codereview.chromium.org/2836039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DevToolsManager::GetInstance
BUG=47806
Review URL: http://codereview.chromium.org/2878010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the download shelf and other places. Delete the original pdfs. This is in line with the new top chrome refresh.
BUG=44574
TEST=none
Review URL: http://codereview.chromium.org/2805055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
destructor. This isn't really needed now that we've disabled phantom
tabs, but I'm doing in case we end up reenabling phantom tabs.
BUG=45541
TEST=covered by unit test.
Review URL: http://codereview.chromium.org/2800037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ran tests for a few hours on windows without seeing a failure.
BUG=44026
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/2870036
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/2865031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/2805059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
possible when making calls across threads.
TEST=build remoting
BUG=none
Review URL: http://codereview.chromium.org/2805025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Ran tests for a few hours on windows without seeing a failure.
BUG=44026
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/2870036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Before this change New User sometime blinck after successful login.
Review URL: http://codereview.chromium.org/2878018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2838018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/3280
TEST=See login with on Chrome OS.
Review URL: http://codereview.chromium.org/2848033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin@chromium.org
Review URL: http://codereview.chromium.org/2812036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If SocketStream is deleted while ResolvProxy is running, proxy service
might access SocketStream's member fields, such as proxy_info_, after
SocketStream is deleted, so it would cause crash like
http://crash/reportdetail?reportid=40166b9529ce6b74
In SocketStream destructor, it will set context to NULL, so it will
cancel proxy request if pac_request_ is not NULL.
BUG=46750
TEST=none
Review URL: http://codereview.chromium.org/2852034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51351 0039d316-1c4b-4281-b951-d872f2087c98
|