| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This is mainly intended to be pulled to the 3.0 branch. It won't be submitted until another corresponding change to
undo the damage is ready.
BUG=13467
TEST=Added unit tests
Review URL: http://codereview.chromium.org/132003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11441
TEST=Try the non-standard browser keys on a keyboard that has them. I.e. the back and forward button on a Thinkpad.
Review URL: http://codereview.chromium.org/140081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
Review URL: http://codereview.chromium.org/144004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The following tests needs to be rebaselined:
The following tests are marked as pass:
Review URL: http://codereview.chromium.org/141057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14786
TEST=set bookmark bar to show by default. open a new browser window. There should be no weird vertical scrolling at the bottom of the page.
Review URL: http://codereview.chromium.org/145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser window. This fixes a visual bug where the border looked
disconnected with the background. This matches what Windows does.
BUG=14884
Review URL: http://codereview.chromium.org/140078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be so that resize animations are not janktastic. TabOverviewContainer
only draws in the parts that are actually used so that it appears as
though the window is smaller than it is. This was needed as
moving/resizing bounds is way too expensive.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/132059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since the "remove" item always causes selection to change, we don't have to worry about trying to call remove twice with the same context menu.
TEST=see bug. Also, no new crashes on linux.
BUG=14443
Review URL: http://codereview.chromium.org/132048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[re-retry, seeing if reliability bots like it]
* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer). For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.
This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket. The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.
* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time. So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.
Review URL: http://codereview.chromium.org/113157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
_NET_CLIENT_LIST_STACKING.
BUG=14004
TEST=Drag tabs in and out of tabstrip in xmonad window manager.
Review URL: http://codereview.chromium.org/141061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
generated upstream.
BUG=13809
TEST=none
Review URL: http://codereview.chromium.org/139001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Ben nor I can get this one.
BUG=13500
TEST=none
Review URL: http://codereview.chromium.org/140009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=14889 (http://crbug.com/14889)
Review URL: http://codereview.chromium.org/140079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14753
Review URL: http://codereview.chromium.org/140039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
These cover a special case of encoding and decoding ASN.1
integers.
Review URL: http://codereview.chromium.org/140077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14770
TEST=See bug.
Review URL: http://codereview.chromium.org/140011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=paul
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/141055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Vodaphone (UK) Mobile Broadband appears to be providing an extra level
of gzip compression, at the same time as it discards the content encoding
"sdch,gzip" and replaces it with "gzip."
The previous approach for handling a missing "sdch" content encoding
statement from a server that *probably* was trying to send encoded
content, was to replace the (probably) garbage content encoding with
tentative decodings for both gzip and sdch. That approach was not
sufficient for the resulting double-gzip encoding that Vodaphone
provided :-(.
This fix leaves the existing content encodings (such as Vodaphone's
solo "gzip"), and adds the tentative decodings (gzip plus sdch).
Hence we translate received content encodings (when we know we requested
an SDCH response by including an applicable dictionary) as follows:
"sdch,gzip" unchanged. This is perfect.
"" ==> "Tent_sdch, Tent_gzip"
"gzip" ==> "Tent_sdch, Test_gzip, gzip"
Note that the TENTATIVE_gzip is a sniffing gzip, that can turn into an
identity (no-op) filter if it can't find a gzip header.
By continuing to use a tentative SDCH, it is possible for the SDCH
filter to make error recovery decision, and to record stats
on this case.
In addition, I've changed the error recovery approach in the SDCH
filter to be ultra conservative. If there is ANY unrecoverable
error in a response to an SDCH request, then we will blacklist
the host of the URL. Recoverable errors are where the SDCH is fully
functional, and decodes its data using the dictionary.
The test cases added focus on the double gzip cases, as observed in
Vodaphone (UK) Mobile Broadband.
BUG=13606
r=huanr
Review URL: http://codereview.chromium.org/140037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
"wait" state for the correct period of time.
BUG=none
TEST=none, code not yet enabled
Review URL: http://codereview.chromium.org/141051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=wtc
Review URL: http://codereview.chromium.org/141054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11512
Review URL: http://codereview.chromium.org/140076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=b/1483703
Review URL: http://codereview.chromium.org/132046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
conversion to std::string correctly for all platforms.
BUG=14641
TEST=LoginDatabase unit tests should build and run on Windows
Review URL: http://codereview.chromium.org/139005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also switched from 3px borders to 4px borders because that's what they are
on windows. On linux, the borders look bigger because our webcontent area
doesn't drop a shadow.
For this to work for resizing on top, I had to remove the event box from
the browser titlebar and move the mouse event handling to the window.
BUG=14645
Review URL: http://codereview.chromium.org/140026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidates the WasHidden/DidBecomeSelected logic into a single method.
This change is needed to make the hung renderer dialog disappear when
switching tabs.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/141048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
default new tab page.
BUG=9966
TEST=Make "about:blank" your home page. Open a new tab. It should be showing about:blank and the location bar should be focused.
Review URL: http://codereview.chromium.org/141028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is step1 into removing the boost + tr1 dependency in windows. It also includes a hack to avoid brining in tr1/functional on gcc, which will move us closer to enabling -fno-rtti.
This CL has passed the try servers. I've also tried compiling gmock, gmock_main, base, base_unittests, and webcore modules in vs2008 express editions.
Review URL: http://codereview.chromium.org/140003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TemplateURL
(when creating with one, the entry changed signal would do it.)
BUG=13326
Review URL: http://codereview.chromium.org/141025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/141016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It will be shared by both test_shell and the browser.
I've also renamed it GtkPluginContainer to be more explicit about what
it's for.
TEST=windowed plugins continue to work in test_shell
Review URL: http://codereview.chromium.org/141033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
gtk/list_store_favicon_loader,
so that it can be used by the url_picker_dialog_gtk as well.
BUG=11507
Review URL: http://codereview.chromium.org/141035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/125239
BUG=7863
TEST=See bug
TBR=ben
Review URL: http://codereview.chromium.org/142001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=some layout tests might start passing
Review URL: http://codereview.chromium.org/131092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
relevant places.
BUG=13326
Review URL: http://codereview.chromium.org/141026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also clean up the code a bit.
BUG=12206
TEST=Start VNC4 with -depth 24, make sure Chromium displays red and blue coorectly on webpages.
Review URL: http://codereview.chromium.org/126256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches the Windows implementation more closely.
As on Windows, positioning is controlled by the WebView
delegate's DidMove() implementation. I also synced the
comments with the original file so it'll be easier to
unfork.
TEST=windowed plugins are still positioned properly in test_shell
Review URL: http://codereview.chromium.org/141034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generate html to compare the old and new baselines
at the end of rebaselining tool to make it easier
to verify the new baselines before checking them in.
BUG=none
TEST=rebaseling tool
Review URL: http://codereview.chromium.org/123028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/131003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were dropping the most significant byte from the input when
decoding PrivateKeyInfo, whether or not it was part of the
original data. This shouldn't matter, except that we need to
get back the original byte lengths so that we can give them to
CryptoAPI.
BUG=14877
TEST=Stress tested the functions by creating 1000 random private keys, exporting them, then re-importing. Also tried stressing the edge cases in particular around extra trailing null bytes.
Review URL: http://codereview.chromium.org/141036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14707
TEST=Tooltips shouldn't cause the main window to appear over the about panel. Alll other tooltip behavior should remain the same.
Review URL: http://codereview.chromium.org/140067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/140072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/140030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This looks like it might be to blame for reliability test failures,
so I'm trying it out.
This reverts commit r18888.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed by: jcampan@chromium.org
Changed at: Fri 19 Jun 2009 21:22:47
Branch: src
Revision: 18889
Comments:
Relanding focus manager refactoring with build fix, see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben
Review URL: http://codereview.chromium.org/141013
Because it creates hundreds of new reliability crashes.
TBR:jcampan
Review URL: http://codereview.chromium.org/140064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18904 0039d316-1c4b-4281-b951-d872f2087c98
|