| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This fixes, at least, LayoutTests/css1/box_properties/acid_test.html
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract some UI SSL test code into new class SSLTestUtil to avoid duplication.
Point nss at root certs so test_shell can talk to mail.google.com without warnings.
Support ciphers needed to talk to testserver.py.
Load temporary testing cert needed to run unit tests.
Implement part of GetSSLInfo.
Change URL in developer error message to point to chromium.org.
Re-enable url_request_unittest.cc, which seems to have been disabled by mistake.
Later changesets will implement x509 certificates for nss,
finish GetSSLInfo support, and update chrome/browser/ssl_uitest.cc to use SSLTestUtil.
Earlier version was committed as r6063, but was rolled back.
Review URL: http://codereview.chromium.org/11249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Add support for "Debug On Start" switch to MultiprocessTest::SpawnChild
Review URL: http://codereview.chromium.org/13052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
another.
Also moves crash_cache project to the "tools folder" on the solution.
Review URL: http://codereview.chromium.org/12851
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
If the title or URL changes, we'll be updated in other ways, so this extra processing is wasted.
Review URL: http://codereview.chromium.org/12859
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes a layout test.
BUG=http://crbug.com/2980
Review URL: http://codereview.chromium.org/13038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a connection fails without EINPROGRESS then we don't close the socket
right away, but wait until the destructor calls Disconnect(). However,
Disconnect assumes that we managed to setup the libevent handle, which
is that case we didn't, and crashes on an assert.
Review URL: http://codereview.chromium.org/12648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
are going to break again.
TBR:jeremy
Review URL: http://codereview.chromium.org/13053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the Mac, so we'll implement it for everyone.
Review URL: http://codereview.chromium.org/12869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it on a clean and clobbered tree, it caused all the
failures
Review URL: http://codereview.chromium.org/12870
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
it's still breaking the tests
Review URL: http://codereview.chromium.org/12868
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12867
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This will require a second pass after a few buildbot runs.
Review URL: http://codereview.chromium.org/13049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If a Node exists explicitly in a repository directory but not in the
local working directory, SCons would throw an exception when globbing
the entry when it tried to extract the non-existent same-named entry
from the local working directory's entries dictionary. Since we know
we want to return local entry anyway, make sure it exists.
Review URL: http://codereview.chromium.org/13044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
instances.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Configurable CHROME_BUILD_TYPE command line or external environment
variable for selecting appropriate release_impl*.scons settings
(_checksenabled, _coverage, _dom_stats, _official, _purify).
* Configurable CHROMIUM_BUILD command line or external environment
variable for selecting appropriate chromium_build*.scons settings
(_google_chrome).
* Configurable /INCREMENTAL linking via command line or external
environment variable ($INCREMENTAL), through appropriate setting
of an internal $CHROMIUM_INCREMENTAL_FLAGS construction variable.
* Full link of release builds by default.
* Alphabetize *.scons files in the mac_env.FilterOut() list.
* Explicitly set _checksenabled.scons link flags.
Review URL: http://codereview.chromium.org/13039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12860
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Change scheme from a (const char*) to a (std::string). This is in response to an earlier comment.
Background:
It used to be a (const char*) to avoid allocating a string object since all the callers initialize it with a string literal.
- Change the initial value of nonce_count_ from 1 to 0. This doesn't functionally change anything (we just change to a pre-increment rather than post-increment), but I prefer the the start-at-zero style.
Review URL: http://codereview.chromium.org/12846
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also address a TODO about stripping references from proxy resolve requests.
Review URL: http://codereview.chromium.org/13029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
my null build to go from 45s to 30s.
Review URL: http://codereview.chromium.org/12828
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
on the distributed tests.
TBR
Review URL: http://codereview.chromium.org/13042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR:ojan
Review URL: http://codereview.chromium.org/13041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to check if this change (6181) was the cause. I'm
reverting.
TBR:jeremy
Review URL: http://codereview.chromium.org/12856
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
approximatively at this revision. I'm reverting to make
sure.
tbr: wtc
Review URL: http://codereview.chromium.org/12855
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/4620
Review URL: http://codereview.chromium.org/12847
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=huanr,kmixter,openvcdiff
Review URL: http://codereview.chromium.org/12699
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
svn merge's diff3-cmd. Eventually, others can use this for other
diff3 tools as well, they'll just need to add the right tweaks
to support other tools.
Review URL: http://codereview.chromium.org/11520
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you have a OneShotTimer pending, and you destroy your
message loop, the cleanup of the timer will use memory
which was already freed by the MessageLoop. When the
MessageLoop shuts down, it deletes pending tasks.
BaseTimer did not provide a virtual destructor to cleanup
its "base". Thus, when the actual OneShotTimer cleaned
up, it would use deleted memory.
This manifested for me when I had accidentally had cleanup
of a oneshottimer occurring through the Singleton, which
occurs AtExit, after the messageloop is already gone.
Created a unit test for this, which does trip the assert due
to heap corruption.
Review URL: http://codereview.chromium.org/13023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
release builds.
R=eroman
BUG=4749
Review URL: http://codereview.chromium.org/12465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch by Mohamed Mansour, r=ben. See http://codereview.chromium.org/12816/ .
BUG=1062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Stub out ipc_channel_posix.cc to allow other code that depends on it to be compiled.
* Cleanup some ipc code a bit to compile on gcc.
* Remove unused IPC::Channel::ProcessPendingMessages()
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The 10 new differed by the usual text/form control differences.
The two changed were:
* LayoutTests/fast/forms/placeholder-set-attribute.html
Baseline changed a while ago (lighter placeholder text color)
* LayoutTests/fast/forms/select-initial-position.html
Currently looks fine (didn't check for historical difference)
Review URL: http://codereview.chromium.org/12837
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Set, but of course I need to close the handle before the CreateFile call... doh!
Review URL: http://codereview.chromium.org/13027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the user specifies a filename without an extension, such as "foo" instead of "foo.gif", we would append "gif" to the filename instead of ".gif" (so the user ends up with a file named "foogif").
I'm not confident this is the only thing wrong with this function. For example if the user specifies "foo." and the filter says "*.gif" shouldn't we add ".gif" to the filename instead of deleting the dot?
Also, we seem to be ignoring the default_extension parameter passed in when we figure out what extension to tack on and instead get the file extension from GetFileExtensionFromPath... :s
Review URL: http://codereview.chromium.org/12838
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/12841
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6173 0039d316-1c4b-4281-b951-d872f2087c98
|