| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pre-existing Chrome process and run tests on it. This is an addition to the low level interface underlying testing frameworks like PyAuto and WebDriver.
Normally, test frameworks communicate with Chrome over an unnamed socket pair on POSIX. The test creates the socket pair and then launches the browser as a child process, passing an open file descriptor for one end of the socket to the browser. This change adds a command line switch that, when passed to the browser, causes it to listen on a named socket instead, eliminating this parent/child process requirement. Therefore, you can potentially connect any number of tests to a preexisting browser process.
For ChromeOS, this allows you to run tests on the instance of Chrome that is launched on startup, which controls things like the login and lock screens, the battery meter, the wireless UI, etc. Currently there is no way to run tests on a pre-existing Chrome instance. Eventually this will also allow you to connect both PyAuto and WebDriver to the same Chrome instance and run both in the same test.
If you pass the browser the following command line switch:
./chrome --testing-channel=NamedTestingInterface:/path/to/file
This causes the browser to listen for incoming connections. An AutomationProxy can connect to the browser by connecting a Unix domain socket to the specified path and control the browser over the socket.
This is currently only for POSIX. Windows support will come in a future change. Also, this initial change only allows one connection; multiple connection support will come in a future change.
BUG=chromium-os:8512
TEST=Run Chrome with --testing-interface=/var/tmp/NamedTestingInterface, then run NamedInterfaceTest.BasicNamedInterface under ui_tests.
Review URL: http://codereview.chromium.org/4202004
TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/5177007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=63415
TEST=Install and App.
Go to the NTP
Right clicking on the app in expanded/small/minimized mode
This should bring up a context menu in all cases.
Review URL: http://codereview.chromium.org/5234005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
least on win and cros. TBR=mnaganov@chromium.org
BUG=54592
TEST=none
Review URL: http://codereview.chromium.org/5138009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=bring up the print dialog and then cancel does not crash the renderer in debug mode.
Review URL: http://codereview.chromium.org/5231002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63440
TEST=browser_tests --gtest_filter=FormManagerTest.*
Review URL: http://codereview.chromium.org/5137004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
So it can be shared by all platforms.
BUG=35020
TEST=trybots
Review URL: http://codereview.chromium.org/4981001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of URLRequest::Read().
Also made some stylistic changes to DCHECKS.
Review URL: http://codereview.chromium.org/5070002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63365
TEST=manual
Review URL: http://codereview.chromium.org/5207003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Required to debug some buildbot failures that do not repro locally.
BUG=63823
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/5105007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
got. This string will eventually go away, which is why I'm not moving
it into the grd or anything.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5142005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5232004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome process and run tests on it. This is an addition to the low level interface underlying testing frameworks like PyAuto and WebDriver.
Normally, test frameworks communicate with Chrome over an unnamed socket pair on POSIX. The test creates the socket pair and then launches the browser as a child process, passing an open file descriptor for one end of the socket to the browser. This change adds a command line switch that, when passed to the browser, causes it to listen on a named socket instead, eliminating this parent/child process requirement. Therefore, you can potentially connect any number of tests to a preexisting browser process.
For ChromeOS, this allows you to run tests on the instance of Chrome that is launched on startup, which controls things like the login and lock screens, the battery meter, the wireless UI, etc. Currently there is no way to run tests on a pre-existing Chrome instance. Eventually this will also allow you to connect both PyAuto and WebDriver to the same Chrome instance and run both in the same test.
If you pass the browser the following command line switch:
./chrome --testing-channel=NamedTestingInterface:/path/to/file
This causes the browser to listen for incoming connections. An AutomationProxy can connect to the browser by connecting a Unix domain socket to the specified path and control the browser over the socket.
This is currently only for POSIX. Windows support will come in a future change. Also, this initial change only allows one connection; multiple connection support will come in a future change.
BUG=chromium-os:8512
TEST=Run Chrome with --testing-interface=/var/tmp/NamedTestingInterface, then run NamedInterfaceTest.BasicNamedInterface under ui_tests.
Review URL: http://codereview.chromium.org/4202004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recorder
plugin is installed on the machine. This plugin intercepts LoadLibrary calls issued by
chrome.dll and wraps NPAPI calls provided the actual plugin dll, in this case media player.
This is to provide the Download this video functionality.
Crash occurs probably due to an interacton with Real player and media player. Fix is to
load the plugin dynamically via the exported kernel32 function LoadLibrary instead of invoking
it via the LoadLibrary import from chrome.dll. This would bypass the recorder plugin.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=63552
Bug=63552
Test=Install real player and media player on the machine and navigate to the url mentioned
in the bug. It should not crash
Review URL: http://codereview.chromium.org/5190005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bug has been introduced in r65418.
In r65418 I replaced some DownloadItem::full_path() with DownloadItem::GetUserVerifiedFileName() for loading icons, but on Windows it needed to be a full-path (rather than a file name).
BUG=62495
TEST=download mini_installer.exe and see if the correct icon is shown in the downloadshelf after the download is finished.
TEST=download regular files and see if the correct icon is shown (from the beginning).
Review URL: http://codereview.chromium.org/5147006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Bug=63779
Review URL: http://codereview.chromium.org/5224003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9438
TESt=Manual
Review URL: http://codereview.chromium.org/5124005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make it so that it sets the pixel type correctly, and initializes the video buffers properly.
BUG=NONE
TEST=BUILD
Review URL: http://codereview.chromium.org/5159004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--- Checks that all source files are in ppapi.gyp and vice-versa
--- Generates test_c_includes.c and test_cc_includes.cc
- Removes tests/test_image_data, which appears to be obsolete
I want to make the script a gyp action, but it didn't work on Windows last I tried. If desired, I can fix that in this CL, or I can make it automated later.
BUG=63527,59791,53451
TEST=None; improves build-time checking
Review URL: http://codereview.chromium.org/5190004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5228005
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/5223003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension.
This change also refactors the balloon collection code to remove duplication between chrome and chromeos.
Removes some gross removal code which was using fake notifications just to get the right ID.
BUG=58266
TEST=open notifications from extension, uninstall extensions
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65879
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66571
Review URL: http://codereview.chromium.org/4635007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fix 3g data expiration crash.
BUG=chromium-os:9388
TEST=manual
Review URL: http://codereview.chromium.org/5197002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5137008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=58804
TEST=Accessibility Inspector.
Review URL: http://codereview.chromium.org/5183006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57895
TEST=manual
Review URL: http://codereview.chromium.org/5151009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5228005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=antonm@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in NavigateParams.
BUG=none
TEST=
Bug 1: open an incognito window. switch back to the non-incognito window then right click a link and choose "open in incognito window." link should be opened in new tab in existing incognito window and that window activated. bug is that this happens but window is not activated.
Bug 2: open an app frame (e.g. chrome --app=http://mail.google.com/). click on a link that would open a new tab (which can't be opened in an app frame). If an existing chrome window would be the target that window is never activated.
Review URL: http://codereview.chromium.org/5219005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4950001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
across CF and CEEE, this just reuses the ceee_presubmit.py file with some
special-casing to avoid checks written for CEEE that do not apply to CF.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5162007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
past IOThread
destruction.
BUG=chromium-os:8179,63692,63796
TEST=sync integration tests
Review URL: http://codereview.chromium.org/5163004
For revert info, see bug 63796.
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/5144006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm going to try to shrink ChromeMain() down to a bunch of function
calls, then move those functions into e.g. chrome_main_mac.cc. Here's
one step on it.
TEST=compiles
Review URL: http://codereview.chromium.org/5166005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only appears for canceled downloads. Appears in the same spot as "Show in folder" does for completed downloads.
BUG=28846
TEST=manual
Review URL: http://codereview.chromium.org/5204004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the view.
BUG=61963
TEST=see bug
Review URL: http://codereview.chromium.org/5227003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread.
Test breakages caused by this change have been fixed here or in other changelists.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/5024003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5206005
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5242002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Save textures in memory rather than reading them directly from the SetRect() source, which is an unsafe hack. This fixes a crash when a texture was painted after the shared memory was unregistered, or if a texture was painted that was created from a static image downloaded from the net. This is a perf regression due to the extra copy, but we can add a special shared memory texture class later. This also regresses the functionality because SetRect() updates only a portion of the texture but RendererCairo paints the entire texture. An upcoming CL will add an API to define the region to paint.
- Remove unused weak pointer tracker from Layer class.
- Create textures of the requested image format rather than hard-coding ARGB8, and fail for formats not supported by Cairo.
- Fix a couple crashes caused by missing refcounts.
- Fix crash when trying to render a Layer that has no assigned texture.
TEST=loaded O2D many times
BUG=none
Review URL: http://codereview.chromium.org/5134005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
timing out.
BUG=63675
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
user enabled predictive instant we switch to verbatim in certain
situations.
BUG=59217
TEST=see bug
Review URL: http://codereview.chromium.org/5225003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
platform. Earlier the tests were exiting in SetUp if the platform was not XP, causing the builders to regard the test as failing.
BUG=61497
TEST=build and run mini installer tests on XP
Review URL: http://codereview.chromium.org/5163006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=GDI capturer works.
Review URL: http://codereview.chromium.org/5173007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are allowed for NTLM/Negotiate authentication.
NTLM/Negotiate authentication recently added group policy support for configuring authentication parameters.
This introduced an issue where non-specification of a server whitelist resulted in no servers being whitelisted, instead of using security zone mapping.
BUG=19
TEST=Go to an NTLM or Negotiate authenticating server on a Windows version of Chromium, and validate that authentication happens without a password prompt.
Review URL: http://codereview.chromium.org/5172006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We weren't sending out the SpdySettings frame until the first SYN_STREAM.
BUG=none
TEST=new unit test
Review URL: http://codereview.chromium.org/5180004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63692
TEST=existing
Review URL: http://codereview.chromium.org/5234003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ViewMsg_SetPhishingModel message from the browser, and run it after pages
load in the renderer. The phishing classifier will only run on new
navigations where the toplevel URL has changed. Since we need to keep the page text around in memory in the case where the model is not yet set when a page loads, this is also conditional on a command-line flag.
The next steps will be to send the SetPhishingModel IPC from the browser, finish implementing the DetectedPhishingSite IPC, and ping to confirm the phishy verdict.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3615003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
at initial start up if the page loaded contains iframes.
The problem is that a hash map was being used to track the scripts to run,
and the window object was used as a key. The window of iframes was mapping
to the same entry in the map as the top level window, causing some scripts
to be lost and not run.
The code now puts all scripts to run in an array. As it runs each one, it
sees if the scripts have already been run in the given window. If so, they
are not run again.
BUG=0
TEST=make sure that content scripts are run for the first page loaded into
chrome frame.
Review URL: http://codereview.chromium.org/5188007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5194003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also fix line endings.
TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/5099004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test breakages caused by this change have been fixed here or in other changelists.
BUG=61753
TEST=none
Review URL: http://codereview.chromium.org/5024003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5206005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL provides a dispatcher that can feed the prerender system with
HTML type requests that were prefetched.
One thing is missing though: this sends all requests in, and doesn't tag the
origin request. Unfortunately referer information is often tossed out in
resource_dispatcher_host...
Is there a private place it's sent along to for this type of use? I left that
undone right now but I'm open to suggestions about a good way to do it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4655004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66790 0039d316-1c4b-4281-b951-d872f2087c98
|