| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pages into an HTML label tag, to make it clickable and more friendly to screen
readers.
TEST= Navigate to ianfette.org and click on the text "I understand that visiting
this site may harm my computer". Checkbox should toggle.
BUG= 12714
Original patch by chromium@willhirsch.co.uk
Original review: http://codereview.chromium.org/115815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben
BUG=11904
TEST=See bug, verify that home buttons don't look like provided image.
Review URL: http://codereview.chromium.org/115845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=10638
TEST=Go to about:credits and verify that there's no reference to JSCRE
Original review URL:
http://codereview.chromium.org/113683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115728
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since media in chrome renderer doesn't use file handle
anymore, and these two files are deprecated, remove
them from the tree.
Review URL: http://codereview.chromium.org/115841
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=ran gclient sync to verify syntax of DEPS change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installer_unittests, installer_util, mini_installer, mini_installer_test,
setup.
Added msvs_guid settings for all targets.
Moved some variables that are used by multiple targets
to the top level.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetBrowserViewForNativeWindow()
This simplifies things on linux where the native window is not the same type
as the native view.
Review URL: http://codereview.chromium.org/115830
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=12042
Review URL: http://codereview.chromium.org/115838
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11780
TEST=go to cygwin.com, click "install or update now". The download shelf should appear with a dangerous download dialog, which should animate properly and without undue jank. Clicking "cancel" should delete the item and hide the shelf (since it's the only thing in the shelf). Clicking "save" should make it become a normal download item.
Review URL: http://codereview.chromium.org/113920
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113923
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to not be selectable for much of the right endcap.
Review URL: http://codereview.chromium.org/115836
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113926
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
is not built or referenced at all by the chrome build yet, and doesn't
yet build in it's new home. We'll change that shortly.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WidgetWin rather than Widget and the associated ATL classes, the class name based comparison for a window
to check if it is an external tab container window is no longer valid.
We now check if a window is an external tab window by looking for the existence of the kWindowObjectKey window property, which is only set on external tab container windows.
Review URL: http://codereview.chromium.org/115833
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115834
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed recently during porting. When
comparing to see who is registered we need to
be comparing against a class that implements
FocusChangeListener (and registers as such
with AddFocusChangeListener). In this case,
host_ does not implement that interface and
doesn't register as a listener, so it will
never be registered. We should be comparing
using 'this', not 'host_'.
I've fixed this and added a browser_test to
catch this in the future.
BUG=12729
TEST=Open Find, press Esc, press Esc again
and the Find box should not briefly appear
and hide again. Also, make sure Esc works
to cancel navigations.
Review URL: http://codereview.chromium.org/115832
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
memory instead of MD5 of text section.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash server requires an MDRawSystemInfo stream in order to process the
file, although it actually only needs a single value in it.
Additionally, it needs a PDB7 structure for each module, so we remove those
modules which probably aren't shared libraries and XOR the first page of data
to get a signature for them. The previous code opened the file and MD5 summed
the text segment. However, we can't know if the shared library is still linked
on disk, nor if the whole text segment is mapped in memory. Thus, we only
assume that a single page is mapped.
dump_syms will need to be forked and updated to match the signature scheme used
in this patch.
http://codereview.chromium.org/113875
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
easier for callers. Also gets bookmark menu button to compile.
I'm also removing a function I just added to gtk_util as it's not
needed. GTK offers gtk_widget_get_toplevel which does what I need.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115831
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
system's thumbnail storage.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12725
TEST=repro test mentioned in http://code.google.com/p/chromium/issues/detail?id=12725#c4
Review URL: http://codereview.chromium.org/113922
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"""
Fixed StatusBubbleViews::AvoidMouse() to support the mirrored UI (RTL) mode.
BUG=12148
TEST=Start chromium with --lang=he. Hover a mouse cursor on a link in the bottom
right corner, verify that the status bubble appears to the left. Verify that the
status bubble appears in a normal (right) position for all other links.
"""
Original review URL:
http://codereview.chromium.org/115461
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/6590
TEST=Cause the download shelf to appear by initiating a download. Hover
over a link in the extreme lower left corner of the browser window. The
status bubble should avoid your mouse by moving to the right, instead of
moving down and obscuring the download shelf.
Review URL: http://codereview.chromium.org/113671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12653
Review URL: http://codereview.chromium.org/115829
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* activex_test_control.dll
* browser_tests.dll
* browser_tests.exe
* memory_watcher.dll
* rlz.dll
* security_tests.dll
* test_chrome_plugin.dll
* themes/default.dll
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113915
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
make chrome app depend on pdfsqueeze
add a rule to run pdfs through pdfsqueeze
BUG=7654
TEST=pdf files in resources should be smaller now.
Review URL: http://codereview.chromium.org/113911
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was related to an infobar (the default browser one) showing.
When the tab is closed, InfoBarClosed is called on the infobar delegates, triggering a delete of the delegate. Then a notification that the tab is destroyed is sent, causing the tab contents to layout its infobars accessing the deleted delegates.
BUG=12668
TEST=All UI tests should pass (especially the LoginPromptTest ones).
Make IE your default browser, start Chrome. The default browser infobar should show. Close the tab.
Review URL: http://codereview.chromium.org/113906
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/113921
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113919
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115826
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
add methods in bookmark model to get/set this preference.
Review URL: http://codereview.chromium.org/113882
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113890
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Cole. TBR=jnj
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115825
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
following" with a blank list. Patch by Yuzo Fujishima (see http://codereview.chromium.org/113444 ), r=beng.
BUG=6901
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(see http://codereview.chromium.org/115558 ), r=beng.
BUG=10632
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the "breakpad_linux*" files to the "browser" target rather than "app",
since they're needed by "render_crash_handler_host_linux*" which is in
"browser". This fixes link errors in unit_tests, which incorporates "browser"
but wasn't getting the definitions in these files.
This is a revised version of r16954 which avoids the scons "multiple inclusion" errors in the non-official build.
Review URL: http://codereview.chromium.org/115823
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115824
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when there are browsers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113912
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so they can be committed ahead of the other CL so that the try server can work.
The modified file removes one item from the manifest that wasn't being used.
TBR=aa,erikkay
Review URL: http://codereview.chromium.org/113918
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
data in the file.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113917
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in some distributions.
BUG=11380
TEST=Start chrome with empty resolv.conf, fix resolv.conf; chrome should
be able to resolve sites.
Review URL: http://codereview.chromium.org/113904
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We specifically detect this case, close the channel and return an error.
This CL also silences error messages that where previously printed to the console in this situation.
BUG=12734
Review URL: http://codereview.chromium.org/113913
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115821
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
namespace change to window_sizer_mac which I noticed when doing a previous
change.
Review URL: http://codereview.chromium.org/113910
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
or not. If not valid, just pass white to ThemeEngine.
This change was motivated by the issue
http://code.google.com/p/chromium/issues/detail?id=2756, but it has been
resolved by only the upstream change
https://bugs.webkit.org/show_bug.cgi?id=25742.
However, this verification code is still useful.
BUG=2756
Checked in for tyoshino@google.com
Original review: http://codereview.chromium.org/113165
Review URL: http://codereview.chromium.org/113907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9936
TEST=Download a .svgz file to local disk, then attempt to view it. Please make sure it didn't get decompressed during the download.
Review URL: http://codereview.chromium.org/99109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/115768
TBR=tyoshino
Review URL: http://codereview.chromium.org/115822
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16999 0039d316-1c4b-4281-b951-d872f2087c98
|