summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove an unnecessary null pointer test for |info| inwtc@chromium.org2010-07-091-1/+1
| | | | | | | | | | | ResourceDispatcherHost::RemovePendingRequest. R=davidben BUG=48210 TEST=none Review URL: http://codereview.chromium.org/2962001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51920 0039d316-1c4b-4281-b951-d872f2087c98
* Define USE_SYMBOLIZE for Solaris because we build the 'symbolize' targetwtc@chromium.org2010-07-091-6/+2
| | | | | | | | | | | | | on Solaris. This allows us to merge two conditionals. R=evan,mark BUG=none TEST=no build errors on any platform. Review URL: http://codereview.chromium.org/2924002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51919 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove references to the close icons that were replaced by procedural ↵andybons@chromium.org2010-07-095-201/+2234
| | | | | | | | | | drawing code in r51367. BUG=none TEST=check logs. make sure that "Could not find image named 'close_bar'" is not present. Review URL: http://codereview.chromium.org/2964001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51918 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: uninitialized member in posix WaitableEventWatcher constructor.mattm@chromium.org2010-07-091-0/+1
| | | | | | | | | | CID=9290 TEST=builds BUG=none Review URL: http://codereview.chromium.org/2954001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51917 0039d316-1c4b-4281-b951-d872f2087c98
* Bring in the latest PPAPI and add an implementation for SetCursor.jam@chromium.org2010-07-094-5/+99
| | | | | | Review URL: http://codereview.chromium.org/2942001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51916 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential crash in MountLibraryImpl::Init().satorux@chromium.org2010-07-091-0/+4
| | | | | | | | | | | | | | This is not a big deal, as the crash does not occur on the netbook. I encountred a crash when I was trying to run chrome for chrome os with libcros.so on my Ubuntu workstation. Note that building libcros.so outside of chroot is very tricky, so no one else probably wants to do that. TEST=manually BUG=none Review URL: http://codereview.chromium.org/2884015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51915 0039d316-1c4b-4281-b951-d872f2087c98
* Work around an grit ID collision by forcingtony@chromium.org2010-07-081-1/+1
| | | | | | | | | | common_resources.grd to start at ID 1000. TBR=pkasting Review URL: http://codereview.chromium.org/2895005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51913 0039d316-1c4b-4281-b951-d872f2087c98
* Un-comment another crash which has popped up.pkasting@chromium.org2010-07-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51912 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AsyncTick to force Chrome through the reentrancy checks formerly in ↵tschmelcher@chromium.org2010-07-082-18/+27
| | | | | | | | | | | | | TickPluginObject, which fixes crashes in Chrome on Windows due to reentrant calls to NPP_URLNotify(). Also fix a bug where pending_ticks_ was not decremented in the reentrancy failure path, which would have caused all future AsyncTick() calls to be ignored. TEST=repeatedly loaded O3D in Chrome on Windows dozens of times and verified no crashes, whereas previously these crashes were frequent on this machine BUG=none Review URL: http://codereview.chromium.org/2824050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51911 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51903 - AutoFill Empty profiles and credit cards should not be saveddhollowa@chromium.org2010-07-082-136/+13
| | | | | | | | | | | | | | Changes PersonalDataManager to filter out empty profiles and credit card information before saving to the database. BUG=47742 TEST=PersonalDataManagerTest.SetEmptyProfile, PersonalDataManagerTest.SetEmptyCreditCard Review URL: http://codereview.chromium.org/2897005 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/2904005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51910 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed race condition in O3D/WebGL FileRequest implementation by onlykbr@google.com2010-07-081-15/+14
| | | | | | | | | | | initiating download upon send(). BUG=none TEST=none Review URL: http://codereview.chromium.org/2903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51909 0039d316-1c4b-4281-b951-d872f2087c98
* Add "save credit card info?" infobar for Autofill.avi@chromium.org2010-07-088-13/+204
| | | | | | | | | BUG=http://crbug.com/48114 TEST=none (depends on bug 47428) Review URL: http://codereview.chromium.org/2949002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51908 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-0813-581/+562
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51906 0039d316-1c4b-4281-b951-d872f2087c98
* Add expectation for MockSystemLibrary->{Add|Remove}Observeroshima@chromium.org2010-07-083-9/+26
| | | | | | | | | | | | This was causing gmock warning in browser tests. Changed cros mocks to StrictMock so that uninteresting call will fail. BUG=none TEST=browser tests will not have gmock warning "Uninterested mock function call" Review URL: http://codereview.chromium.org/2929001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51905 0039d316-1c4b-4281-b951-d872f2087c98
* Add boilerplate text pointing to the experimental API instructions.kathyw@chromium.org2010-07-082-1/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2947001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51904 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill Empty profiles and credit cards should not be saveddhollowa@chromium.org2010-07-082-13/+136
| | | | | | | | | | | Changes PersonalDataManager to filter out empty profiles and credit card information before saving to the database. BUG=47742 TEST=PersonalDataManagerTest.SetEmptyProfile, PersonalDataManagerTest.SetEmptyCreditCard Review URL: http://codereview.chromium.org/2897005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51903 0039d316-1c4b-4281-b951-d872f2087c98
* Pull PPAPI to get the paint aggregator, hook up UI test.brettw@chromium.org2010-07-082-1/+5
| | | | | | Review URL: http://codereview.chromium.org/2931002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51902 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Chrome renderer crash which occurs on closing the print dialog right ↵ananta@chromium.org2010-07-081-4/+2
| | | | | | | | | | | | | | | after it was opened. This is because of attempting to calculate the printable area while the settings are invalid leading to a divide by zero crash. Fixes bug http://code.google.com/p/chromium/issues/detail?id=48493 Bug=48493 Review URL: http://codereview.chromium.org/2809053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51901 0039d316-1c4b-4281-b951-d872f2087c98
* CorrupFrameSessionError Fails.cbentzel@chromium.org2010-07-081-1/+2
| | | | | | | | | BUG=48588 TEST=None Review URL: http://codereview.chromium.org/2955001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51900 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Only query the AutoFill server if we've parsed any of the forms.jhawkins@chromium.org2010-07-084-20/+48
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2880022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51899 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Minimize usage of gtk headers.erg@chromium.org2010-07-0826-125/+220
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2891006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51898 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51887 - Disable SpdyNetworkTransactionTest.CorruptFrameSessionError ↵eroman@chromium.org2010-07-081-2/+1
| | | | | | | | | | | | | which is failing on vista modules bot BUG=48588 TBR=willchan Review URL: http://codereview.chromium.org/2950001 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/2933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51897 0039d316-1c4b-4281-b951-d872f2087c98
* Add an image.thakis@chromium.org2010-07-081-0/+0
| | | | | | | | Part of http://codereview.chromium.org/2843027 Review URL: http://codereview.chromium.org/2917004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51896 0039d316-1c4b-4281-b951-d872f2087c98
* Rolled forward O3D's Chromium DEPS to match the Skia roll-forward inkbr@google.com2010-07-0811-53/+81
| | | | | | | | | | | | | the last CL, which broke the Linux build due to version mismatches. Thanks to tschmelcher for help with the Linux changes. Built and tested O3D on Windows, Linux and Mac OS X. BUG=none TEST=none Review URL: http://codereview.chromium.org/2952001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51895 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile (add include of WebSize to webgles2context_impl.h)jamesr@chromium.org2010-07-082-1/+1
| | | | | | | | | | TBR=kbr TEST=compile BUG=none Review URL: http://codereview.chromium.org/2895003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51894 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51877, since SpdyNetworkTransactionTest.CorruptFrameSessionError ↵eroman@chromium.org2010-07-0820-1192/+594
| | | | | | | | | | | | | | | | | | | | | | | | started failing after this check-in (but only on vista modules builder). BUG=48588 Original CL description: Add the capability to run multiple proxy PAC scripts in parallel. Refactors SingleThreadedProxyResolver into MultiThreadedProxyResolver. New threads are created lazily on demand, up to a fixed maximum. Note that this CL does NOT change the policy in Chrome -- it will continue to use a single thread for proxy resolving, but using the new code to do so. BUG=11079 Review URL: http://codereview.chromium.org/2822043 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/2945004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51893 0039d316-1c4b-4281-b951-d872f2087c98
* Switch WebGLES2Context::resizeOffscreenContent to use a WebSize instead of ↵jamesr@chromium.org2010-07-082-3/+4
| | | | | | | | | | | int/int TEST=none BUG=none Review URL: http://codereview.chromium.org/2924006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51890 0039d316-1c4b-4281-b951-d872f2087c98
* Widen heapchecker suppression for SPDY test.willchan@chromium.org2010-07-081-1/+1
| | | | | | | | BUG=46886 Review URL: http://codereview.chromium.org/2911002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51889 0039d316-1c4b-4281-b951-d872f2087c98
* Adds tests for the SpdyFramer.Create* frame creation methods.mlloyd@chromium.org2010-07-086-22/+576
| | | | | | | | | | | | | Also tightens up and fixes some of the DCHECKs in the frame creation logic to address issues discovered while writing the tests. BUG=None TEST=net_unittests pass Review URL: http://codereview.chromium.org/2834046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51888 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SpdyNetworkTransactionTest.CorruptFrameSessionError which is failing ↵eroman@chromium.org2010-07-081-1/+2
| | | | | | | | | | on vista modules bot BUG=48588 TBR=willchan Review URL: http://codereview.chromium.org/2950001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51887 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of making RenderView not special case PluginDocument and making ↵jam@chromium.org2010-07-0815-112/+233
| | | | | | | | the WebPlugin API more like WebView. Review URL: http://codereview.chromium.org/2827047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51886 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r51857 "Integrating back into using the external ppapi/cpp wrappers."ajwong@chromium.org2010-07-0810-329/+390
| | | | | | | | For some reason, this looks like it breaks all PPAPI ui tests on linux. TBR: tonyg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51885 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51882 - In order to run the sync integration tests on the chromium ↵cbentzel@chromium.org2010-07-082-38/+6
| | | | | | | | | | | | | | | | buildbots, we need a way to load the GAIA credentials from a local password file instead of via command line parameters. This changelist implements a new command line parameter called "--password-file-for-test" for this purpose. BUG=48525 TEST=sync_integration_tests;valid password file;invalid password file;blank password file;non-existent password file Review URL: http://codereview.chromium.org/2899001 TBR=rsimha@chromium.org Review URL: http://codereview.chromium.org/2905004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51884 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Spdy heapchecker suppression.willchan@chromium.org2010-07-081-1/+1
| | | | | | | | BUG=46886 Review URL: http://codereview.chromium.org/2932002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51883 0039d316-1c4b-4281-b951-d872f2087c98
* In order to run the sync integration tests on the chromium buildbots, we ↵rsimha@chromium.org2010-07-082-6/+38
| | | | | | | | | | | | | need a way to load the GAIA credentials from a local password file instead of via command line parameters. This changelist implements a new command line parameter called "--password-file-for-test" for this purpose. BUG=48525 TEST=sync_integration_tests;valid password file;invalid password file;blank password file;non-existent password file Review URL: http://codereview.chromium.org/2899001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51882 0039d316-1c4b-4281-b951-d872f2087c98
* Applying "Solving a bug in Chrome Frame that Firefox doesn't set preferences ↵robertshield@chromium.org2010-07-081-1/+0
| | | | | | | | | | | | | correctly during startup" for hansl@. Original review here: http://codereview.chromium.org/2909003/show TBR=hansl Review URL: http://codereview.chromium.org/2924004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51881 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Bring https:// coloring into line with views.shess@chromium.org2010-07-081-7/+8
| | | | | | | | | BUG=43602 TEST=Good https:// sites are always green, never blue. Review URL: http://codereview.chromium.org/2805078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51879 0039d316-1c4b-4281-b951-d872f2087c98
* Reliability crash list cleanup, part 2. Try commenting out all the ↵pkasting@chromium.org2010-07-081-99/+25
| | | | | | | | | | not-permanently-ignored crashes that are not known to still be happening, to see what's actually still causing issues. BUG=none TEST=none Review URL: http://codereview.chromium.org/2896001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51878 0039d316-1c4b-4281-b951-d872f2087c98
* Add the capability to run multiple proxy PAC scripts in parallel.eroman@chromium.org2010-07-0820-594/+1192
| | | | | | | | | | | | | Refactors SingleThreadedProxyResolver into MultiThreadedProxyResolver. New threads are created lazily on demand, up to a fixed maximum. Note that this CL does NOT change the policy in Chrome -- it will continue to use a single thread for proxy resolving, but using the new code to do so. BUG=11079 Review URL: http://codereview.chromium.org/2822043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51877 0039d316-1c4b-4281-b951-d872f2087c98
* Fix disabled unit test.jrg@chromium.org2010-07-081-4/+29
| | | | | | | | | | | | Certain calls now go direct to barController, not parentController. These changes bounce callbacks back to parentController in test code to be seen. BUG=none TEST=green tree Review URL: http://codereview.chromium.org/2904001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51876 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51858 - Disk cache: Switch the disk cache to use the cache_thread. rvargas@google.com2010-07-0819-1482/+225
| | | | | | | | | | | | | | | | Add an InFlightBackendIO class that handles posting of cacheoperations back and forth between the IO thread and the cachethread. BUG=26730 TEST=unit tests Review URL: http://codereview.chromium.org/2827043 TBR=rvargas@google.com Review URL: http://codereview.chromium.org/2944002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51874 0039d316-1c4b-4281-b951-d872f2087c98
* There were typos in lines 1575, 1578 and 1581.rsimha@chromium.org2010-07-081-4/+4
| | | | | | | | | BUG=43893 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2901001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51873 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: improve bookmark menu subfolder drag workaround.estade@chromium.org2010-07-081-6/+9
| | | | | | | | | | | | The workaround that allows us to drag folders was causing strange behavior under certain circumstances (see bug). The solution is to select and then activate the subfolder, rather than trying to popup the submenu manually. BUG=45891 TEST=a) see bug. b) open bookmark folder, hover over subfolder. Repeated clicking should open/close the submenu. Review URL: http://codereview.chromium.org/2830040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51872 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Flush cairo surface at end of CanvasPaintLinux.estade@chromium.org2010-07-083-9/+5
| | | | | | | | | | | I also added some cairo_surface_flush calls for good measure, mostly to match the GIMP patch, but I don't really have any way of testing whether these are necessary. BUG=47064 TEST=manual (see bug) - throbber, download icons, etc. should be fixed Review URL: http://codereview.chromium.org/2802034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51871 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up and simplify how we deal with filename extensions on Windows. ↵pkasting@chromium.org2010-07-084-33/+102
| | | | | | | | | | Allow users to use any name or extension they want, and only append the "desired" extension when the user's name doesn't have any known extension. Original patch by Jared Wein (see http://codereview.chromium.org/2825010 ), r=me. BUG=7499 TEST=Right-click on link, choose "Save link as...", leave the file type as the default but change the file name to have a different extension. Ensure that the browser doesn't append the original extension. Review URL: http://codereview.chromium.org/2893001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51870 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: Change content settings window to use a list instead of tabs.thakis@chromium.org2010-07-084-38/+108
| | | | | | | | | BUG=46965 TEST=Open content settings window. Should look more like it does on windows. Review URL: http://codereview.chromium.org/2757005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51869 0039d316-1c4b-4281-b951-d872f2087c98
* Allow data_packages outputs to include flattened items withouttony@chromium.org2010-07-083-8/+21
| | | | | | | | | | | | | | | | | | rc_all outputs. This fixes a bug where the code to flatten an html file was in the rc_all output step. So if a data_package output came before the rc_all output in the grd file, we would get a build error. Just refactor the code to flatten for both output types (but only flatten once). BUG=48253 TEST=build completes succesfully Review URL: http://codereview.chromium.org/2889001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51868 0039d316-1c4b-4281-b951-d872f2087c98
* Mark two tests flaky.evan@chromium.org2010-07-082-2/+6
| | | | | | | | | | | They triy to use a timeout to reduce flakiness, but that only makes them fail less often; they are still not completely reliable. BUG=48562 Review URL: http://codereview.chromium.org/2901003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51867 0039d316-1c4b-4281-b951-d872f2087c98
* FTP: change order of commands to improve compatibilityphajdan.jr@chromium.org2010-07-083-199/+51
| | | | | | | | | | | | | | | | It turns out some FTP servers react strangely to a RETR for an unexistent file. They send a success reponse followed by a failure response. The solution is to move the file/directory sniffing logic from RETR earlier, to SIZE. BUG=44582 TEST=net_unittests Review URL: http://codereview.chromium.org/2813044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51866 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind suppression for r51743hclam@chromium.org2010-07-081-0/+36
| | | | | | | | | BUG=48557 TBR=cbentzel Review URL: http://codereview.chromium.org/2919002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51865 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 04:41:41 +0000