| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Ash part]
Add key_rewriter_event_filter.h which allows its delegate to rewrite or delete an aura::KeyEvent. The new interface will be used for implementing the following three features:
* crosbug.com/25097: Remap keys on external keyboards (R19)
* crosbug.com/27167: Consider adding a way to send function keys to web pages (R20)
* crbug.com/115112: Move modifier remapping code from X to Chrome (M20)
Part 2 of 2: http://codereview.chromium.org/9854025/
BUG=chromium-os:25097
BUG=chromium-os:27167
BUG=115112
TEST=try
Review URL: https://chromiumcodereview.appspot.com/9838010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's possible there exist clients with the same set of encryption
keys but different default keys. In that case, they'll get into a ping-pong
match attempting to update the nigori node's keys with their own, but ignoring
the default key when they receive a new nigori node since it's an old key.
BUG=119207
TEST=
Review URL: https://chromiumcodereview.appspot.com/9864011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused check perms to fail
http://chromegw.corp.google.com/i/chromium/builders/Linux/builds/21699/steps/check_perms/logs/stdio
The main class to implement android content provider.
This CL is the implementation of Bookmark part.
It doesn't include Search related API.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9704077
TBR=michaelbai@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9864018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that hashing is fixed, trial turning it on again for the basic
playback test. Tested as much as I can locally since there are no
win_tsan, win_valgrind try bots.
BUG=none
TEST=valgrind, tsan, win_drmemory trybot.
Review URL: http://codereview.chromium.org/9809031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on docs via chrome://gdata/cache/<resource_id>/<file_name> URLs.
BUG=chromium-os:28240
TEST=changed all GDataFileSystemTest.* to use new GDataFileSystem::FindFileByResourceIdSync() method.
TBR=jhawkins@chromium.org... for trivial change in chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
Review URL: https://chromiumcodereview.appspot.com/9856010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128961
Review URL: https://chromiumcodereview.appspot.com/9838092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9826025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=118298
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9794016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
initialize
BUG=120076
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9809035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9861003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9808046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageLoop with orphaned tasks.
This change maintains the same API promises*, but instead of orphaning tasks when they are stopped, the BaseTimer_Helper class holds on to the task until either (1) it expires or (2) the user requests a delay that would arrive earlier than the pending task. If the user requests a longer delay than the pending task, a followup task will be posted when the pending task fires to span the remaining time.
* The one change of usage is related to threading. The threading requirements are now more strict. It is not allowed to destruct a timer on a different thread than the one used to post tasks. A thread ID DCHECK is now in place that will help catch misuse. Some existing instances are changed as part of this CL.
A side effect of this change is that the BaseTimer and DelayTimer are simplified to use features of BaseTimer_Helper (which is now called Timer).
As suggested in timer.h, I ran the disabled TimerTest tests from linux, and they pass consistently. I also added some new tests to verify correct run states.
BUG=117451,103667,119714,119750
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128412
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=128506
Review URL: https://chromiumcodereview.appspot.com/9655006
TBR=jbates@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9791009
TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9860014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change primarily entails creating a SyncChannel between sel_ldr and the
browser. Queries to the database could be made from any thread inside sel_ldr,
so the query mechanism needs to be thread safe.
This feature is currently disabled by default, and requires an environment
variable to enable. A few changes need to be made before this features is safe
and can be enabled, such as making sure each installation has a unique,
crypographically secure key.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2515
TEST= Run NaCl w/ NACL_VALIDATION_CACHE=1
Review URL: http://codereview.chromium.org/9796006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Existing TPMIsEnalbed is renamed to CallTPMIsEnabledAndBlock
Add new asynchronous TPMIsEnabled method
Use asynchronous method in CertLibrary
BUG=118206
TEST=can login
Review URL: http://codereview.chromium.org/9860003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
launcher.
BUG=120301
TEST=see bug
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9860011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=119630
TEST=PPAPITest.Fullscreen, manual.
Review URL: https://chromiumcodereview.appspot.com/9835077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=120057
TEST=dragging files from downloads tray works.
Review URL: http://codereview.chromium.org/9856024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Convert all the remainings.
BUG=chromium-os:28429
TEST=tests, and manually confirm the file manager works as before
Review URL: https://chromiumcodereview.appspot.com/9866010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add cras_output.cc/h for talking to the server and cras_wrapper to
allow unit testing. Code structure borrowed from alsa_output and
mac/audio_low_latency_output. Introduce a gyp setting that can be used
to enable cras_output.
BUG=chromium-os:25409
TEST=New unit test for cras_output. Build and run on desktop linux
and on mario.
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Review URL: http://codereview.chromium.org/9374011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We were notifying submenus of being closed too soon, so they were deleting
child submenus before we'd processed activations within them.
BUG=120213
Review URL: https://chromiumcodereview.appspot.com/9864007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Convert four simple callers. Six to go.
BUG=chromium-os:28429
TEST=tests, and manually confirm the file manager works as before
Review URL: https://chromiumcodereview.appspot.com/9853027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
transparent background.
BUG=120079
TEST=manual
Review URL: http://codereview.chromium.org/9861004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
score_ is partially initialized, and while ultimately the uninit
elements are not used, coercing them to floating point generates uninit
reports when run under drmemory. It's also unecessary, so I'm removing
it.
BUG=115326
R=jshin@chromium.org,timurrrr@chromium.org
TEST=comact_lang_det_unittest_small.cc under drmemory
Review URL: http://codereview.chromium.org/9465026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=zmo@chromium.org,jbates@chromium.org
Review URL: http://codereview.chromium.org/9853009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119803
TEST=see bug
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9863007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
candidate window.
BUG=114070
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9836094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9861009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since fields are generated as simple structure elements the schema compiler
must output the full definitions for structures that are depended-upon before
the structures that depend upon them. This patch also causes same-namespace
forward struct delcarations to be emitted to resolve circular dependencies and
optional-property dependencies in generated code.
BUG=119911
TEST=none
Review URL: http://codereview.chromium.org/9836078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Manual test by creating overflow panel and verifying its shape
Review URL: https://chromiumcodereview.appspot.com/9865008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=113688
TEST=none
Review URL: http://codereview.chromium.org/9815019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit r128964 only solves half of the problem with calling
TransferRegularFile for copy operations. This CL fixes the remaining
issue with invoking the callback on the right thread.
BUG=chromium-os:28426, chromium-os:28460
TEST=Tested copying files within Docs folder in file manager.
Review URL: https://chromiumcodereview.appspot.com/9861006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The only code we've had that depended on StreamSample was PtsHeap, which was removed in r118610.
Review URL: https://chromiumcodereview.appspot.com/9809032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a few potential strings just in case we decide we want to pull the feature for choosing a random wallpaper back to M19.
BUG=120217
TEST=
Review URL: http://codereview.chromium.org/9864002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main class to implement android content provider.
This CL is the implementation of Bookmark part.
It doesn't include Search related API.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9704077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119846
TEST=Go directly to chrome://settings-frame/search -- ensure search box is visible
NOTRY=true
Review URL: http://codereview.chromium.org/9861005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 127893 -Revert 127730 - Revert 127717 - Revert 118788 - Revert 113405 - Revert 113305 - Revert 113300 - Revert 112134 - Revert 112130 - Close idle connections / SPDY sessions when needed
Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.
Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.
Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is prob
ably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).
Added NET_EXPORT for layered_pool class defintion to fix windows shared compile.
BUG=62364, 92244, 109876, 110368, 119847
TEST=
Review URL: http://codereview.chromium.org/9809033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It should be video renderer.
reland http://codereview.chromium.org/9856026/
BUG=120192
Review URL: https://chromiumcodereview.appspot.com/9863008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=118670
TEST=None
Review URL: http://codereview.chromium.org/9856030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allocations even if they were already sent.
Soon, the WK compositor will start ignoring suggestHaveBackbuffer requests under certain circumstances.
Since the GpuMemoryManager can track when this happens, and retry with another identical allocation, GpuCommandBufferStub should always send allocations as they are assigned.
BUG=120190
TEST=Manual
Review URL: http://codereview.chromium.org/9854034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=120254
TEST=Text in pointer settings updated to Enable simple scrolling direction
Review URL: https://chromiumcodereview.appspot.com/9865007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL conceptually does several things (most of them just one line).
1. Roll RLZ 105:118
106: Fix "expression result unused" warning caused by VERIFY() use.
107: rlz: Add an implementation of PingServer() that uses chrome's net stack.
108: Implement RlzValueStoreMac.
109: Move GetMachineId() to its own file. No intended behavior change.
110: Implement GetSystemTimeAsInt64() on mac.
111: Minor cleanups.
112: Don't pay a static initializer for expected_assertion_ when it's not used.
113: Rename rlz_lib2.cc and win/lib/rlz_lib.cc to win/lib/rlz_lib_win.cc
114: mac: Implement GetMachineId().
115: mac: Implement the locking part of ScopedRlzValueStoreLock.
116: Tweaks to make the use of chrome's net stack forceable through gyp.
117: Push RLZ_NETWORK_IMPLEMENTATION_ define to dependent targets.
118: Use base::mac::ScopedNSAutorleasePool only on mac.
2. Change rlz.cpp to use the blocking pool instead of the file thread.
3. Enable on mac.
4. Switch to chrome's network stack on windows
5. Switch RlzSendFinancialPingFunction to be an AsyncExtensionFunction
that calls SendFinancialPing on a worker thread. This is required because
extension functions run with a MessageLoop, so the MessageLoop in
SendFinancialPing in rlz would trigger an assert (and making that inner
loop nestable seems like a very bad idea). This change also removes
one instance of ScopedAllowIO and fixes a TODO.
BUG=46579
TEST=
1.) Do an official chrome build
2.) Add gratuitous logging in rlz.cc and other places and check that by default:
* The channel is reported as "stable"
* The brand code is the empty string
* This brand code counts as organic install
* RLZ exits early.
3.) Create ~/Library/Google/Google\ Chrome\ Brand.plist and add e.g. the string "BRAND" for key KSBrandID, restart chrome.
* Brand code is now "BRAND" (this depends on Chrome's Info.plist not having a KSBrandID key, which has precedence. Currently our Chromes seem to never have this key.)
* A ping is scheduled, but nothing is sent.
* Use the omnibox a little, which causes product events to be recorded.
4.) Restart chrome yet again, wait a bit.
* Logging in "SendFinancialPing()" should print:
pinging http://clients1.google.com:80/tools/pso/ping?as=chrome&brand=BRAND&pid=&hl=en&events=C1F,C1S&rep=2&rlz=C1:1C1_____enUS476,C2:1C2_____enUS476&id=0926C138C2EA77A791CB450D322D0183E5A8079300000001B5
ping completed!
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/9699054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/x64 and chrome/ipch were missing from .gitignore (while they shouldn't be created in the first place, they are because of bug #119528)
Adding .gitignore entries for every solution building in the wrong place is not viable in the long run (especially that it's only temporary for this bug).
When the bug is fixed, we should remove these entries.
BUG=119528
TEST=
Review URL: http://codereview.chromium.org/9857023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
unloads.
BUG=119901
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9866003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=116994
TEST=
Review URL: http://codereview.chromium.org/9662016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=117899
TEST=See bubble appear below wrench menu after accepting one-click signin and
pressing Start in dialog box.
Review URL: http://codereview.chromium.org/9814022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mac_strip.
This allows you to do `GYP_DEFINES='mac_strip_release=0' gclient sync` to
produce Release binaries that are not run through strip_from_xcode.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9855027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
also changes PP_ArrayOutput to be pass-by-value.
This keeps backwards compat for the old interface. It fixes some bugs in the callback system that I found when working on the patch and adds some new machinery for doing array output in the proxy. It also re-enables the file chooser feature which was recently broken.
BUG=118857
Review URL: https://chromiumcodereview.appspot.com/9728001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Manual test by resizing detached panels
Review URL: https://chromiumcodereview.appspot.com/9858028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129021 0039d316-1c4b-4281-b951-d872f2087c98
|