summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* This CL fixes the following issues:-ananta@chromium.org2009-11-112-10/+33
| | | | | | | | | | | | | | | | | | | | | | | 1. http://code.google.com/p/chromium/issues/detail?id=27200 This was a crash which would occur in the Stop function in the UrlmonUrlRequest object which would get invoked when the active document instance was being destroyed. The crash occured if the active document instance was reused in which case we end up reusing the automation client instance. The fix is to ensure that we clean up existing requests from the map before reusing the automation client instance. 2. http://code.google.com/p/chromium/issues/detail?id=27202 This was a DCHECK which would occur when adding a new request to the request map, which indicated that an existing request with the same request id existed in the map. This would occur during a redirect where the request id is reused by Chrome. Fix is to remove the request from the map when we handle the AutomationMsg_RequestEnd message in the UI thread itself. The UrlmonUrlRequest functions which attempt to remove the request from the map now check if the request is valid before doing this. Bug=27200,27202 Review URL: http://codereview.chromium.org/388008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31681 0039d316-1c4b-4281-b951-d872f2087c98
* Change width of install bubble to avoid orphan.aa@chromium.org2009-11-111-1/+1
| | | | | | | | | BUG=27351 TEST=none Review URL: http://codereview.chromium.org/385034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31680 0039d316-1c4b-4281-b951-d872f2087c98
* Add a RWH_TabSwitchPaintDuration histogram.chase@chromium.org2009-11-117-20/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The RWH_TabSwitchPaintDuration histogram calculates the amount of time it took after a particular view was selected for it to be fully painted. I modified the tab switching test to use the new tab switch paint duration histogram in place of the whiteout duration histogram. As a measure, whiteout duration would not carry a value if we kept the backing store around for a tab, and we would end up with a result of zero instead of a useful result. Local results with the new measure are consistent with the number of operations we perform on the tabs. The tab switching test now fails if it cannot locate the correct histogram. In that case, it will output the contents of the log file for remote debugging. BUG=4104 TEST=count of tab switch paint duration histogram results in tab switching test equals number of tabs used in test First committed as: http://src.chromium.org/viewvc/chrome?view=rev&revision=31632 Reverted in: 31645 Review URL: http://codereview.chromium.org/378038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31679 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganized command buffer and GPU plugin code into following structure:apatrick@google.com2009-11-11154-856/+840
| | | | | | | | | | | | gpu/gpu.gyp gpu/command_buffer/... gpu/gpu_plugin/... gpu/np_utils/... And fixed up paths and header sentry macros. Also merged command_buffer.gyp into gpu.gyp. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31676 0039d316-1c4b-4281-b951-d872f2087c98
* Add a close button to ExtensionInstalledBubble.rafaelw@chromium.org2009-11-111-4/+37
| | | | | | | | | BUG=27156 TEST=Install an extension, the installed successful bubble should have a close button with an x image that will close the bubble when clicked. Review URL: http://codereview.chromium.org/384026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31675 0039d316-1c4b-4281-b951-d872f2087c98
* Re-add a supression that shouldn't have been removedstuartmorgan@chromium.org2009-11-111-0/+13
| | | | | | | | | | TBR=dank BUG=20541 TEST=Green Mac valgrind bots Review URL: http://codereview.chromium.org/384046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31674 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: wait for initial scripts response before processing backtrace responseyurys@google.com2009-11-112-22/+92
| | | | | | | | | BUG=27381 TEST=DevToolsSanityTest.TestPauseWhenLoadingDevTools Review URL: http://codereview.chromium.org/384045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31673 0039d316-1c4b-4281-b951-d872f2087c98
* Cole sent me an icon that we'll use in the near term. Longer-term, we should ↵thakis@chromium.org2009-11-112-1/+6
| | | | | | | | | | | figure out how to use the system icon without regressing startup time. BUG=26457 TEST=Look at bookmarks bar. The folder icon, while not being the system folder icon, is at least blue. Review URL: http://codereview.chromium.org/389012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31672 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for desktop notifications.johnnyg@chromium.org2009-11-117-29/+416
| | | | | | | | | | | | | * Allow non-windows BalloonCollections to create non-viewable balloons (so that non-viewing aspects are cross-platform testable) * Makes NotificationObjectProxy overridable by a mock object which logs instead of calls to JS * Move Layout code from private to protected in BalloonCollection to enable verification of position code. BUG=none TEST=these Review URL: http://codereview.chromium.org/371041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31670 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-1165-87/+100
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add test for pause event during frontend load.yurys@google.com2009-11-114-1/+63
| | | | | | | | BUG=27366 TEST=DevToolsSanityTest.TestPauseWhenLoadingDevTools Review URL: http://codereview.chromium.org/392002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31668 0039d316-1c4b-4281-b951-d872f2087c98
* Allow new window creation when the frontmost browser has a modal sheet attached.pinkerton@chromium.org2009-11-111-7/+5
| | | | | | | | BUG=27379 TEST=creating new windows with app modals, tab modal, window modals Review URL: http://codereview.chromium.org/387025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31667 0039d316-1c4b-4281-b951-d872f2087c98
* Set have_inspector_files_ in the UI thread as it is only read from that thread.apavlov@chromium.org2009-11-112-1/+6
| | | | | | | | | BUG=24419 TEST=TSAN Review URL: http://codereview.chromium.org/391017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31665 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r428 to fix issue with symbol visibility.jeremy@chromium.org2009-11-111-1/+1
| | | | | | | | | BUG=22659 TEST=1.Crash reporting on Mac should still work after this CL. Repro steps in bug should no longer cause Chrome to crash. Review URL: http://codereview.chromium.org/389011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31664 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash during tab dragging. The code was invokingsky@chromium.org2009-11-112-8/+18
| | | | | | | | | | | | InitWindowCreatePoint when making a tab pinned, which is only save to invoke when the drag starts. BUG=27329 TEST=make sure no regressions in tab dragging. Review URL: http://codereview.chromium.org/391006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31663 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Skia SSE2 optimizations for Windows build. Linux build will require ↵senorblanco@chromium.org2009-11-111-0/+4
| | | | | | | | | | | | | some further handholding, due to gcc lameness. TEST=all layout tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31629 Review URL: http://codereview.chromium.org/385025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31662 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: allow deleting entries from localStorageyurys@google.com2009-11-111-0/+1
| | | | | | Review URL: http://codereview.chromium.org/385038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31661 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.3.18.6.ager@chromium.org2009-11-111-1/+1
| | | | | | | | | | | | | | | | | Fix stack corruption bug that causes crashes or incorrect behavior in IC lookup routines. Fixed regexp issue with cyrilic characters. Fix bailout of inline constructor generation. Do not show hidden properties array in debugger. BUG=27309,27227,26529,25188,26491 TEST=Covered by V8 tests. Review URL: http://codereview.chromium.org/385036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31660 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 244.0 to 245.0chrome-bot@google.com2009-11-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31659 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make ResourceDispatcherTest.CrossSiteNavigationErrorPage fasterphajdan.jr@chromium.org2009-11-111-14/+6
| | | | | | | | | | | | | and more solid. Sleeping for about 6 seconds is not a good idea. TEST=none BUG=none Review URL: http://codereview.chromium.org/385010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31655 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 27210, show bookmarks bar menu is out of sync with the ↵oshima@chromium.org2009-11-113-27/+43
| | | | | | | | | | | | | | | | | browser's status. * Update the states of menu before showing menu like Window's menu does. * Don't fire activate signal when the state is chagned via API. * Eliminated UpdateStateData and replace it with the NativeMenuGtk and the position stored in the gtk widget. * Fixed StateAreaView to check bookmark bar status. BUG=27210 TEST=Run linux builds (gtk/views/chromeos) check if the bookmark bar menu's status is in sync with the bookmark bar. Review URL: http://codereview.chromium.org/383012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31654 0039d316-1c4b-4281-b951-d872f2087c98
* WebSocket Live Experimentukai@chromium.org2009-11-116-37/+511
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/369002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31653 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r31647 again, I have enough perf datathakis@chromium.org2009-11-113-58/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31652 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a common crash. We were leaking theaa@chromium.org2009-11-111-0/+1
| | | | | | | | | | | | | | BrowserActionView because RemoveChild() does not delete it. This could maybe cause OnImageLoaded() to be called when there is no parent. I couldn't see any other path that could lead to that. BUG=27167 TEST=none Review URL: http://codereview.chromium.org/385031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31651 0039d316-1c4b-4281-b951-d872f2087c98
* Metrics of SocketStreamukai@chromium.org2009-11-115-1/+186
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/380004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31650 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid inconsistent state (leading to checkfailures) due to Windows ↵pkasting@chromium.org2009-11-117-167/+49
| | | | | | | | | | | | minimize/restore functionality hiding and showing the autocomplete dropdown outside of the awareness of the controller. Instead, this switches to the simpler model of just creating a new HWND when we want to show the dropdown, and destroying it when we want to close it. Happily, this also seems to save quite a bit of code. BUG=20511 TEST=Type a character in the omnibox, minimize the window, and restore it. The dropdown should have disappeared. Review URL: http://codereview.chromium.org/391011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31649 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31646.pkasting@chromium.org2009-11-114-33/+14
| | | | | | Review URL: http://codereview.chromium.org/386006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31648 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Use native folder icons for the bookmark bar.thakis@chromium.org2009-11-113-8/+58
| | | | | | | | | | | | | Based on http://codereview.chromium.org/342103 . I will land this to see the startup perf impact, then revert this after a short while, and then send it out for review. BUG=26457 TEST=Look at bookmark bar's "Other bookmarks". Should have blue folder. Review URL: http://codereview.chromium.org/384039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31647 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make widgets clean up after themselves a bit better:pkasting@chromium.org2009-11-114-14/+33
| | | | | | | | | | | * When they get "destroy" window manager messages, clean up internal state so nothing will call into them and in theory someone could re-Init() successfully * When they're deleted, ensure they're also "destroyed" from the window manager point of view BUG=27347 TEST=none Review URL: http://codereview.chromium.org/391010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31646 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31632 - looks like it broke some tests.dpranke@google.com2009-11-117-63/+20
| | | | | | | | | | R=chase@chromium.org TEST=tab_switching_test BUG=none Review URL: http://codereview.chromium.org/389006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31645 0039d316-1c4b-4281-b951-d872f2087c98
* For the immediate milestone, exclude History and Thumbnails from being ↵mrossetti@chromium.org2009-11-115-1/+69
| | | | | | | | | | | backed up by Time Machine. The bug describes appropriate long-term solutions to this problem. BUG=259595 TEST=Launch Chrome. Inspect the following files found in ~/Library/Application Support/Chromium/Default/: a) History, b) History-journal, c) Thumbnails, and d) Thumbnails-journal and verify that they are not being backed up by Time Machine. Review URL: http://codereview.chromium.org/387016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31644 0039d316-1c4b-4281-b951-d872f2087c98
* Add method to control whether local files get universal access during testing.cevans@chromium.org2009-11-112-0/+12
| | | | | | | | | | | This is required to test any form of local filesystem access restrictions. BUG=20450 TEST=Needed for LayoutTests/fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html Review URL: http://codereview.chromium.org/384015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31643 0039d316-1c4b-4281-b951-d872f2087c98
* linux: 64-bitpiman@google.com2009-11-1110-28/+86
| | | | | | | | | | | This CL enables a 64-bit of linux. Set target_arch='x64' in the gyp defines to enable. - fixes a few 64-bit issues - fixes some linux build issues on scons vs make - add rules to build 64-bit version Review URL: http://codereview.chromium.org/371078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31642 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a 'V8' column to task manager to track amount of memory in JavaScript heapjamesr@chromium.org2009-11-1111-7/+134
| | | | | | | | | BUG=27226 TEST=open task manager, enable column, compare with V8 heap profiler Review URL: http://codereview.chromium.org/377037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31641 0039d316-1c4b-4281-b951-d872f2087c98
* There was confusion in the mock socket classes due tombelshe@google.com2009-11-1110-426/+430
| | | | | | | | | | | | | | | | | | | overlapping names. The MockSocket is not actually a socket. It is an interface for fetching data for reads and writes on a socket. The MockClientSocket and MockTCPClientSocket are the actual sockets. Rename MockSocket to SocketDataProvider. Rename SSLMockSocket to SSLSocketDataProvider. Update all tests to reflect name change. BUG=none TEST=none Review URL: http://codereview.chromium.org/384024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31640 0039d316-1c4b-4281-b951-d872f2087c98
* Inodes can be 64-bit, use Int64ToString.thestig@chromium.org2009-11-112-2/+2
| | | | | | | | BUG=27322 TEST=none Review URL: http://codereview.chromium.org/384031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31636 0039d316-1c4b-4281-b951-d872f2087c98
* Add one failing test back indpranke@google.com2009-11-111-0/+2
| | | | | | | | | R=mpcomplete@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31635 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31629.senorblanco@chromium.org2009-11-111-8/+0
| | | | | | Review URL: http://codereview.chromium.org/385028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31634 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/379007 for Dave:sky@chromium.org2009-11-1117-68/+704
| | | | | | | | | | | | Fixes leak in BackingStore as shown by valgrind. XFree doesn't free the data of the image, where as XDestroyImage does. BUG=none TEST=none Review URL: http://codereview.chromium.org/391008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31633 0039d316-1c4b-4281-b951-d872f2087c98
* Add a RWH_TabSwitchPaintDuration histogram.chase@chromium.org2009-11-117-20/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | The RWH_TabSwitchPaintDuration histogram calculates the amount of time it took after a particular view was selected for it to be fully painted. I modified the tab switching test to use the new tab switch paint duration histogram in place of the whiteout duration histogram. As a measure, whiteout duration would not carry a value if we kept the backing store around for a tab, and we would end up with a result of zero instead of a useful result. Local results with the new measure are consistent with the number of operations we perform on the tabs. The tab switching test now fails if it cannot locate the correct histogram. BUG=4104 TEST=count of tab switch paint duration histogram results in tab switching test equals number of tabs used in test Review URL: http://codereview.chromium.org/378038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31632 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple more flaky linux testsdpranke@google.com2009-11-111-0/+3
| | | | | | | | | | BUG=27341 R=mpcomplete@chromium.org TEST=none Review URL: http://codereview.chromium.org/390009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31631 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Skia SSE2 optimizations.senorblanco@chromium.org2009-11-111-0/+8
| | | | | | | | | TEST=all layout tests BUG=none Review URL: http://codereview.chromium.org/385025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31629 0039d316-1c4b-4281-b951-d872f2087c98
* Update various routines to look for IMAGE, IMAGE+TEXT, and TEXT as well as FAIL.dpranke@google.com2009-11-112-23/+34
| | | | | | | | | | | | Also remove a bunch of tests from test_expectations that are no longer failing. BUG=none R=ojan@chromium.org TEST=none Review URL: http://codereview.chromium.org/387015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31626 0039d316-1c4b-4281-b951-d872f2087c98
* 64-bit compatibility changes for the sandbox codegregoryd@google.com2009-11-117-12/+27
| | | | | | | | | This CL contains some basic changes that eliminate some of the warnings that appear when the sandbox code is compiled for 64-bit Windows. This is part of a larger effort to support Native Client on 64-bit Windows (that will require the sandbox to support 64-bit Windows). TEST=will be tested when the rest of the code builds for 64-bit Windows BUG=27218 Review URL: http://codereview.chromium.org/378030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31625 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in showing bookmark menus where the wrong menu wouldsky@chromium.org2009-11-112-4/+6
| | | | | | | | | | | appear when rtl. BUG=26376 TEST=see bug Review URL: http://codereview.chromium.org/384021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31624 0039d316-1c4b-4281-b951-d872f2087c98
* Check for an active network connection when network adapter status changes.zork@google.com2009-11-111-1/+17
| | | | | | | | | | | | BUG=19784 TEST=On a system with two network adapters, ensure one has an active internet connection, and the other does not. Disconnect the active one, and check that in notifier::NetworkStatusDetectorTaskMT::OnNetworkAliveDone() the call to network_alive->alive() returns false. Review URL: http://codereview.chromium.org/377019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31623 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a couple of missing parts for extensios on linux/views.oshima@chromium.org2009-11-113-10/+13
| | | | | | | | | | | | | | | | * Creating RenderWidgetHostView for gtk * Fix assertion failure in BrowserBubble * Don't change the window size if the size is empty, which causes gtk assertion error. With this change, most of extension tests in browser passes except for toolstrip. Given that toolstrip is obsolete, may be we should just remove it from test. BUG=None TEST=Run browesr_tests. All tests for extension must pass except for ExtensionApiTest.Toolstrip Review URL: http://codereview.chromium.org/390006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31622 0039d316-1c4b-4281-b951-d872f2087c98
* Add some tests that have been flaky today.dpranke@google.com2009-11-111-7/+19
| | | | | | | | | | BUG=27335,27334 R=mpcomplete@chromium.org TEST=none Review URL: http://codereview.chromium.org/387019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31621 0039d316-1c4b-4281-b951-d872f2087c98
* Rework painting to be something that will actually work. This allows plugins tobrettw@chromium.org2009-11-115-22/+110
| | | | | | | | | | | | | | only paint portions of their backing store. This also implements correct memory management on the chrome side. We can now supply more than one backing store, and will delete them properly when requested by the plugin. TEST=none BUG=none Review URL: http://codereview.chromium.org/371093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31620 0039d316-1c4b-4281-b951-d872f2087c98
* Added a flag to the Canvas class which allows forcing an RTL directionalityidana@chromium.org2009-11-114-10/+38
| | | | | | | | | | | | | on text drawn using Canvas::DrawStringInt(). Using this flag, it is possible to render RTL text correctly on platforms where LRE/PDF chars are not supported (e.g. Windows XP with no RTL fonts installed). BUG=23425 TEST=Run chrome and enter Hebrew text into the omnibox (see bug description). Make sure suggestions are formatted correctly. Verify in both RTL and LTR UIs. Review URL: http://codereview.chromium.org/384018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31619 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 16:08:56 +0000