summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Product name and version should be boldfaced in the About box.mark@chromium.org2009-10-261-8/+12
| | | | | | | | BUG=25862 TEST=The About box Review URL: http://codereview.chromium.org/330023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30116 0039d316-1c4b-4281-b951-d872f2087c98
* Rebasline some tests failures from WebKit merge 42026:42115japhet@chromium.org2009-10-2610-4/+17
| | | | | | | | | | BUG=none TEST=green Review URL: http://codereview.chromium.org/339011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30114 0039d316-1c4b-4281-b951-d872f2087c98
* Makes inactive pinned tabs throb on views when the title changes.sky@chromium.org2009-10-264-14/+68
| | | | | | | | | | BUG=25308 TEST=go to gmail, pin the tab, select another tab. Have someone IM you and make sure your gmail tab throbs. Review URL: http://codereview.chromium.org/329021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30113 0039d316-1c4b-4281-b951-d872f2087c98
* Widen a Mac UI valgrind suppression sligthlystuartmorgan@chromium.org2009-10-261-0/+1
| | | | | | | | | BUG=25656 TEST=Mac UI valgrind bots Review URL: http://codereview.chromium.org/330022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30112 0039d316-1c4b-4281-b951-d872f2087c98
* Switch optimization cflag to late-resolve the debug_optimize and ↵ajwong@chromium.org2009-10-261-2/+2
| | | | | | | | | | | | | release_optimize vars. This will allow lower-level targets to change their desired optimization level. In particular, the ffmpeg build requires this because it has problems compiling with -O0. BUG=22307 TEST=none Review URL: http://codereview.chromium.org/334018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30110 0039d316-1c4b-4281-b951-d872f2087c98
* Update some bug information in test_expectations.japhet@chromium.org2009-10-261-7/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/334008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30109 0039d316-1c4b-4281-b951-d872f2087c98
* Add a check for NULL in PopulateFolderCombo.thestig@chromium.org2009-10-261-5/+8
| | | | | | | | BUG=25849 TEST=none Review URL: http://codereview.chromium.org/335032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30108 0039d316-1c4b-4281-b951-d872f2087c98
* Fix text alignment in the About box. The left edges of the product name,mark@chromium.org2009-10-261-6/+560
| | | | | | | | | | version, legal block, and update icon (if present) should all line up. BUG=25582 TEST=Look at it. Come over here and look at it. Review URL: http://codereview.chromium.org/334031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30107 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit http://codereview.chromium.org/314016 with views fixedzork@chromium.org2009-10-2611-48/+69
| | | | | | Review URL: http://codereview.chromium.org/338008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30106 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented NPN_ScheduleTimer and NPN_UnscheduleTimer.apatrick@google.com2009-10-2611-19/+351
| | | | | | | | | TEST=none BUG=18020 Review URL: http://codereview.chromium.org/329013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30105 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dupes when generating the list of tests to show in theojan@chromium.org2009-10-261-3/+19
| | | | | | | | layout test dashboard. Also, if a path does not match any failing tests, then assume it's a full path so we can still show it's expectations. Review URL: http://codereview.chromium.org/334030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30104 0039d316-1c4b-4281-b951-d872f2087c98
* Data to reproduce infinite loop fixed by 48_aac_infinite_loop.patchfbarchard@chromium.org2009-10-261-0/+0
| | | | | | Review URL: http://codereview.chromium.org/333019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30102 0039d316-1c4b-4281-b951-d872f2087c98
* Make the About box display existing pending operations instead of firing offmark@chromium.org2009-10-264-35/+89
| | | | | | | | | | | | | | | | | | a new update check even when an existing update check or installation attempt is in progress. Remove the check that validates that the Update button is disabled after being clicked. This test has become very fragile now that the Update button reliably enables itself as soon as an update installation attempt fails. BUG=13165 TEST=Get the About box to offer you the opportunity to install an update. Click "Install Now". Close the About box and quickly reopen it. The update status should be "Installing new version..." and not "Checking for updates..." Review URL: http://codereview.chromium.org/339010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30100 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Fix signed vs unsigned issuepiman@chromium.org2009-10-261-5/+4
| | | | | | Review URL: http://codereview.chromium.org/297015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30099 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes up bookmark bubbles and the browser window so that they shut down ↵dmaclach@chromium.org2009-10-2614-843/+858
| | | | | | | | | | | | | | | | | | | correctly. BookmarkBubbleController has been made an NSWindowController instead of the view controller that it used to be, and now loads its window from the nib instead of creating it on the fly. Also cleans up fullscreen mode so that the window referenced from browser_window_controller stays constant instead of having [self window] and window_ potentially pointing at two different windows. BookmarkBubble.xib has been modified so that it instantiates a window containing a bubble view instead of just instantiating a view. BUG=25054 TEST=Try going in and out of full screen mode. Try bringing up a bookmark bubble by clicking on the star. Try creating a pile of windows and then quitting, Review URL: http://codereview.chromium.org/333017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30095 0039d316-1c4b-4281-b951-d872f2087c98
* Update test_expectations based off the layout test dashboard.ojan@chromium.org2009-10-261-4/+12
| | | | | | Review URL: http://codereview.chromium.org/330020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30093 0039d316-1c4b-4281-b951-d872f2087c98
* Find-in-page should not ding while deleting characters.finnur@chromium.org2009-10-263-3/+17
| | | | | | | | | BUG=18120 TEST=Open google.com, type Ctrl+F, type in garbage. Erase one letter at a time and there should be no beeping while you erase. Try it again, but this time use shift-delete to cut a few letters off the end. It should not ding. Now Copy the whole find string, press Esc, open Find again and on Paste it should not ding. Review URL: http://codereview.chromium.org/338005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30092 0039d316-1c4b-4281-b951-d872f2087c98
* o Cleans up canonical extension_install_ui.cc to avoid #ifdefs when feasible.mark@chromium.org2009-10-267-104/+107
| | | | | | | | | | | | | | | o Adds Cocoa implementation of the extension installation prompt. o Added new cross-platform implementations of the extension install error prompt. o Got rid of unused extension install strings from early implementations. o Added a string to display as the header of the error dialog, since it was inline English. Patch by Andrew Bonventre <andybons@gmail.com> BUG=19654 TEST=Install an extension on any platform, observe consistent visual behavior and messaging. Review URL: http://codereview.chromium.org/333015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30091 0039d316-1c4b-4281-b951-d872f2087c98
* video-error-abort.html is failing on mac after the last merge.tony@chromium.org2009-10-261-0/+1
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/335033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30089 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix browser action bubble arrow positions.derat@chromium.org2009-10-265-70/+95
| | | | | | | | | | | This also cleans up some of the InfoBubbleGtk code a bit. BUG=23373 TEST=tested LTR and RTL under metacity Review URL: http://codereview.chromium.org/332022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30088 0039d316-1c4b-4281-b951-d872f2087c98
* Mark flaky tests as flaky:phajdan.jr@chromium.org2009-10-262-2/+4
| | | | | | | | | | | | BookmarkHTMLWriterTest.Test (suspected resource flakiness) LoginPromptTest.TestTwoAuths TEST=none BUG=17592, 25794 Review URL: http://codereview.chromium.org/332024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30087 0039d316-1c4b-4281-b951-d872f2087c98
* Mark DOMStorageTest.SessionStorageLayoutTests as flaky.ojan@chromium.org2009-10-261-1/+3
| | | | | | | BUT=24145 Review URL: http://codereview.chromium.org/338024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30086 0039d316-1c4b-4281-b951-d872f2087c98
* This test is failing on linux only. Part of the last merge.tony@chromium.org2009-10-261-0/+1
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/337029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30085 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bad comparator. This caused lookups in std::map to be wrong.eroman@chromium.org2009-10-262-3/+76
| | | | | | | | | BUG=25823 TEST=HostCacheTest.KeyComparator Review URL: http://codereview.chromium.org/338023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30084 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in latest gyp.bradnelson@google.com2009-10-262-2/+2
| | | | | | | | | | BUG=None TEST=None TBR=gspencer Review URL: http://codereview.chromium.org/337028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30083 0039d316-1c4b-4281-b951-d872f2087c98
* CompactNavigationBar for toolkit views build, with some design change per ↵oshima@chromium.org2009-10-2623-48/+190
| | | | | | | | | | | | | | | | | Cole's request. * Swapped the positions of entry field and navigation buttons. * Hide navigation buttions when the entry field gains focus. - To implement this, I added OnKillFocus in AutocompleteEditController, and updated corresponding files. * Added accelerator (shift-ctrl-0) to toggle compact navigation bar Changes to BrowserExtender * Made all virtual methods in BrowserExtender pure virtual. * Added HideToolbar method to control visibility of toolbar from Extender. Review URL: http://codereview.chromium.org/329009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_shell_tests.exe runtime dependency.maruel@chromium.org2009-10-261-4/+0
| | | | | | | | TEST=build test_shell_tests only and run. BUG=none Review URL: http://codereview.chromium.org/335030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30081 0039d316-1c4b-4281-b951-d872f2087c98
* Merge from r50027:50073. Just some new tests failing.tony@chromium.org2009-10-262-1/+12
| | | | | | | | TBR=jorlow Review URL: http://codereview.chromium.org/332028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30080 0039d316-1c4b-4281-b951-d872f2087c98
* [mac] Send cmd-c and friends back to browser.thakis@chromium.org2009-10-262-5/+14
| | | | | | | | | | | | | | | | Fixes cmd-c, cmd-v, cmd-x, cmd-a. The menu blinking is worth the extra IPC hop. BUG=25254 TEST=Select text, hit cmd-c. "Edit" menu should blink. Hit cmd-v. "Edit" menu should blink again, correct text should be pasted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30045 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=30046 Review URL: http://codereview.chromium.org/330014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30079 0039d316-1c4b-4281-b951-d872f2087c98
* About box auto-update improvements.mark@chromium.org2009-10-2611-446/+758
| | | | | | | | | | | | | | | The About box now knows how to check to see if updates have been installed in the background without anyone having to click the Update button in the box. The About box no longer gets stuck in the "installed" state. Even if an update has been installed, the About box will still check for new updates when reopened. BUG=13165, 20488 TEST=Play with the about box and auto-update a whole lot Review URL: http://codereview.chromium.org/338012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30078 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusted timeouts for a couple failing tests; switched from umount to ↵kkania@google.com2009-10-264-57/+51
| | | | | | | | hdiutil detach to solve some unmounting problems seen on Tiger. Review URL: http://codereview.chromium.org/332030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30077 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in the latest gyp.bradnelson@chromium.org2009-10-261-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/329020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30076 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor widget methods to support desktop notifications, including GTK stubs.johnnyg@chromium.org2009-10-267-16/+79
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/307030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30074 0039d316-1c4b-4281-b951-d872f2087c98
* Fix fullscreen mode in chromeos=1 build.oshima@chromium.org2009-10-262-10/+37
| | | | | | | | | | | | | | * added member vars for main menu and compact navbar * show/hide main menu/compact navbar/status area upon fullscreen mode change. I'll work on linux_views as well. BUG=22805 TEST=Create new window from compact navbar menu, and toggle full screen mode Review URL: http://codereview.chromium.org/332027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30073 0039d316-1c4b-4281-b951-d872f2087c98
* Don't scale up small browser action icons.finnur@chromium.org2009-10-261-8/+5
| | | | | | | | | | | | | | | | | | | | | When creating the canvas, take cues from the image we just loaded and don't hard code it to 19x19. This way we can have smaller than 19x19 icons that show up centered within the browser icon button. This doesn't attempt to deal with scaling down images that are too large to fit the 19x19 canvas, but we haven't decided how to handle those anyway. BUG=25487 TEST=Load the api_test/browser_action_tab_specific_state extension and click on the browser action. The red square within the button should not grow in size as you click. Review URL: http://codereview.chromium.org/337026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30072 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adjust Omnibox implementation to not break undo chain.shess@chromium.org2009-10-264-1/+102
| | | | | | | | | | | | This does not fix undo, it just makes the implementation break it less. BUG=18084 TEST=Omnibox should continue to work. Review URL: http://codereview.chromium.org/337027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30071 0039d316-1c4b-4281-b951-d872f2087c98
* Update buildbot sample to work with newest APIs.aa@chromium.org2009-10-261-3/+3
| | | | | | Review URL: http://codereview.chromium.org/330015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30070 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when a page action cannot load its icon.aa@chromium.org2009-10-261-1/+2
| | | | | | | | | | | | | | | | | This can happen legitmately if the icon has been moved or corrupted on disk. I think we are hitting it too frequently for that to be the whole explanation, but since this code is moving around a lot shortly, it seems prudent to put in the quick fix and worry about what's really going on post-refactor. BUG=25601 TEST=Remove an extension's page action icon from its folder after installation. Should not crash when attempting to show page action. Review URL: http://codereview.chromium.org/339005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30069 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30062.glen@chromium.org2009-10-263-16/+9
| | | | | | Review URL: http://codereview.chromium.org/338022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30068 0039d316-1c4b-4281-b951-d872f2087c98
* Polish to the gmail checker sample.aa@chromium.org2009-10-264-24/+65
| | | | | | | | | | | | * New, crisper icons that are exactly 19x19 * Add a loading animation at the beginning before Gmail responds. * Fix a bug where we sometimes don't update the UI after a logout/login cycle. Review URL: http://codereview.chromium.org/338013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30067 0039d316-1c4b-4281-b951-d872f2087c98
* Move creation of SEH frame into a separate funcion.For any function that ↵stoyan@google.com2009-10-262-7/+17
| | | | | | | | | | uses SEH, the compiler creates a single EXCEPTION_REGISTRATION record at the function prolog (even if the function has nested or inside condition statement __try/__except constructs). When __try block is entered and leaved only the index to the relevant scope table is updated.When the exception occurs the __except_handler4 may ignore it if there is no scope table set i.e. we are outside __try block.In ChromeFrame when exception happens, the global vectored exception filter walks through the SEH chain and is misled that there is handler/filter installed and therefore skips creation of a crashdump. BUG=23845 TEST=crashes in ChromeFrame background threads are reported. Review URL: http://codereview.chromium.org/335011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30066 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in the WebKit code samplekathyw@google.com2009-10-262-2/+2
| | | | | | | | | | BUG=25804 TEST=none TBR=aa Review URL: http://codereview.chromium.org/333027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30065 0039d316-1c4b-4281-b951-d872f2087c98
* Set necessary args for tab_switching_test.chase@chromium.org2009-10-261-0/+4
| | | | | | | | | BUG=25200 TEST=running tab_switching_test in VS reports results Review URL: http://codereview.chromium.org/307047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30064 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Change the interface from HostResolver::DisableIPv6() to ↵eroman@chromium.org2009-10-265-14/+19
| | | | | | | | | | HostResolver::SetDefaultAddressFamily(), to make it more general. This came up in a codereview comment, but was after I had checked in. Review URL: http://codereview.chromium.org/303026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30063 0039d316-1c4b-4281-b951-d872f2087c98
* Lazily create the find bar.ben@chromium.org2009-10-263-9/+16
| | | | | | | | | http://crbug.com/21910 TEST=none Review URL: http://codereview.chromium.org/334019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30062 0039d316-1c4b-4281-b951-d872f2087c98
* Assertion failure fixoshima@chromium.org2009-10-261-3/+5
| | | | | | | | | | | | * Closing a submenu was hitting NOTREACHED in OnMenuHidden. * Changed to register OnMenuHidden callback only when we're about to open the menu, then disconnect it when closed. This is safer as the same menu can be used as submenu (although that's probably not great style) Review URL: http://codereview.chromium.org/328002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30061 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make Cmd-[ and Cmd-] work properly again.viettrungluu@chromium.org2009-10-262-80/+674
| | | | | | | | | | | | | I had accidentally made them open new tabs. I added a |-commandDispatchUsingKeyModifiers:| method to the browser window controller and made the back/forward buttons send this selector instead (this is how Toolbar.xib was changed). [N.B.: As of this writing, Cmd+Shift-back/forwards is broken, but that's a separate, non-Mac-specific, issue.] BUG=25810 TEST=Make sure Cmd-[ and Cmd-] work as expected (not opening history items in new tabs). Make sure back and forward buttons work properly (including while holding down Cmd and Cmd+Shift). Review URL: http://codereview.chromium.org/333026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30059 0039d316-1c4b-4281-b951-d872f2087c98
* Only double the buffer when AsyncResourceHandler's caller fill the buffer.erg@google.com2009-10-262-10/+16
| | | | | | | | | | | This is an update to r29904 and came out of a discussion with Darin. BUG=http://crbug.com/24493 TEST=NONE Review URL: http://codereview.chromium.org/335010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30058 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CERT_RDN_ENCODED_BLOB case to CertSubjectCommonNameHasNullwtc@chromium.org2009-10-261-0/+6
| | | | | | | | | | | | | | because we get CERT_RDN_ENCODED_BLOB on machines patched for the CryptoAPI ASN.1 security vulnerabilities. R=rvargas BUG=24190 TEST=the X509CertificateTest.PaypalNullCertParsing test in net_unittests (debug build) should not hit a NOTREACHED() assertion failure when running on a patched Windows machine. Review URL: http://codereview.chromium.org/337014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30057 0039d316-1c4b-4281-b951-d872f2087c98
* Update TOSlaforge@chromium.org2009-10-262-95/+99
| | | | | | Review URL: http://codereview.chromium.org/334027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30055 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 07:49:03 +0000