summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Make sure variables are referenced in CHECK macros, even for official builds.deanm@chromium.org2009-01-261-11/+13
| | | | | | | | | | | | | | Previously the GCC based builds couldn't build with OFFICIAL_BUILD, since code like: bool success = Something(); DCHECK(success); Would result in a compile warning (treated as error) about success being unused. Review URL: http://codereview.chromium.org/18747 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8630 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork test_shell_main:amanda@chromium.org2009-01-2617-716/+611
| | | | | | | | | | | | | | | | | - remove Mac version - move platform-specific operations into PlatformDelegate and remove #ifdefs - add event recorder link stubs for use by platforms that don't have event recording working yet Notes: There's a bunch of stuff in test_shell_{gtk,mac,win} that should also be pulled into the platform delegate so that the TestShell class can also be unforked, but those can be worked on independently per platform after this refactoring. Review URL: http://codereview.chromium.org/18451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8629 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8627,8625.maruel@chromium.org2009-01-2614-339/+745
| | | | | | Review URL: http://codereview.chromium.org/18598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8628 0039d316-1c4b-4281-b951-d872f2087c98
* Fix MSVC warning.phajdan.jr@chromium.org2009-01-261-1/+3
| | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/18594 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8627 0039d316-1c4b-4281-b951-d872f2087c98
* One test has been fixed in V8 bleeding_edge. Adding a comment to theager@google.com2009-01-261-1/+4
| | | | | | | test list to avoid duplicate work. Review URL: http://codereview.chromium.org/18593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8626 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up dns prefetch code, and also port it.phajdan.jr@chromium.org2009-01-2614-745/+337
| | | | | | | | BUG=5687, 6683 Review URL: http://codereview.chromium.org/15076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8625 0039d316-1c4b-4281-b951-d872f2087c98
* Update tests_fixable to catch regressions from merge 40124:40164.jhawkins@chromium.org2009-01-261-2/+4
| | | | | | | | Update tests_fixable to catch regressions from merge 40124:40164. Review URL: http://codereview.chromium.org/18584 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8623 0039d316-1c4b-4281-b951-d872f2087c98
* Small porting in chrome/phajdan.jr@chromium.org2009-01-267-13/+21
| | | | | | | | | This is actually http://codereview.chromium.org/18446 without process_watcher changes. Review URL: http://codereview.chromium.org/18724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8622 0039d316-1c4b-4281-b951-d872f2087c98
* Bump for 160 dev cyclemal@chromium.org2009-01-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8621 0039d316-1c4b-4281-b951-d872f2087c98
* Add user script support to extensions.aa@chromium.org2009-01-2512-102/+192
| | | | | | | | | | | | | | | This is implemented mostly by relying on the existing user script code. But since extension user scripts are declared, not discovered in a directory, I had to add support for adding 'lone' user scripts to UserScriptMaster. This led to a bit of refactoring. Note that this CL relies on: http://codereview.chromium.org/18352 Review URL: http://codereview.chromium.org/18198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8614 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix a IAT unpatch crash.deanm@chromium.org2009-01-242-58/+58
| | | | | | | | | | | | | The IAT destructor (which will unpatch) now should run at AtExitManager shutdown, which is before we return from main(). It was a static constructor (bad), which registers an atexit() destructor which happens sometime during ExitProcess / LdrShutdown. Also this removes some static constructors (the iat patchers, the throttle_queue, etc). I removed a StatsCounter completely, removing its static initializer. BUG=6886 Review URL: http://codereview.chromium.org/18712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8613 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the TabStripModelDelegate can never be NULL.ben@chromium.org2009-01-243-64/+68
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/18578 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8612 0039d316-1c4b-4281-b951-d872f2087c98
* Random de-Windows-ification-ism-izing in renderer_host.brettw@chromium.org2009-01-246-45/+48
| | | | | | Review URL: http://codereview.chromium.org/18577 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8611 0039d316-1c4b-4281-b951-d872f2087c98
* Do some cleanup in the resource message filter. Hopefully it will compile onbrettw@chromium.org2009-01-242-40/+86
| | | | | | | Linux and Mac now. Review URL: http://codereview.chromium.org/18740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8610 0039d316-1c4b-4281-b951-d872f2087c98
* No functional change. Delete trailing whitespace and word-wrap to 80 columns.evan@chromium.org2009-01-244-28/+36
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8609 0039d316-1c4b-4281-b951-d872f2087c98
* Do some header file cleanup of RenderWidgetHost. I moved everything to bebrettw@chromium.org2009-01-247-483/+476
| | | | | | | | private except the few functions that actually are overridden by RenderViewHost. Review URL: http://codereview.chromium.org/18739 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8608 0039d316-1c4b-4281-b951-d872f2087c98
* Passing one plugin test on Linux now.evan@chromium.org2009-01-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8607 0039d316-1c4b-4281-b951-d872f2087c98
* Two things:ben@chromium.org2009-01-2426-84/+136
| | | | | | | | | - remove views dependencies from browser by moving profile related dialog actions into BrowserWindow. - simplify the include dependencies in TabStripModel (making it easier to bring up on mac) by implementing more of its high level functionality in the delegate. Review URL: http://codereview.chromium.org/18736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8606 0039d316-1c4b-4281-b951-d872f2087c98
* revert r8603rvargas@google.com2009-01-2470-408/+231
| | | | | | Review URL: http://codereview.chromium.org/18576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8605 0039d316-1c4b-4281-b951-d872f2087c98
* Create a dialog box for the about:network view and kill the tab type.brettw@chromium.org2009-01-2411-454/+481
| | | | | | | | | This adds an AppendText method to the text field view. The job tracker stuff is just copied from the old network status file. Review URL: http://codereview.chromium.org/18728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8604 0039d316-1c4b-4281-b951-d872f2087c98
* Change URLRequest to use a ref-counted buffer for actual IO.The ref-counting ↵rvargas@google.com2009-01-2470-231/+408
| | | | | | | | will prevent the deletion / reuse of memorywhile the buffer is actually being used by pending IO.This seems a very intrusive change, but at least we will be ableto make sure that it works without having to chase every singledestruction of an URLRequest to make sure that any pending IOwas cancelled, and also allows us to avoid blocking onthe object destruction.BUG=5325 Review URL: http://codereview.chromium.org/18390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8603 0039d316-1c4b-4281-b951-d872f2087c98
* update list after mergetc@google.com2009-01-241-0/+20
| | | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/18573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8602 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of webkit merge to r40164.tc@google.com2009-01-247-17/+66
| | | | | | | | One file added between r40124 and r40164, however, all the worker files didn't seem to be in the xcode project so I added all of them. Review URL: http://codereview.chromium.org/18733 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8601 0039d316-1c4b-4281-b951-d872f2087c98
* Load plugin metadata (mime types, etc.) on Linux.evan@chromium.org2009-01-243-32/+64
| | | | | | | | | Verified to work with at least Flash 10. Review URL: http://codereview.chromium.org/18571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8600 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of CertStore on shutdown.sky@google.com2009-01-233-22/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18568 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8599 0039d316-1c4b-4281-b951-d872f2087c98
* Pull toolbar importer from trunk.brg@chromium.com2009-01-236-1251/+0
| | | | | | | This change was requested by personalization. Review URL: http://codereview.chromium.org/18550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8598 0039d316-1c4b-4281-b951-d872f2087c98
* Update the tests_fixable list for more tests passing on Linux.jhawkins@chromium.org2009-01-231-4/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8596 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing file from last checkin.brettw@chromium.org2009-01-231-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8595 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out the backing store from the RenderWidgetHost into its own file tobrettw@chromium.org2009-01-238-366/+505
| | | | | | | | | | | | | make porting easier. I also did some cleanup in the scrolling and painting areas, collapsing the confusing ScrollRect call inside OnMsgScrollRect to just be inside the function and call a new function on the backing store to scroll it. Same for painting. This also moves plugin window moving to the view. Review URL: http://codereview.chromium.org/18702 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8594 0039d316-1c4b-4281-b951-d872f2087c98
* ===================================================xji@chromium.org2009-01-2314-37/+173
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change list fixes the following 2 chrome bugs: 2821 RTL: Ellipsis appeared at right for RTL locales on "Task Manager - Google Chrome" dialog (http://crbug.com/2821) 6132: Strings in tables are displayed LTR when they should be RTL (http://crbug.com/6132) =================================================== Background: The above 2 bugs are related to Chrome task manager. Task manager is a TableView, which is a subclass of NativeControl. Currently, TableView window is created by using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, which is wrong. WS_EX_LAYOUTRTL | WS_EX_RTLREADING renders a RTL alignment but LTR reading order. Please see the following blog for detail: http://blogs.msdn.com/michkap/archive/2007/03/11/1857043.aspx We need to replace the above flag with WS_EX_LAYOUTRTL only. Consequently, we need to make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. For example, if the text in an URL, then the returned text should be explicitly marked as LTR text. Please note: there are several other places where we create RTL window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, such as AutoCompleteEditView (omnibox), MenuHostWindow, TextField (for example, text in bookmark dialog), and other NativeControl (including checkbox, combobox, native_button, radio_button, separator, tabbed_pane, and tree view). They all need to be fixed. And the following bug is filed for tracking. http://crbug.com/6573 =================================================== The fix is based on Idan's comments on bug 6132 1.create the table view with WS_EX_LAYOUTRTL (rather than WS_EX_LAYOUTRTL | WS_EX_RTLREADING) 2 Make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. If the text in an URL, then the returned text is explicitly marked as LTR text. Otherwise, the returned text is marked with LTR if it is RTL environment and there is no strong RTL character in the text. This is to avoid the wrong placement of (or wrong mirrored) ending-punctuation. =================================================== Since we have quite a few places creating window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING style. We decided to migrate to the right style step to step. This is the first step, and there is unnecessary function introduced by this change list. 1. I am using l10n_util::GetExtendedTooltipStyles() for the right style for now. And I marked a TODO there to obsolete this function name, replace with GetExtendedStyles eventually. (the l10n_util.h is no longer in the change list since I've checked it in with another CL). 2. I introduced native_control::GetAdditionalRTLStyle() which should replace GetAdditionalExStyle() eventually. =================================================== When wrapping text with LTR format in GetText(), ideally, we should parse the text to check whether this is a n URL or not (for example, a webpage title could be an URL, or user could add URL as search engine's name or keyword). I did not do that and only added a TODO there because I think that might be rare case and parsing the text might cause performance degradation. Review URL: http://codereview.chromium.org/18076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8593 0039d316-1c4b-4281-b951-d872f2087c98
* Six more layout tests in 'fast' folder.finnur@google.com2009-01-2317-33/+326
| | | | | | Review URL: http://codereview.chromium.org/18723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8591 0039d316-1c4b-4281-b951-d872f2087c98
* Update test lists to cleanup some rollbacks that happened by mistake in r8532.kuchhal@chromium.org2009-01-232-23/+9
| | | | | | Review URL: http://codereview.chromium.org/18730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8590 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Adjust the current experiment so that the cachervargas@google.com2009-01-231-15/+18
| | | | | | | | | | size is not limited by 1% of the disk space. Also, group four was limited by the mask so it was effectively the same as group 3. Review URL: http://codereview.chromium.org/18727 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8589 0039d316-1c4b-4281-b951-d872f2087c98
* Remove now-passing Linux layout tests from tests_fixable.jhawkins@chromium.org2009-01-231-32/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8588 0039d316-1c4b-4281-b951-d872f2087c98
* I'm relanding the UserDataManager leak fix. I didn't realize we hadsky@google.com2009-01-235-6/+9
| | | | | | | | | | | | | stubs for mac which needed to be updated too. This time I'll wait for the bots to finish compiling before committing. BUG=none TEST=none TBR=munjal Review URL: http://codereview.chromium.org/18566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8587 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome part of the Webkit related CL.jcampan@chromium.org2009-01-231-0/+1
| | | | | | Review URL: http://codereview.chromium.org/16815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8585 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts my user data manager change as it breaks the mac buildbot.sky@google.com2009-01-233-6/+4
| | | | | | | | | | BUG=none TEST=none TBR=munjal Review URL: http://codereview.chromium.org/18564 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8584 0039d316-1c4b-4281-b951-d872f2087c98
* Build image_diff tool on the Mac. Fix up a few other things that had becomemark@chromium.org2009-01-231-86/+269
| | | | | | | strange in chrome.xcodeproj. Review URL: http://codereview.chromium.org/18562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8583 0039d316-1c4b-4281-b951-d872f2087c98
* Install the npapi_test_plugin in the same way we did the layout_test one.evan@chromium.org2009-01-232-1/+7
| | | | | | | Review URL: http://codereview.chromium.org/18563 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8582 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of UserDataManager on shutdown.sky@google.com2009-01-233-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8581 0039d316-1c4b-4281-b951-d872f2087c98
* Adds switch to ui tests that enable dialogs in slave process. I'msky@google.com2009-01-231-3/+9
| | | | | | | | | | | adding this to make it easier to attach to a failing ui test. BUG=none TEST=none Review URL: http://codereview.chromium.org/18725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8580 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage by disabling testsben@chromium.org2009-01-231-12/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8579 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the safe browsing interstitial page support multiple unsafe ↵jcampan@chromium.org2009-01-2313-192/+662
| | | | | | | | | | | | | | | | | | | | | | | resources in one page. We had a bug when an interstitial was showing and another unsafe resource was detected. We would show another interstitial on top of the original one, causing the DontProceed method to be invoked several times. That would cause us to remove more than once an entry from the navigation controller and cause crashers. With this new CL, if an interstitial shows and a new resource is flagged as bad, the SafeBrowsingBlockingPage will queue that notification. If the user decides to proceed through the interstitial, we'll create another interstitial warning about all the unsafe resources we have received so far. This CL also contains a fix for a crasher that would happen when closing a tab with a safe browsing interstitial. BUG=5916,6207,6306 TEST=Test all actions in the interstitial you get when opening pages with the followin scenarios: - Main page is malware - Main page is fishing - Main page is OK contains resources (images,iframes...) which are malware - Main page is OK contains resources (images,iframes...) which are phishing - Main page is OK contains resources (images,iframes...) some of them phishing, some of then malware. Note that when there are more than one bad resource, it is normal to see a 1st interstitial, then another one listing all the other bad resources. (ex of malware site http://ianfette.org, phishing site http://cvisit.tripod.com) Review URL: http://codereview.chromium.org/18346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8578 0039d316-1c4b-4281-b951-d872f2087c98
* Prep for generated .vcproj files:sgk@google.com2009-01-2314-59/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix minor stylistic inconsistencies in some .vcproj files: * /> tag termination: net\net_resources.vcproj * Add empty <ToolFiles>, <References> and <Globals> sections: net\net_resources.vcproj third_party\zlib\zlib.vcproj third_party\libpng\libpng.vcproj chrome\tools\test\image_diff\image_diff.vcproj * Remove .\ on file names where its use is inconsistent with the rest of the file names in the .vcproj: net\build\net.vcproj net\build\net_unittests.vcproj chrome\installer\util\util.vcproj * Add explicit RootNamespace attribute: chrome\test\automation\automation.vcproj testing\gtest.vcproj * Fix file order in four locales that don't match other locale .vcproj files: chrome\app\locales\da.vcproj chrome\app\locales\he.vcproj chrome\app\locales\zh-TW.vcproj chrome\app\locales\en-US.vcproj * Remove duplicate files from the list: chrome\browser\views\browser_views.vcproj (event_utils.[ch]) Review URL: http://codereview.chromium.org/18555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8577 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r8486, which updates the manifestaa@chromium.org2009-01-2314-227/+449
| | | | | | | | | | | | | | | | | | | | | | | parsing in the Extension class to also parse out user script details. The problem was that extension_protocols.cc appears to link OK if you don't refer to anything in it, but as soon as you try to use something defined in it, a bunch of other symbols it refers to turn up undefined. To avoid this problem in the future, I stopped compiling extensions_protocol.cc so that we would realize if we tried to use it. Also in this change, I absolutified paths in ExtensionsService before creating Extension instances. On Linux, the path that PathService was giving us was not absolute. Review URL: http://codereview.chromium.org/18704 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8576 0039d316-1c4b-4281-b951-d872f2087c98
* Update test list to remove tests that are passing now and rebaseline one test.kuchhal@chromium.org2009-01-234-46/+47
| | | | | | | | | BUG=945322 Review URL: http://codereview.chromium.org/18721 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8575 0039d316-1c4b-4281-b951-d872f2087c98
* Keystone auto-update support for TestShellmark@chromium.org2009-01-235-5/+201
| | | | | | Review URL: http://codereview.chromium.org/18521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8574 0039d316-1c4b-4281-b951-d872f2087c98
* Importing pkg-dmg for all of your dmg packaging needs.mark@chromium.org2009-01-232-0/+1525
| | | | | | | Review URL: http://codereview.chromium.org/18521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8573 0039d316-1c4b-4281-b951-d872f2087c98
* Don't expose the go and star button views directly through the BrowserWindow ↵ben@chromium.org2009-01-2313-114/+102
| | | | | | | | interface (for porting). Review URL: http://codereview.chromium.org/18540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8572 0039d316-1c4b-4281-b951-d872f2087c98
* ui refresh from cole. make it look chromey and get the basic framework for ↵pinkerton@google.com2009-01-2321-446/+8067
| | | | | | | | the views we'll need. Review URL: http://codereview.chromium.org/18720 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8571 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 17:03:17 +0000