| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=321415
Review URL: https://codereview.chromium.org/65533016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=310768
Review URL: https://codereview.chromium.org/65413008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a WebRequestAPI BrowserContextKeyedService to observe EventRouter
for EventListener additions and removals.
This is part of the AppShell extensions refactor and will make it easier to
move extensions::EventRouter into src/extensions.
BUG=316367
TEST=unit test added, existing browser_tests
R=yoz@chromium.org
TBR=davemoore@chromium.org for trivial change to chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
Review URL: https://codereview.chromium.org/73193008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes several enum values that are unused, as well as handling
for CBF_BITMAP which is completely unused outside of test code.
BUG=319285
R=avi@chromium.org, creis@chromium.org, tony@chromium.org
Review URL: https://codereview.chromium.org/71963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When create fake app, we need to wait the animation.
R=skuhne@chromium.org
BUG=320143
TEST=browser_tests --gtest_filter=LauncherAppBrowserTest.*
Review URL: https://codereview.chromium.org/65413006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This makes it easier to find certain properties.
Review URL: https://codereview.chromium.org/63433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sync cycle might receive response from server that causes scheduler to
stop and draws pending_configure_params_ invalid. Check started_
before dereferencing pending_configure_params_ to avoid SEGFAULT.
BUG=320738
Review URL: https://codereview.chromium.org/62263003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When both are equal the display is somewhat visually noisy, so hide the original
proxy div if the strings are equal and show it again when they begin to differ.
You can test this by pressing 'reapply' on the proxy page, which will
temporarily cause the original and effective proxy to differ.
BUG=235998
TEST=adhoc
Review URL: https://codereview.chromium.org/61953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=321456
TBR=dubroy@chromium.org
Review URL: https://codereview.chromium.org/77573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
maximized.
This is done via the Ash WindowPositioner class. The change is in the WindowPositioner::GetBoundsAndShowStateForNewWindow
function which for windows returns SHOW_STATE_MAXIMIZED if this is the first window being opened.
Based on a discussion with oshima, I enabled the WindowSizerAshTest ash unit tests for Windows. There were a number
of places in the WindowSizer class where we were allowing browsers to be in ASH only for Chrome OS. Checking for
the host desktop type should be enough. This was needed to get the window to be maximized for ASH.
Fixes bug http://crbug.com/231603
BUG=231603
R=cpu@chromium.org, oshima@chromium.org, sky@chromium.org, cpu, oshima, sky
Review URL: https://codereview.chromium.org/62333015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We probably should use uint16 for SubsampleEntry::clear_bytes to be consistent
with BMFF Common Encryption spec. But I'd keep this CL minimal so that it's
easier to merge.
TBR=ddorwin@chromium.org
BUG=317999
TEST=none
Review URL: https://codereview.chromium.org/61763024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a rework of r231910. Instead of putting the detachable logic in
AsyncResourceHandler, move it to a wrapper DetachableResourceHandler. On
detach, it simulates a cancel to the ResourceHandler it wraps and then
continues to drain the request itself. This should have fewer buffering
complications.
BUG=286186
TEST=ResourceDispatcherHostTest.Cancel,
ResourceDispatcherHostTest.DetachedResourceTimesOut,
ResourceDispatcherHostTest.DeletedFilterDetached,
ResourceDispatcherHostTest.DeletedFilterDetachedRedirect,
ResourceDispatcherHostTest.DetachWhileStartIsDeferred
ResourceDispatcherHostTest.TestProcessCancelDetachedTimeout,
ResourceDispatcherHostTest.CancelRequestsForContextDetached,
ResourceDispatcherHostTest.DataSentBeforeDetach
Review URL: https://codereview.chromium.org/59783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This test is failing very consistently on Linux aura.
BUG=321451
TBR=kalman@chromium.org
Review URL: https://codereview.chromium.org/77533002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui.
See also https://codereview.chromium.org/66993003/ for relevant LGTMs.
BUG=273710
TBR=creis@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/58963004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
difference from the ideal scale. This meant that in the worst
case our only available high-res tiling was 2X the required
resolution.
This patch adjusts the creation of new tilings, to ensure we
always have a tiling option that is less-than-or-equal-to
the current ideal scale.
BUG=307206
Review URL: https://codereview.chromium.org/27251002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This test is failing quite a bit on Linux Aura.
BUG=321448
TBR=kalman@chromium.org
Review URL: https://codereview.chromium.org/77223003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=320054
R=stevenjb@chromium.org
TEST=manually
Review URL: https://codereview.chromium.org/76673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/76553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(rather than calling into ChromeShellDelegate each time)
Clean up unused enum values.
BUG=
Review URL: https://codereview.chromium.org/75583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=231331
TEST=none
Review URL: https://codereview.chromium.org/71383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Include sandbox/linux/services/linux_syscalls.h to make sure that
all system calls are defined.
Also only build demo.cc for x86 which is the only platform it has been
built for.
BUG=321363
TBR=markus
Review URL: https://codereview.chromium.org/63943007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=320910
R=rsesek@chromium.org
Review URL: https://codereview.chromium.org/75543008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/76583002/ adds support for the flag. Turning on this flag means that the boto file would get overridden to "", and no boto file will be loaded. This is fine because chromium-gn is public readable.
BUG=321254
Review URL: https://codereview.chromium.org/75283003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Adding logging to CastEnvironment.
2. Actually triggering logging within the cast library.
3. Adding thread checks.
4. Removing trace calls outside of the logging class.
Open issues:
1.Use of rtp_timestamp and frame id is not consistent.
In addition, the AudioBus does not include these values.
2. There is a pending cl to switch frame_id to int. This cl does not include that.
3. There are a few more places to add logging.
As this cl is already big enough, all of the above will come in a follow-up cl.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236034
Review URL: https://codereview.chromium.org/69603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=319527
Review URL: https://codereview.chromium.org/59823009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change does three things:
(1) Remove flags for Instant Extended. Instant Extended is now always on.
(2) Add a separate flag to control query extraction. Also rename
suppress_on_srp to query_extraction to make its purpose clearer.
(3) Assorted cleanup resulting from (1) and (2).
Note that a lot more code (especially in search.cc) can be cleaned up and I
will address that in follow up changes. Attempting to keep this from
snowballing into a huge CL.
BUG=297915
Review URL: https://codereview.chromium.org/73613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
position.
The code path had not been updated to provide animation in the correct axis when the shelf was vertical, resulting in labels to be offset by an incorrect amount (most visible in the IME label).
BUG=316635, 307116
Review URL: https://codereview.chromium.org/68373006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we start using gin from other projects but mojo, we want to be
extra careful what we include. Therefore, we introduce a public/
directories with headers that are ok to be included from gin-embedders.
As a start, we move wrapper_info.h into public/.
BUG=317398
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/69293015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The native CommandLine lives in base, and so too should the Java wrapper. Move
CommandLine.java to base, updating all references and factoring out previously
contained switches to BaseSwitches and ContentSwitches.
BUG=320747
TBR=ajwong@chromium.org
Review URL: https://codereview.chromium.org/62333025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=246274
TEST=covered by test
Review URL: https://codereview.chromium.org/72903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CVV challenge fields need to be validated before accepting.
BUG=315212
TEST=Force CVV challenge, enter invalid CVV, click 'Continue'/'Validate'. The CVV field should be highlighted, the dialog should not be dismissed.
R=isherman@chromium.org
Review URL: https://codereview.chromium.org/64553018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Rotate vk display 180 for easier experiment
>
>
> BUG=319493
>
> Review URL: https://codereview.chromium.org/62103019
TBR=bshe@chromium.org
Review URL: https://codereview.chromium.org/77393002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
there are no known_disabled extensions.
As it is now we don't report neither Extensions.KnownDisabledReDisabled:0, nor Extensions.KnownDisabledInitialized, when there are no known_disabled and no currently disabled_extensions.
This CL makes it so that we always report either and will result in an increase of the number of 0 reports for Extensions.KnownDisabledReDisabled.
Review URL: https://codereview.chromium.org/76533002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=321209
TEST=spring boots, video works, histogram shows video acceleration enabled.
Review URL: https://codereview.chromium.org/76393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=319493
Review URL: https://codereview.chromium.org/62103019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=319477
R=aedla@chromium.org, creis@chromium.org, jln@chromium.org
Review URL: https://codereview.chromium.org/73833004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use VLOG(1) instead of LOG(WARNING) for the following
messages:
[1100:1268:1009/125256:WARNING:dns_socket_pool.cc(85)]
Failed to connect socket: -109
[15162:16935:1031/172646:WARNING:address_sorter_posix.cc(305)]
Could not connect to <address> reason -109
BUG=305883
Review URL: https://codereview.chromium.org/76073004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/74663002 updated the setting from
setTextAutosizingontScaleFactor to setAccessibilityFontScaleFactor.
This patch is the chromium-side update to the new API.
This depends on https://codereview.chromium.org/74663002 landing.
BUG=320193
Review URL: https://codereview.chromium.org/75793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes ProcessedStudy a class with accessors, rather than a struct and
adds an Init method. Moves ValidateStudyAndComputeTotalProbability()
to processed_study.cc.
BUG=315807
Review URL: https://codereview.chromium.org/75553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=315315
Review URL: https://codereview.chromium.org/61213011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed unused result warning of fwrite call.
> Allow TracingController output trace data to specified file
>
> Sometimes we need to let TracingController output traces to specified
> file, e.g. trace-startup (which will be migrated from TraceController
> to TracingController).
>
> Also fixed the problem of IO operations in UI thread.
>
> BUG=none
> TEST=TracingControllerTest.EnableAndDisableRecordingWithFilePath
> TEST=TracingControllerTest.EnableCaptureAndDisableMonitoringWithFilePath
> R=joi@chromium.org, nduca@chromium.org
>
> Review URL: https://codereview.chromium.org/66893003
This reverts commit 5f0d8c08989b900b61f7be1ee97d3c237dba4a76.
TBR=yzshen
BUG=none
Review URL: https://codereview.chromium.org/77273003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step for moving ui.gyp into ui/base/
After this lands, Blink will be updated to reference the new file under
ui/resources.
Then the by-pass target will be removed from ui.gyp. And then we can
move it to its finall location.
BUG=299841
TEST=None
R=ben@chromium.org
Review URL: https://codereview.chromium.org/74853003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for event dispatches.
Delete some hooks for logging adding/removing listeners that were ifdefed out.
BUG=316367
Review URL: https://codereview.chromium.org/66773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=309578
Review URL: https://codereview.chromium.org/65533014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Docs preview here:
https://chrome-apps-doc.appspot.com/_patch/65063002/apps/contextMenus.html
https://chrome-apps-doc.appspot.com/_patch/65063002/extensions/contextMenus.html
BUG=316294
Review URL: https://codereview.chromium.org/65063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As this function is used to format a volume (a partition on a storage device),
rather than a device.
BUG=316526
TEST=none
R=benwells@chromium.org
Review URL: https://codereview.chromium.org/65503004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move some non-event related functionality from RootWindow onto RootWindowHost.
>
> - Transform logic
> - Compositor
>
> R=sky@chromium.org
> http://crbug.com/308843
>
> Review URL: https://codereview.chromium.org/70103020
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/77233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Rename RootWindowHost* to WindowTreeHost*
>
> TBR=sky@chromium.org
> http://crbug.com/308843
>
> Review URL: https://codereview.chromium.org/76583003
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/77203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236093 0039d316-1c4b-4281-b951-d872f2087c98
|