| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
- Use ScopedVector<T> instead of std::vector<T*> for owning semantics.
- Change GetStorageForBytes() to take a void* to get rid of ugly casts.
- Use SetString in SetURL to get rid of duplicate lines.
- Clean up templates for getting storage for a string.
Review URL: https://chromiumcodereview.appspot.com/14787013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I think this might have worked at some point but now returning kLostContext from HandleSwapBuffers is not enough so call LoseContext if SwapBuffers fails.
BUG=240434
Review URL: https://chromiumcodereview.appspot.com/14649023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Position the dialog underneath the bookmarks bar rather than the omnibox
so that it doesn't block the bookmarks bar, as navigation should be
fully supported when the dialog is displayed.
Screenshot at http://crbug.com/237640#c3.
BUG=237640
Review URL: https://chromiumcodereview.appspot.com/14611015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Showing the find bar after an instant page was committed wouldn't work.
The problem was that switching surface order wasn't not implemented.
BUG=240545
TEST=Did a search and pressed Command-F. Verified that the find bar
was visible.
Review URL: https://chromiumcodereview.appspot.com/14773028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/15030005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some web application uses Ctrl+Space short cut, e.g. Google Docs use it as row
selection in column short cut. So let's pass Ctrl+Space keyboard event to them
if there is only one input method is available.
BUG=240196
TEST=Manually checked on lumpy
Review URL: https://chromiumcodereview.appspot.com/14693003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=237998
TBR=tommi
Review URL: https://chromiumcodereview.appspot.com/14863012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The "clean" make rule wasn't cleaning for all toolchains.
BUG=none
R=sbc@chromium.org
Review URL: https://codereview.chromium.org/15017017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
will greatly reduce the amount of work that cronjobs need to do. They might even
finish without timing out.
R=cduvall@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/15181002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also makes the UI show report.id instead of report.type+report.id now that the id for stat objects are unique.
BUG=https://code.google.com/p/webrtc/issues/detail?id=1767
Review URL: https://chromiumcodereview.appspot.com/15035008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Requires https://codereview.chromium.org/15067010/ before landing)
TBR=jam@chromium.org
R=cpu@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/14995016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace ResourceMetadata::IterateEntries() with GetIterator().
Add thread assertion in ResourceMetadataStorage::Iterator.
Rename existing test to ResourceMetadataTestOnUIThread.
Add new test ResourceMetadataTest for methods running on the blocking task runner.
BUG=238999
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/14864029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The video binaries committed in https://src.chromium.org/viewvc/chrome?view=rev&revision=198317 were not identical to the ones uploaded for previous code review.
TBR=kbr@chromium.org
BUG=221498
Patch by Yuli Huang <yuli@chromium.org>.
Review URL: https://codereview.chromium.org/14817006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=frankf@chromium.org
NOTRY=True
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/14635005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
kCompositeToMailbox and kEnableSoftwareCompositingGLAdapter
need this. kEnableCompositorFrameMessage itself will eventually get
deprecated.
BUG=230226
Review URL: https://chromiumcodereview.appspot.com/14861015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:239969
TEST=Validated the xml, pretty print succeeded.
Review URL: https://chromiumcodereview.appspot.com/15039025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=225781
TEST=visited the following site:
http://html5doctor.com/demos/video-canvas-magic/demo1.html
Visit http://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_canvas_drawimage_video.
Canvas painting still works.
Review URL: https://chromiumcodereview.appspot.com/14787012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This API call was not being used.
Review URL: https://chromiumcodereview.appspot.com/14741010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not visible
Allow WebContentsModalDialogHost to provide the parent window for the
web contents modal dialog. This is where the responsibility for knowing
which window to use most naturally lies, and it avoids the problem of
being unable to determine the parent when the WebContents is not visible
at dialog creation.
BUG=157161, 238392
R=ben@chromium.org, erg@chromium.org, sail@chromium.org
Review URL: https://codereview.chromium.org/15012017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
VCS metadata.
Review URL: https://chromiumcodereview.appspot.com/14949016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a bunch of functions to SpdyStream to help manage
stream ownership.
Reduce the number of active_streams_ lookups in SpdyStream.
Make SpdyStream::~SpdyStream() non-virtual.
BUG=178943
R=rch@chromium.org
Review URL: https://codereview.chromium.org/15129003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a speculative fix for bug 237917.
BUG=237917
TEST=None
R=dennisjeffrey@chromium.org
Review URL: https://codereview.chromium.org/14962005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It needed the bytes_read in the ReadFile param.
NOTRY=true
R=scottmg
BUG=237249
TEST=link.exe no longer crashes
Review URL: https://chromiumcodereview.appspot.com/15180002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested this with the PNaCl translator, and it seems to work.
Perhaps this was disabled before because nacl_io wasn't
building with PNaCl?
NOTRY=true
BUG=none
Review URL: https://chromiumcodereview.appspot.com/14655019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[In this reland, manually load the browser dll as a resource on Windows.]
Previously, whenever the theme or history database format were modified, a
large binary database or pak file had to be committed. This was only done
intermittently, messing up some perf expectations. Since last June, this
has added over 100 megabytes to our repository weight.
By generating the SQLite databases and Cached Theme.pak files at startup
of the one test suite that uses them, we're guaranteed that we'll always
be using the current versions and won't add upgrade costs to our
performance_ui_tests. We'll also not continuously add to new binary
resources to the permanent git archive.
BUG=111570
TBR=sky@chromium.org
First Review: https://codereview.chromium.org/14273023
Review URL: https://codereview.chromium.org/14585015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=True
BUG=None
TEST=Ran the tests locally.
Review URL: https://chromiumcodereview.appspot.com/15050004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starts using the Dialog as the base class and rewrites AutofillDailogCOntentView
as AutofillDialogView that contains the title and the footer with the buttons.
BUG=180980
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14886012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14937005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug that the test cases' Init method indicates success even if the required interfaces aren't implemented. Although this doesn't happen in our own code base, it seems like a good idea to make it correct. It came up in another CL for video source and destination hosts (15039009)
BUG=79375
Review URL: https://chromiumcodereview.appspot.com/14698016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test is hanging on chromeOS and causing invocations of pyauto_perf
to fail only after hitting a very long timeout.
Disabling until the problem is addressed.
BUG=chromium:233706
TEST=None
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14617020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The (deprecated) NaClDescIoDescMakeFromHandle used to assume the
given file handle was opened read-write, which breaks mmap on
Windows when the file is opened read-only.
In this change, FileIO::RequestOSFileHandle now passes the actual
open flag to the new NaClDescIoDescFromHandleAllocCtor.
BUG=183015
Review URL: https://chromiumcodereview.appspot.com/14836003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks compile on Linux ChromiumOS Builder
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/42709/steps/compile/logs/stdio#error1
TBR=zmo@google.com
BUG=232556
Review URL: https://codereview.chromium.org/15175004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Try to reland r199530 after fixing an issue that causes Mac Debug to crash when switching GPUs.
The original review can be found here: https://codereview.chromium.org/14794006/
BUG=232556
TBR=joi@chromium.org, kbr@chromium.org, piman@chromium.org
Review URL: https://codereview.chromium.org/14981007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The function is used only from CreateFileOperation.
It should not be exposed as a public file system interface.
BUG=236771
Review URL: https://chromiumcodereview.appspot.com/15124002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A previous change removed the building of libppapi
within the SDK but the trybots didn't detect this
because of the use of wildcards in the SDK build process
to install libraries (a fix is on the way for that too).
BUG=
R=binji@chromium.org
Review URL: https://codereview.chromium.org/14844007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of decoupling chrome/browser/chromeos/input_method dependency.
BUG=None
TEST=Try bots
Review URL: https://chromiumcodereview.appspot.com/14609003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to make way for the flag that will control the unprefixed API that
will be coming soon.
BUG=239485
R=darin@chromium.org, grt@chromium.org, scherkus@chromium.org
Review URL: https://codereview.chromium.org/14582024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, GCF+Aura parented the ChromeFrameAutomationClient window
directly to the DesktopRootWindowHostWin window. This caused some focus
warping (and possibly other) issues when SetParent was called again.
BUG=235411
Review URL: https://chromiumcodereview.appspot.com/14927013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(otherwise, presubmit whines about copyright now matching because it
contains \r)
I'm not 100% sure this will fix the problem because something will
do line ending changes, but... we will see.
TBR=cpu@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/14655021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=179951
Review URL: https://chromiumcodereview.appspot.com/14969010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Base: Disable the scoped handle verifier.
>
> This is intended for the M28 beta branch.
>
> BUG=240766
> TEST=none
> TBR=cpu@chromium.org
>
> Review URL: https://codereview.chromium.org/14979005
TBR=rvargas@google.com
Review URL: https://codereview.chromium.org/14578009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Re-adding https://chromiumcodereview.appspot.com/13932008/ (reverted it before M28 cut).
BUG=229829
Review URL: https://chromiumcodereview.appspot.com/14988006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out iOS does not support the unprefixed version.
BUG=239502
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/14682024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Library code shouldn't be choosing the allocator used by the executable.
The comment talks about a v8 heap profiling extension that was removed
by jar in r132841, so we shouldn't need this dependency anymore.
TBR=eugenis@chromium.org
BUG=112389
Review URL: https://codereview.chromium.org/15167002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=samarth
BUG=240852
Review URL: https://codereview.chromium.org/15123004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for the private additions to the Public Suffix List.
* Since net::RegistryControlledDomainService only contained static methods, this
CL changes these methods to be contained within the namespace
net::registry_controlled_domains and removes the class entirely.
* All methods defined as part of net::registry_controlled_domains now
have a mandatory argument to specify whether the private registries
should be included.
* Since the old implementation did not take into account the private
registries, this sets all old callers to use EXCLUDE_PRIVATE as the
net::registry_controlled_domains::PrivateRegistryFilter argument.
* Changes the parameter for including unknown registries or not to be an enum
instead of a boolean, using a similar naming scheme as for the private
registries: net::registry_controlled_domains::UnknownRegistryFilter.
* This also updates the effective-TLD data file to:
45cfff9c781f 2013-04-23 11:51 +0100
It includes changes from a number of Mozilla bugs, listed on
https://hg.mozilla.org/mozilla-central/log/45cfff9c781f/netwerk/dns/effective_tld_names.dat
between 290afd57d2a8 (2012-07-04 16:08 +0100) and
45cfff9c781f (2013-04-23 11:51 +0100).
Patch set 1 is equal to the committed patch set from:
https://codereview.chromium.org/13979002/
TBRing OWNERs from original CL.
TBR=pam@chromium.org
BUG=37436, 96086
Review URL: https://codereview.chromium.org/15140003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Metrics may have regexp characters requiring escaping, such as:
ImageDecoding_avg_by_url/image_decoding.html?gif
Example of the fix:
http://chromeperf79.chrome.corp.google.com:8028/builders/linux_bisect/builds/185
BUG=233580
Review URL: https://chromiumcodereview.appspot.com/14772033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended for the M28 beta branch.
BUG=240766
TEST=none
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/14979005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DownloadItem had both a Resume() method and a
ResumeInterruptedDownload() method. The former was used for paused (and
potentially interrupted) downloads while the latter was used for
interrupted downloads.
This change makes ResumeInterruptedDownload() internal to
DownloadItemImpl and only exposes Resume() as a public method on
DownloadItem. This should reduce confusion in the API. Resume() also
correctly resets the auto-resume count for a DownloadItem.
BUG=7648
Review URL: https://chromiumcodereview.appspot.com/14954002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200061 0039d316-1c4b-4281-b951-d872f2087c98
|