| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Along the way, refactor some related code.
BUG=now
TEST=manually
Review URL: http://codereview.chromium.org/1605029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use ISO 639-1 language code for input method indicator.
- Do not use raw language codes in the drop-down menu.
BUG=crosbug.com/2428
BUG=crosbug.com/2564
TEST=manual
Review URL: http://codereview.chromium.org/1622025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
document or query params.
We should only remove the icon when visiting a new origin or the underlying setting has changed.
BUG=40742
Review URL: http://codereview.chromium.org/1640004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At this moment, this requires a browser restart, thus shows
a dialog about it.
DPENDS_ON http://codereview.chromium.org/1595026/show
BUG=crosbug.com/2336
TEST=manually
Review URL: http://codereview.chromium.org/1645007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the UI by Options->Change AutoFill settings->click on an
address->click on "Make this my default profile" flag.
( Original patch by raz@chromium.org )
BUG=41247
TEST=Set this pref in one browser, sync it in the other
Review URL: http://codereview.chromium.org/1612019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=confirmed it worked on linux and didn't break the windows build by trybots
BUG=none
Review URL: http://codereview.chromium.org/1595026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recently the tarball got approx. 2x bigger because of that.
TBR=nsylvain
TEST=none
BUG=29044
Review URL: http://codereview.chromium.org/1545036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Startup perf was not impacted in an earlier test run, so this should be safe.
BUG=38182
Review URL: http://codereview.chromium.org/1530031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19113
TEST=Right border has correct color
Review URL: http://codereview.chromium.org/1518027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed Control+space since it's just for testing. Added Alt+~ which is popular for Japanese IME users on Windows.
We will add more hot-keys like 'Right-Alt+Right-Shift' and 'Zenkaku_Hankaku' later (in a separate CL).
BUG=crosbug/492
TEST=manual
Review URL: http://codereview.chromium.org/1593026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I added this method to webkit_glue in r44435, but forgot to
add it to this file.
Review URL: http://codereview.chromium.org/1566042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, remove "Cance" button. If really needed,
we could adding support for canceling in the future.
BUG=crosbug.com/2074
TEST=manually
Review URL: http://codereview.chromium.org/1612018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is called after Start().
BUG=41359
TEST=unittests
Review URL: http://codereview.chromium.org/1547033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, the logic for UI language switching is not yet implemented.
Will add the logic in a separate patch.
TEST=manually
BUG=crosbug.com/2336
Review URL: http://codereview.chromium.org/1652002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reason the assert is no longer valid is that browser tests no longer
run a nested message loop.
BUG=none
TEST=none
TBR=suzhe@chromium.org
Review URL: http://codereview.chromium.org/1645006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a test run to see how it impacts startup perf (if any).
BUG=38182
TBR=chase
Review URL: http://codereview.chromium.org/1595027
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/1560034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a test run to see how it impacts startup perf (if any).
BUG=38182
TBR=chase
Review URL: http://codereview.chromium.org/1595027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
certificate_authorities list, it means client certificates issued by
any CA are acceptable. NSS_CmpCertChainWCANames returns SECFailure
in that case, so we need to test for that case.
Improve error code mapping.
Add a comment to note new NSS functions we can use in the future, and
add a missing LeaveFunction call.
R=agl
BUG=16830
TEST=Visit a server that sends a CertificateRequest message with an
empty certificate_authorities list. The client certificate selection
dialog should pop up with all client certificates shown as eligible.
Review URL: http://codereview.chromium.org/1589034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build on linux 64
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19113
TEST=none
Review URL: http://codereview.chromium.org/1547032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1654001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19113
TEST=scale up by 4x and watch right edge for texel wrap.
Review URL: http://codereview.chromium.org/1560032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This encapsulates differences between the language codes used in
InputMethodDescriptor and Chrome's application locale codes.
TEST=unit_tests
BUG=crosbug.com/2336
Review URL: http://codereview.chromium.org/1611026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to move the chrome specific version informaton used by
Linux into src/chrome.
Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome.
In src/webkit/glue, add a new glue method for getting the product version. When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell.
Review URL: http://codereview.chromium.org/1560027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
threading support needed for Safari on 10.6.
Review URL: http://codereview.chromium.org/1622023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
isn't completely fixed yet.
TBR=jrg@chromium.org
BUG=40429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IMoniker patch is enabled.
TBR=amit
Review URL: http://codereview.chromium.org/1575039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1604031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
but enabled on other platform.
new-run-webkit-websocketserver won't run on Windows
because of https://bugs.webkit.org/show_bug.cgi?id=37518
BUG=40976,40995,41319
TEST=trybots pass
Review URL: http://codereview.chromium.org/1630019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Parses the json file
BUG=27885
TEST=test modified
Review URL: http://codereview.chromium.org/1609022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes things so that they now work 'naturally', i.e switch
to chrome frame looks just like switching to pdf. The same bind context
and underlying network transaction objects are used and requests aren't
sent multiple times. Finally the TestPostReissue test is happy!
This patch fixes two issues with earlier scheme:
Issue 1: data can be read only once from a given bind context. Mshtml
looks at the mime type in the FORMATETC but never issues a read. So when
it switches, the new active document can read from start. Since we are
reading the data for switching, when we actually switch, we have to
transfer over the data read so far to our UrlmonUrlRequest.
Issue 2: The very first UrlmomUrlRequest has to start binding right away,
in the context of BindToStorage or network transcations associated with
the bind context are gone (due to OnStopBinding for BindToObject).
TEST=covered by existing tests
BUG=33332
Review URL: http://codereview.chromium.org/1508033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill suggestions from the AutoFillManager.
BUG=41378
TEST=none
Review URL: http://codereview.chromium.org/1633011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessing members of a destroyed object while unwinding the callstack.
BUG=41274
TEST=Run Chrome with full page heap on. Clicking an item in the omnibox dropdown should not crash.
Review URL: http://codereview.chromium.org/1566040
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/1589033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=30242
TEST=Go to this page:
http://weston.ruter.net/projects/test-cases/chrome-mp3-audio-crash/
Click play and it won't hang.
Opening (not) too many audio streams in Leopard will cause a
deadlock in AudioQueue, freezing the browser process. Unfortunately
there isn't a way to detect that in the AudioQueue API. So this
change limits the number of streams allowed.
The limit for Leopard is set to 15 and other OSes are 50.
Review URL: http://codereview.chromium.org/1559024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40902
TEST=Go to a folder with not enough items to show a vertical scrollbars. Copy and paste items so that the scrollbar is shown. The scrollbar should be next to the window edge. Also try resizing the window.
Review URL: http://codereview.chromium.org/1625013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See screen cap in bug.
BUG=41356
Review URL: http://codereview.chromium.org/1642006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= 37564
TEST= start Chrome with --first-run enabled -- you should see a new search engine selection dialog.
Review URL: http://codereview.chromium.org/1586005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Technically, this still isn't centered (there's one more pixel below the
icon then there is over it). But being off-center one pixel up looks better
than being off-centere one pixel down. (And both look better than the
current trunk.)
BUG=41189
TEST=none
Review URL: http://codereview.chromium.org/1568031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoginDatabase"
This reverts commit 2fa9a35a2e607688e7c2f8908c0d1e4c31ff5c96.
TBR=stuartmorgan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1545033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The extension bubble animation would trigger an infinite loop of resizing of the web content between two heights. By deferring the call to render_widget_host->WasResized() it seems to allow the height to settle and gets rid of the flickering. This was mostly prevalent on 10.5, but occasionally showed up on 10.6 when using devtools to inspect the popup.
BUG=31970
TEST=Using RSS extension, open the rss popup at www.aaronboodman.com
Review URL: http://codereview.chromium.org/1596013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jcivelli
Review URL: http://codereview.chromium.org/1606018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builder. This test creates a temporary file name and feeds
the path to the SaveAs dialog put up by Chrome. If the file already existed the test fails. The other problem was that Chrome appends
the .htm extension to the path passed in which caused the subsequent GetFileAttributes expectation to fail.
Fix is to replace the .tmp extension in the temporary file name with .htm and to delete the file initially before starting the test.
This test is still marked as flaky as it expects programmatic keyboard input.
Review URL: http://codereview.chromium.org/1613015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
error check clearer.
BUG=41380
TEST=ExtensionApiTest.CaptureVisibleTab
Review URL: http://codereview.chromium.org/1545031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of using WebDataService. Once PasswordStoreWin is migrated as well,
PasswordStoreLinux will likely be folded back into PasswordStoreDefault.
BUG=35038
TEST=PasswordStoreLinuxTest.*
Review URL: http://codereview.chromium.org/1525026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a destroyed object while unwinding the callstack.
BUG=41274
TEST=Run Chrome with full page heap on. Clicking an item in the omnibox dropdown should not crash.
Review URL: http://codereview.chromium.org/1566040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
r44150 is a fix for r43882. r43882 is a bugfix to include the idle sockets in the socket limit and close them when we hit the limit. Including the idle sockets in the socket limit check make us hit the socket limit more often, which exposed some bugs in the existing code. These two patches may also have introduced some separate crashes of their own (it's unclear from the stacktraces). I'm reverting them for now to mitigate the crashes.
BUG=32817,41228
Review URL: http://codereview.chromium.org/1657001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Tint highlighted icons (the *_DARK variety) the color of highlighted text.
- Use new variants of the IDR_OMNIBOX_HTTP* and IDR_OMNIBOX_HISTORY* icons in
GTK mode where there isn't a white background.
BUG=41189
TEST=none
Review URL: http://codereview.chromium.org/1559029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40604
TEST=Do something that shows an infobar (e.g. go to youtube and kill flash). Switch to and from fullscreen, resize window. Infobar text should stay visible. For infobars with links (e.g. geolocation infobar), the link should still show a hand cursor.
Review URL: http://codereview.chromium.org/1654004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on IE8. It appears that the OnUpdateTargetUrl
notification is not received at times on IE8.
TBR=amit
Review URL: http://codereview.chromium.org/1612015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44399 0039d316-1c4b-4281-b951-d872f2087c98
|