| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows and linux, but is drawn nearly completely with vectors.
Also fix the SkColor->NSColor conversion in the mac theme provider.
Also let status bubble text color be influenced by current theme.
BUG=18902,18438
TEST=Download items now look like on windows. Color of the main download item text should change with the theme. Also, the status bubble text now adapts to the theme, and themes that specify text colors can now successfully change the color of e.g. the text in tabs. Also check that the status text ("104.0/110 MB, 1 h 45 secs left") is elided at the right when it's too long.
Review URL: http://codereview.chromium.org/192033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The resulting PDF file will now be passed to the browser and be saved as "chromium_printing_test.pdf" under current directory.
BUG=9847
TEST=printing on linux should now generate chromium_printing_test.pdf in download directory. Printing on Windows should still work.
Patch contributed by minyu.huang@gmail.com
Review URL: http://codereview.chromium.org/172115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Made a local run for 25 times, got no single failure.
BUG=http://crbug.com/21108
TEST=none
Review URL: http://codereview.chromium.org/200040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/202005
BUG=17229
Review URL: http://codereview.chromium.org/200039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The spec says that calling realloc(ptr, 0) should free ptr
and return NULL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved versions of those files from sandbox/src/ to base/ (overwrite versions in
base/ to avoid 64-bit warning).
Removed 'sandbox' namespace, adapted other files as necessary.
BUG=8348
TEST=none
Original review URL: http://codereview.chromium.org/179039
Patch by rsteiner
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20987,20985
TEST=none
Review URL: http://codereview.chromium.org/196003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DOMStorageDispatcher hosts (which are each owned by one ResourceMessageFilter) for the same profile share a WebKit context, and each one of those contexts owns a DOMStorageContext. The DOMStorageContext owns storage namespace objects which own storage area objects which wrap their WebKit counterparts.
Not only is this cleaner code wise and more efficient (we're not duplicating WebStorageNamespaces and Areas for each DOMStorageDispatcherHost) but this is necessary for events and locking.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/192003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
somewhat unfortunate, but we need to do this until we have a built-in feed
previewer.
R=mal
BUG=21238
Review URL: http://codereview.chromium.org/201044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/183008
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=thomasvl
TEST=none
BUG=8630
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thomasvl
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/202006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and mark the ones that pass) in preparation for rebaselining.
TBR=asargent
TEST=none
BUG=8630
Review URL: http://codereview.chromium.org/199036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This paves the way for some upcoming allocator improvements
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of these squash harmless compiler warnings but the custom_button.cc
change fixes a real problem with the accelerator key bitmask calculation
(+ preceeds << in terms of operator precedence)
The change to tab_strip.cc is ugly but it fixes the following error:
chrome/browser/views/tabs/tab_strip.cc: In member function
‘void TabStrip::StartRemoveTabAnimation(int, TabContents*)’:
chrome/browser/views/tabs/tab_strip.cc:201: error: assuming
signed overflow does not occur when assuming that
(X - c) > X is always false
As an added bonus, this makes the Linux shared build of toolkit_views
work too.
Review URL: http://codereview.chromium.org/199025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This funciton is defined as part of tcmalloc; it shouldn't be in libcmt anymore.
BUG=none
TEST=none; we're removing code from libc. If this is a problem, it will fail to link.
Review URL: http://codereview.chromium.org/200036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not OS_WIN.
Added USE_X11. Set when OS_LINUX or OS_FREEBSD is set.
Added USE_BASE_DATA_PACK for base::DataPack usage, set for OS_MACOSX,
OS_LINUX or OS_FREEBSD.
Added USE_NSS for ... nss (for crypto). Windows and MacOS use
platform-specific libraries.
All of the above cause slightly odd formulations like:
#if defined(OS_WIN)
...
#elif defined(USE_BASE_DATA_PACK)
...
#endif
Possibly should also define USE_DLL_FOR_DATA, etc? Or something?
Wrapped various references to struct stat64 and stat64() to use struct
stat and stat() for FreeBSD - but a "man stat64" on Linux suggests
that we could do the same thing for at least Linux, too, and perhaps
eliminate the wrapper?
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=christian.plesner.hansen@gmail.com
Review URL: http://codereview.chromium.org/193038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/202003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webview can be NULL if dispatchDidFinishDocumentLoad is called via a
frame destructor.
BUG=20324
TEST=LayoutTests/http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html
Review URL: http://codereview.chromium.org/194022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
insertion.
TEST=none
BUG=20993
Review URL: http://codereview.chromium.org/199020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when a new automation client instance is launched and attempts to attach to an existing external tab. An example of where this could happen is javascript on a page attempting a window.open with target _blank. In this case the Chrome browser creates a TabContents instance which is attached to an ExternalTabContainer instance. The automation client then attaches to this ExternalTabContainer. This all works if the automation client is in the same client process. If a new process is launched a separate automation channel is created between the client and the chrome browser which causes this to not work as expected.
Fix is have a floating ExternalTabContainer instance which is eventually connected to by the client. When we receive a notification from the client that it is about to connect to the ExternalTabContainer instance we setup the automation channel and other info in the underlying automation profile.
The new TabContents is created with the same profile instance as the current TabContents. This does not
work correctly if the underlying profile is an automation profile as its lifetime is tied to the
ExternalTabContainer. To fix this I added a setter for the new policy to the NavigationController. Not doing
this causes the browser to crash if the original ExternalTabContainer instance dies.
There is a bigger issue here which is that all this profile sharing would cause session cookies to not work correctly if multiple automation clients are connected to the same Chrome browser instance over the same profile. I will file a separate bug to track this issue.
Bug=1694574
Review URL: http://codereview.chromium.org/200003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I did this for two reasons:
1) For enumeration types that are not defined within a class,
and therefore do not have a corresponding .cpp file, we have
an obvious place to put the compile asserts.
2) It keeps these assertions out of the more interesting code,
which should help with readability a bit.
R=jorlow
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/198034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jianli
TEST=none
BUG=21162
Review URL: http://codereview.chromium.org/201039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
history"
This CL fixes issue 20934 by eliminating the side effect caused by Enter key press event.
BUG=20934: Omnibox keyboard behavior wrong for "See recent pages in history"
TEST=Input something in omnibox, make sure it triggers "See N recent pages in history containing XXX", then select this item and press Enter to see if chrome://history/#q=XXX is opened.
Review URL: http://codereview.chromium.org/196020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also in this change, I stop brodacasting the proxy settings changes to LOG(INFO) --- This is because navigating to "view-net-internal:proxyservice.config" offers a better solution, so no point polluting the log file.
Note that the format change is intended to make the string more succint and human readable. For example, here is a before and after comparison:
------------
New version:
------------
Automatic settings:
Auto-detect: No
Custom PAC script: [None]
Manual settings:
Proxy server: [None]
Bypass list: [None]
Bypass local names: No
------------
Old version:
------------
{
auto_detect: 0
pac_url:
proxy_rules:
{
type: TYPE_NO_RULES
single_proxy:
proxy_for_http:
proxy_for_https:
proxy_for_ftp:
socks_proxy:
}
proxy_bypass_local_names: 0
proxy_bypass_list:
id: 1
}
BUG=http://crbug.com/14478
TEST=ProxyConfigTest.ToString
Review URL: http://codereview.chromium.org/198039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"open", "create", "waiting" and "read_info").
BUG=http://crbug.com/14478
TEST=HttpCache unittests.
Review URL: http://codereview.chromium.org/201035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20703
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20408
TEST=Open tools menu, see that there are no instances of two adjacent separators
Review URL: http://codereview.chromium.org/192032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally was using theme colors, which seem to have changed.
http://crbug.com/20556
TEST=Type www.google.com and hit tab, should see "Search Google:" in a
bubble. The bubble should be blue with a darker background.
Review URL: http://codereview.chromium.org/175055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=21162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=21054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, remove StrictTransportSecurity code from SSLPolicy because that code
doesn't work.
R=agl
Review URL: http://codereview.chromium.org/198035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after WebKit roll. Touch webkit_resources.grd so that build bot takes changes to injected scripts.
BUG=21116
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/194033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/201038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after WebKit roll.
BUG=21116
TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/193034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaced usage of MessageLoop in EditorClientImpl with WebCore::Timer.
Changed the clients to be instance variables of WebViewImpl instead of
being separately heap allocated. This cleaned up some of the lifetime
issues.
R=dglazkov
Review URL: http://codereview.chromium.org/198030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
plugin name was showing up blank.
TBR=ananta
Review URL: http://codereview.chromium.org/196035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20915
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=net_unittests --gtest_filter=HttpCache.GET_Previous206_NotModified
Step to reproduce the failure:
1. Sparse cache has data for (0 - 9)
2. Make a non-range request for the resource
3. Server replies with 304 not modified
4. User would get 304 modified while 200 is expected
The cause is that PartialData::ResponseHeadersOK requires a full specified
range to accept the response when server replies with 304. This is not a
valid assumption as the response of 304 can be caused by the cache submitting
a range request for validation purpose.
Review URL: http://codereview.chromium.org/198018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21146
TEST=Omnibox dropdown corners look nicer
Review URL: http://codereview.chromium.org/201037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteTextFieldCell calls -keyboardFocusIndicatorColor when
drawing the focus ring, which valgrind considers a leak. While we
were testing drawing when not focussed, unit tests could not test
drawing when focussed without the window being made key, which is bad
for many reasons.
This change adds some code to allow faking the key window, then adds
tests for drawing when focussed which exposes the memory leak, then
adds a suppression for that memory leak.
http://crbug.com/21137
TEST=valgrind AutocompleteTextFieldCellTest.Display
Review URL: http://codereview.chromium.org/192031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
new UI on XP even if we couldn't update the ShimInclusionList key because of non-admin install. This change patches RegEnumKey, if needed, so that WMP thinks the key contains chrome.exe
BUG=20259
Review URL: http://codereview.chromium.org/193024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use SSPI for NTLM authentication on Windows.
Add an explicit embedded_identity_used_ boolean member to
make sure we use the username/password in the URL only once
for the transaction. This allows us to reset
auth_identity_[target].source to HttpAuth::IDENT_SRC_NONE
after auth failed.
Initial patch by Arindam.
Original review URL: http://codereview.chromium.org/159656
R=arindam,eroman
BUG=19,18009,20560
TEST=1. Open a webpage that requests NTLM authentication
on Windows. 2. New unit test for wrong auth identity in
URL.
Review URL: http://codereview.chromium.org/193022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21126
TEST=use media_bench -hash and it compare txt files instead of raw dump output. Should be substantially faster.
Review URL: http://codereview.chromium.org/195012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests\http\tests\misc\favicon-as-image.html. This test originally had 2 boxes, and now has 3. Results were updated upstream in http://trac.webkit.org/changeset/43834. Note that we still fail this test, but fail it because we don't render the 3 boxes properly, rather than cuz we are comparing 2 boxes against 3 boxes.
TEST=layout test try servers
BUG=11795
Review URL: http://codereview.chromium.org/195019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the system drop shadow adds a border, so removed the border we
were drawing. Also pushed all of the one-pixel-here-one-pixel-there
positioning tweaks to -autocompletePopupPosition.
http://crbug.com/20283
TEST=Omnibox popup border should have drop shadow, be two pixels below
Omnibox, and rounded corners should align with rounded corners of star
and go buttons.
Review URL: http://codereview.chromium.org/185013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
update text expectaions
TBR=japhet
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25559 0039d316-1c4b-4281-b951-d872f2087c98
|