summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Resurrecting Tommi's attachment download test in response to a FORM post ↵ananta@chromium.org2010-10-165-3/+283
| | | | | | | | | | | | | | | | | request. This test was incorrectly deleted during the test reorganization. Added expectations to this test to look for the File download dialog box and close it when we see this. Added an end to end download attachment test with a lot of help from Stoyan about the intricacies of gmock which saves the file and verifies that the content matches that being sent from the server. Bug=36694 Review URL: http://codereview.chromium.org/3833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62846 0039d316-1c4b-4281-b951-d872f2087c98
* Really fix ChromeFrame compile for scoped changes.brettw@chromium.org2010-10-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62845 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two cases I missed when renaming/moving Windows-related scoped stuff.brettw@chromium.org2010-10-161-4/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62844 0039d316-1c4b-4281-b951-d872f2087c98
* Move the windows-specific scoped_* stuff from base to base/win and in the ↵brettw@chromium.org2010-10-1625-802/+869
| | | | | | | | | | | | | | | | base::win namespace. This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch. This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there. I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3781009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
* chromium-os:5494 Networks with identical names not handled properly.stevenjb@chromium.org2010-10-1611-66/+72
| | | | | | | | | | | | Changed lookups based on name to use service_path instead. Added wifi_network() and cellular_network() to network_library and removed wifi_name, wifi_strength, celular_name, cellular_service_path, and cellular_strength to simplify API. BUG=chromium-os:5495 TEST=Network menu tests. Set up two networks with the same name, one encrypted and one not. Confirm that all operations on each work as expected. Review URL: http://codereview.chromium.org/3744009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62839 0039d316-1c4b-4281-b951-d872f2087c98
* Flip the filesystem flag from --enable to --disable.kinuko@chromium.org2010-10-166-10/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3750010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62835 0039d316-1c4b-4281-b951-d872f2087c98
* Fix event tracing for windows test flakyness.siggi@chromium.org2010-10-167-47/+91
| | | | | | | | | | | | | | | Assert on non-null properties to the static members of the trace controller. Fix usage of same. Add a PostEventsDisabled method to trace producer to which allows for a non-racy enable/disable test. Fix a race in the trace event unittest by normalizing the state of the singleton ETW provider to dead, dead, and stone cold dead with an at exit manager. BUG=52388 BUG=59328 TEST=Unittests in the change. Review URL: http://codereview.chromium.org/3777007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62834 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - net/.pkasting@chromium.org2010-10-1648-263/+243
| | | | | | | | | | Also converts COOKIE_DLOG (since VLOG can be toggled on a granular basis), removes some unneeded "endl"s and {}s, aligns "<<"s per style guide, and changes KeygenHandler::GenKeyAndSignChallenge() to avoid using "goto". BUG=none TEST=none Review URL: http://codereview.chromium.org/3846001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62831 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in XPath fix from upstream.cevans@chromium.org2010-10-162-4/+19
| | | | | | | | | BUG=58731 TEST=NONE Review URL: http://codereview.chromium.org/3839002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62828 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb up the preconnect logic from pools to StreamFactory.willchan@chromium.org2010-10-1613-98/+497
| | | | | | | | | BUG=54450 TEST=none Review URL: http://codereview.chromium.org/3750009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62827 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK caused by passing a parameter to a string that doesn't have a ↵thakis@chromium.org2010-10-161-3/+2
| | | | | | | | | | | placeholder. BUG=None TEST=sky doesn't complain about DCHECKs. Review URL: http://codereview.chromium.org/3795009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62826 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Replace TalkMediator delegate handling with thread-safe observer listsakalin@chromium.org2010-10-168-164/+68
| | | | | | | | | | | Speculative fix for crash in bug. BUG=chromium-os:7797 TEST=Manually with bug repro Review URL: http://codereview.chromium.org/3837002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62825 0039d316-1c4b-4281-b951-d872f2087c98
* Properly check CreateFileMapping's return value.tony@chromium.org2010-10-161-1/+1
| | | | | | | | | | According to MSDN, NULL is returned on error, not INVALID_FILE_HANDLE. BUG=58056 Review URL: http://codereview.chromium.org/3760008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62824 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed some network menu logic bugs.stevenjb@chromium.org2010-10-154-71/+128
| | | | | | | | | | | Also modified NetworkMenu::ActivatedAt to use ConnectToNetworkAt() to reduce duplicated logic. BUG=chromium-os:7343 TEST=Test network menu Review URL: http://codereview.chromium.org/3796008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62822 0039d316-1c4b-4281-b951-d872f2087c98
* Implement IME for Mac plugins using the Cocoa event model on 10.6stuartmorgan@chromium.org2010-10-1524-14/+465
| | | | | | | | | | | | | Based on the implementation of Gecko's Cocoa event model IME handling on 64-bit, but modified to fit Chrome's cross-process event handling. Because NSTextInputContext is 10.6+, 10.5 will need a cempletely different implementation. BUG=30905 TEST=Plugins implementing the updated NPAPI Cocoa IME spec should handle IME on 10.6. Review URL: http://codereview.chromium.org/3808001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62820 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing test while I investigate it.asargent@chromium.org2010-10-151-1/+2
| | | | | | | | BUG=58388 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62818 0039d316-1c4b-4281-b951-d872f2087c98
* Update use of SkCanvas and SkDevice to match change in Skia:vandebo@chromium.org2010-10-1521-140/+183
| | | | | | | | | | | Refactor SkCanvas so that backends don't need to override it - instead take a device factory class. see: http://codereview.appspot.com/2103045/ BUG=New Skia devices required a corresponding canvas TEST=None Review URL: http://codereview.chromium.org/3590011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62813 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the Clear UI tab per final UI decision, will be implemented elswhereraz@chromium.org2010-10-151-2/+2
| | | | | | | | | BUG=59368 TEST=Tabbed ui for clearing private data UI gone Review URL: http://codereview.chromium.org/3819004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62810 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS users settings page checkbox offset problem.xiyuan@chromium.org2010-10-151-44/+46
| | | | | | | | | | | Wrapping into a "section" resolved the problem. BUG=chrimium-os:7689 TEST=Verify fix for chromium-os:7689. Review URL: http://codereview.chromium.org/3771008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62809 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in PrefValueStoreTest.DetectProxyConfigurationConflict.thestig@chromium.org2010-10-151-4/+2
| | | | | | | | BUG=none TEST=Valgrind and Heapchecker goes green. Review URL: http://codereview.chromium.org/3770013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62807 0039d316-1c4b-4281-b951-d872f2087c98
* Basic client-host key (+ dead key) support for Chromoting (Windows).garykac@google.com2010-10-151-342/+18
| | | | | | | | | BUG=50247 TEST=none Review URL: http://codereview.chromium.org/3779006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62806 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the webstorePrivate.getBrowserLogin callback signature.asargent@chromium.org2010-10-158-41/+82
| | | | | | | | | | | | | | | | | I accidentally defined it as taking 2 parameters intstead of a single object with two named properties. This CL fixes that (and incidentally happens to make it match the callback for the promptBrowserLogin callback, which is nice for consistency). I also did a little cleanup and added a test for getBrowserLogin and added another test for promptBrowserLogin while I was in the neighborhood. BUG=58033 TEST=none Review URL: http://codereview.chromium.org/3767010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62805 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Widen CrOS suppression for error in OpaqueBrowserFrameView.thestig@chromium.org2010-10-151-2/+1
| | | | | | | | | BUG=57949 TEST=none TBR=timurrrr Review URL: http://codereview.chromium.org/3750013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62804 0039d316-1c4b-4281-b951-d872f2087c98
* Fix drag data population on Windows so URL data doesn't take precedence over ↵dcheng@chromium.org2010-10-151-2/+4
| | | | | | | | | | | text. BUG=59229 TEST=Manual test using test case attached to bug 59229. Review URL: http://codereview.chromium.org/3818005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62803 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 69860:69873japhet@chromium.org2010-10-151-1/+1
| | | | | | | | | | BUG=none TEST=green TBR=hayato Review URL: http://codereview.chromium.org/3839001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62802 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/browser/cocoa/bookmark_* to chrome/browser/cocoa/bookmarks/.viettrungluu@chromium.org2010-10-1586-303/+310
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3828006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62792 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Added Support for DIM AutoComplete Match Classification specifiers.scr@chromium.org2010-10-153-18/+49
| | | | | | | | | | | BUG=55418 TEST=Type "yout" in the autocomplete and look for "youtube" in the autocomplete popup. The letters "yout" should be dimmer than the suggested letters "ube" which should be "normal". Review URL: http://codereview.chromium.org/3750008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62791 0039d316-1c4b-4281-b951-d872f2087c98
* Add the chroot creator to the default set of allowed groups (with override ↵mmoss@google.com2010-10-151-6/+15
| | | | | | | | | | flag). This fixes a buildbot issue where chroots can't be used without sudo (because there is no 'admin' group, and chrome-bot only belongs to the 'chrome-bot' group). Review URL: http://codereview.chromium.org/3755010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62790 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] fix about:sync crash with unrecoverable errorakalin@chromium.org2010-10-157-98/+197
| | | | | | | | | | | | | | | If the client had encountered an unrecoverable error typing about:sync would crash because the client code would try to dereference the backendhost for the purpose of printing the model group information(by this time backendhost would have been released). The fix is to bail out of printing the model information if the client had encountered an unrecoverable error. however we would still print the client had encountered an urecoverable error and the line number etc. In the process moved a bunch of code related to collecting about information for sync, from browser_about_handler.cc to sync_ui_util.cc. The refactoing helps us in unit testing by passing in a mock service object. BUG=55503 TEST=Wrote a new unit test for it. ConstructAboutInformationWithUnrecoverableErrorTest. Also tested by pretending one of the datatypes generated an unrecoverable error in the debugger. Original patch by lipalani@google.com Original review: http://codereview.chromium.org/3715002 Review URL: http://codereview.chromium.org/3810011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62789 0039d316-1c4b-4281-b951-d872f2087c98
* Move Cloud Print Proxy UI back to about:flags.scottbyer@chromium.org2010-10-152-19/+2
| | | | | | | | | BUG=59296, 59297 TEST=UI does not show up on Windows anymore unless you have the flag on. Review URL: http://codereview.chromium.org/3748008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62788 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61832 - GTK: Start implementing the new clear data dialog.avi@chromium.org2010-10-152-189/+62
| | | | | | | | | | | | | | | | | | | | We don't block with a throbber while doing a clear data operation. The views version of this dialog disables the entire dialog and displays a throbber while waiting for an operation to complete. We don't do that yet. This is important because there's no way to display error codes the sync server might throw; it's comparatively likely that deleting server side data may fail compared to deleting local data. That's the next step. BUG=57877 TEST=New dialog has same functionality as before; new functionality intermittently works (since we can't display errors yet). Review URL: http://codereview.chromium.org/3574013 TBR=erg@google.com Review URL: http://codereview.chromium.org/3841001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62787 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61848 - [Mac] UI for clearing sync data on the server.avi@chromium.org2010-10-155-2522/+611
| | | | | | | | | | | | | | xib change: Nest current checkboxes inside tab, add needed elements to other tab. BUG=57876 TEST=as in bug 54349; functionality currently hidden behind flag Review URL: http://codereview.chromium.org/3590020 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/3840001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62786 0039d316-1c4b-4281-b951-d872f2087c98
* In a fake SSLInfo, set security_bits to -1 instead of 0 wtc@chromium.org2010-10-154-5/+9
| | | | | | | | | | | | because the encryption strength is unknown (0 means no encryption). R=finnur BUG=53366,13049 TEST=no unit test failures Review URL: http://codereview.chromium.org/3749003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62785 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all exception patterns into punicode. Current matcher uses punicode ↵cira@google.com2010-10-154-54/+281
| | | | | | | | | | | | | | | entered in the omnibox and utf8 entered in the exception dialog, and they match only for ASCII urls. This change will show punicode patterns to the user in the exception dialog. We already have that behavior if user uses Omnibox UI to specify the pattern. This CL doesn't solve the UI issue crbug.com/52629 as it still shows punycode representation of the pattern to the user. BUG=38317,52629 TEST=Open exception/images dialog, and add non-ascii pattern as an exception. Try going to that url. You should see the images on the page, and pattern you entered will be displayed as punicode in the exception dialog. Review URL: http://codereview.chromium.org/3087015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62784 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Plugins: Add a debugging statement to help track down bug 59317.thestig@chromium.org2010-10-151-0/+2
| | | | | | | | BUG=59317 TEST=none Review URL: http://codereview.chromium.org/3754008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62783 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62189 - [Mac] Update Clear Browsing dialog for proper functioning ↵avi@chromium.org2010-10-153-108/+43
| | | | | | | | | | | | | | | | | | from incognito windows, only hide server data delete if switch is not set. Mirror to r62147. nib changes: - for the five "clear server data" items, hidden bound to !owner.isSyncVisible - for the "clear server data" button, enabled bound to owner.isSyncEnabled, enabled2 bound to !isClearing BUG=none TEST=none Review URL: http://codereview.chromium.org/3674005 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/3836003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62782 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62296 - GTK: Implement error handling in the clear server data box.avi@chromium.org2010-10-153-161/+40
| | | | | | | | | | | | | | Also rolls in some of raz@'s windows fixes. BUG=57877 TEST=Dialog grays out before disappearing when trying to clear server side data (and handles server errors) Review URL: http://codereview.chromium.org/3680003 TBR=erg@google.com Review URL: http://codereview.chromium.org/3836002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62781 0039d316-1c4b-4281-b951-d872f2087c98
* Don't define USE_HEAPCHECKER on Windows.thestig@chromium.org2010-10-151-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3815007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62780 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62635 - removed dashboard link from options ui, clear no longer ↵avi@chromium.org2010-10-1511-47/+113
| | | | | | | | | | | | | | behind switch BUG=59095 TEST=See ui in options tab and clear other data tab Review URL: http://codereview.chromium.org/3758004 TBR=raz@chromium.org Review URL: http://codereview.chromium.org/3811008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62779 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62641 - Remove the dashboard link from the Prefs, since it's now in ↵avi@chromium.org2010-10-155-20/+136
| | | | | | | | | | | | | | | | Clear Browsing Data. Essentially a revert of r52258, though done by hand. xib: Removed the link from the sync group, removed continuation array, resized everything else to close the gap. BUG=59095 TEST=go into options, find no "go to Google Dashboard" link Review URL: http://codereview.chromium.org/3761005 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/3799004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62778 0039d316-1c4b-4281-b951-d872f2087c98
* about:flags: Fix disabling experiments.thakis@chromium.org2010-10-157-29/+271
| | | | | | | | | | | | | | | The problem was that the restart code would copy the switches added by about:flags to the restarted instance, so that e.g. --enable-expose-for-tabs would be passed on the the command line even though the experiment was disabled. Now the flags added by about:switches are explicitly removed before the restart. Also wrap the switches added by about:flags with --start-flags-switches and --end-flags-switches switches. These unknown switches are ignored, but are useful to see on about:version. Also add a bunch of unrelated unit tests. BUG=56314 TEST=See bug. Review URL: http://codereview.chromium.org/3813007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62777 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2010-10-155-5/+14
| | | | | | | | | | CID=1420,1480,1517,1634 BUG=none TEST=none Review URL: http://codereview.chromium.org/3767001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62776 0039d316-1c4b-4281-b951-d872f2087c98
* seccomp: disable seccomp for RendererMainTestevan@chromium.org2010-10-152-2/+21
| | | | | | | | | | | | This test *could* work, but it requires refactoring as outlined in the bug. BUG=59376 TEST=test works with seccomp enabled at compile-time Review URL: http://codereview.chromium.org/3797010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62775 0039d316-1c4b-4281-b951-d872f2087c98
* [mac] Fix so that Service menu items show up properly in contextual menus.csilv@chromium.org2010-10-151-1/+1
| | | | | | | | BUG=53117 TEST=Select text and verify that service menu items show up in contextual menu. Review URL: http://codereview.chromium.org/3776006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62773 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in name of pref.pkasting@chromium.org2010-10-151-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3818004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62771 0039d316-1c4b-4281-b951-d872f2087c98
* Revert most of my recent changes to RendererMainTest.evan@chromium.org2010-10-151-13/+1
| | | | | | | | | | There's little point in defending against timing out here -- if we time out the test is broken, and we have existing timeouts to catch broken tests. Review URL: http://codereview.chromium.org/3817009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62770 0039d316-1c4b-4281-b951-d872f2087c98
* Roll ffmpeg to pick up gyp fix.nick@chromium.org2010-10-151-1/+1
| | | | | | | | | BUG=57212, 59277 TEST=trybots Review URL: http://codereview.chromium.org/3817008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62768 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62766 - Fix event tracing for windows test flakyness.tim@chromium.org2010-10-156-40/+13
| | | | | | | | | | | | | | | | | Assert on non-null properties to the static members of the trace controller. Fix usage of same. Add a PostEventsDisabled method to trace producer to which allows for a non-racy enable/disable test. BUG=52388 BUG=59328 TEST=Unittests in the change. Review URL: http://codereview.chromium.org/3800006 TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/3815008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62767 0039d316-1c4b-4281-b951-d872f2087c98
* Fix event tracing for windows test flakyness.siggi@chromium.org2010-10-156-13/+40
| | | | | | | | | | | | | | Assert on non-null properties to the static members of the trace controller. Fix usage of same. Add a PostEventsDisabled method to trace producer to which allows for a non-racy enable/disable test. BUG=52388 BUG=59328 TEST=Unittests in the change. Review URL: http://codereview.chromium.org/3800006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62766 0039d316-1c4b-4281-b951-d872f2087c98
* Pull events-related code out of ExtensionMessageService into its own class.mpcomplete@chromium.org2010-10-1528-233/+328
| | | | | | | | | | | | | | The events code is independent of the messaging code and didn't belong in the same class. This is part 1 of an extension event refactor. See bug for more details. BUG=58214 TEST=covered by tests Review URL: http://codereview.chromium.org/3758005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62764 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-13 07:40:17 +0000