| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=checkperms.py passes
Review URL: http://codereview.chromium.org/2850030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46197
TEST=manual (see bug)
Review URL: http://codereview.chromium.org/2860024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=debug chrome doesn't complain when shutting down a loading window
Review URL: http://codereview.chromium.org/2870025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2823031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=none
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47422
TEST=none
Review URL: http://codereview.chromium.org/2852025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
consistent with the way
things work in general, and specifically when things fail as the transaction boundaries are well
defined.
The entries will get deleted from memory after the next successful SaveChanges operation (happens every 10 seconds), and they will get deleted from disk on the next browser restart.
Also clear the metadata bits that track whether there are any entries in the Directory for those
types to keep it in a consistent state.
BUG=40252
Review URL: http://codereview.chromium.org/2873020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2876010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
such queries.
Instead, just ignore those queries.
BUG=47501
TEST=none
Committing patch on behalf of jochen.
Original code review: http://codereview.chromium.org/2850028/show
Review URL: http://codereview.chromium.org/2870028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2821010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2806034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move these files from cocoa/ to cocoa/location_bar/:
autocomplete_text_field.h
autocomplete_text_field.mm
autocomplete_text_field_cell.h
autocomplete_text_field_cell.mm
autocomplete_text_field_cell_unittest.mm
autocomplete_text_field_editor.h
autocomplete_text_field_editor.mm
autocomplete_text_field_editor_unittest.mm
autocomplete_text_field_unittest.mm
autocomplete_text_field_unittest_helper.h
autocomplete_text_field_unittest_helper.mm
location_bar_view_mac.h
location_bar_view_mac.mm
location_bar_view_mac_unittest.mm
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2807024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support -- not hooked up at this point.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2818029
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/2811034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An unused file was still being compiled and referenced a file no longer compiled.
This was breaking the Linux shlib tests.
BUG=None
TEST=Linux shlib tests should pass
TBR=sky
Review URL: http://codereview.chromium.org/2817032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46514
TEST=made sure syncing of an uninstalled disabled extension works
Review URL: http://codereview.chromium.org/2849027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47471
TEST=none
TBR=rafaelw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+/-/Fullscreen menu items.
Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2800015
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2836029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hooked up at this point.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2818029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47545
TBR=aa
Review URL: http://codereview.chromium.org/2857022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uninitialized variable in getProgramInfoLog and friends.
Fix crash in GLES2DecoderImpl if resizing the <canvas> when parent_ is null.
BUG=44590
TEST=64-bit chrome on Linux is able to run the o3d-webgl samples.
Review URL: http://codereview.chromium.org/2819025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
caused by r50489.
The function that got changed is shared by both types of Apps, but in the case of old-style apps |extension| is NULL, so dereferencing it will crash.
BUG=47484
TEST=Launch Chrome with --app=http://www.google.com and it should not crash.
Review URL: http://codereview.chromium.org/2842028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2800015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47539
TBR=aa
Review URL: http://codereview.chromium.org/2867028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2879001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-performSelector:withObject: has been seen in some crashes, so expand
the dispatch methods implemented to cover that and a couple obvious
variants.
Use a local copy of |BreakDebugger()| so that the crashes top-of-stack
is more obviously intentional. Then there can be a bug to attract
crash-triagers and explain how to handle things.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2828022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41290
TEST=manual
Review URL: http://codereview.chromium.org/2830017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Replace Canvas instance users with CanvasSkia users.
- Rename Canvas2 to Canvas.
- Delete Canvas subclass of CanvasSkia.
This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11457
TEST=Drag thumbnail on NTP. Shouldn't dcheck.
Review URL: http://codereview.chromium.org/2807023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the os says we should, or focus was on the button that triggered
showing the menu. Also changes mnemonic processing to not guess at
mnemonic if menu has mnemonics.
BUG=45734
TEST=none
Review URL: http://codereview.chromium.org/2831031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=brettw
BUG=47461
TEST=none
Review URL: http://codereview.chromium.org/2852024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
adding the example project.
R=bradnelson
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2844025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Each translate infobar is now its own class and most of the logic is in the delegate.
BUG=40828
TEST=Thoroughly test the translate feature on Linux.
Review URL: http://codereview.chromium.org/2867017
Review URL: http://codereview.chromium.org/2836023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was trying to debug some code, and noticed some excess
complexity.
There are no significant semantic changes.
DCHECK on a foo.get() is a waste given we're about to deref
the pointer.
Execution cost should be be minially less, and we get rid
of several lines of code.
BUG=46263
r=mbelshe
Review URL: http://codereview.chromium.org/2805033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
triggering builds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2847028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests are failing. Reverting last two rolls.
TBR=hclam
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2835017
TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/2806035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(text-intro-05-t).
Tests are failing. Reverting last two rolls.
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2845024
TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/2836027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2845024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=47518
TEST=none
Review URL: http://codereview.chromium.org/2805035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2814033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2835017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46672
RBR=glider,senorblanco
TEST=TSan UI should remain green
Review URL: http://codereview.chromium.org/2861027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subsequent changes will:
* Allow URLPatterns to specify * for scheme, so that http/https doesn't need to be repeated for each host.
* Fix the overlap detection.
Suggested review order:
- test files
- url_pattern*
- extension_extent*
- extension*
- everything else
BUG=46633
Review URL: http://codereview.chromium.org/2876007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Change the order and make the rules a bit more specific to handle disabled action buttons.
Review URL: http://codereview.chromium.org/2805028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Reverted r50804 as it seems to be related to memory error.
Review URL: http://codereview.chromium.org/2833033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
items.""
This reverts r50828 as the error is already suppressed r50793.
TBR=asargent
Review URL: http://codereview.chromium.org/2844028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11457
TEST=Go to google.com, drag logo around. Should be attached to cursor.
Review URL: http://codereview.chromium.org/2870026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the logic to disable the "remeber" functions in the UI elements (basically reverting r44084, but leaves the incognito host content setting map in place. Changes to this map are allowed but do not get stored in preferences.
BUG=44480
TEST=none
Review URL: http://codereview.chromium.org/2811025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50829 0039d316-1c4b-4281-b951-d872f2087c98
|