| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Even though the numbers are going down, we're actually pulling in one more
patch. This patch will regress DOM performance by 23%, but we'll fix that
immediately in WebKit once the new API this patch adds is available. See
https://code.google.com/p/chromium/issues/detail?id=159674 for more context.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This solves a compile error for CityHash on ARM: Platform.h:81
BUG=160369
TEST=tree
Review URL: https://codereview.chromium.org/11410045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bitmaps can be destroyed independently.
BUG=160477
Review URL: https://codereview.chromium.org/11410038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only after giving the native widget a chance to handle them.
This ensures that keys like backspace work in the omnibox in Chrome AURA and mimic the keydown handling in NativeWidgetAura
BUG=159950
R=sky
Review URL: https://codereview.chromium.org/11361200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is only used for testing on Android.
BUG=
Review URL: https://codereview.chromium.org/11359166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
driver 8.15.11.8593 on Windows
BUG=155749
TEST=content_unittests
TBR=vangelis
Review URL: https://codereview.chromium.org/11361224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
SafeBrowsingServerTest to avoid collision with SafeBrowsingServiceTest in safe_browsing_service_browsertest.cc. This is in prepartion to https://codereview.chromium.org/11366196/ landing (after master restarts) which moves safe_browsing_test.cc to browser_tests to avoid building another target just for this one test.
BUG=148792
Review URL: https://codereview.chromium.org/11366204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't unambiguously parse NLST listing (just file names,
but they might have spaces, which might end up looking
just like some other listing format), so we need to force
a "proper" listing.
It turns out issuing "LIST -l" command does so for mod_ftp,
and is hopefully harmless for other servers.
BUG=76999
TEST=Covered by net_unittests, also see bug for manual testing with mod_ftp.
Review URL: https://chromiumcodereview.appspot.com/11364204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was added with the intention of using Size as a vector, replacing use of
IntSize. Since we have Vector2d now, negative sizes should not exist, so clamp
them in set_width/set_height and the constructor.
Not covered by tests, as we can't test DCHECKs.
TBR=sky
BUG=160158
Relanding: https://codereview.chromium.org/11365160/
Review URL: https://codereview.chromium.org/11410024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The group name is <number><suffix>, e.g., 100A, so base::StringToSizeT will
return false.
BUG=114277,143454
TEST=chrome --force-fieldtrials=HostCacheSize/8723suffix/; open 'chrome://net-internals/#dns' and verify 'Capacity: 8723'
Review URL: https://codereview.chromium.org/11366201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
StackingClient stomp each other in aura::Env. Instead:
- Don't have StackingClient implementations install themselves by default
- Add chrome implementation of StackingClient that dispatches to ash or desktop
- Pass extra |context| to GetDefaultParent (normally a RootWindow) that it can use to determine desktop type.
- Workaround a few locations by using ScopedForceDesktopType: in these locations, the GetHostDesktopForNative... functions fail because they're used during window creation when the windows have no parent (and so can't determine which desktop they're in).
- Remove window-specific StackingClient (unnecessary?)
BUG=128578
Review URL: https://codereview.chromium.org/11364053
TBR=scottmg@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code in Update() that caused a Show() hasn't been useful
since we started clearing last_user_text_ and last_full_text_ in Hide().
So, remove it and the thus unused loader_processed_last_update.
BUG=none
R=melevin@chromium.org
TEST=none; no change in functionality.
Review URL: https://codereview.chromium.org/11410020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=138529
TEST=Covered by net_unittests.
Review URL: https://chromiumcodereview.appspot.com/11293227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/p/chromium.fyi/waterfall?show=Chromium%20Win%20VS2012
FAILED: ninja -t msvc -r . -o obj\chrome\browser\ui\sync\browser_ui.one_click_signin_helper.obj -e environment.x86 -- cl.exe /nologo /showIncludes /FC @obj\chrome\browser\ui\sync\browser_ui.one_click_signin_helper.obj.rsp /c ..\..\chrome\browser\ui\sync\one_click_signin_helper.cc /Foobj\chrome\browser\ui\sync\browser_ui.one_click_signin_helper.obj /Fdbrowser_ui.pdb
e:\b\build\slave\chromium_win_vs2012\build\src\chrome\browser\ui\sync\one_click_signin_helper.cc(483) :error C2039: 'bind2nd' : is not a member of 'std'
e:\b\build\slave\chromium_win_vs2012\build\src\chrome\browser\ui\sync\one_click_signin_helper.cc(483) :error C3861: 'bind2nd': identifier not found
TBR=rogerta@chromium.org
Review URL: https://codereview.chromium.org/11361228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158803
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/11364160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other in aura::Env. Instead:
- Don't have StackingClient implementations install themselves by default
- Add chrome implementation of StackingClient that dispatches to ash or desktop
- Pass extra |context| to GetDefaultParent (normally a RootWindow) that it can use to determine desktop type.
- Workaround a few locations by using ScopedForceDesktopType: in these locations, the GetHostDesktopForNative... functions fail because they're used during window creation when the windows have no parent (and so can't determine which desktop they're in).
- Remove window-specific StackingClient (unnecessary?)
BUG=128578
Review URL: https://codereview.chromium.org/11364053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the 3 TODOs for Dana from region.*
TEST=cc_unittests,ui_unittests
R=danakj@chromium.org
Review URL: https://codereview.chromium.org/11410025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
schemes."
This reverts r166702 and r166996. Unfortunately, the Android content providers
can't handle the changes to the case in the hostname due to canonicalization
(specifically the change from TestContentProvider to testcontentprovider). This
is because the Java classloader is case-sensitive.
BUG=160273,159832
TEST=AndroidWebViewTest
Review URL: https://chromiumcodereview.appspot.com/11365197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit baefae90f294a981c973bffbdd3eccabfe796b6a.
The change broke Chrome for Android because non-vanilla protobuf-lite
Java files were generated.
Original review:
https://codereview.chromium.org/11228038/
TBR=phajdan.jr
BUG=160256
Review URL: https://codereview.chromium.org/11359146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
implementing views::Widget::CloseAllSecondaryWidgets()" on win aura.
Review URL: https://codereview.chromium.org/11359154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/158115
TBR=sky@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/11275139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r10219: (bradnelson) Adding download of new gcc arm toolchain.
r10221: (phosek) Handle case when mmap_min_addr != CONFIG_LSM_MMAP_MIN_ADDR under SELinux.
r10222: (shcherbina) Validator_ragel ncval: factor out elf loading to separate library.
r10223: (dschuff) Add a function to test.sh to run LLVM/Clang regression tests
r10224: (jvoung) Clean up tools/file_check.py to make it more general.
r10225: (mcgrathr) Make naclsdk find ARM toolchains
r10226: (dschuff) export PNACL_TOOLCHAIN_LABEL in buildbot_pnacl.sh
r10227: (mcgrathr) Don't use --clobber on ARM toolchain bots
r10228: (mcgrathr) Update ARM binutils, gcc, newlib revisions
r10229: (robertm) Make the PNaCl toolchain builder create a more verbose REV file
BUG=none
TEST=nacl_integration
Review URL: https://codereview.chromium.org/11377097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Swap code order to SchedulePaint after EnableInactiveRendering.
Calling SchedulePaint before the synchronous paint hack doesn't work.
Calling EnableInactiveRendering and SchedulePaint after the paint hack works, but makes less sense.
BUG=160125,158369
TEST=Windows paint inactive when other Chrome windows are activated.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11365176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11293213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because these metrics are slow, they change the characteristics of traces. When
we want to look at performance, then these become misleading. So, enable them
only when desired, when someone wants tracing information about overdraw.
Also reverting changes made to make the overdraw metrics faster and less precise.
Since they are optional, we should get the most accurate data out of them when
they are turned on.
BUG=159718
R=enne,jamesr
Review URL: https://codereview.chromium.org/11369188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we support a form of CAA record for DNSSEC stapled certificates. Now
that RFC 6698 has been published, we want to change it to use that.
This CL adds support for DANE records in stapled certificates. After this has
reached the stable channel, the old CAA support can be removed.
BUG=none
TEST=Check that https://spki.dane.imperialviolet.org loads without errors.
Review URL: https://chromiumcodereview.appspot.com/11184027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
verify-webapp.py was lookin only in webapp sources. The new verify_resources.py
verifies all source files and not only webapp.
Review URL: https://codereview.chromium.org/11362072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=joth@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11275264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this CL, the following EventFilters are converted into EventHandlers:
* AcceleratorFilter
* MagnificationControllerImpl
* TrayEventFilter
* TouchObserverHUD
* AppListController
* ShelfLayoutManager::AutoHideEventFilter
* SystemGestureEventFilter
BUG=159632
Review URL: https://codereview.chromium.org/11362196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
os (2). Please reland with clean
try runs.
Revert 167195 - Eliminate use of window.localStorage in drive_banners.js
BUG=160002
TEST=Check banner showing loginc.
Review URL: https://codereview.chromium.org/11377099
TBR=serya@google.com
Review URL: https://codereview.chromium.org/11369191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: http://codereview.chromium.org/11312189/
Review URL: https://codereview.chromium.org/11358198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SpellcheckService.
There is still a lot of additional cleanup I would like to do (e.g., removing all the functions which simply pass along to the particular dictionaries) after this one is in. This one is primarily a lot of shuffling of code around and fixing naming to be more logical.
Note: I will delete the vestigial files in a separate CL.
BUG=154923
TEST=test have been renamed: spellcheck_service_unittest.cc, spellcheck_service_browsertest.cc
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11364190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=benjhayden@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11363146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove deleted file.
TBR=csharp@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/11366198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fill in implementation for:
- SyncFileSystemService::GetConflictFiles which internally calls GetRemoteFileMetadata and GetLocalFileMetadata
- SyncFileSystemService::GetConflictFileInfo which calls RemoteFileSyncService::GetConflictFiles
- Adding mock method for: RemoteFileSyncService::{GetConflictFiles, GetRemoteFileMetadata}
BUG=155505, 157795
TEST=SyncFileSystemServiceTest.GetConflictFiles*
Review URL: https://codereview.chromium.org/11364172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
With iterator debugging disabled on windows dbg bots, this should be fast enough again
BUG=159662
Review URL: https://chromiumcodereview.appspot.com/11275259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=160002
TEST=Check banner showing loginc.
Review URL: https://codereview.chromium.org/11377099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=160304
TEST=unit test & visual
Review URL: https://chromiumcodereview.appspot.com/11359152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
styles of checks must be wrapped in <div class=type> to ensure consistency in spacing. Checkboxes require an id or a pref property. Radio buttons require name and value properties.
BUG=160301
Review URL: https://chromiumcodereview.appspot.com/11364137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11363193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetLongPathName() can fail if the user doesn't have the necessary
privileges on an ancestor directory. If this call failed during
CreateTemporaryFileInDir(), the temporary file that was created
in the previous GetTempFileName() call will leak.
None of the callers rely on the path being expanded on return. So
get rid of the call.
BUG=155612
Review URL: https://chromiumcodereview.appspot.com/11300011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are uncalled and don't actually work at all in the component build.
Leaving them around is just confusing. Code that wants to instantiate these
types can use the WebCompositorSupport interface or directly construct
the Impls.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11231017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove long-dead updateAnchorWidth function
- Remove some if statements that never fail
- Add a check for the correct day headers to the browser test.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11234027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167187 0039d316-1c4b-4281-b951-d872f2087c98
|