| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling OnTextInputStateChanged can change the window hierarchy of the keyboard
window or its container window. Doing this while the hierarchy is already in the
process of changing (in OnWindowParentChanged override) can cause unpredictable
behaviour.
BUG=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/14772014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also rename the "SPI" / "Service Providers" view to the
"modules" view, as it now contains extension information as
well.
In the process of doing this, switches the SPI view to using
jstemplate.
BUG=236048
R=eroman@chromium.org
Review URL: https://codereview.chromium.org/14659006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- All spinners have the same margins;
- "Fetching payment details" instead of "Retrieving Wallet information";
- Wider spinner for account names;
- Legal text placeholder (without links and preview);
- Hide the header while in the Fetch mode;
- Hide the Wallet logo while in the Autofill mode;
- Cleaner Wallet logo (moved into a separate CL).
BUG=237626,232958
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/14801009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code to check whether to allow an invocation of NaCl doesn't
work correctly for content (MIME type) handlers. Change the app
URL checking code in that case.
BUG=235962
TEST=browser_tests, --gtest_filter="NaClExtensionTest.*"
R=jochen@chromium.org, jorgelo@chromium.org
Review URL: https://codereview.chromium.org/14796002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds IPC messages to support the new resources.
Adds stubbed out host methods to hold implementation
TBR=tsepez@chromium.org, yzshen@chromium.org
BUG=230980
TESTS=none
Review URL: https://codereview.chromium.org/13771020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
registry for a test and flag the environment for the child process to know it should also override the registry.
Prerequisite to make IEImporterBrowserTest pass when using the ExternalProcessImporterHost in https://codereview.chromium.org/12670013/. Keeping this as a separate CL given that one is already very complex and has been lgtm'ed as is by 4 reviewers already.
Precursor CL to https://codereview.chromium.org/12670013/.
BUG=219419, 22412
TEST=Make sure tests run without affecting the real registry.
Make sure (via logging) that the override doesn't happen when running import directly from Chrome.
Make sure the IEImporterBrowserTest pass both now (in-process) and on top of https://codereview.chromium.org/12670013/ (out-of-process).
Review URL: https://chromiumcodereview.appspot.com/14143010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=234374
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=58449
Review URL: https://chromiumcodereview.appspot.com/14861009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the icon is always visible even if there are no notifications,
but now it should be invisible in such case.
BUG=237981
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/14645024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
During startup, sometimes the status tray and icons can't be created
because the taskbar doesn't exist.
BUG=237894
R=mukai@chromium.org
Review URL: https://codereview.chromium.org/14940002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change allows the client to specify a list of 'hints' when sending
a GetUpdate request to the server. It also adds a set of flags that can
be used to help the server determine whether or not the list of hints is
complete.
This change also adds flags to help the server infer the reason why the
client is requesting updates. These flags can be set on a per-data type
basis to indicate if there was a local refresh request or a local change
to the type.
BUG=138613,231693
Review URL: https://chromiumcodereview.appspot.com/13831012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to Extensions.
BUG=234256
Review URL: https://chromiumcodereview.appspot.com/14909002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=true (nacl try jobs passing)
BUG=
Review URL: https://chromiumcodereview.appspot.com/14886008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=234565
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14867003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The command-line switch is for now preserved for backward compatibility.
BUG=none
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/14634005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The line count for notifications with messages that contained words
longer than 1 line did not take into account the wrapping of these
words. This fixes that.
This is a fixed version of http://crrev.com/14619004 which was reverted
due to unit test failures.
BUG=236526
R=dewittj@chromium.org
Review URL: https://codereview.chromium.org/14894003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=178543
TEST=None
R=ben@chromium.org
Review URL: https://codereview.chromium.org/14624010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Changes notification center background to #f1f1f1
* Color behind a transparent icon is now #f5f5f5
* "No Notifications" font is now the same as the buttons
* Color for "No Notifications" is now #b4b4b4
* Color for normal labels in notification center is now #7b7b7b to match CrOS sytem tray
* Color for hovered labels in notification center is now #2a2a2a to match CrOS system tray
R=dharcourt@chromium.org
BUG=NONE
Review URL: https://codereview.chromium.org/14707007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into a separate function (which we can later auto-generate if needed).
Now that all of the enable/disables are listed out clearly, they are easy to move to Blink as part of the new WebRuntimeFeatures::enableStableFeatures() API:
https://codereview.chromium.org/14950002/
After the Blink change is rolled into Content, we'll be able to replace these blocks with single calls to enableStableFeatures() and enableExperimentalFeatures().
BUG=237740
R=creis@chromium.org
Review URL: https://codereview.chromium.org/14930005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=device_unittests
R=youngki@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14884002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds logic similar to how URL requests are resolved for
shared module paths in chrome/browser/extensions/extension_protocols.cc.
BUG=237248
Review URL: https://chromiumcodereview.appspot.com/14785009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Concentrates all MenuModelForSection calls in one place.
- Removes "Manage..." items from all section drop-downs.
- Uses Java-side strings and (possibly) images for Add/Edit.
BUG=235639
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/14744006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an app is updated (as opposed to installed), existing shortcuts are
refreshed, but new shortcuts are not created.
BUG=177579
BUG=234041
Review URL: https://chromiumcodereview.appspot.com/14682008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=joi
BUG=227219
Review URL: https://codereview.chromium.org/14941004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously this height was 16 pixels. It should have been and is now 18
pixels, the same as the height of message lines.
The baseline-to-baseline distance between the last title line and the
first message line and between the last title line and the first item
line on Windows was fixed: It was previously 20 pixels and should have
been and is now 22 pixels.
The baseline-to-baseline distance between title lines on Windows was
also fixed: It was previously 19 pixels and should have been and is now
20 pixels.
Finally, the distance between the baseline of the last message line or
last item line and the bottom of the card on Windows was fixed. It was
previously 11 pixels and should have been and is now 12 pixels.
BUG=235172
R=dewittj@chromium.org
Review URL: https://codereview.chromium.org/14867002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=237823
Review URL: https://chromiumcodereview.appspot.com/14602019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PluginAtPositionResponse, this would end up killing embedder process.
Bringing up devtools for embedder is unhappy without this since it trigger GetGuestByInstanceID with kInstanceIDNone.
BUG=237652
TEST=Brining up devtools for embedder now does not crash/kill embedder.
Review URL: https://chromiumcodereview.appspot.com/14566004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This drops a dependency on Profile in the interface of ProfileKeyedService
infrastructure, and adds helper functions that make it explicit what is being
done (it's not obvious just from "return context" for example that this will
result in the service having its own instance in Incognito mode instead
of no instance).
BUG=227219
R=erg@chromium.org, joi@chromium.org
Review URL: https://codereview.chromium.org/13865012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not only am I interested in measuring the overhead of bitstream conversion, it also makes for a very easy way to reproduce the CHECK() for bug 234449.
Finally, converted a few scoped_ptr<T> to T now that less of our code relies on RefCountedThreadSafe.
BUG=234449
R=dalecurtis@chromium.org
Review URL: https://codereview.chromium.org/14736006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=noelallen@chromium.org
Review URL: https://codereview.chromium.org/14061009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/14945002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when to end the dismissal period for the card.
BUG=164227
TEST=Suppose, the card should normally stay dismissed for X hours. Get cards, unplug the network cable (or otherwise break the connection to the server), dismiss the card and wait for 5 hours. Then plug the cable back. Check that the card reappears in X hours after the dismissal, not restoring the network connection.
Also try to sit w/o connection for more than X hours. In this case, the card should reappear as soon as the connection is restored, at the first cards update after this happens.
Review URL: https://chromiumcodereview.appspot.com/14731004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=230974
Review URL: https://chromiumcodereview.appspot.com/14652010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is another step towards unified SPDY2/3/4 unittests. I merge two of the
classes used by SPDY-related unittests into common versions, parameterize them
explicitly by NextProto (instead of implicitly based on whether you get the
net::test_spdy2 or net::test_spdy3 version), and modify tests to instantiate
them with the proper version.
BUG=226192
Review URL: https://chromiumcodereview.appspot.com/14573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When suggest text is shown the location entry is shrunk.
This means that clicking on the suggest text or the white
space next to it doesn't focus the location entry.
This CL fixes that by not shrinking the location entry when
suggest text is shown. The suggest label ignores mouse
events so clicks correctly go to the location entry.
Note, the location entry is still resized when the suggest
text needs to be on the left (for example, left to right
text in RTL mode).
BUG=224804
TEST=
Run chrome with instant extended enabled.
Type "hello w" in the omnibox. Wait for "orld" to be displayed.
Click on the search results page.
Click on "orld" and verify that focus switches to the location
entry and caret is positioned at end of "hello w".
Review URL: https://chromiumcodereview.appspot.com/14145007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blink rev 149624 fixes a layer explosion issue that forced us to disable
compositing for fixed-position elements. Now we are able to turn on this
feature again for high-DPI devices to get the performance gains of fixed-pos
compositing.
BUG=172738
R=jamesr@chromium.org, piman@chromium.org
Review URL: https://codereview.chromium.org/14884005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/14952002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move components to zip as per the discussion here:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/MgbMTQCNzR0/discussion
BUG=
R=agl@chromium.org, gavinp@chromium.org, jam@chromium.org, joi@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197964
Review URL: https://codereview.chromium.org/14021015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=237977
TBR=phajdan
Review URL: https://codereview.chromium.org/14634004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We now properly set either NEW_CLIENT (if !HasSyncSetupCompleted) or
NEWLY_SUPPORTED_DATATYPE otherwise.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/14884006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was a bug where flashing could occur if a non-updated tiling was
used for activation. As tiles only get created during
UpdateTilePriorities and null tiles are accepted for activation (under
the premise that there is nothing recorded there and tiles couldn't be
created), this could cause a premature activation and flashing content.
Fix this case by making sure that syncing a tiling always updates that
tiling if the tree is up to date and doesn't need update draw
properties.
Add checks to make sure that all tilings have been updated and the tree
itself is up to date when calling AreVisibleResourcesReady.
R=danakj@chromium.org
BUG=230540
Review URL: https://chromiumcodereview.appspot.com/14883003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- decrement the unread_count when it's shown as a toast.
- increment again if the notification is dismissed by timeout.
BUG=234538
Review URL: https://chromiumcodereview.appspot.com/14559004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The intl_* page_sets are intended to replace intl1 and intl2. The typical_25
page_set will be added.
BUG=None
TEST=New page suites with page_cycler benchmark on linux
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/13991016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=237985
Review URL: https://codereview.chromium.org/14732005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was a pause icon, now an appropriate miniature version of the 128x128 icon.
Original icon is advancedsettings from Crystal Clear icon set by Everaldo
Coelho. Licensed under LGPL.
16x16 icon downloaded from:
http://www.openwebgraphics.com/resources/data/3322/16x16_advancedsettings.png
BUG=236751
R=arv@chromium.org, grv@chromium.org
Review URL: https://codereview.chromium.org/14624004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove current HQPReplaceHUP field trial and NewScoring field trial.
Replace them with one common field trial that controls them both. This
is useful because new scoring is probably more useful in HQP-replace-HUP
mode. Hence, I want to test all 4 combinations of on-and-off simultaneously.
This new trials allows me to direct users to each of those four groups
separately.
The trial is not created on the client. It will be downloaded through
the variations server. Hence, I can decide the probabilities at a later
date. I'm likely looking at 70% control, 10% in each of the other
three arms. I plan to run comparisons of control versus each other
arm as well as HQP-replace-HUP against HQP-replace-HUP-plus-new-scoring.
Field trial groups names will be
Standard
HQPReplaceHUP
NewScoring
HQPReplaceHUP_NewScoring
Tested used --force-fieldtrials
TBR=pkasting@chromium.org
BUG=175751
Review URL: https://codereview.chromium.org/14801007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=180260
R=cpu@chromium.org, ddorwin@chromium.org
Review URL: https://codereview.chromium.org/14582015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Without -9, this was not killing the forwarder.
BUG=237820
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14721005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using components, the CDM and adapter cannot be within the Chrome bundle.
Since the adapter is built with Chrome, the CDM cannot be within its bundle.
As a result, the adapter no longer needs to be a bundle.
The chrome_paths.cc code allows testing with the non-component path.
BUG=180260
R=xhwang@chromium.org
Review URL: https://codereview.chromium.org/14743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are a couple of apps using the experimental identity API that we'd prefer
not to break. This change refactors the API such that chrome.identity has all
the new stuff, and chrome.experimental.identity is the legacy API.
TBR=mpcomplete@chromium.org
BUG=228908
Review URL: https://codereview.chromium.org/14642015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198210 0039d316-1c4b-4281-b951-d872f2087c98
|