| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
up, which will require some changes in render_view as well as the plugin list.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1697008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manually ran the js tests
Review URL: http://codereview.chromium.org/2014005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ideally this dependency on chrome from net should not exist, but
until that is resolved, we can at least avoid the dependency when
using net.gyp from the standalone webkit build (which lacks a
checkout of chrome/).
R=nick
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1996010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The problem was we assumed ProcessPendingRequest() would always make progress once the group's releasing socket went down to zero. However, in OnAvailableSocketSlot(), since the top stalled group might still have a releasing socket, it won't necessarily make progress. The algorithmic solution is to simply never do any socket slot processing in DoReleaseSocket() if there are any releasing sockets. This requires us to search for any stalled groups after releasing sockets gets back down to 0, so it requires the full group scan each time num_releasing_sockets goes back to 0. There is a performance hit here, but I think a linear search through 256~ groups in the worst case is ok.
TODO(willchan): evaluate the perf hit and consider adding a secondary data structure to improve the stalled group search.
BUG=42267
Review URL: http://codereview.chromium.org/2013009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to more than one target.
We had originally decided that this would be an disallowed.
glBindBuffer(GL_ARRAY_BUFFER, some_buffer_id);
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, some_buffer_id);
Unfortunately the GLES2 conformance tests require this
behavior.
This CL makes this behavior possible but it has to be
turned on because it means all buffers have to have CPU
side backing (not just ELEMENT_ARRAY_BUFFERs) and it
means a slowdown for dynamic vertex related stuff
like skinning because an extra copy has to be made
every time they are updated.
So, by default it will be off but we'll come up with
some way to turn it on. Al's suggestion is to use
eglCreateContext with a custom intialization attribute.
My #1 question: What about the name of the command,
the name of the constant and the filename the constant
is in. Any thoughts?
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1992008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was going to do Show(std::stringi d), but it'd require some refactoring on notification framework,
so I decided to have UPdateAndShow first. I'll do refactoring once I finish screen lock and will
update the code accordingly.
other minor changes:
* removed is_visible() as it's unnecessary.
* cleanup browsertests code.
BUG=http://crosbug.com/2692
TEST=added test cases to existing browser tests.
Review URL: http://codereview.chromium.org/1933008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42943
TEST=none
Review URL: http://codereview.chromium.org/2008003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1998012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22588
Review URL: http://codereview.chromium.org/1998008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when URL is modified in non-empty input field - RTL
In RTL chrome in windows, the text get from "Pattern" text field is wrapped
with LRE/POP, which makes the pattern invalid. Trim explicit bidi control characters
off in NativeTextfieldWin::GetText().
BUG=http://crbug.com/42867
TEST=
1. Launch Chrome with RTL language UI
2. click Wrench => Options => Under the Hood => Content settings => Exceptions
=> Edit...
3. modify an existing url on the Pattern field.
The "OK" button should not be grayed out.
Review URL: http://codereview.chromium.org/1703026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set the color of the text for the app icons.
Since we do not have a background on sections any more
BUG=43578
TEST=None
Review URL: http://codereview.chromium.org/2016007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/1994006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34176
TEST=none
Review URL: http://codereview.chromium.org/2024006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify that "Customize" button on "Personal Stuff" options page brings you the dialog with a Chrome window frame and not occupy the full screen.
Review URL: http://codereview.chromium.org/2043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
backend. We queue all trasnactions that reach Start before
we are done creating the disk cache.
BUG=26729
TEST=unittests.
Review URL: http://codereview.chromium.org/2002002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
out of configureWindow and into a new adjustWindowForHeight: method. Call this method when adding or removing bookmark nodes to the menu, such as for dropping or pasting. When adjusting the button widths consider the best cell width, which may be less than the current button width, so that folder menus can shrink as well as grow. When adding the first bookmark to an empty folder remove the '(empty)' placeholder and when removing the last real bookmark from a folder insert the '(empty)' placeholder.
BUG=42868,43227
TEST=In addition to attempting to recreate the problems as described in the bug reports: 1) Add (by dragging in or pasting) a new bookmark to a folder which is on the edge of being too big and needing to scroll and verify that it does become scrollable, 2) remove a bookmark (by cutting or deleting) from the folder which just became scrollable and verify that it is no longer scrollable, 3) create a new, empty folder and verify that it shows '(empty)' , 4) add a bookmark (by dragging or pasting) to the newly created empty folder and verify that there is only one bookmark shown and that it is not the '(empty)' placeholder, and 5) remove the single bookmark just added to the folder (by cutting or deleting) and verify that the menu now shows the '(empty)' placeholder.
Review URL: http://codereview.chromium.org/2024004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert r46707:
Mark StatsTableTest.MultipleThreads as flaky
instead of using #if 0.
TBR=maruel,phajdan.jr
TEST=none
BUG=10611
Review URL: http://codereview.chromium.org/2054003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame. There appear to be a number of crashes
caused when we wrap the bind status callback and call the underlying IMoniker::BindToStorage function. The crashes occur because
of urlmon calling into dlls which have been unloaded.
Fix is to use the exception barrier version which only reports crashes which occur directly in chrome frame in our BindtoStorage call
and to use the generic ExceptionBarrier in our bind status callback wrapper before calling out to the underlying callback.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=43373
Bug=43373
Review URL: http://codereview.chromium.org/2002009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scrollbar is vertical or not.
Review URL: http://codereview.chromium.org/1996009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43613
Review URL: http://codereview.chromium.org/2012005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build and Unittests
Review URL: http://codereview.chromium.org/1995008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window class in DllMain on attach and tag it with our module handle, then unregister said window class on detach.
BUG=43343
Review URL: http://codereview.chromium.org/1994007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When you first logged in to Chrome OS, it used to say "your account is not set up to sync" until you downloaded the initial sync. Now it follows the regular sync signup flow where it's "account details are not yet entered" until the authentication happens, then it's "setup in progress" while downloading the initial download, then it's "your account is set up to sync."
BUG=maybe in chrome OS tracker?
TEST=build chrome OS. log in to chrome OS with a new account. Immediately check wrench>options>personal stuff. It should not say "your account is not set up to sync..."
Review URL: http://codereview.chromium.org/2023004
TBR=dantasse@chromium.org
Review URL: http://codereview.chromium.org/2049002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Excerpt from: http://codereview.chromium.org/1991004/show
----------------
Put version information into header file for easy consumption by RC files.
RC files can use an #include to pull in this header, rather than being each
dynamically generated.
BUG=none
TEST=none
----------------
Review URL: http://codereview.chromium.org/2020003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When you first logged in to Chrome OS, it used to say "your account is not set up to sync" until you downloaded the initial sync. Now it follows the regular sync signup flow where it's "account details are not yet entered" until the authentication happens, then it's "setup in progress" while downloading the initial download, then it's "your account is set up to sync."
BUG=maybe in chrome OS tracker?
TEST=build chrome OS. log in to chrome OS with a new account. Immediately check wrench->options->personal stuff. It should not say "your account is not set up to sync..."
Review URL: http://codereview.chromium.org/2023004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for instrumenting Chrome and Chrome Frame for performance measurements with ETW.
BUG=none
TEST=Unittests in this CL.
Review URL: http://codereview.chromium.org/2020002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1979005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42645
TEST=Existing plugin tests continue to pass; nothing should change.
Review URL: http://codereview.chromium.org/2011005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43347
TEST=included
Review URL: http://codereview.chromium.org/2003006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43347
TEST=included
Review URL: http://codereview.chromium.org/2048002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it so that the code carefully shuffled rects, points, and sizes
through the right conversions as it moves from view coordinates to
screen coordinates (to position the popup).
This only really comes up when you're debuggin whether your pretty
scalable PDF graphics really work by using Quartz Debug to set the
scale factor to 3 or something.
BUG=40999
TEST=See bug
Review URL: http://codereview.chromium.org/2028004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1969004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Reduce the rate at which we upload UMA stats.
r=laforge
Review URL: http://codereview.chromium.org/1999003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The interface (for perf reasons) snapshots the histogram
name, and reuses it in future calls. As a result, any attempt
to modulate (change) the name between call is ignored.
This change uses a DCHECK to detect such abuse.
BUG=43377
BUG=43375
r=vandebo
Review URL: http://codereview.chromium.org/2019001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
more unit tests for Delete.
BUG=42374
TEST=included
Review URL: http://codereview.chromium.org/1763008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugzilla.redhat.com/show_bug.cgi?id=581256
The SELinux policy doesn't let chrome_sandbox touch other processes' oom_adj
and we're spamming the log.
(See comments in the patch for details)
http://codereview.chromium.org/2005006/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4ab711db8ace2106fea6a95e12d2da6fbe4f78f7.
TBR=tommi
Review URL: http://codereview.chromium.org/2014004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
themselves, navigate to other pages in the same extension, persist their
state using # after the URL, etc.
TEST=write an extension that reloads its page action pop-up (e.g. on a button click), see that before this change it does not work, after it does
BUG=none
Review URL: http://codereview.chromium.org/1947002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34176
TEST=none
Review URL: http://codereview.chromium.org/1794009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flaky instead of disabled. Add the corresponding bug to the comment.
BUG=43586
TEST=none
Review URL: http://codereview.chromium.org/1979004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1985008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac OS X uses a fixed default stack size of 512kB, which is too small for some
purposes. glibc on Linux uses ulimit -s, which is both a more reasonable thing
to do, and is generally set to a rational limit, such as 8MB.
BUG=43422
TEST=None really on the trunk. On the Mac 375 branch, using the .pac file on
the bug, Chrome should not crash on startup.
Review URL: http://codereview.chromium.org/2035007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We cache and suppress sending progress notifications till
we get the first OnDataAvailable. This is to prevent
mshtml from making up its mind about the mime type.
However, this is the invasive part of the patch and
could trip other software that's due to mistimed progress
notifications. It is probably not good to hide redirect
and some cookie notifications.
We only need to suppress data notifications like
BINDSTATUS_MIMETYPEAVAILABLE,
BINDSTATUS_CACHEFILENAMEAVAILABLE etc.
This is an atempt to reduce the exposure by starting to
cache only when we receive one of the interesting progress
notification.
BUG=42611
TEST=none
Review URL: http://codereview.chromium.org/2046003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than for every
item in a WriteTransaction originals array, and make sure to restore items into dirty_metahandles
on save changes failure to avoid data loss.
This prevents a situation where after a SaveChanges, a "clean" (not dirty) item will pass the
SafeToPurgeFromMemory filter because is_dirty is false, but it is in fact still in dirty_metahandles,
and we yank it from metahandles_index. This causes a crash later on as GetByHandle will return NULL
for items in this boat. The other part of this fix makes sure we don't lose a bookmark change on
browser restart due to a single sqlite operation failing during SaveChanges by restoring items into the
dirty index.
BUG=43047,40341
Review URL: http://codereview.chromium.org/2043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/1735018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
implementation is a copy of the WebKit code, I will figure out how to reuse it soon.
Review URL: http://codereview.chromium.org/2011004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of using #if 0.
TBR=maruel
TEST=none
BUG=10611
Review URL: http://codereview.chromium.org/1990007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=johnnyg
Review URL: http://codereview.chromium.org/2040004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46706 0039d316-1c4b-4281-b951-d872f2087c98
|