| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow RenderText selection bounds amid multi-char graphemes.
Add a consolidated IsValidLogicalIndex implementation.
(this is less strict than the renamed IsValidCursorIndex)
Use adjacent cursor positions in MoveCursor as needed.
(prevents invalid cursors when collapsing selections)
Skip painting empty glyph ranges on Windows.
Add a unit test; minor cleanup and comment changes.
BUG=327903,366786
TEST=Search for "จำลอง" in the omnibox; enter "จ" and get a valid selection of the inline autocomplete text.
R=asvitkine@chromium.org
Review URL: https://codereview.chromium.org/252563003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpStreamFactoryImpl::Job since that already happens (more correctly)
in QuicStreamFactory.
Fix a bug where QuicStreamFactory would not mark Alternate-Protocol broken
under all circumstances.
Review URL: https://codereview.chromium.org/255713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
number of times.
Clear the callbacks from ExtensionDownloadsEventRouterData when one is run so that it won't be re-run when the event page is unloaded.
Add DCHECKs to callbacks in DownloadTargetDeterminer to check that they are only called when they are expected.
Add a DelayedTask timeout to make sure that a callback is called within 15 seconds.
BUG=360332,302071
Review URL: https://codereview.chromium.org/249853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes an issue with duplicate icons appearing in the app list
in certain situations. This was being caused by TopIconAnimationViews
not cleaning themselves up when the app list window is hidden.
This issue likely didn't manifest on ChromeOS due to the whole app list
being torn down on close which would have destroyed the views.
It was also reset dragging_for_reparent_item_ was not
cleaned up causing a DCHECK to happen when reparenting again.
BUG=358560
TEST=Drag app list item out of folder and press ESC while folder is
disappearing.
Review URL: https://codereview.chromium.org/262633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases, the touch selection quick menu is needed to be shown
under the selected text. If touch selection handles are not far enough,
the quick menu might cover them and make it impossible to drag them.
For such cases, we move the quick menu down a bit to prevent the
overlap.
BUG=366320
Review URL: https://codereview.chromium.org/251143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be used after the ui::PlatformEventSource is destroyed.
This CL is a prerequisite for https://codereview.chromium.org/235733003/
BUG=365947
TEST=None
Review URL: https://codereview.chromium.org/263513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL follows up from comments in https://codereview.chromium.org/261523006/
Use profile() instead of profile()->GetOriginalProfile().
Remove unnecessary DCHECK.
BUG=354367
Review URL: https://codereview.chromium.org/269543007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out we were creating one of these for nearly every unittest. This led
to a couple of problems:
1. Cycle time. With this patch, "tools/telemetry/run_tests Browser" is 20-25%
faster (195s -> 150s).
2. Spam. With this patch, we output many fewer warnings about missing flash.
BUG=337829
Review URL: https://codereview.chromium.org/240593005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Move handling of the dummy file descriptor into SetuidSandboxClient.
Review URL: https://codereview.chromium.org/262533004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Merge internal change: 65913245
R=rch@chromium.org
Review URL: https://codereview.chromium.org/266723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=366807
Review URL: https://codereview.chromium.org/259663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the lifetime of DirectoryTypeDebugInfoEmitters,
DirectoryCommitContributors, and DirectoryUpdateHandlers. Under the old
lifetime management design, we had no state that lived beyond
a configure cycle. This would be bad, since we want the debug info
counter values to remain after the initial configure is done. The
refactoring ensures that the DirectoryTypeDebugInfoEmitters will live as
long as their data type is enabled. As a side effect, the commit
contributors and update handlers get to live that long, too.
Plumbs the DirectoryTypeDebugInfoEmitters through the commit contributor
and update handler classes. This prepares them for updating counters
and emitting events from sync/engine/ code, although this functionality
won't be implemented until the next patch in the series.
BUG=328606
Review URL: https://codereview.chromium.org/260613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/251223003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The dcheck does not make sense since user could manually change the URL to remove the source param.
BUG=368511
Review URL: https://codereview.chromium.org/264613007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322664
Review URL: https://codereview.chromium.org/254863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blink uses the "State" field on a WebTouchPoint to generate a
WebCore::TouchEvent from a WebTouchEvent, however, when converting back
to pass to plugins it doesn't set this field properly. The changed/target
fields should be removed from WebTouchEvent and Blink should reassemble
the WebTouchEvent into the same form that it expects it in. This work is
tracked in crbug.com/358132; however, it's longer term. This patch is a
bandaid fix for <webview> apps in the interm.
BUG=352195
Review URL: https://codereview.chromium.org/237773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileChooserViewBrowserTest.ViewProfileUMA leaks memory inside ProfileChooserView::CreateProfileChooserView().
> UMA for New Profile Management. Track User-Menu Tutorial actions with Histograms.
>
> Specifically tracking Tutorial Display, Tutorial Accept
> and Tutorial Dismissal.
>
> Googlers:
> View the Enrollment section of the design doc for details.
> https://docs.google.com/a/google.com/document/d/1ybiN1r2xAlMj0PBABH63PJIyVWhsM409xPpZI4zlmck
>
> BUG=357693
> TEST=Interact with the user menu and the tutorial card. Verify
> that UMA Histograms reflect the actual behaviour.
>
> Review URL: https://codereview.chromium.org/227083007
TBR=mlerman@chromium.org
Review URL: https://codereview.chromium.org/269543012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/258663003/)
Reason for revert:
Likely cause of all Mac browser_tests failures
[4296:71427:0501/193356:FATAL:video_util.cc(145)] Check failed: !(view_area.height() & 1).
0 libbase.dylib 0x698ac3ef base::debug::StackTrace::StackTrace() + 63
1 libbase.dylib 0x698ac44b base::debug::StackTrace::StackTrace() + 43
2 libbase.dylib 0x69951672 logging::LogMessage::~LogMessage() + 82
3 libbase.dylib 0x699500eb logging::LogMessage::~LogMessage() + 43
4 libmedia.dylib 0x67756110 media::LetterboxYUV(media::VideoFrame*, gfx::Rect const&) + 928
5 libmedia.dylib 0x6775773c media::CopyRGBToVideoFrame(unsigned char const*, int, gfx::Rect const&, media::VideoFrame*) + 492
6 libcontent.dylib 0x75f39814 content::(anonymous namespace)::RenderVideoFrame(SkBitmap const&, scoped_refptr\u003Cmedia::VideoFrame> const&, base::Callback\u003Cvoid ()(bool)> const&) + 2420
Original issue's description:
> Use texture-backed VideoFrame pipeline for Aura desktop capturing.
>
> BUG=269312
> TEST=local build, run on CrOS snow
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267717
TBR=fischman@chromium.org,hshi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=269312
Review URL: https://codereview.chromium.org/267813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=dtu@chromium.org
BUG=333078
Review URL: https://codereview.chromium.org/264453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
win_chromium_rel failure unrelated to this CL
NOTRY=True
Review URL: https://codereview.chromium.org/264463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
win_chromium_rel failure not related
NOTRY=True
Review URL: https://codereview.chromium.org/265703006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
debug a crash in release builds.
TBR=samarth@chromium.org
BUG=367204
TEST=none
Review URL: https://codereview.chromium.org/265743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ERR_INTERNET_DISCONNECTED will be considered as transient error, as interface
especially a wireless can interface can go up and down in a spotty area.
Since we want to use these sockets, if there are any temporary problems
like interface down or some sort. Otherwise application has to be restarted.
BUG=364216
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/240663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just a refactor; effectively reverting SVN 266176 and rewriting it so
that AppListController re-centers the app list when the screen bounds
change (AppListView no longer needs to do this itself).
Rationale: This architecture is simpler. On subsequent CLs I was having
trouble plumbing more state (specifically, the virtual keyboard state)
down into AppListView; this will mean we can do it from
AppListController which has easy access to the virtual keyboard.
BUG=363928
Review URL: https://codereview.chromium.org/260663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes a hack I added in [1] which enabled the fast text
autosizer for tot and dev by default. Once [2] lands, this will now be
on by default.
[1] https://src.chromium.org/viewvc/chrome?view=rev&revision=258661
[2] https://codereview.chromium.org/249943002/
Reviewers: Please do not check the commit box just yet.
BUG=365911
Review URL: https://codereview.chromium.org/249573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have many windows that assume a transparent background, such as drag
windows. Using an ARGB visual means that drag representations can mostly
be transparent, with nicer rounded corners, and windows which draw their
own shadows.
However, we can't turn this on by default as is. While this works with
--disable_gpu and theoretically on the open source drivers, it won't
work with NVidia's drivers. Put this behind a flag so we can do further
experimenting.
BUG=347333,369209
Review URL: https://codereview.chromium.org/266643003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=269312
TEST=local build, run on CrOS snow
Review URL: https://codereview.chromium.org/258663003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Histograms.
Specifically tracking Tutorial Display, Tutorial Accept
and Tutorial Dismissal.
Googlers:
View the Enrollment section of the design doc for details.
https://docs.google.com/a/google.com/document/d/1ybiN1r2xAlMj0PBABH63PJIyVWhsM409xPpZI4zlmck
BUG=357693
TEST=Interact with the user menu and the tutorial card. Verify
that UMA Histograms reflect the actual behaviour.
Review URL: https://codereview.chromium.org/227083007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead make ChromeBookmarkClient register as an observer of
BookmarkModel to watch for events when bookmark nodes are deleted.
BUG=367707
TEST=add, remove some bookmarks, make sure chrome does not crash.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/261583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://chromiumcodereview.appspot.com/260833002/
TBR=rsesek
NOTRY=true
Review URL: https://codereview.chromium.org/260893015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates NaCl revision from 13106 -> 13115
This CL reverts revision 266284.
Now that we have split up the toolchain into multiple tars, we should
use the package versioning script to manage which tars to extract.
Unfortunately, currently the SDK uses different directory names compared
to what the NaCl toolchain directories normally use, so we also must map
and move the toolchain directories to the SDK ones.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3839
Review URL: https://codereview.chromium.org/261773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/257303003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome OS needs to have access to the metrics aggretion and serialization logic
to build a metric sender service replacing chrome. Protobuf definitions are
moved to components too.
The code remaining will be extrated in components/metrics and
components/variation during a refactoring later this year.
BUG=chromium:360183
TEST=run unittests
TBR=sky@chromium.org, benwells@chromium.org
Review URL: https://codereview.chromium.org/239093004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=284770
Review URL: https://codereview.chromium.org/266673009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This allows them to remove their NPAPI plugin.
BUG=NONE
Review URL: https://codereview.chromium.org/260893010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Updating G-services settings to provide checkin and registration URLs as GURLs
Updating checkin_interval to be a time delta, removing fixed TODOs
BUG=359254
Review URL: https://codereview.chromium.org/244883004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=368902
TEST=(see bug)
R=rpaquay@chromium.org
Review URL: https://codereview.chromium.org/266693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mojo webui test in content_browsertests was not the proper place to
perform bindings-related fuzzing (though it was initially convenient). As a
first step, move the existing tests to the new "framework" sky added in
https://src.chromium.org/viewvc/chrome?revision=267208&view=revision
This also restores the webui code to something near its original purpose,
although I've kept a few of the hooks that may be useful as real webui
tests are added.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/268593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extension and web store can support them.
BUG=345806
Review URL: https://codereview.chromium.org/258373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=367900
R=ben@chromium.org
Review URL: https://codereview.chromium.org/255043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's flaky on Win/Mac.
BUG=369349
TEST=gpu bots
R=bajones@chromium.org
TBR=bajones@chromium.org, kbr@chromium.org
Review URL: https://codereview.chromium.org/265833009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=358315
Review URL: https://codereview.chromium.org/245933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This comment directs the reader where to find the display format string
specification; it has moved to a new location.
NOTRY=true
Review URL: https://codereview.chromium.org/260903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring back a little bit of sanity to BPF_TEST. Remove a lot of void* types and
their associated reinterpret_cast and enjoy type checking.
BUG=368970
R=jorgelo@chromium.org, mdempsky@chromium.org
Review URL: https://codereview.chromium.org/260963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These methods have always been unused.
NOTRY=true
Review URL: https://codereview.chromium.org/251883003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change RenderViewTest::GetElementBounds to support subpixel values (by
rounding to full pixels for now) in preparation for moving blink to
return values with subpixel precision for offsetWidth and friends.
R=phajdan.jr@chromium.org
BUG=360889
Review URL: https://codereview.chromium.org/260963004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
NOTRY=true
Review URL: https://codereview.chromium.org/260893009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* includes changes to make the naming consistent between
bytes_downloaded and downloaded_bytes
BUG=366388
Review URL: https://codereview.chromium.org/268673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267691 0039d316-1c4b-4281-b951-d872f2087c98
|