summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Refactor Pickle Read methods to use higher performance PickleIterator.jbates@chromium.org2012-03-07129-765/+862
| | | | | | | | | | | | | | | | There was a lot of redundant error checking and initialization code in all Pickle Read methods because of the void** iterator type. This change replaces the void* iterator with PickleIterator, which encapsulates the read pointer so that less error checking and initialization code is needed for reading. PickleIterator has all the necessary data to do the actual reading. The advantage of having it provide Read methods (as opposed to leaving them solely in the Pickle interface) is that the callers do not need to pass around the const Pickle* once they have a PickleIterator. Followup CLs will refactor the call sites to remove const Pickle* arguments where they are now unnecessary. Then the Pickle::Read* methods can be removed entirely. The alternative approach would have been to change the Pickle::Read methods to non-const and remove the iterator parameter (making Read methods advance an internal read pointer). Unfortunately, the const Read with iterator design is entrenched throughout the chromium code, making this a much more complex change with the same performance outcome. BUG=13108 Review URL: https://chromiumcodereview.appspot.com/9447084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125447 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring to make GpuPerformanceStats part of gpu info collection.zmo@chromium.org2012-03-0718-178/+410
| | | | | | | | | | | | | Then expand GpuBlacklist so we could blacklist GPU features based on GpuPerformanceStats. This is Windows only feature. BUG=116350 TEST=waterfall R=vangelis Review URL: https://chromiumcodereview.appspot.com/9616036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125446 0039d316-1c4b-4281-b951-d872f2087c98
* Uninitialized variable.viettrungluu@chromium.org2012-03-071-1/+2
| | | | | | | | | BUG=114015 Review URL: https://chromiumcodereview.appspot.com/9622016 Patch from girard@chromium.org <girard@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125445 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 125081 - Don't use NTP for app install if NTP does not show apps page.xiyuan@chromium.org2012-03-074-14/+39
| | | | | | | | | | | | | | | | | | | + ExtensionInstallUIBrowserTest.AppInstallConfirmation* expect to open a NTP. Skip that part of test for now; + Fix the "Show me" link in extension install bubble to open ash applist instead of NTP; + Use the USE_ASH instead of USE_AURA in new_tab_ui since it's ash integration; BUG=116318,117087 TEST=Verify that extension install bubble shows up instead of NTP after extension install. Review URL: http://codereview.chromium.org/9595025 Review URL: http://codereview.chromium.org/9616032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125444 0039d316-1c4b-4281-b951-d872f2087c98
* gdata: Disable all tests in gdata_browsertest.ccsatorux@chromium.org2012-03-071-4/+4
| | | | | | | | | | | | | | Some of them are failing. Let the original author to fix them... http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tester%20%282%29/builds/542/steps/browser_tests/logs/stdio#failure9 http://build.chromium.org/p/chromium.chromiumos/waterfall?builder=Linux%20ChromiumOS%20GTK BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9623010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125443 0039d316-1c4b-4281-b951-d872f2087c98
* Enable audio/video tag in content_shellvrk@chromium.org2012-03-0715-52/+74
| | | | | | | | | | | | | | | | Some media initialization work needed to be added to the shell in order for the ffmpeg stubs to be loaded and for the media tags to be recognized. AudioManager also needed to be added to the shell, as the Chromium-equivalent lives in BrowserProcessImpl, and the media code should not assume the MediaInternals has been created. BUG=112043,116906 TEST=content_shell builds and can play the videos in the bug above Review URL: http://codereview.chromium.org/9316077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125442 0039d316-1c4b-4281-b951-d872f2087c98
* In CrMallocErrorBreak, do not kill the process if errno is ENOMEM.rsesek@chromium.org2012-03-072-6/+31
| | | | | | | | | | | | | | | | This will allow large JPEG decodes to be handled and optionally killed by the OOM killer instead. Based on a sampling of the other malloc_error_break() bugs ("unaligned pointer", "freed was not allocated", "double free", and "incorrect checksum"), this will only affect the "allocate region" error, as those others happen at free(), rather than malloc(). BUG=103980 TEST=Covered by ProcessUtilTest.MacTerminateOnHeapCorruption Review URL: http://codereview.chromium.org/9597031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125441 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Limit D3D devices to one per Present Thread (4 max).apatrick@chromium.org2012-03-076-296/+286
| | | | | | | | | | | | | Instead of one D3D device per unsuspended tab, there is one D3D device per Present Thread plus one additional swap chain per unsuspended tab. Also, the swap chains are completely destroyed when a tab is suspended, rather than resizing the device swap chain to 1 x 1. Specified flag on D3D device creation to tell it not to create worker threads to evaluate vertex shaders because we aren't using vertex shaders here but the devices appeared to create some (actually lots) anyway. Sent Suspend notification directly from browser IO thread to present thread rather than via UI thread so tehy don't get unnecessarily held up if the UI thread is busy. BUG=116175,115707 Review URL: https://chromiumcodereview.appspot.com/9565043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125439 0039d316-1c4b-4281-b951-d872f2087c98
* Ash: Polish window frame appearance for dialogs, fix app window crashjamescook@chromium.org2012-03-074-20/+56
| | | | | | | | | | | | | | | * Adjust spacing of title text for popups and dialogs. * Add header/content separator line to dialogs. * Add custom title text color, dark gray instead of black. * Fix crash when maximizing app windows, which causes the frame to be deleted. ** There's still a problem where the maximize button doesn't actually change the window size. BUG=117075 TEST=visual, also launched file browser app in a window and maximized it, no crash Review URL: https://chromiumcodereview.appspot.com/9625012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125438 0039d316-1c4b-4281-b951-d872f2087c98
* update suppression for memory leaks on issue 82717zhaoqin@google.com2012-03-071-3/+3
| | | | | | | | | | TBR=jam@chromium.org BUG=82717 TEST=waterfall.sh Review URL: https://chromiumcodereview.appspot.com/9624016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125437 0039d316-1c4b-4281-b951-d872f2087c98
* Have sync initialization kick off TemplateURLService's lazy load.stevet@chromium.org2012-03-071-2/+6
| | | | | | | | | | | | We now force the lazy load in SearchEngineDTC much like we do with Autofill to prevent Sync from waiting on a TURL-related action. BUG=116426 TEST=Verify 116426 Review URL: http://codereview.chromium.org/9615019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125436 0039d316-1c4b-4281-b951-d872f2087c98
* ash uber tray: Make the date item clickable.sadrul@chromium.org2012-03-074-9/+59
| | | | | | | | | | | | Clicking the date item brings up the advanced-settings dialog, which allows changing date, timezone etc. BUG=110130 TEST=none Review URL: https://chromiumcodereview.appspot.com/9622015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125435 0039d316-1c4b-4281-b951-d872f2087c98
* Scroll End Events report velocities "on rails"tdresser@chromium.org2012-03-072-2/+114
| | | | | | | | | | BUG=117159 TEST=GestureRecognizerTest.GestureEventVerticalRailFling, GestureEventHorizontalRailFling, GestureEventNonRailFling Review URL: http://codereview.chromium.org/9608004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125434 0039d316-1c4b-4281-b951-d872f2087c98
* [File Manager] Open documents in Google Docskaznacheev@chromium.org2012-03-073-2/+86
| | | | | | | | | BUG=chromium-os:27136 TEST= Review URL: https://chromiumcodereview.appspot.com/9620004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125433 0039d316-1c4b-4281-b951-d872f2087c98
* gdata: Add a private extension API to get gdata files.satorux@chromium.org2012-03-074-17/+147
| | | | | | | | | | | | | | | This initiates downloading of gdata files if these aren't cached, and returns the local file paths to the javascript layer. Along the way, remove "optional": "false". false is set by default, and "false" as string is true in boolean context. Replace "true" with true as well. BUG=chromium-os:27404 TEST=manually Review URL: https://chromiumcodereview.appspot.com/9546032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125432 0039d316-1c4b-4281-b951-d872f2087c98
* NaCl: Remove declaration of non-existent methodmseaborn@chromium.org2012-03-071-2/+1
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9592039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125431 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error message for restricted sign in.nkostylev@chromium.org2012-03-071-1/+1
| | | | | | | | | | BUG=chromium-os:24485 TEST=None Review URL: http://codereview.chromium.org/9624007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125430 0039d316-1c4b-4281-b951-d872f2087c98
* Roll OCMOCK forward to 8b8793cf29a5bac0541421ea06c7dff071afb25ekushi.p@gmail.com2012-03-075-11/+9
| | | | | | | | | | BUG=113894 TEST=unit_tests Review URL: http://codereview.chromium.org/9616059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125428 0039d316-1c4b-4281-b951-d872f2087c98
* Separate more out of PepperPluginDelegateimplbrettw@chromium.org2012-03-0711-315/+482
| | | | | | | | | | | | | | | Separate out the device enumeration event handler. I also moved the media stream type conversions into this class in an effort to keep them in one place and make the plugin delegate impl smaller. Separate out the Image2D code. Separate out a little more of the audio code using factory functions. Review URL: http://codereview.chromium.org/9455079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125427 0039d316-1c4b-4281-b951-d872f2087c98
* suppress memory leak in LoginPromptTest.TestTwoAuthszhaoqin@google.com2012-03-071-0/+13
| | | | | | | | | | TBR=joi@chromium.org BUG=117208 TEST=waterfall.sh Review URL: https://chromiumcodereview.appspot.com/9608010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125426 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing rename of LoadJSON in json_schema_compiler.mkwst@chromium.org2012-03-071-3/+3
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/9623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125425 0039d316-1c4b-4281-b951-d872f2087c98
* C++ Readability review for stevenjbstevenjb@chromium.org2012-03-073-183/+288
| | | | | | | | | | | | Original CLs: http://codereview.chromium.org/7314025, http://codereview.chromium.org/7841048 (tests) BUG=none TEST=none Review URL: http://codereview.chromium.org/7942003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125424 0039d316-1c4b-4281-b951-d872f2087c98
* Protector: valid signatures are not updated during Web Data migration.ivankr@chromium.org2012-03-075-116/+159
| | | | | | | | | | | | | | *) All Protector migrations are merged. *) If a valid signature is present in pre-39 version table, it is not updated. *) This also fixes http://crbug.com/115717 BUG=115717 TEST=WebDatabaseMigrationTest.* Review URL: http://codereview.chromium.org/9600079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125423 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Make C++ wrappers for PPB_NetAddress_Private backwards compatible.viettrungluu@chromium.org2012-03-072-41/+74
| | | | | | | | | | | | (The compatibility is needed for Pepper Flash to use the wrappers.) Also fix the IDL file to correctly specify that version 1.0 is only available starting with M19. (The generated header itself didn't change, since we're currently generating for M19.) Review URL: https://chromiumcodereview.appspot.com/9618014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125422 0039d316-1c4b-4281-b951-d872f2087c98
* Adding persistance for gesture recognition parms.girard@chromium.org2012-03-078-1/+168
| | | | | | | | | | | | | Observer updates GestureRecognition parameters when settings change. BUG=114015 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124433 Review URL: http://codereview.chromium.org/9460001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125421 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed some TODO comments so they wouldn't show up in the docs.jond@google.com2012-03-075-17/+24
| | | | | | Review URL: http://codereview.chromium.org/9600025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125420 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for different tween types in ui::Layer animationsvollick@chromium.org2012-03-0710-43/+119
| | | | | | | | | | | | Also includes code for cutting down on the number of draws requested during animations. BUG=None TEST=None Review URL: http://codereview.chromium.org/9599003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125419 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes ash component build.sky@chromium.org2012-03-071-2/+3
| | | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/9620012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125418 0039d316-1c4b-4281-b951-d872f2087c98
* gdata: Fix the build...satorux@chromium.org2012-03-071-2/+2
| | | | | | | | | BUG=none TEST=browser_tests built Review URL: https://chromiumcodereview.appspot.com/9608007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125417 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2012-03-071-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125416 0039d316-1c4b-4281-b951-d872f2087c98
* Improves flaky unit tests on Windows and Mac OS X.henrika@chromium.org2012-03-072-27/+51
| | | | | | | | | | BUG=116961 TEST=media_unittests on Windows and Mac OS X Review URL: http://codereview.chromium.org/9625002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125415 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit r110031:110053.senorblanco@chromium.org2012-03-072-5/+1
| | | | | | | TBR=ukai Review URL: https://chromiumcodereview.appspot.com/9622011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125414 0039d316-1c4b-4281-b951-d872f2087c98
* [linux] Revert use of 'open sans' on Linux.csilv@chromium.org2012-03-074-20/+2
| | | | | | | | BUG=114402 TEST=Web-UI pages show up in Arial. Review URL: https://chromiumcodereview.appspot.com/9609012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125413 0039d316-1c4b-4281-b951-d872f2087c98
* Aura: Allow WK renderer to queue next frame before drawing UI.backer@chromium.org2012-03-071-1/+5
| | | | | | | | | | | | RWHVA is also a OnCompositingEnded observer. Without this patch, RWHVA has to wait until the UI draws before it gets signaled. With this patch RWHVA is notified immediately, which allows the corresponding RW to queue up it's next frame. BUG=none TEST=run './chrome --show-fps-counter http://www.webkit.org/blog-files/3d-transforms/poster-circle.html' on desktop where vsync is supported; see a consistent 60 FPS instead of 30 FPS Review URL: http://codereview.chromium.org/9619005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125411 0039d316-1c4b-4281-b951-d872f2087c98
* gdata: Add a missing file.satorux@chromium.org2012-03-071-0/+124
| | | | | | | | | | | Should have been included in crrev.com/125404 BUG=none TEST=browser_tests built Review URL: https://chromiumcodereview.appspot.com/9620011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125410 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2012-03-071-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125409 0039d316-1c4b-4281-b951-d872f2087c98
* Roll GRIT to r17.joi@chromium.org2012-03-071-1/+1
| | | | | | | | | BUG=none Review URL: http://codereview.chromium.org/9546007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125408 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppression for bug 116526.akalin@chromium.org2012-03-071-9/+1
| | | | | | | | | | | | Leak should have been fixed by fixes for 115987. BUG=116526,115987 TEST= TBR=glider@chromium.org Review URL: https://chromiumcodereview.appspot.com/9592044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125407 0039d316-1c4b-4281-b951-d872f2087c98
* Disable HostResolverImplTest.CanceledRequestsReleaseJobSlotsakalin@chromium.org2012-03-071-1/+2
| | | | | | | | | | | | It times out flakily. BUG=117187 TEST= TBR=szym@chromium.org Review URL: https://chromiumcodereview.appspot.com/9619012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125406 0039d316-1c4b-4281-b951-d872f2087c98
* Add the first version of GDataTest.satorux@chromium.org2012-03-076-2/+81
| | | | | | | | | | | | | | | | | This CL introduces a browsertest case for gdata by introducing the following changes: - testserver: add GDataHandler and TYPE_GDATA. - InProcessBrowserTest: allow invoking customized test server. - gdata_browsertest.cc: actual test code. Currently it only covers a part of full APIs, to make sure if my current approach is looking okay. BUG=chromium-os:26355 TEST=passed locally Review URL: https://chromiumcodereview.appspot.com/9597014 Patch from Jun Mukai <mukai@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125404 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Move ScopedGObject into ui/base/gtk/scoped_gobject.htfarina@chromium.org2012-03-076-27/+42
| | | | | | | | | R=erg@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9594009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125403 0039d316-1c4b-4281-b951-d872f2087c98
* Add a SetDisplayName() method to DownloadItemasanka@chromium.org2012-03-075-2/+34
| | | | | | | | | | BUG=78085 TEST=unit tests Review URL: http://codereview.chromium.org/9546002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125402 0039d316-1c4b-4281-b951-d872f2087c98
* Rename NaCl/pepper gamepad interface from _dev to stablescottmg@chromium.org2012-03-0728-86/+85
| | | | | | | | | | | | | Following API review, and revisions here: https://chromiumcodereview.appspot.com/9405033/. This change is just the mechanical renames and bump of version number to 1.0. BUG=112879, 115119 Review URL: http://codereview.chromium.org/9566022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125399 0039d316-1c4b-4281-b951-d872f2087c98
* Add mode 'hashtable'.maruel@chromium.org2012-03-074-147/+225
| | | | | | | | | | | | | | | Refactor the code to be easier to read. Add more integration tests. R=rogerta@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/9553015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125398 0039d316-1c4b-4281-b951-d872f2087c98
* Switch chrome to use TabContentsViewWin. The goal is to eventually have all ↵jam@chromium.org2012-03-0717-56/+388
| | | | | | | | | | | TabContentsView implementations in content, since a lot of classes that they would depend on shouldn't be exposed to embedders. (for others reading: Ben said once this is done TabContentsViewAura will be created and we can remove TabContentsViewViews). BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9600004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125396 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DownloadItem::SetDangerType().asanka@chromium.org2012-03-077-33/+13
| | | | | | | | | | | | Then get rid of MarkUrlDangerous, MarkFileDangerous, and MarkContentDangerous. BUG=78085 TEST=Compiles Review URL: http://codereview.chromium.org/9546028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125395 0039d316-1c4b-4281-b951-d872f2087c98
* Check for null pointer.rogerta@chromium.org2012-03-071-0/+4
| | | | | | | | | | | | | | In incognito windows, there is no profile sync service. The one-click signin feature was accessing the pointer without checking if it was null. BUG=117005 TEST=Open an incognito window and signin to any google service. Make sure the browser does not crash. Review URL: http://codereview.chromium.org/9605036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125393 0039d316-1c4b-4281-b951-d872f2087c98
* speech: Do not use unix_hacker style for virtual methods.tfarina@chromium.org2012-03-076-13/+14
| | | | | | | | | | This patch renames SpeechInputBubble::web_contents() to GetWebContents(). R=satish@chromium.org Review URL: https://chromiumcodereview.appspot.com/9594034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125392 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NativeTabContentsContainerGtk since it's not used on any platform.jam@chromium.org2012-03-073-198/+0
| | | | | | Review URL: https://chromiumcodereview.appspot.com/9605034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125390 0039d316-1c4b-4281-b951-d872f2087c98
* Moved the implementations of ReleaseOutputStream() and ReleaseInputStream() ↵xians@chromium.org2012-03-0717-521/+627
| | | | | | | | | | | | | | | to AudioManagerBase and let all the AudioManagerPlatforms inherit the same implementations. Also moved the MakeAudioOutputStream() and MakeAudioInputStream() to AudioManagerBase, separate the AUDIO_PCM_LINEAR mode and AUDIO_PCM_LOW_LATENCY mode into two different functions inside the AudioManagerPlatforms. So that the structure is clearer and also easier to deprecate the AUDIO_PCM_LINEAR for the future. Made the destructor of the AudioManagerPlatforms protected so it can be called by only the AudioManagerBase. BUG=116064 TEST=media_unittests Review URL: http://codereview.chromium.org/9570014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125389 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 20:01:06 +0000