| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=52682
TEST=included
Review URL: http://codereview.chromium.org/3142022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52723
Review URL: http://codereview.chromium.org/3126023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3169029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=rolandsteiner
Review URL: http://codereview.chromium.org/3119029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
New hooks allow the user to pause/resume/cancel/remove downloads and more.
Review URL: http://codereview.chromium.org/3176016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3116019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In browser_resources.grd, both IDR_SYNC_SETUP_FLOW_HTML and
IDR_REMOTING_SETUP_FLOW_HTML are point to setup_flow.html although they
are different files in different folders. ResourceBundle gets confused
and always return the later one when asked for IDR_SYNC_SETUP_FLOW_HTML.
This problem only happens on Windows but not Linux.
This patch tries to avoid this problem by renaming remoting files with
a remoting_ prefix.
BUG=52777, 52625
TEST=Setup sync now loads the correct setup_flow.html
Review URL: http://codereview.chromium.org/3191013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'd like to see how common it is to use a network file system for
your home directory. This would help evaluate how important it is
to support these users.
See also:
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/b43d2905f079fa1c
Review URL: http://codereview.chromium.org/3187011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3157027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui_test.
This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.
TEST=ui_tests in Release mode
BUG=49838
Review URL: http://codereview.chromium.org/2805100
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3169031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make them browsing them easier in Keychain Access and certutil.
It also gives them a more useful name in Keychain permission dialogs.
The friendly name is currently just the hostname which requested
the key. It would be nice to have some surrounding text with
localization, but this works for now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2806045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46981
TEST=none
TBR=glen
Review URL: http://codereview.chromium.org/3108035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I considered ASCII, but it's producing what is intended to be a
human-readable string. For example, in theory the "bytes/s" annotation
could be localized into a language where the "b" is non-ASCII.
Review URL: http://codereview.chromium.org/3107021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3146024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
things in a way that seems better to me.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3135034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes one behavioral change: a mouse release with a successful HitTest and |canceled| true will set the state to HOT instead of NORMAL. This seemed more correct to me.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3175027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were a bunch of TODO comments whose action items were already
completed. Removing said comments.
BUG=50306
TEST=none
Review URL: http://codereview.chromium.org/3143031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Allow automagic links to types in API descriptions, using "$ref:TYPE_ID"
-Fix syntax error in callback code
-Fix a couple other small nits
BUG=52616
TEST=none
Review URL: http://codereview.chromium.org/3117029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove debugging cruft from an old bug that has been closed.
- Make it UI-thread only. This complicates ResourceMessageFilter a little, but
makes the EMS lifetime a lot easier to reason about.
BUG=no
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/3117024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr@chromium.org,
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3149026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is added. This field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion.
BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.
Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com
TBR=brettw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
worked correctly.
I think there might still be a place for this, but it is in
Browser::AdjustWindowOpenDispositionForTab(), which is a much more
constrained use case, and also isn't working correctly, because
it lacks knowledge of apps.
BUG=52442
Review URL: http://codereview.chromium.org/3199004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It turns out to be reasonably common not to have a host for some URLs, such
as data: URLs, and the extra logging actually slows down feature extraction
significantly.
Review URL: http://codereview.chromium.org/3198003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit now has this logic as of http://trac.webkit.org/changeset/65340. I
couldn't remove ViewHostMsg_DocumentLoadedInFrame/
NavigationController::DocumentLoadedInFrame since it accumulated other usages
since then.
(second attempt of r56693, this time with updated unit tests)
BUG=40395
TEST=manual testing with hp.com and keyboard shortcut search experiment,
history_uitest
Review URL: http://codereview.chromium.org/3124035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to (but not limited to) allow system update notification to have "restart" button.
* BalloonHost::EnableDOMUI() to enable DOMUI in notification page.
* chromeos::BalloonCollectionImpl::AddDOMUIMessageCallback to add
a callback for given DOMUI message.
* Added two tests cases (see below)
BUG=chromium-os:5810
TEST=TestAddDOMUIMessageCallback and TestDOMUIMessagCallback are added to notification_browsertest
Review URL: http://codereview.chromium.org/3186016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jmikhail@google.com
BUG=none
TEST=chromdriver pass on multi-dll build
Review URL: http://codereview.chromium.org/3167025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3186018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
field is recorded in visit_database.
So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries.
In the future, history extension API may allow queries to combinate with this criterion.
BUG=none
TEST=Unit tests are already included. Please test the web browser with history from previous
versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the
sources added to the visit_source table in hitory database are correct.
Original review=http://codereview.chromium.org/2906004/show
Patch by weili@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The parameter describes a list of Values that act as parameters to the callback. It is always a ListValue. It should be typed as such.
BUG=none
TEST=compile; manual testing
Review URL: http://codereview.chromium.org/3146019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3145024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.
TEST=ui_tests in Release mode
BUG=49838
Review URL: http://codereview.chromium.org/2805100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the browser chrome. This doesn't fix problems with the NTP background image offsets (see bug 51853).
This also makes sure the OTR avatar is reversed in RTL mode, and clipped as usefully as possible when there isn't enough room for the full image.
BUG=44157
TEST=Frame, toolbar, bookmark bar, and find bar all look lined up with default and custom themes, restored and maximized, LTR and RTL, side tabs and normal tabs, and in popup and app windows
Review URL: http://codereview.chromium.org/3137019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes TryKillingOldServer fails with an exception we don't catch,
which is even worse because then the new server fails to start.
We should rely on the C++ code to kill the server in a reliable way,
rather than this Python hack.
TEST=net_unittests, unit_tests, ui_tests, ...
BUG=52644
Review URL: http://codereview.chromium.org/3110025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=52750
Review URL: http://codereview.chromium.org/3171020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need the new noclone attribute since gcc tries to specialize many of the
::Read() members for the subtypes since they're only invoked from Log().
Reported by some dude named flo on IRC.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3133025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=52552
Review URL: http://codereview.chromium.org/3180018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify that the linux certs webpage is displayed in a new tab (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3116022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51786
TEST=valgrind stays green
Review URL: http://codereview.chromium.org/3183019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------
Make the saved passwords tab work.
BUG=49093
TEST=None
------------
TBR=sargrass
Review URL: http://codereview.chromium.org/3108034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We shouldn't have people in the NO group of the field trial generating
prefetching histograms. This CL removes them.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3132016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With r51258 we started requiring the TLS renegotiation extension from a
whitelist of servers that we knew supported it. When Chrome is getting MITM
attacked, this extension can be removed and this broke some debugging tools
(which intercept SSL connections) and some proxies which do the same.
This patch causes us to expect to be MITM attacked when tunneling via an HTTP
proxy and when the --allow-ssl-mitm-proxies command line flag is given.
BUG=48485
TEST=Can't really test without one of these MITM proxy machines.
http://codereview.chromium.org/3111019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jmikhail
BUG=51346
Review URL: http://codereview.chromium.org/3191010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CAPTCHA code from existing user controller and plumb into google
authenticator2.
TEST=Install ChromeOS build. Hit Captcha. Enter captcha.
BUG=50408
Review URL: http://codereview.chromium.org/3134009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ui_tests, chrome_frame_tests
BUG=52097
Review URL: http://codereview.chromium.org/3191009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If IPC send fails, further automation calls are extremely likely to fail.
Avoid wasting a lot of time on further timeouts by closing the channel
immediately on the first error.
TEST=ui_tests
BUG=51346
Review URL: http://codereview.chromium.org/3131020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52669
Review URL: http://codereview.chromium.org/3140018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56721 0039d316-1c4b-4281-b951-d872f2087c98
|