summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* A step in exposing Bitmap to JavaScript.gman@google.com2009-08-0668-1625/+1113
| | | | | | | | | | | | | | | | | | | | | The plan is to make pack.createBitmapFromRawData return an array of bitmaps. 1 bitmap if it's a standard 2d image 6 bitmaps if it's a cubemap N bitmaps if it's a volume map. The bitmaps will have a semantic so you can look at them and tell they were from a volumemap, a cubemap or a 2d image. On the way I'm attempting to clean up the code. Moving stuff out of Bitmap the did not belong there and Refactoring Bitmap so there are less If Format = stuff. Review URL: http://codereview.chromium.org/164034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22583 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit purify test exclusions to add Plugin.Refresh.dglazkov@chromium.org2009-08-061-0/+2
| | | | | | | | | | TBR=jam BUG=18598 TEST=none Review URL: http://codereview.chromium.org/164045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22582 0039d316-1c4b-4281-b951-d872f2087c98
* Lots of changes required to build on GCC in full paranoia mode with no ↵maf@google.com2009-08-0647-321/+338
| | | | | | | | warnings generated. Review URL: http://codereview.chromium.org/165013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22581 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the socket is deleted when ConnectJob times out.willchan@chromium.org2009-08-062-1/+48
| | | | | | | | | | | | It's benign since ClientSocketPoolBase has a scoped_ptr that will delete it anyway, but it hits a DCHECK since ConnectJob::ReleaseSocket() should return NULL when the ConnectJob encountered an error. Update TestConnectJobDelegate to call ConnectJob::ReleaseSocket() and EXPECT on its value. Replicate the ConnectJob tests for the late binding case (doesn't add any extra coverage since we're not executing ClientSocketPoolBase code, just ConnectJob, but this way I don't accidentally delete necessary tests when I delete all the old tests after switching over completely to late binding). BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/160664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22580 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show themes in extension config UI. This fixes various bugsaa@chromium.org2009-08-063-22/+6
| | | | | | | | | | | | | | | | where the extension config UI doesn't work right with themes. This isn't ideal because users go to chrome://extensions/ expecting themes to be listed. If they aren't there, users might be confused. But I don't have an alternate solution. Also, this change removes the error listing from the top of chrome://extensions/. These errors are just getting noisy, I don't think they provide much value. BUG=13649,18456 Review URL: http://codereview.chromium.org/160631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22578 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run the SetProxyConfig task on the UI thread as it causes a bunch of ↵ananta@chromium.org2009-08-061-14/+2
| | | | | | | | | | DCHECKS to fire in the ProxyConfigService objects. Review URL: http://codereview.chromium.org/164013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22577 0039d316-1c4b-4281-b951-d872f2087c98
* Icon loader: respect delegate's response to NotifyDelegate call (false means ↵estade@chromium.org2009-08-061-2/+2
| | | | | | | | the delegate doesn't assume ownership). Review URL: http://codereview.chromium.org/164038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22575 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an obsolete TODO comment. HostResolver has changedwtc@chromium.org2009-08-061-4/+1
| | | | | | | | | | | significantly. R=eroman BUG=none TEST=none Review URL: http://codereview.chromium.org/147165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22574 0039d316-1c4b-4281-b951-d872f2087c98
* Mark LayoutTests/fast/dom/Window/window-object-cross-frame-calls.html as flakydpranke@google.com2009-08-061-1/+1
| | | | | | | | | | | | (fail/pass/crash) BUG=none R=jrg@chromium.org TEST=none Review URL: http://codereview.chromium.org/164040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22573 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress yet another fontconfig leakdkegel@google.com2009-08-061-0/+15
| | | | | | | | | | TBR=agl BUG=18590 TEST=watch ui valgrind bots for a week Review URL: http://codereview.chromium.org/165027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22572 0039d316-1c4b-4281-b951-d872f2087c98
* Update v8 to 1.3.2, same as chrome. That version has a fix for Linux.piman@google.com2009-08-062-4/+4
| | | | | | | Review URL: http://codereview.chromium.org/164035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22571 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Save a reference to the origin passed into the StorageAreaImpl for ↵phajdan.jr@chromium.org2009-08-063-8/+3
| | | | | | | | | | | | as long" This reverts commit f604ba19d0f74aafc8d6dba3d2e53f297f8446ed. TBR=jorlow Review URL: http://codereview.chromium.org/164036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22569 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a BAD_OVERRIDE defect reported by Coverity. Change thewtc@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | prototype of the GetDefaultThemeProvider method in the base class to match the prototypes of the GetDefaultThemeProvider methods in the subclasses BrowserFrameWin and BrowserFrameGtk. R=glen BUG=17104 TEST=none Review URL: http://codereview.chromium.org/159479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22568 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix window tooltip so that it is not shown out of place.arv@google.com2009-08-061-11/+15
| | | | | | | | | | | BUG=18529 TEST=The bug is hard to reproduce but it involved moving the mouse fast over the link. Review URL: http://codereview.chromium.org/164012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22567 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Minor tweak to make the Google chrome logo line up better.arv@google.com2009-08-061-1/+1
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/165010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22566 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor ExpectedFilename() to be a little easier to understanddpranke@google.com2009-08-061-20/+29
| | | | | | | | | | BUG=none TEST=none R=tc@chromium.org Review URL: http://codereview.chromium.org/165012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22564 0039d316-1c4b-4281-b951-d872f2087c98
* Fix minor bug - start layout_test_helper before checking sys depsdpranke@google.com2009-08-061-14/+14
| | | | | | | | | | | | | Starting layout_test_helper first gives us a chance to put the system into the right config before running; not doing so makes it kind of pointless. BUG=none R=tc@chromium.org TEST=none Review URL: http://codereview.chromium.org/164014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22563 0039d316-1c4b-4281-b951-d872f2087c98
* Save a reference to the origin passed into the StorageAreaImpl for as longjorlow@chromium.org2009-08-063-3/+8
| | | | | | | | | | | | as the StorageAreaImpl exists since it only stores a pointer to it and thus it'll refer to freed memory if we don't. TEST=none BUG=none Review URL: http://codereview.chromium.org/160675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22562 0039d316-1c4b-4281-b951-d872f2087c98
* Skip the willCacheResponse-delegate-callback test since it only makes sense fordarin@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | PLATFORM(MAC). R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/164006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22560 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of Coverity fixes, rather minor severity.phajdan.jr@chromium.org2009-08-0630-40/+52
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land extension docs build/render/presubmit. The original patch, ↵rafaelw@chromium.org2009-08-0521-1190/+787
| | | | | | | | | | http://codereview.chromium.org/159607, was reverted because of incorrect dependencies. Note that the extension docs build.py is no longer a gyp build target. Review URL: http://codereview.chromium.org/159830 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22558 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where a download isn't canceled when the user requests it.paul@chromium.org2009-08-052-7/+21
| | | | | | | | | | | | | | | This particular bug only occurs when the user is prompted via save file dialog and then chooses cancel. In this case, the file selection code path for canceling was not the same as regular cancel case, so the network requests continued. BUG=18160 TEST=When prompted to save a download, choose cancel and notice that there is no further network traffic due to that download. Review URL: http://codereview.chromium.org/160627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22557 0039d316-1c4b-4281-b951-d872f2087c98
* Safari Bookmark/Favicon import.jeremy@chromium.org2009-08-059-89/+367
| | | | | | Review URL: http://codereview.chromium.org/159750 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22556 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make gfx::Canvas honor GTK font settings.derat@chromium.org2009-08-051-0/+76
| | | | | | | | | BUG=18038 TESTED=restarted chrome a bunch while mucking around with gnome-appearance-settings Review URL: http://codereview.chromium.org/164017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22555 0039d316-1c4b-4281-b951-d872f2087c98
* So tired of trying to keep up with these test expectationspkasting@chromium.org2009-08-051-6/+6
| | | | | | | | | TBR=jar BUG=9798,10380,10382,10410,18027,18584 TEST=none Review URL: http://codereview.chromium.org/164026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22554 0039d316-1c4b-4281-b951-d872f2087c98
* Yet Another Flaky Mac Crashpkasting@chromium.org2009-08-051-1/+2
| | | | | | | | | TBR=jar BUG=11795 TEST=none Review URL: http://codereview.chromium.org/165020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22552 0039d316-1c4b-4281-b951-d872f2087c98
* More updates. One crash no longer seems to occur on the Mac; a Windows test ↵pkasting@chromium.org2009-08-051-2/+1
| | | | | | | | | | | is flaky in release mode too. TBR=jar BUG=17942,18027 TEST=none Review URL: http://codereview.chromium.org/164022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22551 0039d316-1c4b-4281-b951-d872f2087c98
* A couple tests seem to be flakily crashing :(pkasting@chromium.org2009-08-051-2/+2
| | | | | | | | | TBR=jar BUG=9798,10463 TEST=none Review URL: http://codereview.chromium.org/164019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22550 0039d316-1c4b-4281-b951-d872f2087c98
* This is a quick fix for include file path issue in livesynctest related file.tejasshah@google.com2009-08-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/165015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22549 0039d316-1c4b-4281-b951-d872f2087c98
* FAIL -> CRASHpkasting@chromium.org2009-08-051-1/+1
| | | | | | | | | TBR=tc BUG=18569 TEST=none Review URL: http://codereview.chromium.org/164018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22548 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some tests that seem to be passing.pkasting@chromium.org2009-08-051-7/+0
| | | | | | | | | TBR=dglazkov BUG=10475,16639,16410,16675 TEST=none Review URL: http://codereview.chromium.org/164015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22547 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include path for header file to fix sync build.tim@chromium.org2009-08-051-1/+1
| | | | | | | I'll hold off committing until Idan lets me know I didn't butcher anything else, too :) Review URL: http://codereview.chromium.org/165004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22546 0039d316-1c4b-4281-b951-d872f2087c98
* Updated O3D to work with most recent Chrome base.apatrick@google.com2009-08-056-12/+41
| | | | | | | Added build.scons for Chrome IPC. Review URL: http://codereview.chromium.org/160616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22545 0039d316-1c4b-4281-b951-d872f2087c98
* Mark overflow-scroll-delete.html as flaky on mac debug. It's been flipping ↵tc@google.com2009-08-051-0/+2
| | | | | | | | | | | back and forth for a long time. TBR=pkasting Review URL: http://codereview.chromium.org/165009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22544 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fancy html5 draggy stuff.estade@chromium.org2009-08-053-60/+159
| | | | | | | | | | | | | | | | | | | | | Also, don't crash in release mode when the tab contents is deleted during a drag. 1) Source side: when the tab contents is going down, abort the current drag (if any). Initiate drags on a GtkInvisible (matching firefox, among other programs I assume). This lets us give up ownership of the drag widget and let the drag unwind. 2) Destination side: make a seemingly harmless GTK assert point to a crbug bug. This warrants further investigation. BUG=16249 TEST=drag around ntp thumbnails BUG=18557 In release mode, you should be able to do all the following without crashing or getting any asserts besides the two mentioned in 18557 TEST=drag something from gedit over a tab that closes TEST=drag something from the render view over a tab that closes TEST=drag something from the render view off of the browser from within a tab that closes TEST=repeat all the above with a tab that is being swapped out according to the repro steps in bug 16073 Review URL: http://codereview.chromium.org/159889 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22542 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22517.rohitrao@chromium.org2009-08-0524-493/+438
| | | | | | Review URL: http://codereview.chromium.org/165001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22541 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that we never call into WebCore::Page static methods when Page ↵dglazkov@chromium.org2009-08-058-1/+22
| | | | | | | | | | | | | | | | constructor hasn't been called. This is a top crash for Mac right now. The crash occurs because the static table of all pages in the renderer is initialized in WebCore:: Page constructor, and if we attempt to access this table before the Page was created (i.e. before WebView::Create is called), we get into a crashy situation. I am really not sure how to reproduce this, but I can defend against the situation. BUG=17555 R=darin TEST=unable to repro, speculative fix. Review URL: http://codereview.chromium.org/159887 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22540 0039d316-1c4b-4281-b951-d872f2087c98
* Draw the theme overlay. I hadn't implemented this previously becausetc@google.com2009-08-051-7/+7
| | | | | | | | | | | | I didn't have an example theme that does this. TEST=Install the Folders theme from the theme gallery and you should see a paperclip and some paper in the theme. Review URL: http://codereview.chromium.org/165002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22539 0039d316-1c4b-4281-b951-d872f2087c98
* Add the anti-clockwise waiting throbber to app mode/popup windows.tc@google.com2009-08-055-24/+50
| | | | | | | | | BUG=18181 Review URL: http://codereview.chromium.org/160653 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22537 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for unpacking and patching methods.kuchhal@chromium.org2009-08-0518-189/+338
| | | | | | | | | BUG=12849 TEST=none Review URL: http://codereview.chromium.org/160623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22535 0039d316-1c4b-4281-b951-d872f2087c98
* Fishing expedition in mac ui tests. dank@chromium.org2009-08-053-13/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds suppressions for lots of bugs. The only problems left I know of result in valgrind internal error messages. Widen suppression for 16128 to match on Mac. Remove suppression for 16210, which is a dup of 16128, and was out of date. The reference builds don't have symbols on the mac, so suppressions don't work. And they have old known valgrind issues. Disable SunSpiderReferenceTest.Perf and V8BenchmarkReferenceTest.Perf under valgrind until those problems are addressed (and possibly longer -- reference builds tend to have old valgrind errors since fixed and no longer of interest). Also, disable DownloadTest.UnknownSize under valgrind, it is known to send garbage. None of these errors are showing up on the bots for some reason; they only show up when you do a local run of shard_all_tests.sh, which does one test at a time instead of the normal batches of 30. It seems valgrind on the mac isn't stable enough to do large batches of ui tests in a single run. BUG=6522,16128,16210,17113,17451,18189,18223,18236,18252,18253,18268,18540 TEST=run tools/valgrind/shard_all_tests.sh for ui_tests on mac, verify it finds no normal valgrind warnings Review URL: http://codereview.chromium.org/159770 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22533 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing svn:ignore on several files.bradnelson@google.com2009-08-050-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22532 0039d316-1c4b-4281-b951-d872f2087c98
* Implement TabContentsViewMac::SizeContents(), so that the TabContentsViewjaphet@chromium.org2009-08-051-2/+5
| | | | | | | | | | | | gets sized properly on creation. BUG=619 BUG=15960 TEST=none Review URL: http://codereview.chromium.org/162016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout test controller simulation script to make it work for worker UI test.jianli@chromium.org2009-08-051-3/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22527 0039d316-1c4b-4281-b951-d872f2087c98
* Use a font size of 9pt in the tab titles. This is a bittc@google.com2009-08-051-5/+7
| | | | | | | | | | | bigger than before. This matches the font size used in Windows (the heights are the same), but on Linux, the text render a bit wider. BUG=17866 Review URL: http://codereview.chromium.org/160663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22525 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: clean up some code I saw while tracking down a bugevan@chromium.org2009-08-051-4/+3
| | | | | | | | The bug was already fixed, but this change shouldn't hurt too. Review URL: http://codereview.chromium.org/162020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22524 0039d316-1c4b-4281-b951-d872f2087c98
* linux: always show bookmarks bar on NTPevan@chromium.org2009-08-051-1/+1
| | | | | | | | BUG=16825 Review URL: http://codereview.chromium.org/159897 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22523 0039d316-1c4b-4281-b951-d872f2087c98
* Original change by Min-Yu Huang <minyu.huang@gmail.com> intc@google.com2009-08-0517-614/+900
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/160347 This is the very preliminary implementation to support printing on Linux and it has not been finished yet. For each page to be printed, we convert rendering actions on canvas into cairo APIs and generate a PS/PDF file. chrome/chrome.gyp: Include our newly added and renamed files. chrome/browser/browser.h: chrome/browser/browser.cc: Allow the user print the web page by hitting ctrl-p. chrome/browser/gtk/standard_menus.cc: Show "Print" in the menu. chrome/renderer/print_web_view_helper.cc: chrome/renderer/print_web_view_helper.h: chrome/renderer/print_web_view_helper_mac.cc chrome/renderer/print_web_view_helper_win.cc Move the class PrepareFrameAndViewForPrint to the header file and move platform dependent parts to their corresponding files. chrome/renderer/print_web_view_helper_linux.cc: Hard-coded parameters for printing. Only print the first page now. skia/ext/vector_canvas.cc: skia/ext/vector_canvas.h: skia/ext/vector_canvas_linux.cc: skia/ext/vector_canvas_win.cc: Move platform dependent parts to their corresponding files. skia/ext/vector_platform_device.h: skia/ext/vector_platform_device_linux.cc: skia/ext/vector_platform_device_linux.h We translate skia APIs into Cairo APIs here. A PDF file is also created and saved to the disk at this moment for testing purpose (you have to run chrome without the sandbox to save the file). There are still lots of bugs. skia/skia.gyp: Include our newly added files when compiling skia package on Linux. BUG=9847 Review URL: http://codereview.chromium.org/160673 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22522 0039d316-1c4b-4281-b951-d872f2087c98
* Add the sync files to chrome.gyp. They still don't result in anything ↵tim@chromium.org2009-08-0512-3/+2158
| | | | | | | | | | | | building because the files are wrapped in #ifdef CHROME_PERSONALIZATION which is not defined anywhere at the moment. Add live_sync to chrome\test and corresponding target to chrome.gyp Review URL: http://codereview.chromium.org/159902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22521 0039d316-1c4b-4281-b951-d872f2087c98
* Update to WebKit r46807.pkasting@chromium.org2009-08-054-20/+9
| | | | | | | | BUG=none TEST=Covered by existing unittests Review URL: http://codereview.chromium.org/162018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22518 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 20:41:52 +0000