summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove --do-not-create-shortcuts flag from setup.exegab@chromium.org2012-06-277-15/+1
| | | | | | | | | | | | As a precursor to extracting the install logic in subfunctions, might as well remove this flag which we decided was never used and is no longer needed (it was originally meant for Chrome Frame, but the installer path for CF now does this correctly without this flag). BUG=132825,127544 TEST=Install CF with "setup.exe --chrome-frame --do-not-register-for-update-launch --do-not-launch-chrome" and ensure no shortcuts are created. Review URL: https://chromiumcodereview.appspot.com/10700008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144580 0039d316-1c4b-4281-b951-d872f2087c98
* Disable core animation plugins when compositing is unavailable.jbauman@chromium.org2012-06-276-26/+48
| | | | | | | | | | | When compositing is disabled or blacklisted we won't be able to composite core animation plugins, so disable them. BUG=122430 TEST=flash works on nytimes.com with --disable-accelerated-compositing Review URL: https://chromiumcodereview.appspot.com/10542112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144578 0039d316-1c4b-4281-b951-d872f2087c98
* [Chromoting] Remove test code that got checked in with review comments.garykac@chromium.org2012-06-271-2/+1
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10696014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144575 0039d316-1c4b-4281-b951-d872f2087c98
* Modify experimental identity flow to display scope descriptions and details.estade@chromium.org2012-06-2734-75/+851
| | | | | | | | | | | | | Only desktop Linux should be affected for now. largely based on patch by jstritar BUG=130206 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10630021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144574 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r 144499 "Rename the remaining usage of Monitor to Display"oshima@chromium.org2012-06-2764-550/+552
| | | | | | | | | | | | Temporarily reverting rename change to investigate 133784 TBR=oshima@chromium.org BUG=123160 TEST=none Review URL: https://chromiumcodereview.appspot.com/10689014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144573 0039d316-1c4b-4281-b951-d872f2087c98
* Display per-type status in about:syncrlarocque@chromium.org2012-06-276-92/+127
| | | | | | | | | | | | | | | | This change merges the per-datatype throttling status, per-datatype unrecoverable error status and the routing info into a single table on about:sync's about tab. In the future, we may be able to expand on this to provide even more detailed information, such as the current model association status. BUG=134698 TEST= Review URL: https://chromiumcodereview.appspot.com/10657033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144572 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Use ScopedProcessInformation.rvargas@google.com2012-06-278-186/+176
| | | | | | | | | | | | This is a partial reland of 130716 - Use ScopedProcessInformation and other RAII types in sandbox - minus the bugs introduced by that cl. BUG=127931 TEST=none Review URL: https://chromiumcodereview.appspot.com/10605002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144571 0039d316-1c4b-4281-b951-d872f2087c98
* Make omnibox's HistoryQuickProvider new scoring less aggressive.mpearson@chromium.org2012-06-271-3/+3
| | | | | | | | | | | | Require more visits to a site for it to get an inlineable score. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10692008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144567 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2012-06-271-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144566 0039d316-1c4b-4281-b951-d872f2087c98
* Update software rendering list to 1.44jbauman@chromium.org2012-06-271-1/+1
| | | | | | | | | BUG=134885 TEST= Review URL: https://chromiumcodereview.appspot.com/10709002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144563 0039d316-1c4b-4281-b951-d872f2087c98
* Add the following additional content settings types to the permissions list ↵markusheintz@chromium.org2012-06-275-34/+86
| | | | | | | | | | | | | | of the Website Settings UI: Images, JavaScript, Fullscreen, MouseLock and MediaStream. Display the Location and Notification settings always. Before this CL Location and Notification settings are only displayed if their setting is other than CONTENT_SETTING_ASK. BUG=113688 TEST=The Website Settings popup shows the following additional permissions: Images, JavaScript, Fullscreen, Mouse lock, Mediastream. Location and Notification settings are always displayed. Review URL: https://chromiumcodereview.appspot.com/10698005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144561 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2012-06-271-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144555 0039d316-1c4b-4281-b951-d872f2087c98
* Roll grit to r52.flackr@chromium.org2012-06-271-1/+1
| | | | | | | | | BUG=134796 TEST=None Review URL: https://chromiumcodereview.appspot.com/10692014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144552 0039d316-1c4b-4281-b951-d872f2087c98
* Fix suppression for WebRTCAudioDeviceTest.FullDuplexAudioWithAGCbradchen@google.com2012-06-272-3/+3
| | | | | | | | | | | | In a new CL due to git confusion and tree corruption. TBR=timur BUG=131154 TEST= Review URL: https://chromiumcodereview.appspot.com/10690018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144541 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144484 - Reland r143115: Provide a Chrome-owned buffer to FFmpeg for ↵dmichael@chromium.org2012-06-277-127/+54
| | | | | | | | | | | | | | video decoding. TEST=none BUG=none Review URL: https://chromiumcodereview.appspot.com/10678010 TBR=scherkus@chromium.org Review URL: https://chromiumcodereview.appspot.com/10704014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144539 0039d316-1c4b-4281-b951-d872f2087c98
* Recover pixel aspect ratio in ISO BMFF parser.strobe@google.com2012-06-273-3/+28
| | | | | | | | | | BUG=134801 TEST=Manual (non-public media file) Review URL: https://chromiumcodereview.appspot.com/10689003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144537 0039d316-1c4b-4281-b951-d872f2087c98
* Fix overlay display in certificate options.rkc@chromium.org2012-06-271-2/+4
| | | | | | | | | | | | | When we try to delete a certificate, the overlay that is shown doesn't have a parent set; which causes an exception in the show overlay javascipt. Fix this so the delete button works again. R=csilv@chromium.org BUG=130396 TEST=Tested that a certificate was deleted when the delete button was pressed and the OK option selected. Review URL: https://chromiumcodereview.appspot.com/10680010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144536 0039d316-1c4b-4281-b951-d872f2087c98
* Do not try to use elevation on XP/W2K3. Instead activate "as invoker" and ↵alexeypa@chromium.org2012-06-271-14/+32
| | | | | | | | | | | fail privileged operations with ACCESS_DENIED if the caller does not have enough permissions. BUG=121496 Review URL: https://chromiumcodereview.appspot.com/10705003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144535 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream Android RenderWidgetHostView and WebContentsView.sievers@chromium.org2012-06-278-37/+663
| | | | | | | | | TBR=jam@chromium.org (for content/content_browser.gyp) Review URL: https://chromiumcodereview.appspot.com/10580044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144534 0039d316-1c4b-4281-b951-d872f2087c98
* Properly display the negotiated protocol for spdy proxy sessions.rch@chromium.org2012-06-271-5/+2
| | | | | | | | | | BUG=134864 TEST=Visit an HTTP URL through a SPDY proxy. View the session in chrome://net-internals/#spdy and notice that the protocol is not "unknow". Review URL: https://chromiumcodereview.appspot.com/10695010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144532 0039d316-1c4b-4281-b951-d872f2087c98
* Invoke PluginImplementedObjectDestroyed for ppp_class deallocatejhorwich@chromium.org2012-06-272-9/+11
| | | | | | | | | | | | | | | | | | | | | Deallocate on the plugin's GetInstanceObject ScriptableObject gets invoked twice during plugin destruction, typically resulting in a crash, for proxied plugins that expose a scriptable object. Once by PPP_ClassProxy::OnMsgDeallocate and once by PluginVarTracker::DidDeleteInstance. This patch removes the object from the var tracker when it is destroyed in PPP_Class_Proxy. It also tweaks a unittest to verify Deallocate is invoked only once during the test. BUG=133950 TEST=Run gmail, reload page (ctrl-r) and observe for plugin crashes TEST=Run ppapi_example out-of-process, reload page, observe for plugn crashes TEST=ppapi_unittests --gtest_filter="PluginVar*" Review URL: https://chromiumcodereview.appspot.com/10678007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144531 0039d316-1c4b-4281-b951-d872f2087c98
* Use the first_party_for_cookies URL to filter which requests the WebRequest ↵battre@chromium.org2012-06-274-17/+45
| | | | | | | | | | | | API sees BUG=134101 TEST=see bug report Review URL: https://chromiumcodereview.appspot.com/10636056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144529 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding r144496 which was reverted in r144503.fischman@chromium.org2012-06-279-87/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix several shutdown/error-path bugs in VAVDA and avoid unnecessary MakeCurrent() calls - GpuVideoDecodeAcceleratorHost is already AddRoute'd to GpuChannelHost on creation, so CommandBufferProxyImpl::OnChannelError doesn't have to call GVDAH::OnChannelError as well (was causing double-notifications of errors to GVDAH). - GpuVideoDecodeAcceleratorHost::Send() would DCHECK that no error had previously been reported on the channel, but that's incorrect because its client will likely still have async posted tasks from before the error notifications. Now instead of DCHECK'ing simply early-return after an error was seen. - gpu_video_decode_accelerator.cc:MakeDecoderContextCurrent() used to unconditionally bind the GpuCommandBufferStub* into its closure, but nothing guarantees the lifetime of the stub; in fact context loss will cause the stub to be deleted so this could crash as well. Now take a WeakPtr to the stub and check its validity before every use (and return false if invalid to allow clients to avoid assuming context currency). - GpuVideoDecodeAccelerator is now a GpuCommandBufferStub::DestructionObserver to avoid attempting further work once the stub is about to be deleted. - Removed a bunch of unnecessary MakeCurrent() calls; VAAPI_* calls don't need it, and are sometimes made on the decoder (not main) thread, from which it is incorrect to call GL-related methods such as MakeCurrent() anyway. BUG=134020 TEST=manual playback of multiple HW-decoded .mp4's doesn't crash anything when different tabs are closed. TBR=posciak,piman Review URL: https://chromiumcodereview.appspot.com/10692016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144528 0039d316-1c4b-4281-b951-d872f2087c98
* Add third_party/cros to .gitignoreakalin@chromium.org2012-06-271-0/+1
| | | | | | | | | | BUG= TEST= TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/10704010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144527 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Extract AutocompleteLog from autocomplete.*.tfarina@chromium.org2012-06-2712-81/+119
| | | | | | | | | | BUG=94842 R=pkasting@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10681008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144526 0039d316-1c4b-4281-b951-d872f2087c98
* Update suppression for crbug.com/119677bradchen@google.com2012-06-271-1/+1
| | | | | | | | | | TBR=oshima BUG=119677 TEST= Review URL: https://chromiumcodereview.appspot.com/10699008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144525 0039d316-1c4b-4281-b951-d872f2087c98
* Add subdirectory smoke test and fix subdirectory handling when handling a ↵maruel@chromium.org2012-06-275-27/+40
| | | | | | | | | | | | | | | | symlink. TBR'ing because it's breaking compile on Mac swarm. TBR=cmp@chromium.org NOTRY=true BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10690015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144524 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2012-06-271-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144523 0039d316-1c4b-4281-b951-d872f2087c98
* Update GPU blacklist to 1.41zmo@chromium.org2012-06-271-1/+1
| | | | | | | | | | | | | So we blakclist Intel HD 4000 on Mac. Note that we have to fix crbug 122430, otherwise, with this blacklisting, we will lose flash. BUG=134015 TEST= TBR=kbr Review URL: https://chromiumcodereview.appspot.com/10704009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144522 0039d316-1c4b-4281-b951-d872f2087c98
* Platform app documentation tweaksmihaip@chromium.org2012-06-2711-211/+147
| | | | | | | | | | | | | | | - Remove reference to GPU flag for the browser plugin, it's no longer necessary. - The default value for offline_enabled flipped with http://crrev.com/144319 - Fix CSP link in the sidebar - Include the actual default CSP used on the CSP page (and update the copy on the offline page; we're not using chrome-extension-resource URLs for now) - Clarify the remote/external resources section a bit R=mkearney@chromium.org Review URL: https://chromiumcodereview.appspot.com/10687010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144521 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename shelf_auto_hide_behavior.h to shelf_types.tfarina@chromium.org2012-06-2718-22/+20
| | | | | | | | | | | NOTE: This was a TODO for sky@. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10676014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144520 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of ui_test_utils::WaitForNewBrowserjam@chromium.org2012-06-272-14/+2
| | | | | | | BUG=119521 Review URL: https://chromiumcodereview.appspot.com/10684006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144518 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome compile with the win8 sdk cpu@chromium.org2012-06-272-2/+1
| | | | | | | | | | | | So we can move the metro bits to src IID_IDataObjectAsyncCapability is declared but not defined. BUG=127799 TEST= it builds Review URL: https://chromiumcodereview.appspot.com/10674010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144517 0039d316-1c4b-4281-b951-d872f2087c98
* This adds an interface for setting crash data from a plugin. It also ↵raymes@chromium.org2012-06-2718-9/+195
| | | | | | | | | | | | provides an implementation for setting crash URLs. BUG=134176 TEST=Added test case to sanity check API call. Also hooked up to flash and produced a crash and checked that the report included the document url (http://crash/reportdetail?reportid=1719cae3a745f633) Review URL: https://chromiumcodereview.appspot.com/10681006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144516 0039d316-1c4b-4281-b951-d872f2087c98
* Disable CaptivePortalBrowserTest.TwoWindows, as it'smmenke@chromium.org2012-06-271-1/+2
| | | | | | | | | | | slightly flaky on all platforms. TBR=cbentzel@chromium.org BUG=134357 Review URL: https://chromiumcodereview.appspot.com/10697008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144515 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaned up <input> CSS and simplified user consent mark-up.jamiewalch@google.com2012-06-272-30/+32
| | | | | | | | | BUG=134063 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10661009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144513 0039d316-1c4b-4281-b951-d872f2087c98
* Add test_graphics3d to ppapi_uitest, untrusted (NaCl) test suite, usingnfullagar@google.com2012-06-273-5/+38
| | | | | | | | | | | | | | OSMesa as needed for bots. Add AudioConfig tests to ppapi_uitest untrusted (NaCl) suite. Tweak gyp for untrusted NaCl build so apps using TLS links without errors. Addendum: don't add -mno-tls-use-call to arm build (otherwise pnacl compiler will fail because it doesn't recognize this option.) BUG=none TEST=this is the test Review URL: https://chromiumcodereview.appspot.com/10682005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144512 0039d316-1c4b-4281-b951-d872f2087c98
* #include <iterator> for std::insert_iterator. This fixes compile on VS2010 ↵pkasting@chromium.org2012-06-271-0/+1
| | | | | | | | | | | Express. BUG=133049 TEST=none TBR=penghuang Review URL: https://chromiumcodereview.appspot.com/10692013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144510 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Add a bool flag to catch crash cause of http://crbug.com/134507.xiyuan@chromium.org2012-06-272-1/+14
| | | | | | | | | | | | | Add a boolean flag to catch the case that window is destroyed during SetVisible(false) call. BUG=134507 TEST=None. Review URL: https://chromiumcodereview.appspot.com/10677010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144508 0039d316-1c4b-4281-b951-d872f2087c98
* sas.dll is not included to Windows 8 SDK. Use one from from Windows 7 SDK ↵alexeypa@chromium.org2012-06-274-9/+9
| | | | | | | | | | | | instead. BUG=134509 TEST=src/remoting.gyp:remoting_host_installation is buildable. Review URL: https://chromiumcodereview.appspot.com/10673011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144507 0039d316-1c4b-4281-b951-d872f2087c98
* Fix method definition order.bryeung@chromium.org2012-06-273-300/+295
| | | | | | | | | | | | This makes the definition order match the declaration order. TEST=compiles BUG=none Review URL: https://chromiumcodereview.appspot.com/10630014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144506 0039d316-1c4b-4281-b951-d872f2087c98
* app_list: Document the ownership of the remaining data members.tfarina@chromium.org2012-06-275-33/+22
| | | | | | | | | R=xiyuan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10664031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144505 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144496 - Fix several shutdown/error-path bugs in VAVDA and avoid ↵mattm@chromium.org2012-06-279-83/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | unnecessary MakeCurrent() calls: - GpuVideoDecodeAcceleratorHost is already AddRoute'd to GpuChannelHost on creation, so CommandBufferProxyImpl::OnChannelError doesn't have to call GVDAH::OnChannelError as well (was causing double-notifications of errors to GVDAH). - GpuVideoDecodeAcceleratorHost::Send() would DCHECK that no error had previously been reported on the channel, but that's incorrect because its client will likely still have async posted tasks from before the error notifications. Now instead of DCHECK'ing simply early-return after an error was seen. - gpu_video_decode_accelerator.cc:MakeDecoderContextCurrent() used to unconditionally bind the GpuCommandBufferStub* into its closure, but nothing guarantees the lifetime of the stub; in fact context loss will cause the stub to be deleted so this could crash as well. Now take a WeakPtr to the stub and check its validity before every use (and return false if invalid to allow clients to avoid assuming context currency). - GpuVideoDecodeAccelerator is now a GpuCommandBufferStub::DestructionObserver to avoid attempting further work once the stub is about to be deleted. - Removed a bunch of unnecessary MakeCurrent() calls; VAAPI_* calls don't need it, and are sometimes made on the decoder (not main) thread, from which it is incorrect to call GL-related methods such as MakeCurrent() anyway. BUG=134020 TEST=manual playback of multiple HW-decoded .mp4's doesn't crash anything when different tabs are closed. Review URL: https://chromiumcodereview.appspot.com/10668030 TBR=fischman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144503 0039d316-1c4b-4281-b951-d872f2087c98
* [chromeos] Update the baseline for netflix pluginnirnimesh@chromium.org2012-06-271-1/+1
| | | | | | | | | | R=rohitbm@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10692011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144502 0039d316-1c4b-4281-b951-d872f2087c98
* Rename run_test_cases_test.py -> run_test_cases_smoke_test.py since it's a ↵maruel@chromium.org2012-06-271-0/+0
| | | | | | | | | | | | | | smoke test. TBR=cmp@chromium.org NOTRY=true BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10693011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144501 0039d316-1c4b-4281-b951-d872f2087c98
* Move NetworkLoginObserver observer management to NetworkLibraryImplBase.stevenjb@chromium.org2012-06-273-7/+5
| | | | | | | | | | BUG=134685 TEST=No more crashes in ~NetowrkLoginObserver Review URL: https://chromiumcodereview.appspot.com/10684002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144500 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the remaining usage of Monitor to Displayoshima@chromium.org2012-06-2764-552/+550
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10675011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144499 0039d316-1c4b-4281-b951-d872f2087c98
* Match up lifetime of ImageLoadingTracker to its usage.miket@chromium.org2012-06-271-1/+1
| | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=143991 began using tracker_ as a state-tracking signal, but didn't reset tracker_ with a new instance of ImageLoadingTracker if the dialog instance is reused. This caused a crash the second time a user clicked a trash can on the extensions page. BUG=134780 TEST=no longer crashes. Review URL: https://chromiumcodereview.appspot.com/10689006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144498 0039d316-1c4b-4281-b951-d872f2087c98
* Use capturing with XGetImage() only in screenshot_taker.mukai@chromium.org2012-06-272-10/+16
| | | | | | | | | | | | | | | GrabWindowSnapshot() happens in the "Report Issue" (c/b/ui/webui/feedback_ui.cc) and XGetImage runs earlier than closing the wrench menu. This could delay the response on "Report Issue" but it's much more important to work correctly for this specific item. R=derat@chromium.org BUG=134818 TEST=manually done on lumpy / selecting "Report Issue" and Ctrl-F5 Review URL: https://chromiumcodereview.appspot.com/10694003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144497 0039d316-1c4b-4281-b951-d872f2087c98
* Fix several shutdown/error-path bugs in VAVDA and avoid unnecessary ↵fischman@chromium.org2012-06-279-88/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MakeCurrent() calls: - GpuVideoDecodeAcceleratorHost is already AddRoute'd to GpuChannelHost on creation, so CommandBufferProxyImpl::OnChannelError doesn't have to call GVDAH::OnChannelError as well (was causing double-notifications of errors to GVDAH). - GpuVideoDecodeAcceleratorHost::Send() would DCHECK that no error had previously been reported on the channel, but that's incorrect because its client will likely still have async posted tasks from before the error notifications. Now instead of DCHECK'ing simply early-return after an error was seen. - gpu_video_decode_accelerator.cc:MakeDecoderContextCurrent() used to unconditionally bind the GpuCommandBufferStub* into its closure, but nothing guarantees the lifetime of the stub; in fact context loss will cause the stub to be deleted so this could crash as well. Now take a WeakPtr to the stub and check its validity before every use (and return false if invalid to allow clients to avoid assuming context currency). - GpuVideoDecodeAccelerator is now a GpuCommandBufferStub::DestructionObserver to avoid attempting further work once the stub is about to be deleted. - Removed a bunch of unnecessary MakeCurrent() calls; VAAPI_* calls don't need it, and are sometimes made on the decoder (not main) thread, from which it is incorrect to call GL-related methods such as MakeCurrent() anyway. BUG=134020 TEST=manual playback of multiple HW-decoded .mp4's doesn't crash anything when different tabs are closed. Review URL: https://chromiumcodereview.appspot.com/10668030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144496 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-16 22:05:27 +0000