| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=pinkerton
Review URL: http://codereview.chromium.org/4045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
because of this. Thanks for pointing it out.
Review URL: http://codereview.chromium.org/4218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Original review at http://codereview.chromium.org/3170
Review URL: http://codereview.chromium.org/4043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"minor" which was causing compilation problems.
Patch contributed by James Vega <vega.james@gmail.com>.
Note: Took the leasure to make some globals const.
Review URL: http://codereview.chromium.org/4217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unwrapping process
between DOM nodes and JS objects.
The basic idea is that, IDL files provide static type information. Certain types, such as subtypes of Node,
only need 'NODE' has type for wrapping and unwrapping. So, intead of going through a gigatic switch statement,
IDL compiler generates fast path for know types, the CL only does it for Node and subtypes.
I have seen it improves DOM-peerable example by 5% when running standalone, and 35% when running with
whole Dromaeo tests.
I missed the another point of this CB. It removed expensive MaybeDOMWrapper checks in production code. It contributes a lot to the overhead.
Review URL: http://codereview.chromium.org/3195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Allows testShell to link.
Review URL: http://codereview.chromium.org/4216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
re-use it when the |open_existing| flag is passed to Create().
Review URL: http://codereview.chromium.org/4039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enter triggers a focus change.
BUG=2554
TEST=see bug
Review URL: http://codereview.chromium.org/4014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
on GCC.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Patch from Pawel Hajdan Jr.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Patch from Pawel Hajdan Jr.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for the Mac version code. Plus, we properly release the certs, so the Purify build should be happier.
Review URL: http://codereview.chromium.org/3189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
correctly with the platform hooks.
Review URL: http://codereview.chromium.org/4020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
our combined-build icuuc.lib to icu.lib.
Change solution file references accordingly.
Also change libxml patch and Makefile references
Review URL: http://codereview.chromium.org/4027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
NonCopyable.
Review URL: http://codereview.chromium.org/4209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since we're already working toward 0.3 as the next Beta update,
I bumped the minor to 0.3.
R= nsylvain@chromium.org
Review URL: http://codereview.chromium.org/4204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the distributed test at this location:
chrome_23e0000!v8::internal::Builtins::Setup+0x2bb
Revert this change because it seems to be the culprit.
Review URL: http://codereview.chromium.org/4206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR
Review URL: http://codereview.chromium.org/4205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=evanm
Review URL: http://codereview.chromium.org/4203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up solution files for webkit and net
Add one line keyword change to help linux build
r=hunanr,openvcdiff,nsylvain
Review URL: http://codereview.chromium.org/4026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- And have a way to set the initial events even if chrome
was shut down before it was able to initialize and
thus we have an empty rlz.
Apparently a sizeable % of our users have an empty
rlz string and it looks like this can be the cause.
BUG= 1372961
Review URL: http://codereview.chromium.org/3200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
issue with the proxy exception list not being honored if individual rules had
uppercase characters in them.
The code to match the url with the exceptions was converting both to lowercase.
However there was an error in the way the StringToLowerASCII function was used.
Bug=541
Review URL: http://codereview.chromium.org/4019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
--magic_browzR command line switch.
R= ben@chromium.org
Review URL: http://codereview.chromium.org/4031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/4202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
performance when there are multiple plugins, or when scrolling.
Review URL: http://codereview.chromium.org/3133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reviewed earlier.
Fixes mnemonic bug in chrome menus. After this change you can indicate
whether menus have mnemonics. Mnemonics are shown if the menus have
mnemonics, and the OS says we should show them.
BUG=1355952
TEST=add a bookmark and change the title to &foo. Move the bookmark to
a folder, click on the folder and make sure the title shows the &.
Review URL: http://codereview.chromium.org/4021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
locked.
Review URL: http://codereview.chromium.org/3194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
don't clobber each other.
Also added FF2 and FF3 support.
Review URL: http://codereview.chromium.org/2913
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR
Review URL: http://codereview.chromium.org/4018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also need to augment sln dependencies
tbr
Review URL: http://codereview.chromium.org/3188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Repairing tree bustage from checkin 2443
r=nsylvain
Review URL: http://codereview.chromium.org/3187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command line option "sdch-enable" enables support of sdch
and automtic lazy download of dictionaries. Optionally it
can select a singular domain to work from.
By default, all domains are enabled when the flag is used.
"-sdch-enable=".google.com" Enables it only for Google.
When the switch is not set on the command line, all this
code is completely disabled.
Still TBD:
a) Finish implementation of security details (much of it is in place)
b) Add tests for security details.
r=huanr,ajenjo,kmixter
Review URL: http://codereview.chromium.org/461
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whether menus have mnemonics. Mnemonics are shown if the menus have
mnemonics, and the OS says we should show them.
BUG=1355952
TEST=add a bookmark and change the title to &foo. Move the bookmark to
a folder, click on the folder and make sure the title shows the &.
Review URL: http://codereview.chromium.org/4002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the loading of dlls that cause renderer crashes.
- Remove the old FreeLibrary() method
Review URL: http://codereview.chromium.org/2458
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3000
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
correct path. Lack of EOL on bloom_filter.h had broken the Linux build, this is a fatal warning with GCC.
Review URL: http://codereview.chromium.org/4007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Not in my machine unless I incredibuild.
- But change makes sense.
Review URL: http://codereview.chromium.org/4006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- CL is identical and was already lgtm
TBR=rvargas
Review URL: http://codereview.chromium.org/3179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
facilitate alternate implementations.
The current SafeBrowsingDatabase code is moved to *_impl files.
Adding a new implementation can be done via command line flags
in the SafeBrowsingDatabase::Create factory method.
Review URL: http://codereview.chromium.org/3162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stack crashing is this one:
chrome_2650000!xmlTextWriterStartElement+0x23
chrome_2650000!MetricsLog::StartElement+0xb5
chrome_2650000!MetricsLog::ScopedElement::ScopedElement+0x67
chrome_2650000!MetricsLog::RecordHistogramDelta+0xd8
chrome_2650000!MetricsService::RecordHistogram+0x122
chrome_2650000!MetricsService::RecordCurrentHistograms+0xc3
chrome_2650000!MetricsService::StopRecording+0x94
chrome_2650000!MetricsService::PushPendingLogsToUnsentLists+0xbf
chrome_2650000!MetricsService::SetRecording+0x36f
chrome_2650000!MetricsService::Stop+0x11
chrome_2650000!BrowserMain+0xefa
chrome_2650000!ChromeMain+0x862
It looks like writer_ is null on invalid.
It also look like there is debugging code that was left
in.
Review URL: http://codereview.chromium.org/4005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
from a full disk.
Review URL: http://codereview.chromium.org/4003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2431 0039d316-1c4b-4281-b951-d872f2087c98
|