summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* add layout_test_helper on windowsdpranke@google.com2009-08-037-10/+92
| | | | | | | | | | | | | | add layout_test_helper to toggle cleartype on and off as necessary for layout tests on windows (mirroring similar functionality on the mac) BUG=none R=tony TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22185 Review URL: http://codereview.chromium.org/159684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22303 0039d316-1c4b-4281-b951-d872f2087c98
* Delay loading of ExtensionHosts until the background page is ready.mpcomplete@chromium.org2009-08-0310-5/+109
| | | | | | | | | BUG=13912 TEST=no Review URL: http://codereview.chromium.org/159756 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22302 0039d316-1c4b-4281-b951-d872f2087c98
* When loading an alternate 404 error page, always set 'replace' to true.darin@chromium.org2009-08-034-1/+21
| | | | | | | | | | | | | This is necessary because WebCore still loads an empty blank page when we postpone the data for the original 404 error page. R=tony BUG=18109 TEST=errorpage_uitest.cc Review URL: http://codereview.chromium.org/159801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22301 0039d316-1c4b-4281-b951-d872f2087c98
* Extension docs build script, gyp target and PRESUBMIT.PY checkrafaelw@chromium.org2009-08-0375-979/+10146
| | | | | | | | | | | | | | | | | | This addeds a mechanism for extension docs to "render" from the api/extension_api.json api "idl", the docs/static file content and the template/ html templates into the static extension docs. It retains the property that extension docs loaded in chrome with file:/// scheme will regenerate if dependent data has changed, but otherwise is static. The build.py script runs test_shell to render the static files. A extension_docs gyp target is defined with appropriate inputs & outputs that will run the build.py A PRESUBMIT.PY check will warn on upload and commit if any files have changed that would require a docs rebuild. Note that the PRESUBMIT.PY checks are not currently being run for git cl upload or git cl dcommit. Review URL: http://codereview.chromium.org/159607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22300 0039d316-1c4b-4281-b951-d872f2087c98
* Use LoadString instead of the ATL-dependent AtlGetStringResourceImage.jhawkins@chromium.org2009-08-031-11/+11
| | | | | | | | BUG=5022 TEST=none Review URL: http://codereview.chromium.org/159779 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22299 0039d316-1c4b-4281-b951-d872f2087c98
* Convert usage of CPoint to gfx::Point.jhawkins@chromium.org2009-08-031-17/+17
| | | | | | | | BUG=5022 TEST=none Review URL: http://codereview.chromium.org/160514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22298 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Move the enter/leave-notify-event handling to TabRendererGtk and hook ↵jhawkins@chromium.org2009-08-034-35/+26
| | | | | | | | | | up the close button signals to this handler. BUG=18196 TEST=Open two tabs. Hover the mouse over the close button of the inactive tab. The inactive tab should stay highlighted. Review URL: http://codereview.chromium.org/160512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22297 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of non-functional elements from the themes prefs; add switcher.avi@chromium.org2009-08-037-190/+224
| | | | | | | | | BUG=http://crbug.com/18094 TEST=try the theme picker and enjoy! Review URL: http://codereview.chromium.org/159727 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22296 0039d316-1c4b-4281-b951-d872f2087c98
* Fix breakage.erg@google.com2009-08-031-0/+1
| | | | | | Review URL: http://codereview.chromium.org/159802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22295 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Theme labels in LocationBarViewGtk.erg@google.com2009-08-036-25/+80
| | | | | | | | | | | Labels in LocationBarViewGtk should be black even when a dark GTK theme is used when we're not in GTK theme mode. Likewise, when we're using a GTK theme, we should have the background and border color of the "Search X for:" box use colors from the theme instead of having hard coded ones. Review URL: http://codereview.chromium.org/159798 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22293 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even the logging statement from ~LogMessage. We shouldn't be using ↵phajdan.jr@chromium.org2009-08-031-7/+6
| | | | | | | | | | | LOG macros there. TEST=none http://crbug.com/18028 Review URL: http://codereview.chromium.org/159789 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22292 0039d316-1c4b-4281-b951-d872f2087c98
* Move test_file_util out of libbase. Test code should not be mixed with ↵phajdan.jr@chromium.org2009-08-033-7/+44
| | | | | | | | | | | | | | | production code. Rename previous test_support_base to test_support_perf. I couldn't just add things to test_support_base because one file there defined main, and it would produce link conflict for new users of test_support_base. TEST=none http://crbug.com/18101 Review URL: http://codereview.chromium.org/159791 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22291 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Allow keypad to be used for all tab selection accelerators.estade@chromium.org2009-08-031-0/+20
| | | | | | | | | | (the only other accelerator that uses a number is ctrl+0, and that already accepts the keypad) BUG=18229 Review URL: http://codereview.chromium.org/159799 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22289 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add stock icons to some dialog buttons.estade@chromium.org2009-08-036-11/+33
| | | | | | | | | | | | | | | | | To be clear, this only adds button images from stock images, and doesn't change the text of the buttons. I chose APPLY for dialogs that involve checkboxes. I chose OK for dialogs without checkboxes. also - switched the position of the OK/Cancel buttons on the import lock dialog. - changed the first run dialog CANCEL button to QUIT, because CANCEL is really confusing in that situation (this is a problem on windows as well). I couldn't find any other dialogs that are missing button images, but if you see some call em out. BUG=none TEST=look at all the pretty images. Review URL: http://codereview.chromium.org/160493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22288 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting hunspell upgrade 22263,22257,22252,22243. Causing many valgrind ↵mhm@chromium.org2009-08-0334-5275/+2778
| | | | | | | | | warnings. TBR: brettw, dank, jshin Review URL: http://codereview.chromium.org/159797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22287 0039d316-1c4b-4281-b951-d872f2087c98
* Make extensions auto-update schedule persist across browser restarts.asargent@chromium.org2009-08-036-22/+163
| | | | | | | | | | | | | | Instead of starting the timer all over again, we instead persist some information about when we had scheduled it and when it actually fired. We then try to balance keeping clients reasonably up to date with avoiding a thundering herd against servers. BUG=http://crbug.com/12545 TEST=none Review URL: http://codereview.chromium.org/160433 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22286 0039d316-1c4b-4281-b951-d872f2087c98
* DEPS roll to latest gyp.sgk@google.com2009-08-031-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159795 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22285 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of master preferences parsing before adding a new preference.kuchhal@chromium.org2009-08-0315-366/+325
| | | | | | | | | | | | | Currently we are parsing master preferences file three time on startup. Since we only return an int bit mask flag after parsing preferences, it can not handle any preference other than boolean and we end up reading it again for first run tabs and ping delay. This change refactors all the preferences parsing logic to directly pass around DictionaryValue object around in Chrome as well as installer. No functional change but this will make adding a new preference for new icon more logical since we will not read the preferences file once again. BUG=12701 TEST=Make sure all the distribution preferences still work as before. Review URL: http://codereview.chromium.org/159539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22284 0039d316-1c4b-4281-b951-d872f2087c98
* Don't build testing related plugins on x64 (complicated story with fPIC).deanm@chromium.org2009-08-031-8/+14
| | | | | | | | | BUG=18337 Review URL: http://codereview.chromium.org/159655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22283 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing space to command line that registers Chrome on Windows.kuchhal@chromium.org2009-08-031-1/+1
| | | | | | | | | | | | | So instead of --register-chrome-browser="<path>\chrome.exe"--register-chrome-browser-suffix=".<user>" it is actually --register-chrome-browser="<path>\chrome.exe" --register-chrome-browser-suffix=".<user>". BUG=3641 TBR=huanr Committed: http://src.chromium.org/viewvc/22194 Review URL: http://codereview.chromium.org/160481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22282 0039d316-1c4b-4281-b951-d872f2087c98
* linux: set FD_CLOEXEC on the singleton socketevan@chromium.org2009-08-031-0/+14
| | | | | | | | | | | The IME library may spawn a subprocess, which will then hold open our singleton socket after we've shut down. BUG=17952 Review URL: http://codereview.chromium.org/160523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22281 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP notification tweaks.arv@google.com2009-08-032-9/+33
| | | | | | | | | | | | | | | | | | | | | These came up in the usability studies. Show the first run notification for 30 seconds. Truncate the blacklisted title so that more of the message is shown. In small mode both the title and the message have to be truncated. The current UI design does not work well enough for small screens. BUG=None TEST=Start chrome with an empty/new profile. The first run notification on the new tab page should be shown for 30s. Then navigate to a page with a long title and go back to the new tab page and blacklist that page. The title in the notifier should be truncated. Review URL: http://codereview.chromium.org/160462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22280 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK we hit when a mime type isn't ASCII.evan@chromium.org2009-08-031-6/+18
| | | | | | | | | | | I have a layout test for this, but Tony says I should send it upstream so that will be a separate commit. BUG=17958 Review URL: http://codereview.chromium.org/160363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22279 0039d316-1c4b-4281-b951-d872f2087c98
* Add a variant of 10791 to known crashes.huanr@chromium.org2009-08-031-0/+2
| | | | | | Review URL: http://codereview.chromium.org/159796 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22278 0039d316-1c4b-4281-b951-d872f2087c98
* Adding registration of accelerators for the browser in toolkit_views.jcampan@chromium.org2009-08-038-122/+179
| | | | | | | | | | | BUG=None TEST=Open Chrome built with toolkit_views, test that accelerators work. See review: http://codereview.chromium.org/160502 Review URL: http://codereview.chromium.org/159790 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22277 0039d316-1c4b-4281-b951-d872f2087c98
* Allow cancellable download items to be removable from download shelf.mhm@chromium.org2009-08-031-1/+2
| | | | | | | | BUG=18235 (http://crbug.com/18235) TEST=Cancel a big download and remove it. Review URL: http://codereview.chromium.org/159769 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22276 0039d316-1c4b-4281-b951-d872f2087c98
* add application/ogg mime typefbarchard@chromium.org2009-08-031-0/+1
| | | | | | | | | BUG=18000 TEST=unknown which websites this affects. ask andrew who reported the bug. Review URL: http://codereview.chromium.org/159683 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22275 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22273.mhm@chromium.org2009-08-031-4/+1
| | | | | | Review URL: http://codereview.chromium.org/160524 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22274 0039d316-1c4b-4281-b951-d872f2087c98
* Allow cancellable download items to be removable from download shelf.mhm@chromium.org2009-08-031-1/+4
| | | | | | | | BUG=18235 (http://crbug.com/18235) TEST=Cancel a big download and remove it. Review URL: http://codereview.chromium.org/159769 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22273 0039d316-1c4b-4281-b951-d872f2087c98
* Fix indentation on worker targetmark@chromium.org2009-08-031-33/+32
| | | | | | Review URL: http://codereview.chromium.org/159793 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22272 0039d316-1c4b-4281-b951-d872f2087c98
* Put forwarding function for GetTheme into the automation profile.avi@chromium.org2009-08-031-0/+3
| | | | | | | | TBR Review URL: http://codereview.chromium.org/159794 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22271 0039d316-1c4b-4281-b951-d872f2087c98
* Implement kCurrentThemeID so we can know what the last theme to be installed ↵avi@chromium.org2009-08-035-1/+47
| | | | | | | | | | | was. BUG=none TEST=not visible in UI Review URL: http://codereview.chromium.org/159705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22270 0039d316-1c4b-4281-b951-d872f2087c98
* Use intptr_t for casting pointers for 64-bit.deanm@chromium.org2009-08-031-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/160522 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22269 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r22266.jam@chromium.org2009-08-032-3/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22268 0039d316-1c4b-4281-b951-d872f2087c98
* LocationBarView::PageActionImageView::LoadImageTask::Run() may pass a NULL ↵mirandac@chromium.org2009-08-031-1/+1
| | | | | | | | | | | | | | | image pointer through to OnImageLoaded; make sure that the pointer is not dereferenced in these cases. BUG= http://crbug.com/18140 TEST= none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22213 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22254 Review URL: http://codereview.chromium.org/159711 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22267 0039d316-1c4b-4281-b951-d872f2087c98
* Try reverting skia to r250 to see if the blitter crashes still occur.jam@chromium.org2009-08-032-4/+3
| | | | | | | | | I'll revert this change after a chromebot run. TBR=huanr Review URL: http://codereview.chromium.org/160521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22266 0039d316-1c4b-4281-b951-d872f2087c98
* Adds functionality to the layout test comparison tool to use local log files ↵gwilson@google.com2009-08-033-64/+262
| | | | | | | | | | | | instead of scraping the buildbots. Also corrects some of the search locations for baselines and refactors in anticipation of integration with other scripts. R=ojan TEST=run test_output_formatter.bat -r BUG=none Review URL: http://codereview.chromium.org/159744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22265 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: prepare for l10n.mnaganov@chromium.org2009-08-034-12/+645
| | | | | | | | | | | | User-visible strings are now obtained through WebInspector.UIString method. Added .grd files for WebKit Inspector and Chromium DevTools strings. BUG=none TEST=none Review URL: http://codereview.chromium.org/160454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22264 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Add a suppression for a hunspell memory leak during the ↵mhm@chromium.org2009-08-031-0/+19
| | | | | | | | | | | SpellCheckStrings_EN_US test. TBR=dank BUG=18254 TEST=Watch the linux valgrind bot turn green Review URL: http://codereview.chromium.org/159764 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22263 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the NSTextInput protocol.hbono@chromium.org2009-08-037-18/+362
| | | | | | | | | | | | | | | | This change implements the NSTextInput protocol to integrate dead-keys and IME support into Mac Chromium. Same as Linux, to improve compatibility with Windows Chrome, this change emulates IPC messages sent on Windows when we input characters to fix Issue 11952 and Issue 11981. Even though I notice we need more work for fixing edge cases (e.g. disabling IMEs on a password input) also on Mac, it is the good starting point. (Supporting edge-cases requires complicated code and it makes hard to review.) BUG=11952 "IME support is not implemented" BUG=11981 "Deadkeys do not work" BUG=16393 "Mac: Not able to insert any letter using "Special Characters" pallet" TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), type a '[{' key and an 'A' key on a Canadian-French keyboard, and see a Latin character "U+00E2" is displayed in the <input> form. TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), enable an Chinese Pinyin IME, type a 'W' key, type an 'O' key, and see a Chinese character is displayed in the <input> form. TEST=Open a web page which contains a <textarea> form, type a return key, and see a new line is inserted. Review URL: http://codereview.chromium.org/150206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22262 0039d316-1c4b-4281-b951-d872f2087c98
* Add defensive code in pickle to preclude realloc of shared header_ memory.jar@chromium.org2009-08-031-2/+7
| | | | | | | | | | | | | | | | Since I was able to (some how) generate a problem with header_ being double freed (perhaps, because it was shared in some way??), this change adds several lines of defensive coding. The current assignment operator appears very dangerous, as it allowed Resize to be called when the header_ was not owned by the instance (it was read-only). I haven't found a path to cause a problem, but we may as well be defensive. BUG=17027 BUG=17088 r=CPU Review URL: http://codereview.chromium.org/160490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22261 0039d316-1c4b-4281-b951-d872f2087c98
* When a content script has a match pattern of http://*/*, weaa@chromium.org2009-08-032-5/+14
| | | | | | | | | | | | should run on web pages that have an IP address for their host. BUG=18256 TEST=Added unit test Review URL: http://codereview.chromium.org/159767 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22260 0039d316-1c4b-4281-b951-d872f2087c98
* minor fix to correctly strip goog.exportSymbolsgman@google.com2009-08-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22259 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Check the return value of file_util::ReadFileToString. It's ↵jhawkins@chromium.org2009-08-031-4/+13
| | | | | | | | | | | possible that the file will be removed from the filesystem inbetween the enumeration and reading of the file. In this instance, the script is removed from the script list. CID=3888 BUG=none TEST=none Review URL: http://codereview.chromium.org/159680 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22258 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Add a suppression for a hunspell memory leak during the ↵jhawkins@chromium.org2009-08-031-1/+21
| | | | | | | | | | | SpellCheckTest_GetAutoCorrectionWord_EN_US test. TBR=dank BUG=18254 TEST=Watch the valgrind bot turn green. Review URL: http://codereview.chromium.org/160515 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22257 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ProxyResolverV8::JSBindings --> ProxyResolverJSBindings.eroman@chromium.org2009-08-029-242/+289
| | | | | | | | | (Since it isn't really V8-specific, and could be re-used for impelmentations using a different JS engine). Review URL: http://codereview.chromium.org/159773 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22256 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an alternate set of frame images.sky@chromium.org2009-08-027-6/+17
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159716 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22255 0039d316-1c4b-4281-b951-d872f2087c98
* LocationBarView::PageActionImageView::LoadImageTask::Run() may pass a NULL ↵mirandac@chromium.org2009-08-021-1/+3
| | | | | | | | | | | | | image pointer through to OnImageLoaded; make sure that the pointer is not dereferenced in these cases. BUG= http://crbug.com/18140 TEST= none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22213 Review URL: http://codereview.chromium.org/159711 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22254 0039d316-1c4b-4281-b951-d872f2087c98
* Move alternate error page loading out of WebFrame.darin@chromium.org2009-08-0213-155/+280
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the RenderView be in charge of loading alternate error pages. While working on this change, I noticed several related bugs: 1- Loading an URL with an invalid host name from the new tab page results in an error page. If you hit back and then forward, you will be left with an empty location bar. In a debug build this trips an assertion in ClassifyNavigation because the given page_id is -1. This problem is caused by not duplicating the NavigationState of the failed load when creating a load for the error page. Hence, the pending_page_id of the forward navigation is lost. 2- Loading an URL with an invalid host name as a subframe results in an extra navigation in session history. One navigation for the main frame and one navigation for the error page load. This is another symptom of the problem described in #1. However, the solution is different. Here, we need to know that the subframe load is an AUTO_SUBFRAME load so that we load the error page using 'replace' semantics (so that WebCore does not generate a new session history entry). Finally, I decided to restrict alternative DNS error pages to only work for the main frame to match what we do for alternative 404 error pages. It doesn't seem worth it to show link doctor results for subframes since their primary purpose is to assist people who mis-type an URL. R=tony,brettw BUG=15648 TEST=covered by errorpage_uitest.cc Review URL: http://codereview.chromium.org/159575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22253 0039d316-1c4b-4281-b951-d872f2087c98
* Hunspell 1.2.8 update caused valgrind warnings.mhm@chromium.org2009-08-021-0/+2
| | | | | | | | | BUG=18254 TEST=None Review URL: http://codereview.chromium.org/159766 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22252 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-20 01:10:03 +0000